coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[XS] Change in coreboot[main]: mb/google/puff/var/*: Set WLAN device type back to pci
by David Ruth (Code Review) 09 Jan '24

09 Jan '24

David Ruth has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/79795?usp=email ) Change subject: mb/google/puff/var/*: Set WLAN device type back to pci ...................................................................... mb/google/puff/var/*: Set WLAN device type back to pci This mostly reverts commit 6c705e766f7f ("mb/google/puff/var/*: Set LAN/WLAN device type to generic"). Setting the WLAN device type to generic broke ACPI SSDT table definition, so set it back to pci. BUG=b:295544257 TEST=Untested. Change-Id: I574760f0f0a38eb74643382ecd162ca0a18fcc35 Signed-off-by: David Ruth <druth(a)chromium.org> --- M src/mainboard/google/puff/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/79795/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I574760f0f0a38eb74643382ecd162ca0a18fcc35 Gerrit-Change-Number: 79795 Gerrit-PatchSet: 3 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/byra/var/*: Set WLAN device type back to pci
by David Ruth (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Eric Lai, Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik. David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79794?usp=email ) Change subject: mb/google/byra/var/*: Set WLAN device type back to pci ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79794/comment/fb7e6262_68f46993 : PS1, Line 12: > Because https://review.coreboot. […] Done Patchset: PS1: > I'm on the road for the next week so wouldn't be able to retest until I get back home, so go ahead a […] Thanks, Matt. -- To view, visit https://review.coreboot.org/c/coreboot/+/79794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5dad9deb040c8cb0c507e11726f0ba44ccb2909 Gerrit-Change-Number: 79794 Gerrit-PatchSet: 1 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Jan 2024 15:40:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Ruth <druth(a)chromium.org> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/ibm/sbp1: Set FSP loglevel
by Felix Held (Code Review) 09 Jan '24

09 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79791?usp=email ) Change subject: mb/ibm/sbp1: Set FSP loglevel ...................................................................... mb/ibm/sbp1: Set FSP loglevel Change-Id: Ia97dbda30f657f0b1568364d712eaea8d134b3b0 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79791 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/ibm/sbp1/romstage.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/ibm/sbp1/romstage.c b/src/mainboard/ibm/sbp1/romstage.c index f5b081b..5cda689 100644 --- a/src/mainboard/ibm/sbp1/romstage.c +++ b/src/mainboard/ibm/sbp1/romstage.c @@ -279,8 +279,13 @@ /* Determines if warnings are promoted to system level. */ mupd->FspmConfig.promoteWarnings = 0x0; - /* Set FSP debug message to Disable */ - mupd->FspmConfig.serialDebugMsgLvl = 0x0; + if (CONFIG(DEFAULT_CONSOLE_LOGLEVEL_7) || + CONFIG(DEFAULT_CONSOLE_LOGLEVEL_8)) + mupd->FspmConfig.serialDebugMsgLvl = 3; + else if (CONFIG(DEFAULT_CONSOLE_LOGLEVEL_6)) + mupd->FspmConfig.serialDebugMsgLvl = 1; + else + mupd->FspmConfig.serialDebugMsgLvl = 0; /* Force 256MiB MMCONF (Segment0) only */ mupd->FspmConfig.mmCfgSize = 0x2; -- To view, visit https://review.coreboot.org/c/coreboot/+/79791?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia97dbda30f657f0b1568364d712eaea8d134b3b0 Gerrit-Change-Number: 79791 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: nb/amd/pi/00730F01/state_machine: re-enable LPC decodes
by Felix Held (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Krystian Hebel, Martin L Roth, Matt DeVillier. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79852?usp=email ) Change subject: nb/amd/pi/00730F01/state_machine: re-enable LPC decodes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Another way to do it is to set FCH_RESET_DATA_BLOCK->LegacyFree to 0 in […] i'll have a look at it, but that sounds like the better solution to me -- To view, visit https://review.coreboot.org/c/coreboot/+/79852?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91ef4423bd7bf6c1d7a175336f0f89479f2cde02 Gerrit-Change-Number: 79852 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 14:40:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: soc/mediatek: Add common implementation to configure display
by Yu-Ping Wu (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79776?usp=email ) Change subject: soc/mediatek: Add common implementation to configure display ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f Gerrit-Change-Number: 79776 Gerrit-PatchSet: 5 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 14:05:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google: Show different logos for different ChromeOS devices
by Subrata Banik (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Shelley Chen, Subrata Banik. Subrata Banik has uploaded a new patch set (#10) to the change originally created by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email ) Change subject: vc/google: Show different logos for different ChromeOS devices ...................................................................... vc/google: Show different logos for different ChromeOS devices This commit adds support for showing different logos on the ChromeOS firmware splash screen based on the device model (between Chromebook-Plus and regular ChromeOS devices like Chromebook and Chromebox). This allows OEMs to customize the branding on their devices. This patch also introduces three new Kconfigs: - CHROMEOS_FW_SPLASH_SCREEN - CHROMEOS_LOGO_PATH - CHROMEBOOK_PLUS_LOGO_PATH which allow users to enable the fw splash screen feature in the vendorcode. Previously, we were using the BMP_LOGO Kconfig in drivers/intel/fsp2_0, but we didn't want the top level Kconfigs to be located inside the architecture specific files. BUG=b:317880956 BRANCH=None TEST=emerge-rex coreboot chromeos-bootimage verify that FW splash screen appears Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/drivers/intel/fsp2_0/Makefile.inc M src/include/bootsplash.h M src/lib/Kconfig M src/lib/bmp_logo.c M src/vendorcode/google/chromeos/Kconfig M src/vendorcode/google/chromeos/Makefile.inc A src/vendorcode/google/chromeos/splash.c 7 files changed, 67 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/79775/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/79775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Gerrit-Change-Number: 79775 Gerrit-PatchSet: 10 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: vc/google: Show different logos for different ChromeOS devices
by Paul Menzel (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Shelley Chen, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email ) Change subject: vc/google: Show different logos for different ChromeOS devices ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Gerrit-Change-Number: 79775 Gerrit-PatchSet: 9 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 13:17:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google: Show different logos for different ChromeOS devices
by Subrata Banik (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Andrey Petrov, Julius Werner, Paul Menzel, Ronak Kanabar, Shelley Chen. Subrata Banik has uploaded a new patch set (#9) to the change originally created by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Julius Werner, Code-Review+2 by Shelley Chen, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: vc/google: Show different logos for different ChromeOS devices ...................................................................... vc/google: Show different logos for different ChromeOS devices This commit adds support for showing different logos on the ChromeOS firmware splash screen based on the device model (between Chromebook-Plus and regular ChromeOS devices like Chromebook and Chromebox). This allows OEMs to customize the branding on their devices. This patch also introduces three new Kconfigs: - CHROMEOS_FW_SPLASH_SCREEN - CHROMEOS_LOGO_PATH - CHROMEBOOK_PLUS_LOGO_PATH which allow users to enable the fw splash screen feature in the vendorcode. Previously, we were using the BMP_LOGO Kconfig in drivers/intel/fsp2_0, but we didn't want the top level Kconfigs to be located inside the architecture specific files. BUG=b:317880956 BRANCH=None TEST=emerge-rex coreboot chromeos-bootimage verify that FW splash screen appears Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/drivers/intel/fsp2_0/Makefile.inc M src/include/bootsplash.h M src/lib/Kconfig M src/lib/bmp_logo.c M src/vendorcode/google/chromeos/Kconfig M src/vendorcode/google/chromeos/Makefile.inc A src/vendorcode/google/chromeos/splash.c 7 files changed, 67 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/79775/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/79775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Gerrit-Change-Number: 79775 Gerrit-PatchSet: 9 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: Choose Correct FW splash screen at runtime
by Subrata Banik (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Andrey Petrov, Paul Menzel, Ronak Kanabar, Shelley Chen. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email ) Change subject: Choose Correct FW splash screen at runtime ...................................................................... Patch Set 8: (11 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79775/comment/baa8bb79_ec0a3c83 : PS8, Line 7: Choose Correct FW splash screen at runtime > correct Acknowledged https://review.coreboot.org/c/coreboot/+/79775/comment/e707dc18_c6b36e0c : PS8, Line 7: Choose Correct FW splash screen at runtime > It’d be great if you rephrased, as it seems ChromeOS specific? Acknowledged https://review.coreboot.org/c/coreboot/+/79775/comment/64f0f3c4_8a12c9b2 : PS8, Line 16: CB_ > Fair point, maybe better to rename all those things to "CHROMEOS" to avoid ambiguity. Acknowledged https://review.coreboot.org/c/coreboot/+/79775/comment/3b31a52d_a97a5de7 : PS8, Line 15: CHROMEOS_FW_SPLASH_SCREEN : CB_LOGO_PATH : CB_PLUS_LOGO_PATH > Please mark it up as a list. Acknowledged File src/include/bootsplash.h: https://review.coreboot.org/c/coreboot/+/79775/comment/4abff182_1326151c : PS8, Line 19: Allow platform-specific BMP logo overrides via : * HAVE_CUSTOM_BMP_LOGO config. : * For example: Introduce configurable BMP logo for : * customization on platforms like ChromeOS > Please use the fully allowed text width. Acknowledged https://review.coreboot.org/c/coreboot/+/79775/comment/6788f4a9_9ec52358 : PS8, Line 24: get_bmp_file > nit: Since this is now an exported function I think it should start with `bmp_` for cleaner namespac […] Acknowledged File src/vendorcode/google/chromeos/Kconfig: https://review.coreboot.org/c/coreboot/+/79775/comment/f729b241_088122b2 : PS8, Line 83: Firmware > firmware Acknowledged https://review.coreboot.org/c/coreboot/+/79775/comment/1ec1f4f7_26e89f6d : PS8, Line 88: to > nit: typo? Acknowledged https://review.coreboot.org/c/coreboot/+/79775/comment/b5f827f5_c8b0624b : PS8, Line 89: an > nit: typo? Acknowledged https://review.coreboot.org/c/coreboot/+/79775/comment/801ce83c_9fa0575b : PS8, Line 95: Logo > logo Acknowledged https://review.coreboot.org/c/coreboot/+/79775/comment/33d6adc1_8dc41c4a : PS8, Line 100: Logo > logo Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/79775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Gerrit-Change-Number: 79775 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 13:15:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/intel/mtlrvp: streamline Chrome EC configs
by Deepti Deshatty (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Balaji Manigandan, Felix Singer, Kapil Porwal, Krishna P Bhat D, Paul Menzel, Vijay P Hiremath. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79211?usp=email ) Change subject: mb/intel/mtlrvp: streamline Chrome EC configs ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: Kindly help submit the CL's 79211 and 79824. -- To view, visit https://review.coreboot.org/c/coreboot/+/79211?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f Gerrit-Change-Number: 79211 Gerrit-PatchSet: 11 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 12:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024