coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen
by Subrata Banik (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Pratikkumar V Prajapati, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75626?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen ...................................................................... Patch Set 13: (2 comments) File src/soc/intel/meteorlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/75626/comment/dbe2b2c8_3d4d1bf8 : PS8, Line 183: if (m_cfg->TmeEnable) { > If more security params are added later then we might be to keep TME at the end of the function, if we return from this function based on if TME is not enabled. > > Also, we are not going to call the helper function multiple times so better to keep these couple of lines of code only in fill_fspm_security_params() Please move the code block inside the separate helper function which would help to optimize the `if` loop as well. Just return if certain config is not enabled. https://review.coreboot.org/c/coreboot/+/75626/comment/7ff6da7b_f4f62f85 : PS8, Line 185: TME_EXCLUDE_CBMEM_ENCRYPTION > Assuming your que is, "if we are enabling TME_GENERATE_NEW_KEY_ON_WARM_BOOT then shouldn't TME_EXCLUDE_CBMEM_ENCRYPTION be auto enabled ? otherwise certain ranges won't be able to recover across power-cycle?" > > if TME_GENERATE_NEW_KEY_ON_WARM_BOOT is enabled then nothing will get decrypted from DRAM residual of last warmboot. But if want to access CBMEM, we need to exclude CBMEM from encryption. ideally in context of coreboot, we would like to ensure that memory encryption technique doesn't impact the coreboot assets or user impact. > But i don’t think we can enable TME_EXCLUDE_CBMEM_ENCRYPTION config option just because TME_GENERATE_NEW_KEY_ON_WARM_BOOT is enabled. why not? I don't see a point where the user should be okay to lose the coreboot assets just because they have chosen TME_GENERATE_NEW_KEY_ON_WARM_BOOT kconfig. The basic coreboot persistent assets across warm resets should be usable as is. > We can enable TME_EXCLUDE_CBMEM_ENCRYPTION separately. i want to keep both of the param independent. I strongly believe that user should know the relation between those kconfigs 1. TME_GENERATE_NEW_KEY_ON_WARM_BOOT - would create a new memory encryption key on each warm reset hence, one won't be able to access the coreboot assets unless excluding the coreboot asset ranges from the encrypted boundary. 2. TME_EXCLUDE_CBMEM_ENCRYPTION - This is associated with #1 where unless this config is enabled, the user will lost access to the coreboot assets if TME_GENERATE_NEW_KEY_ON_WARM_BOOT is enabled. > Because our current implementation only supports CBMEM, in future we might want to exclude some other range. (note that only one range can be excluded based in current TME spec and range has to be in physical mem only). So its better to enable TME_EXCLUDE_CBMEM_ENCRYPTION separately. I agree that, there might be more assets which are platform specific and platform user would like to also keep those assets excluded from encryption range but the current SOC design limitation (i.e., encryption exclusion range can be only linear) will forbid that flexibility from the user. -- To view, visit https://review.coreboot.org/c/coreboot/+/75626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8d33f470977ce8db2fd137bab9c63e325b4a32d Gerrit-Change-Number: 75626 Gerrit-PatchSet: 13 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 10:06:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in libgfxinit[main]: Avoid warning '"Pos32" is already use-visible'
by Nico Huber (Code Review) 01 Aug '23

01 Aug '23

Nico Huber has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/76491?usp=email ) Change subject: Avoid warning '"Pos32" is already use-visible' ...................................................................... Avoid warning '"Pos32" is already use-visible' Ensures compatibility with GCC 13. Change-Id: Ic41a20167b88b5952642cc59e80315c5d2fd98b0 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/76491 Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M common/hw-gfx-gma-pipe_setup.ads M common/hw-gfx-gma.adb 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Paul Menzel: Looks good to me, but someone else must approve Nico Huber: Verified Elyes Haouas: Looks good to me, approved diff --git a/common/hw-gfx-gma-pipe_setup.ads b/common/hw-gfx-gma-pipe_setup.ads index 960e70f..7270cb2 100644 --- a/common/hw-gfx-gma-pipe_setup.ads +++ b/common/hw-gfx-gma-pipe_setup.ads @@ -16,7 +16,6 @@ with HW.GFX.GMA.Config_Helpers; with HW.GFX.GMA.Registers; -use type HW.Int32; private package HW.GFX.GMA.Pipe_Setup is diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index cacafd3..c3073d3 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -33,7 +33,6 @@ with HW.Debug; with GNAT.Source_Info; -use type HW.Int32; package body HW.GFX.GMA with Refined_State => -- To view, visit https://review.coreboot.org/c/libgfxinit/+/76491?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: Ic41a20167b88b5952642cc59e80315c5d2fd98b0 Gerrit-Change-Number: 76491 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: doc/forums: Update Matrix channel link
by Nico Huber (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Felix Singer, Patrick Georgi, Paul Menzel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76864?usp=email ) Change subject: doc/forums: Update Matrix channel link ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76864/comment/e83b1eae_78da44c4 : PS1, Line 9: Channel portalling has been disabled for the matrix.org-libera.chat > Maybe link to https://libera.chat/news/matrix-deportalling. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76864?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896bfed71790988503dc8229fe9b34e175046dbf Gerrit-Change-Number: 76864 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 01 Aug 2023 09:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: doc/forums: Update Matrix channel link
by Nico Huber (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Felix Singer, Nico Huber, Patrick Georgi. Hello Felix Singer, Patrick Georgi, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76864?usp=email to look at the new patch set (#2). Change subject: doc/forums: Update Matrix channel link ...................................................................... doc/forums: Update Matrix channel link Channel portalling has been disabled for the matrix.org-libera.chat bridge[1]. Hence, we created a new Matrix channel #coreboot:matrix.org (that is plumbed to the IRC channel). [1] https://libera.chat/news/matrix-deportalling Change-Id: I896bfed71790988503dc8229fe9b34e175046dbf Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Documentation/community/forums.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/76864/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76864?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896bfed71790988503dc8229fe9b34e175046dbf Gerrit-Change-Number: 76864 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/rex: enable d3hot for storage devices
by Subrata Banik (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Eric Lai, Jakub Czapiga, Kangheui Won, Kapil Porwal, Sukumar Ghorai, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76835?usp=email ) Change subject: mb/google/rex: enable d3hot for storage devices ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > This actually depends on SSD FW. It would be good to test Hynix, Samsung etc. Anyway, d3hot should be fine for mainstream SSD. I agree that this is to W/A SSD FW related issue, but there is no harm to try RTD3 at the controller side. -- To view, visit https://review.coreboot.org/c/coreboot/+/76835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19decc2706954e73bc28fc2d9c3c4d18d2c384b7 Gerrit-Change-Number: 76835 Gerrit-PatchSet: 3 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 09:30:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/soc/intel/alderlake: add SOC_INTEL_RAPTORLAKE_PCH_S symbol
by Eric Lai (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Michał Żygowski, Subrata Banik, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76322?usp=email ) Change subject: src/soc/intel/alderlake: add SOC_INTEL_RAPTORLAKE_PCH_S symbol ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76322?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I303fac78dac1ed7ccc9d531a6c3c10262f7273ee Gerrit-Change-Number: 76322 Gerrit-PatchSet: 12 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 09:00:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/soc/intel/alderlake: add SOC_INTEL_RAPTORLAKE_PCH_S symbol
by Michał Kopeć (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Eric Lai, Michał Żygowski, Subrata Banik, Tarun Tuli. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76322?usp=email ) Change subject: src/soc/intel/alderlake: add SOC_INTEL_RAPTORLAKE_PCH_S symbol ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76322?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I303fac78dac1ed7ccc9d531a6c3c10262f7273ee Gerrit-Change-Number: 76322 Gerrit-PatchSet: 12 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 08:58:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AB-MGCL
by Eric Lai (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jian Tong, Shou-Chieh Hsu. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76866?usp=email ) Change subject: mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AB-MGCL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76866?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92a1f2110e74b5d25572e0e86e04b5b32112c1f5 Gerrit-Change-Number: 76866 Gerrit-PatchSet: 1 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 08:57:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/cret: Generate new SPD ID for new memory parts
by 9elements QA (Code Review) 01 Aug '23

01 Aug '23

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75882?usp=email ) Change subject: mb/google/dedede/var/cret: Generate new SPD ID for new memory parts ...................................................................... Patch Set 4: Automatic boot test returned (PASS/FAIL/TOTAL): 8 / 4 / 12 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/175665 FAIL: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/175664 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/175663 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/175662 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/175661 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/175660 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/175659 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/175658 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/175657 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/175656 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/175655 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/175654 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/75882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7f23dc3604fe1869772d92c9d7b8cc32ed9bbb9 Gerrit-Change-Number: 75882 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 08:56:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add overridetree
by Rex Chou (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Chen-Tsung Hsieh, Derek Huang, Dtrain Hsu, Ian Feng, Kenny Pan, Shou-Chieh Hsu, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli. Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76662?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add overridetree ...................................................................... Patch Set 10: (17 comments) File src/mainboard/google/brya/variants/craaskov/overridetree.cb: https://review.coreboot.org/c/coreboot/+/76662/comment/2200bada_e1018c1d : PS9, Line 79: device ref i2c1 on > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/1eed69e4_73b57a5d : PS9, Line 81: register "generic.hid" = ""ELAN9004"" : register "generic.desc" = ""ELAN Touchscreen"" : register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" : register "generic.probed" = "1" : register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" : register "generic.reset_delay_ms" = "20" : register "generic.reset_off_delay_ms" = "2" : register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" : register "generic.enable_delay_ms" = "1" : register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" : register "generic.stop_delay_ms" = "150" : register "generic.stop_off_delay_ms" = "2" : register "generic.has_power_resource" = "1" : register "hid_desc_reg_offset" = "0x01" : device i2c 10 on end > use tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/f30eca04_2a20387c : PS9, Line 98: > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/2afc7f75_ba980bd4 : PS9, Line 110: > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/c8db7705_8bd36833 : PS9, Line 111: > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/4683eb10_6f01b1ef : PS9, Line 131: > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/d8abc487_ec9d531c : PS9, Line 176: register "use_custom_pld" = "true" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/736a0514_eaa884a7 : PS9, Line 177: register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/f76200a9_183cbc78 : PS9, Line 183: register "use_custom_pld" = "true" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/2ac02ec5_9b339859 : PS9, Line 184: register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(3, 1))" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/45e0a2ad_fd9edb66 : PS9, Line 190: register "use_custom_pld" = "true" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/afda517f_100224db : PS9, Line 191: register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, LEFT, ACPI_PLD_GROUP(4, 1))" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/7d58696d_6ced20cd : PS9, Line 206: chip drivers/usb/acpi > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/3e5085d7_37f3e841 : PS9, Line 215: register "use_custom_pld" = "true" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/9e9efb1d_8a579055 : PS9, Line 216: register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(3, 1))" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/66b6184e_fa37a2fd : PS9, Line 222: register "use_custom_pld" = "true" > tab Done https://review.coreboot.org/c/coreboot/+/76662/comment/588c4f0b_dc8b6795 : PS9, Line 223: register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, LEFT, ACPI_PLD_GROUP(4, 1))" > tab Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76662?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id002282d91dc94b00f5d133203b62ca39d6cae6d Gerrit-Change-Number: 76662 Gerrit-PatchSet: 10 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 08:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Derek Huang <derekhuang(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023