coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6708 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add overridetree
by Derek Huang (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Chen-Tsung Hsieh, Dtrain Hsu, Ian Feng, Kenny Pan, Rex Chou, Shou-Chieh Hsu, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76662?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add overridetree ...................................................................... Patch Set 9: (17 comments) File src/mainboard/google/brya/variants/craaskov/overridetree.cb: https://review.coreboot.org/c/coreboot/+/76662/comment/068cf66b_48f8d16e : PS9, Line 79: device ref i2c1 on tab https://review.coreboot.org/c/coreboot/+/76662/comment/176ed105_87a230c3 : PS9, Line 81: register "generic.hid" = ""ELAN9004"" : register "generic.desc" = ""ELAN Touchscreen"" : register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" : register "generic.probed" = "1" : register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" : register "generic.reset_delay_ms" = "20" : register "generic.reset_off_delay_ms" = "2" : register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" : register "generic.enable_delay_ms" = "1" : register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" : register "generic.stop_delay_ms" = "150" : register "generic.stop_off_delay_ms" = "2" : register "generic.has_power_resource" = "1" : register "hid_desc_reg_offset" = "0x01" : device i2c 10 on end use tab https://review.coreboot.org/c/coreboot/+/76662/comment/a3feb6e7_929c5050 : PS9, Line 98: tab https://review.coreboot.org/c/coreboot/+/76662/comment/62b3bcb7_dc4ebaf4 : PS9, Line 110: tab https://review.coreboot.org/c/coreboot/+/76662/comment/b2a768c3_6fa5dcea : PS9, Line 111: tab https://review.coreboot.org/c/coreboot/+/76662/comment/2c33e47c_3807d8e5 : PS9, Line 131: tab https://review.coreboot.org/c/coreboot/+/76662/comment/03d10abb_84f80001 : PS9, Line 176: register "use_custom_pld" = "true" tab https://review.coreboot.org/c/coreboot/+/76662/comment/04baeacc_15d90d62 : PS9, Line 177: register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))" tab https://review.coreboot.org/c/coreboot/+/76662/comment/2ddabd99_4ab93aae : PS9, Line 183: register "use_custom_pld" = "true" tab https://review.coreboot.org/c/coreboot/+/76662/comment/a028da3a_8fc40369 : PS9, Line 184: register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(3, 1))" tab https://review.coreboot.org/c/coreboot/+/76662/comment/d5de1513_6bb68323 : PS9, Line 190: register "use_custom_pld" = "true" tab https://review.coreboot.org/c/coreboot/+/76662/comment/e15180f5_b27a0408 : PS9, Line 191: register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, LEFT, ACPI_PLD_GROUP(4, 1))" tab https://review.coreboot.org/c/coreboot/+/76662/comment/266d5783_1fd6b5ee : PS9, Line 206: chip drivers/usb/acpi tab https://review.coreboot.org/c/coreboot/+/76662/comment/3b79a490_0d700686 : PS9, Line 215: register "use_custom_pld" = "true" tab https://review.coreboot.org/c/coreboot/+/76662/comment/0b1f0817_feccb66a : PS9, Line 216: register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(3, 1))" tab https://review.coreboot.org/c/coreboot/+/76662/comment/5812c05b_4aa94130 : PS9, Line 222: register "use_custom_pld" = "true" tab https://review.coreboot.org/c/coreboot/+/76662/comment/425a60ac_ff1a166f : PS9, Line 223: register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, LEFT, ACPI_PLD_GROUP(4, 1))" tab -- To view, visit https://review.coreboot.org/c/coreboot/+/76662?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id002282d91dc94b00f5d133203b62ca39d6cae6d Gerrit-Change-Number: 76662 Gerrit-PatchSet: 9 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 06:33:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: support DPTF oem_variables
by Eric Lai (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Derek Huang, Felix Held, Ivan Chen, Mark Hsieh, Shou-Chieh Hsu, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76773?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/joxer: support DPTF oem_variables ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/joxer/ramstage.c: https://review.coreboot.org/c/coreboot/+/76773/comment/4f96724b_932cc4b9 : PS3, Line 20: static void update_oem_variables(void) why don't you just put this in variant.c? IMHO, no need for extra file. -- To view, visit https://review.coreboot.org/c/coreboot/+/76773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167 Gerrit-Change-Number: 76773 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 05:31:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: support DPTF oem_variables
by Scott Chao (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Derek Huang, Eric Lai, Felix Held, Ivan Chen, Mark Hsieh, Shou-Chieh Hsu, Tarun Tuli. Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76773?usp=email ) Change subject: mb/google/nissa/var/joxer: support DPTF oem_variables ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167 Gerrit-Change-Number: 76773 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 05:26:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: support DPTF oem_variables
by Mark Hsieh (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Derek Huang, Eric Lai, Felix Held, Ivan Chen, Shou-Chieh Hsu, Tarun Tuli. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76773?usp=email ) Change subject: mb/google/nissa/var/joxer: support DPTF oem_variables ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/joxer/ramstage.c: https://review.coreboot.org/c/coreboot/+/76773/comment/6afee221_c365511c : PS2, Line 31: config->oem_data.oem_variables[0] = 1; > this will have variables[1] = 1 since you set in device tree.. updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/76773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167 Gerrit-Change-Number: 76773 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 05:24:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: support DPTF oem_variables
by Mark Hsieh (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Derek Huang, Felix Held, Ivan Chen, Shou-Chieh Hsu, Tarun Tuli. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76773?usp=email ) Change subject: mb/google/nissa/var/joxer: support DPTF oem_variables ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/76773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167 Gerrit-Change-Number: 76773 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 05:23:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: arch/x86: Adjust stack pointer to point to dummy argument
by Sridhar Siricilla (Code Review) 01 Aug '23

01 Aug '23

Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76878?usp=email ) Change subject: arch/x86: Adjust stack pointer to point to dummy argument ...................................................................... arch/x86: Adjust stack pointer to point to dummy argument The patch pushes dummy argument so that stack pointer points to this dummy element instead of coreboot table address as depthcharge picks the second element from top of the stack as coreboot table address. The change is applicable when system switches from long mode to protected mode before passing the control to depthcharge. TEST=Tested in simics environment.64bit coreboot could boot to OS. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I6e4034f65f5db23560f774f56e0edfb08e4283ad --- M src/arch/x86/c_exit.S 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/76878/1 diff --git a/src/arch/x86/c_exit.S b/src/arch/x86/c_exit.S index 069a66c..869be3f 100644 --- a/src/arch/x86/c_exit.S +++ b/src/arch/x86/c_exit.S @@ -31,6 +31,6 @@ andl $0xFFFFFFF0, %esp subl $12, %esp pushl %ebx /* Argument 0 */ - + pushl $0 /* Dummy argument */ jmp *%eax #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/76878?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e4034f65f5db23560f774f56e0edfb08e4283ad Gerrit-Change-Number: 76878 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: mb/google/rex: enable d3hot for storage devices
by Subrata Banik (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Sukumar Ghorai, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76835?usp=email ) Change subject: mb/google/rex: enable d3hot for storage devices ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Looks like redundant CL of CB:76831 -- To view, visit https://review.coreboot.org/c/coreboot/+/76835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19decc2706954e73bc28fc2d9c3c4d18d2c384b7 Gerrit-Change-Number: 76835 Gerrit-PatchSet: 2 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 04:31:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/boxy: Update power limits
by Stanley Wu (Code Review) 01 Aug '23

01 Aug '23

Stanley Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76877?usp=email ) Change subject: mb/google/dedede/var/boxy: Update power limits ...................................................................... mb/google/dedede/var/boxy: Update power limits Add ramstage.c in Makefile.inc and update boxy power limits in Boxy ramstage.c. BUG=b:290293153 TEST=emerge-dedede coreboot and check psys and PLx value on boxy Change-Id: I4257dab358f066ebd13b6f251e8a5258a72fbd39 Signed-off-by: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/boxy/Makefile.inc A src/mainboard/google/dedede/variants/boxy/ramstage.c 2 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/76877/1 diff --git a/src/mainboard/google/dedede/variants/boxy/Makefile.inc b/src/mainboard/google/dedede/variants/boxy/Makefile.inc index eb2c9bc..66f0263 100644 --- a/src/mainboard/google/dedede/variants/boxy/Makefile.inc +++ b/src/mainboard/google/dedede/variants/boxy/Makefile.inc @@ -1,3 +1,4 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ramstage-y += gpio.c +ramstage-y += ramstage.c diff --git a/src/mainboard/google/dedede/variants/boxy/ramstage.c b/src/mainboard/google/dedede/variants/boxy/ramstage.c new file mode 100644 index 0000000..64510cc --- /dev/null +++ b/src/mainboard/google/dedede/variants/boxy/ramstage.c @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/variants.h> + +/* + * Psys_pmax considerations + * + * Given the hardware design in dibbi, the serial shunt resistor is 0.01ohm. + * The full scale of hardware PSYS signal 1.6v maps to system current 6.009A + * instead of real system power. The equation is shown below: + * PSYS = 1.6v ~= (0.01ohm x 6.009A) x 50 (INA213, gain 50V/V) x R631/(R631 + R638) + * R631/(R631 + R638) = 0.5325 = 36K / (36K + 31.6K) + * + * The Psys_pmax is a SW setting which tells IMVP9.1 the mapping between system input + * current and the actual system power. Since there is no voltage information + * from PSYS, different voltage input would map to different Psys_pmax settings: + * For Type-C 15V, the Psys_pmax should be 15v x 6.009A = 90.135W + * For Type-C 20V, the Psys_pmax should be 20v x 6.009A = 120.18W + * For a barrel jack, the Psys_pmax should be 19v x 6.009A = 114.171W + * + * Imagine that there is a type-c 100W (20V/5A) connected to DUT w/ full loading, + * and the Psys_pmax setting is 120W. Then IMVP9.1 can calculate the current system + * power = 120W * 5A / 6.009A = 100W, which is the actual system power. + */ +const struct psys_config psys_config = { + .efficiency = 97, + .psys_imax_ma = 6009, + .bj_volts_mv = 19000, + .bj_power_w = 65, +}; + +void variant_devtree_update(void) +{ + variant_update_psys_power_limits(&psys_config); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/76877?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4257dab358f066ebd13b6f251e8a5258a72fbd39 Gerrit-Change-Number: 76877 Gerrit-PatchSet: 1 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/boxy:Add power limits for Boxy
by Stanley Wu (Code Review) 01 Aug '23

01 Aug '23

Stanley Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76876?usp=email ) Change subject: mb/google/dedede/var/boxy:Add power limits for Boxy ...................................................................... mb/google/dedede/var/boxy:Add power limits for Boxy Add PLx from JSL PDG in boxy devicetree. BUG=b:290293153 TEST=emerge-dedede coreboot and read correct value on boxy Change-Id: I7b063dc235fb714ba47eb620b914f2f9e92a2715 Signed-off-by: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/boxy/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/76876/1 diff --git a/src/mainboard/google/dedede/variants/boxy/overridetree.cb b/src/mainboard/google/dedede/variants/boxy/overridetree.cb index ecf71ae..10ae686 100644 --- a/src/mainboard/google/dedede/variants/boxy/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boxy/overridetree.cb @@ -33,6 +33,19 @@ }, }" + # Power limit config + register "power_limits_config[JSL_N4500_6W_CORE]" = "{ + .tdp_pl1_override = 6, + .tdp_pl2_override = 20, + .tdp_pl4 = 60, + }" + + register "power_limits_config[JSL_N5100_6W_CORE]" = "{ + .tdp_pl1_override = 6, + .tdp_pl2_override = 20, + .tdp_pl4 = 60, + }" + # Enable Root Port 3 (index 2) for LAN # External PCIe port 7 is mapped to PCIe Root Port 3 register "PcieRpEnable[2]" = "1" -- To view, visit https://review.coreboot.org/c/coreboot/+/76876?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b063dc235fb714ba47eb620b914f2f9e92a2715 Gerrit-Change-Number: 76876 Gerrit-PatchSet: 1 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: mb/google/rex: enable d3hot for storage devices
by Kangheui Won (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun Tuli. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76835?usp=email ) Change subject: mb/google/rex: enable d3hot for storage devices ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: nit: IMHO it'd better to state that this is a W/A for storage devices in rex. -- To view, visit https://review.coreboot.org/c/coreboot/+/76835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19decc2706954e73bc28fc2d9c3c4d18d2c384b7 Gerrit-Change-Number: 76835 Gerrit-PatchSet: 2 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 03:27:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023