coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[XS] Change in coreboot[master]: [WIP] mb/google/guybrush: enable amdfw separation
by Kangheui Won (Code Review) 01 Aug '23

01 Aug '23

Kangheui Won has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60292?usp=email ) Change subject: [WIP] mb/google/guybrush: enable amdfw separation ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/60292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I332e6b84362c12ff3b437db46788d2c27da9af0a Gerrit-Change-Number: 60292 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: (wip)util/crossgcc: Update binutils from 2.40 to 2.41
by Elyes Haouas (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Felix Singer, Martin L Roth. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76852?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: (wip)util/crossgcc: Update binutils from 2.40 to 2.41 ...................................................................... (wip)util/crossgcc: Update binutils from 2.40 to 2.41 Change-Id: I6c985974e2eeea1329b2dbb232711c72b0bd99bc Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/patches/binutils-2.40_stop_loosing_entry_point_when_LTO_enabled.patch R util/crossgcc/patches/binutils-2.41_as-ipxe.patch R util/crossgcc/patches/binutils-2.41_no-makeinfo.patch D util/crossgcc/sum/binutils-2.40.tar.xz.cksum A util/crossgcc/sum/binutils-2.41.tar.xz.cksum 6 files changed, 46 insertions(+), 90 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/76852/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76852?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c985974e2eeea1329b2dbb232711c72b0bd99bc Gerrit-Change-Number: 76852 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: (wip)util/crossgcc: Update GMP from 6.2.1 to 6.3.0
by Elyes Haouas (Code Review) 01 Aug '23

01 Aug '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76865?usp=email ) Change subject: (wip)util/crossgcc: Update GMP from 6.2.1 to 6.3.0 ...................................................................... (wip)util/crossgcc: Update GMP from 6.2.1 to 6.3.0 Change-Id: I67d443cb15d89482b20b01f4068502b16ac8fc8e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gmp-6.3.0_generic-build.patch D util/crossgcc/sum/gmp-6.2.1.tar.xz.cksum A util/crossgcc/sum/gmp-6.3.0.tar.xz.cksum 4 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/76865/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 575073c..4680618 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -34,7 +34,7 @@ COREBOOT_MIRROR_URL="https://www.coreboot.org/releases/crossgcc-sources" # GCC toolchain version numbers -GMP_VERSION=6.2.1 +GMP_VERSION=6.3.0 MPFR_VERSION=4.2.0 MPC_VERSION=1.3.1 GCC_VERSION=11.4.0 diff --git a/util/crossgcc/patches/gmp-6.2.1_generic-build.patch b/util/crossgcc/patches/gmp-6.3.0_generic-build.patch similarity index 100% rename from util/crossgcc/patches/gmp-6.2.1_generic-build.patch rename to util/crossgcc/patches/gmp-6.3.0_generic-build.patch diff --git a/util/crossgcc/sum/gmp-6.2.1.tar.xz.cksum b/util/crossgcc/sum/gmp-6.2.1.tar.xz.cksum deleted file mode 100644 index 3ea4232..0000000 --- a/util/crossgcc/sum/gmp-6.2.1.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -0578d48607ec0e272177d175fd1807c30b00fdf2 tarballs/gmp-6.2.1.tar.xz diff --git a/util/crossgcc/sum/gmp-6.3.0.tar.xz.cksum b/util/crossgcc/sum/gmp-6.3.0.tar.xz.cksum new file mode 100644 index 0000000..56abf27 --- /dev/null +++ b/util/crossgcc/sum/gmp-6.3.0.tar.xz.cksum @@ -0,0 +1 @@ +b4043dd2964ab1a858109da85c44de224384f352 tarballs/gmp-6.3.0.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/76865?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67d443cb15d89482b20b01f4068502b16ac8fc8e Gerrit-Change-Number: 76865 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: doc/forums: Update Matrix channel link
by Paul Menzel (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76864?usp=email ) Change subject: doc/forums: Update Matrix channel link ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76864/comment/c482e3e5_f0adea44 : PS1, Line 9: Channel portalling has been disabled for the matrix.org-libera.chat Maybe link to https://libera.chat/news/matrix-deportalling. -- To view, visit https://review.coreboot.org/c/coreboot/+/76864?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896bfed71790988503dc8229fe9b34e175046dbf Gerrit-Change-Number: 76864 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 01:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Generate new TME key on each warm boot
by Ravishankar Sarawadi (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Pratikkumar V Prajapati, Subrata Banik, Tarun Tuli. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75627?usp=email ) Change subject: soc/intel/meteorlake: Generate new TME key on each warm boot ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3161ab99b83fb7765646be31978942f271ba1f9e Gerrit-Change-Number: 75627 Gerrit-PatchSet: 9 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 01:35:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen
by Ravishankar Sarawadi (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Pratikkumar V Prajapati, Subrata Banik, Tarun Tuli. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75626?usp=email ) Change subject: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8d33f470977ce8db2fd137bab9c63e325b4a32d Gerrit-Change-Number: 75626 Gerrit-PatchSet: 13 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 01:34:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: enable d3hot for storage devices
by Sukumar Ghorai (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kangheui Won, Kapil Porwal, Subrata Banik, Tarun Tuli. Hello Jakub Czapiga, Kangheui Won, Kapil Porwal, Subrata Banik, Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76835?usp=email to look at the new patch set (#2). Change subject: mb/google/rex: enable d3hot for storage devices ...................................................................... mb/google/rex: enable d3hot for storage devices _DSD "StorageD3Enable" property is needed to set under the root port in the DSDT or SSDT. The ACPI _DSD method is the preferred way to opt D3hot support for storage devices. Name (_DSD, Package () {         ToUUID("5025030F-842F-4AB4-A561-99A5189762D0"),            Package () {                 Package (2) {"StorageD3Enable", 1}, // 1 - Enable; 0 - Disable             }         } ) BUG=b:289028958 TEST=Check code compiles & boot rex, and verify the "StorageD3Enable" SSDT entry. Change-Id: I19decc2706954e73bc28fc2d9c3c4d18d2c384b7 Signed-off-by: Kangheui Won <khwon(a)chromium.org> Signed-off-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/76835/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19decc2706954e73bc28fc2d9c3c4d18d2c384b7 Gerrit-Change-Number: 76835 Gerrit-PatchSet: 2 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/rex: enable d3hot for storage devices
by Sukumar Ghorai (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Kangheui Won. Hello Kangheui Won, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/76835?usp=email to review the following change. Change subject: mb/google/rex: enable d3hot for storage devices ...................................................................... mb/google/rex: enable d3hot for storage devices _DSD "StorageD3Enable" property is needed to set under the root port in the DSDT or SSDT. The ACPI _DSD method is the preferred way to opt D3hot support for storage devices. Name (_DSD, Package () {         ToUUID("5025030F-842F-4AB4-A561-99A5189762D0"),            Package () {                 Package (2) {"StorageD3Enable", 1}, // 1 - Enable; 0 - Disable             }         } ) BUG=b:289028958 TEST=Check code compiles & boot rex, and verify the "StorageD3Enable" SSDT entry. Change-Id: I19decc2706954e73bc28fc2d9c3c4d18d2c384b7 Signed-off-by: Kangheui Won <khwon(a)chromium.org> Signed-off-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/76835/1 diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index 793a46d..1435a7b 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -302,6 +302,13 @@ .clk_req = 4, .flags = PCIE_RP_LTR | PCIE_RP_AER, }" + chip soc/intel/common/block/pcie/rtd3 + register "is_storage" = "true" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A19)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A20)" + register "srcclk_pin" = "4" + device generic 0 on end + end end #PCIE9 SSD card device ref ish on probe ISH ISH_ENABLE -- To view, visit https://review.coreboot.org/c/coreboot/+/76835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19decc2706954e73bc28fc2d9c3c4d18d2c384b7 Gerrit-Change-Number: 76835 Gerrit-PatchSet: 1 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: mb/google/cyan: Drop I2C devices as wake sources
by Eric Lai (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Felix Held, Matt DeVillier. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76798?usp=email ) Change subject: mb/google/cyan: Drop I2C devices as wake sources ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Touchpad is wake source on chromebook. And we use GPE for that. cyan is pretty old boards not sure how they do this, hmm. -- To view, visit https://review.coreboot.org/c/coreboot/+/76798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d0883e4de9572a14c8bad0ac086370bd00eeb1a Gerrit-Change-Number: 76798 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 00:42:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cbfstool: Add relocation support for EFI binaries
by Jérémy Compostella (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Anil Kumar K, Cliff Huang, Paul Menzel, Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76762?usp=email ) Change subject: cbfstool: Add relocation support for EFI binaries ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76762/comment/64b9f78f_daa9f171 : PS3, Line 14: Platform specific > Maybe lower case? platform specific Done File src/commonlib/fsp_relocate.c: https://review.coreboot.org/c/coreboot/+/76762/comment/c718c511_1881d901 : PS3, Line 284: return 0; > Why does the return value need to be changed? Excellent question: I could not find any reason why this function would return -1 on success but it was not an issue so far as no code was checking its return value. Oher similar functions such as `te_relocate` do end on a `return 0`. -- To view, visit https://review.coreboot.org/c/coreboot/+/76762?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e98ffd1d864cf9ac675421471d888334d8ab28b Gerrit-Change-Number: 76762 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 01 Aug 2023 00:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023