coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: support DPTF oem_variables
by Mark Hsieh (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Derek Huang, Eric Lai, Felix Held, Ivan Chen, Scott Chao, Shou-Chieh Hsu, Tarun Tuli. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76773?usp=email ) Change subject: mb/google/nissa/var/joxer: support DPTF oem_variables ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/joxer/ramstage.c: https://review.coreboot.org/c/coreboot/+/76773/comment/3502cd46_abf04323 : PS3, Line 20: static void update_oem_variables(void) > why don't you just put this in variant.c? IMHO, no need for extra file. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167 Gerrit-Change-Number: 76773 Gerrit-PatchSet: 4 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 11:18:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: support DPTF oem_variables
by Mark Hsieh (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Derek Huang, Felix Held, Ivan Chen, Mark Hsieh, Scott Chao, Shou-Chieh Hsu, Tarun Tuli. Hello Derek Huang, Felix Held, Ivan Chen, Scott Chao, Shou-Chieh Hsu, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76773?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by Scott Chao, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/joxer: support DPTF oem_variables ...................................................................... mb/google/nissa/var/joxer: support DPTF oem_variables 1. Joxer uses dptf.dv to distinguish 6W/15W by setting OEM variable. 2. Update passive policy and critical policy. BUG=b:285477026 TEST=emerge-nissa coreboot and check the OEM variable. Signed-off-by: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167 --- M src/mainboard/google/brya/variants/joxer/overridetree.cb M src/mainboard/google/brya/variants/joxer/variant.c 2 files changed, 42 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/76773/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/76773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167 Gerrit-Change-Number: 76773 Gerrit-PatchSet: 4 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add overridetree
by Derek Huang (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Chen-Tsung Hsieh, Dtrain Hsu, Ian Feng, Kenny Pan, Rex Chou, Shou-Chieh Hsu, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76662?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add overridetree ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76662?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id002282d91dc94b00f5d133203b62ca39d6cae6d Gerrit-Change-Number: 76662 Gerrit-PatchSet: 10 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 11:14:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: 3rdparty/libgfxinit: Uprev to avoid new GCC 13 warning
by Felix Singer (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Elyes Haouas, Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76868?usp=email ) Change subject: 3rdparty/libgfxinit: Uprev to avoid new GCC 13 warning ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76868?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I908d5f2b98e2251a09c587d82b3e7fab55b338a2 Gerrit-Change-Number: 76868 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 01 Aug 2023 11:13:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: 3rdparty/libhwbase: Uprev to avoid new GCC 13 warning
by Felix Singer (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Elyes Haouas, Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76867?usp=email ) Change subject: 3rdparty/libhwbase: Uprev to avoid new GCC 13 warning ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76867?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I816f915d991d3d436d0468ca411037b1dc6d0e56 Gerrit-Change-Number: 76867 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 01 Aug 2023 11:13:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/msi/ms7e06: Add support for MSI PRO Z790-P DDR4/DDR5 (WIFI)
by Michał Kopeć (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Felix Singer, Michał Żygowski. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76325?usp=email ) Change subject: mb/msi/ms7e06: Add support for MSI PRO Z790-P DDR4/DDR5 (WIFI) ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76325?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id2c77621d24bb097b930342eb1961270854d5f68 Gerrit-Change-Number: 76325 Gerrit-PatchSet: 14 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 11:04:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: nb/pi/00730F01: Rework nb resource reading
by Arthur Heymans (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76278?usp=email ) Change subject: nb/pi/00730F01: Rework nb resource reading ...................................................................... Patch Set 3: (1 comment) File src/northbridge/amd/pi/00730F01/northbridge.c: https://review.coreboot.org/c/coreboot/+/76278/comment/7fc9bc85_33721629 : PS1, Line 112: *limit = ((temp & 0xffff0000) >> 16) << 24; > Do the shifts here work with u32 tmp ? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5685de63ff8971fc4873080e4b9542e6bbf58509 Gerrit-Change-Number: 76278 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 10:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Exclude CBMEM region from TME encryption
by Subrata Banik (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Pratikkumar V Prajapati, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75909?usp=email ) Change subject: soc/intel/meteorlake: Exclude CBMEM region from TME encryption ...................................................................... Patch Set 8: (1 comment) Patchset: PS4: > Lets keep it separate, considering separate tests performed which is already detailed in commit message for both of these patches. I don't see a point of having two CL (for same SOC) to enable configs which are interdependent. Assume those cls are landing separately and ended up adding into two different CPFE (by the builder) releases, then there would be one CPFE where CBMEM ranges (cbmem -c/-t, ramoops) are all encrypted and unable to access those range. The condition would be worse if ODM/OEM picked such CPFE for their SMT. It would create unnecessarily trouble by the end of the day. -- To view, visit https://review.coreboot.org/c/coreboot/+/75909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5d9fc3317ee4d3a0794692cea7a593c89db1e92 Gerrit-Change-Number: 75909 Gerrit-PatchSet: 8 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 10:13:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: 3rdparty/libgfxinit: Uprev to avoid new GCC 13 warning
by Nico Huber (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Elyes Haouas, Felix Singer. Hello Felix Singer, Elyes Haouas, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/76868?usp=email to review the following change. Change subject: 3rdparty/libgfxinit: Uprev to avoid new GCC 13 warning ...................................................................... 3rdparty/libgfxinit: Uprev to avoid new GCC 13 warning This pulls just one commit: * commit a4be8a21b0e2 (Avoid warning '"Pos32" is already use-visible') Change-Id: I908d5f2b98e2251a09c587d82b3e7fab55b338a2 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 3rdparty/libgfxinit 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/76868/1 diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 732feb4..a4be8a2 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 732feb414dcb58e9282d25fc8c569d372d179f47 +Subproject commit a4be8a21b0e2c752da0042c79aae5942418f53e2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76868?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I908d5f2b98e2251a09c587d82b3e7fab55b338a2 Gerrit-Change-Number: 76868 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: 3rdparty/libhwbase: Uprev to avoid new GCC 13 warning
by Nico Huber (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Elyes Haouas, Felix Singer. Hello Felix Singer, Elyes Haouas, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/76867?usp=email to review the following change. Change subject: 3rdparty/libhwbase: Uprev to avoid new GCC 13 warning ...................................................................... 3rdparty/libhwbase: Uprev to avoid new GCC 13 warning This pulls just one commit: * commit 584629b9f477 (Avoid warning '"Pos64" is already use-visible') Change-Id: I816f915d991d3d436d0468ca411037b1dc6d0e56 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 3rdparty/libhwbase 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/76867/1 diff --git a/3rdparty/libhwbase b/3rdparty/libhwbase index 95ad8c5..584629b 160000 --- a/3rdparty/libhwbase +++ b/3rdparty/libhwbase @@ -1 +1 @@ -Subproject commit 95ad8c53c6e208d769d190787b9987dbeacbca42 +Subproject commit 584629b9f4771b7618951cec57df2ca3af9c6981 -- To view, visit https://review.coreboot.org/c/coreboot/+/76867?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I816f915d991d3d436d0468ca411037b1dc6d0e56 Gerrit-Change-Number: 76867 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023