coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6718 discussions

[S] Change in coreboot[master]: soc/intel/alderlake: Make RPL-guarded FSP UPDs depend on FSP_USE_REPO
by Michał Kopeć (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Michał Żygowski, Paul Menzel, Subrata Banik, Tarun Tuli. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76418?usp=email ) Change subject: soc/intel/alderlake: Make RPL-guarded FSP UPDs depend on FSP_USE_REPO ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File src/soc/intel/alderlake/include/soc/vr_config.h: https://review.coreboot.org/c/coreboot/+/76418/comment/1d1fb0ff_fcf9f09e : PS5, Line 12: /* > This can be simplified to `#if CONFIG(SOC_INTEL_RAPTORLAKE) || CONFIG(FSP_USE_REPO)`, no? Ah, no. -- To view, visit https://review.coreboot.org/c/coreboot/+/76418?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5a2da463a74f4ac80dcb407a39fc45b0b6a10a8 Gerrit-Change-Number: 76418 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 01 Aug 2023 12:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: support DPTF oem_variables
by Mark Hsieh (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Derek Huang, Eric Lai, Felix Held, Ivan Chen, Scott Chao, Shou-Chieh Hsu, Tarun Tuli. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76773?usp=email ) Change subject: mb/google/nissa/var/joxer: support DPTF oem_variables ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/brya/variants/joxer/variant.c: https://review.coreboot.org/c/coreboot/+/76773/comment/95d87b48_c637b453 : PS4, Line 9: #include <device/pci.h> > nit: header should in alphabet order Updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/76773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e52ac624f7d7628cce3035a2bac67fc527bc167 Gerrit-Change-Number: 76773 Gerrit-PatchSet: 5 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 12:49:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec/ec_commands.h: Use C99 flexible arrays
by Jakub Czapiga (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Elyes Haouas. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76838?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: ec/google/chromeec/ec_commands.h: Use C99 flexible arrays ...................................................................... Patch Set 1: (1 comment) File src/ec/google/chromeec/ec_commands.h: PS1: This file is a copy of [ChromeEC ec_commands.h](https://chromium.googlesource.com/chromiumos/platform/ec/+/r…. I do not think it should be altered this way as any update to source file will lead to more differences than anticipated. I think it would be better to fix this issue in the source repository first (if feasible). -- To view, visit https://review.coreboot.org/c/coreboot/+/76838?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa8ec6638d1141251ecaae6668ca07efa9d14006 Gerrit-Change-Number: 76838 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 12:48:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Make RPL-guarded FSP UPDs depend on FSP_USE_REPO
by Michał Kopeć (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Michał Żygowski, Paul Menzel, Subrata Banik, Tarun Tuli. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76418?usp=email ) Change subject: soc/intel/alderlake: Make RPL-guarded FSP UPDs depend on FSP_USE_REPO ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/soc/intel/alderlake/include/soc/vr_config.h: https://review.coreboot.org/c/coreboot/+/76418/comment/23bb8d80_28190654 : PS5, Line 12: /* This can be simplified to `#if CONFIG(SOC_INTEL_RAPTORLAKE) || CONFIG(FSP_USE_REPO)`, no? -- To view, visit https://review.coreboot.org/c/coreboot/+/76418?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5a2da463a74f4ac80dcb407a39fc45b0b6a10a8 Gerrit-Change-Number: 76418 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 01 Aug 2023 12:48:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: Restrict ASPM to L1 for SD controller
by 9elements QA (Code Review) 01 Aug '23

01 Aug '23

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76829?usp=email ) Change subject: mb/google/rex/var/screebo: Restrict ASPM to L1 for SD controller ...................................................................... Patch Set 4: Automatic boot test returned (PASS/FAIL/TOTAL): 8 / 4 / 12 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/175680 FAIL: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/175679 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/175678 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/175677 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/175676 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/175675 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/175674 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/175673 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/175672 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/175671 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/175670 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/175669 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/76829?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05f02c46486be42286fe9bc4f4be17763bb12b79 Gerrit-Change-Number: 76829 Gerrit-PatchSet: 4 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 12:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: src/drivers/vpd/vpd.c: Use C99 flexible arrays
by Jakub Czapiga (Code Review) 01 Aug '23

01 Aug '23

Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76839?usp=email ) Change subject: src/drivers/vpd/vpd.c: Use C99 flexible arrays ...................................................................... src/drivers/vpd/vpd.c: Use C99 flexible arrays Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Change-Id: Iab55c57ee5cac60911c9fe4cee8d86a252bde372 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76839 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/vpd/vpd.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/drivers/vpd/vpd.c b/src/drivers/vpd/vpd.c index 4bd5f60..3146415 100644 --- a/src/drivers/vpd/vpd.c +++ b/src/drivers/vpd/vpd.c @@ -25,7 +25,7 @@ uint32_t version; uint32_t ro_size; uint32_t rw_size; - uint8_t blob[0]; + uint8_t blob[]; /* The blob contains both RO and RW data. It starts with RO (0 .. * ro_size) and then RW (ro_size .. ro_size+rw_size). */ -- To view, visit https://review.coreboot.org/c/coreboot/+/76839?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab55c57ee5cac60911c9fe4cee8d86a252bde372 Gerrit-Change-Number: 76839 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: security/intel/stm/StmApi.h: Use C99 flexible arrays
by Jakub Czapiga (Code Review) 01 Aug '23

01 Aug '23

Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76843?usp=email ) Change subject: security/intel/stm/StmApi.h: Use C99 flexible arrays ...................................................................... security/intel/stm/StmApi.h: Use C99 flexible arrays Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Change-Id: I3ab3538b276fee5ed135bb4e88d9ef2cd6a00bb9 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76843 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/security/intel/stm/StmApi.h 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/security/intel/stm/StmApi.h b/src/security/intel/stm/StmApi.h index af57341..1a594a7 100644 --- a/src/security/intel/stm/StmApi.h +++ b/src/security/intel/stm/StmApi.h @@ -42,7 +42,7 @@ uint32_t additional_dynamic_memory_size; STM_FEAT stm_features; uint32_t number_of_rev_ids; - uint32_t stm_smm_rev_id[1]; + uint32_t stm_smm_rev_id[]; // The total STM_HEADER should be 4K. } SOFTWARE_STM_HEADER; @@ -65,7 +65,7 @@ typedef struct { uint32_t image_size; uint32_t reserved; - uint64_t image_page_base[1]; //[NumberOfPages]; + uint64_t image_page_base[]; //[NumberOfPages]; } TXT_BIOS_COMPONENT_UPDATE; typedef struct { @@ -413,7 +413,7 @@ uint16_t length; uint8_t originating_bus_number; uint8_t last_node_index; - STM_PCI_DEVICE_PATH_NODE pci_device_path[1]; + STM_PCI_DEVICE_PATH_NODE pci_device_path[]; // STM_PCI_DEVICE_PATH_NODE PciDevicePath[LastNodeIndex + 1]; } STM_RSC_PCI_CFG_DESC; @@ -524,7 +524,7 @@ typedef struct { uint32_t page_count; - uint64_t pages[1]; // number of elements is PageCount + uint64_t pages[]; // number of elements is PageCount } STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA_LOG_BUFFER; typedef union { -- To view, visit https://review.coreboot.org/c/coreboot/+/76843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ab3538b276fee5ed135bb4e88d9ef2cd6a00bb9 Gerrit-Change-Number: 76843 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: security/tpm/tpm{1,2}_log_serialized.h: Use C99 flexible arrays
by Jakub Czapiga (Code Review) 01 Aug '23

01 Aug '23

Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76842?usp=email ) Change subject: security/tpm/tpm{1,2}_log_serialized.h: Use C99 flexible arrays ...................................................................... security/tpm/tpm{1,2}_log_serialized.h: Use C99 flexible arrays Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Change-Id: I79e4b34fe682f5f21415cb93cf65394881173b34 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76842 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/security/tpm/tpm1_log_serialized.h M src/security/tpm/tpm2_log_serialized.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/security/tpm/tpm1_log_serialized.h b/src/security/tpm/tpm1_log_serialized.h index a8b7a60..7c7d51a 100644 --- a/src/security/tpm/tpm1_log_serialized.h +++ b/src/security/tpm/tpm1_log_serialized.h @@ -41,7 +41,7 @@ struct spec_id_event_data spec_id; struct tpm_1_vendor vendor; - struct tpm_1_log_entry entries[0]; /* Variable number of entries */ + struct tpm_1_log_entry entries[]; /* Variable number of entries */ } __packed; #endif diff --git a/src/security/tpm/tpm2_log_serialized.h b/src/security/tpm/tpm2_log_serialized.h index 2b4e43c..a11a2f6 100644 --- a/src/security/tpm/tpm2_log_serialized.h +++ b/src/security/tpm/tpm2_log_serialized.h @@ -64,7 +64,7 @@ struct tpm_digest_sizes digest_sizes[1]; uint8_t vendor_info_size; struct tpm_2_vendor vendor; - struct tpm_2_log_entry entries[0]; /* Variable number of entries */ + struct tpm_2_log_entry entries[]; /* Variable number of entries */ } __packed; #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/76842?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79e4b34fe682f5f21415cb93cf65394881173b34 Gerrit-Change-Number: 76842 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: payloads/coreinfo: Use C99 flexible arrays
by Jakub Czapiga (Code Review) 01 Aug '23

01 Aug '23

Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76848?usp=email ) Change subject: payloads/coreinfo: Use C99 flexible arrays ...................................................................... payloads/coreinfo: Use C99 flexible arrays Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Change-Id: I17811256b04a17539d3ed77f406892ae77e97515 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76848 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M payloads/coreinfo/bootlog_module.c M payloads/coreinfo/cbfs_module.c 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/payloads/coreinfo/bootlog_module.c b/payloads/coreinfo/bootlog_module.c index 5a87f28..07fa814 100644 --- a/payloads/coreinfo/bootlog_module.c +++ b/payloads/coreinfo/bootlog_module.c @@ -17,7 +17,7 @@ struct cbmem_console { u32 size; u32 cursor; - u8 body[0]; + u8 body[]; } __packed; #define CURSOR_MASK ((1 << 28) - 1) diff --git a/payloads/coreinfo/cbfs_module.c b/payloads/coreinfo/cbfs_module.c index 93c90e7..c8fa7e2 100644 --- a/payloads/coreinfo/cbfs_module.c +++ b/payloads/coreinfo/cbfs_module.c @@ -31,7 +31,7 @@ u32 align; u32 offset; u32 architecture; - u32 pad[1]; + u32 pad[]; } __packed; struct cbfile { @@ -40,7 +40,7 @@ u32 type; u32 checksum; u32 offset; - char filename[0]; + char filename[]; } __packed; static int filecount = 0, selected = 0, start_row = 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/76848?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17811256b04a17539d3ed77f406892ae77e97515 Gerrit-Change-Number: 76848 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: libpayload/drivers/cbmem_console: Use C99 flexible arrays
by Jakub Czapiga (Code Review) 01 Aug '23

01 Aug '23

Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76849?usp=email ) Change subject: libpayload/drivers/cbmem_console: Use C99 flexible arrays ...................................................................... libpayload/drivers/cbmem_console: Use C99 flexible arrays Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Change-Id: I3fd3f068ff731e1d9fed7c38ba6815e1eed86450 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76849 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M payloads/libpayload/drivers/cbmem_console.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/payloads/libpayload/drivers/cbmem_console.c b/payloads/libpayload/drivers/cbmem_console.c index df40ad0..c243d5e 100644 --- a/payloads/libpayload/drivers/cbmem_console.c +++ b/payloads/libpayload/drivers/cbmem_console.c @@ -32,7 +32,7 @@ struct cbmem_console { uint32_t size; uint32_t cursor; - uint8_t body[0]; + uint8_t body[]; } __packed; #define CURSOR_MASK ((1 << 28) - 1) -- To view, visit https://review.coreboot.org/c/coreboot/+/76849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fd3f068ff731e1d9fed7c38ba6815e1eed86450 Gerrit-Change-Number: 76849 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023