coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: soc/intel/alderlake: Add missing DSDT device
by Patrick Rudolph (Code Review) 03 Feb '23

03 Feb '23

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72762 ) Change subject: soc/intel/alderlake: Add missing DSDT device ...................................................................... soc/intel/alderlake: Add missing DSDT device Add "SATA" to DSDT as it's referenced by Intel PEP SSDT. Fixes warning shown in Linux: ACPI Error: AE_NOT_FOUND, While resolving a named reference package element - \_SB_.PCI0.SATA (20220331/dspkginit-438) Change-Id: I65a1d17bce246022859f011cdc4712e1206a98fe Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- A src/soc/intel/alderlake/acpi/sata.asl M src/soc/intel/alderlake/acpi/southbridge.asl 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/72762/1 diff --git a/src/soc/intel/alderlake/acpi/sata.asl b/src/soc/intel/alderlake/acpi/sata.asl new file mode 100644 index 0000000..4e8f424 --- /dev/null +++ b/src/soc/intel/alderlake/acpi/sata.asl @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +Device (SATA) +{ + Name (_ADR, 0x00170000) + Name (_DDN, "SATA Controller") +} diff --git a/src/soc/intel/alderlake/acpi/southbridge.asl b/src/soc/intel/alderlake/acpi/southbridge.asl index d348d9e..0ba49e3 100644 --- a/src/soc/intel/alderlake/acpi/southbridge.asl +++ b/src/soc/intel/alderlake/acpi/southbridge.asl @@ -48,3 +48,6 @@ /* GbE 0:1f.6 */ #include <soc/intel/common/block/acpi/acpi/pch_glan.asl> + +/* PCH SATA */ +#include "sata.asl" \ No newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/72762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65a1d17bce246022859f011cdc4712e1206a98fe Gerrit-Change-Number: 72762 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0
by Yidi Lin (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72749 ) Change subject: mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0 ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/72749/comment/4444fcfa_f8a3b469 PS3, Line 51: mt6359p_init mt6359 has been initialized in romstage. Can we just initialize it only once? Btw, src/soc/mediatek/mt8188/msdc.c also initializes mt6359. -- To view, visit https://review.coreboot.org/c/coreboot/+/72749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9 Gerrit-Change-Number: 72749 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 09:42:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Add API to control VM18 in regulator.c
by Yidi Lin (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72748 ) Change subject: mb/google/geralt: Add API to control VM18 in regulator.c ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13bafbe10a18a18e253575fd107c9b415f28ef01 Gerrit-Change-Number: 72748 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 09:24:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0
by Liju-Clr Chen (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu, Yidi Lin. Hello Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72749 to look at the new patch set (#3). Change subject: mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0 ...................................................................... mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0 For Geralt, we use BOE_TV110C9M_LL0 as mipi firmware display, so add the power-on sequence for BOE_TV110C9M_LL0. BUG=b:244208960 TEST=test firmware display pass for BOE_TV110C9M_LL0 on Geralt. Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9 Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com> --- M src/mainboard/google/geralt/panel_geralt.c M src/soc/mediatek/mt8188/Makefile.inc 2 files changed, 73 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/72749/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9 Gerrit-Change-Number: 72749 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/mediatek: Add support for regulator VM18
by Yidi Lin (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72747 ) Change subject: soc/mediatek: Add support for regulator VM18 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799 Gerrit-Change-Number: 72747 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 09:23:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Add power on sequence for BOE_TV110C9M_LL0
by Liju-Clr Chen (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu, Yidi Lin. Hello Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72749 to look at the new patch set (#2). Change subject: mb/google/geralt: Add power on sequence for BOE_TV110C9M_LL0 ...................................................................... mb/google/geralt: Add power on sequence for BOE_TV110C9M_LL0 Add power sequence to power on BOE_TV110C9M_LL0 on Geralt proto board. BUG=b:244208960 TEST=test firmware display pass for BOE_TV110C9M_LL0 on Geralt proto board Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9 Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com> --- M src/mainboard/google/geralt/panel_geralt.c M src/soc/mediatek/mt8188/Makefile.inc 2 files changed, 73 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/72749/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9 Gerrit-Change-Number: 72749 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/geralt: Add API to control VM18 in regulator.c
by Liju-Clr Chen (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu, Yidi Lin. Hello Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72748 to look at the new patch set (#2). Change subject: mb/google/geralt: Add API to control VM18 in regulator.c ...................................................................... mb/google/geralt: Add API to control VM18 in regulator.c Add regulator VM18 support to supply power for BOE_TV110C9M_LL0. BUG=b:244208960 TEST=test firmware display pass for BOE_TV110C9M_LL0 on Geralt. Change-Id: I13bafbe10a18a18e253575fd107c9b415f28ef01 Signed-off-by: Sen Chu <sen.chu(a)mediatek.corp-partner.google.com> Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com> --- M src/mainboard/google/geralt/regulator.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/72748/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13bafbe10a18a18e253575fd107c9b415f28ef01 Gerrit-Change-Number: 72748 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/mediatek: Add support for regulator VM18
by Liju-Clr Chen (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu, Yidi Lin. Hello Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72747 to look at the new patch set (#2). Change subject: soc/mediatek: Add support for regulator VM18 ...................................................................... soc/mediatek: Add support for regulator VM18 To provide power to mipi panel BOE_TV110C9M_LL0, add support for regulator VM18. BUG=b:244208960 TEST=test firmware display pass for BOE_TV110C9M_LL0 on Geralt. Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799 Signed-off-by: Sen Chu <sen.chu(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/common/include/soc/mt6359p.h M src/soc/mediatek/common/include/soc/regulator.h M src/soc/mediatek/common/mt6359p.c 3 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/72747/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799 Gerrit-Change-Number: 72747 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/geralt: Add power on sequence for BOE_TV110C9M_LL0
by Rex-BC Chen (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu, Yidi Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72749 ) Change subject: mb/google/geralt: Add power on sequence for BOE_TV110C9M_LL0 ...................................................................... Patch Set 1: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72749/comment/8add608c_3f64d5c6 PS1, Line 7: power on power-on https://review.coreboot.org/c/coreboot/+/72749/comment/2b2da857_aa52be5d PS1, Line 9: Add power sequence to power on BOE_TV110C9M_LL0 on Geralt proto board. For Geralt, we use BOE_TV110C9M_LL0 as mipi firmware display, so add the power-on sequence for BOE_TV110C9M_LL0. https://review.coreboot.org/c/coreboot/+/72749/comment/00d9c472_adfcb342 PS1, Line 12: on Geralt proto : board on Geralt. File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/72749/comment/7191e4e7_d4fa49de PS1, Line 22: static int mipi_panel_reg_mask (u8 addr, u8 val, u8 mask) move to panel.c. https://review.coreboot.org/c/coreboot/+/72749/comment/3c08bda8_bea6a578 PS1, Line 26: if (i2c_read_field(MIPI_PANEL_I2C, MIPI_PANEL_SLAVE, addr, &msg, 0xFF, 0)) : printk(BIOS_ERR, "Rex: failed to read i2c: %d\n", addr); ` if (i2c_read_field(MIPI_PANEL_I2C, MIPI_PANEL_SLAVE, addr, &msg, 0xFF, 0)) { printk(BIOS_ERR, "Failed to read i2c: %d\n", addr); return -1; } ` https://review.coreboot.org/c/coreboot/+/72749/comment/c20e2189_093937b9 PS1, Line 66: ret = mipi_panel_reg_mask(0x00, 0x11, 0x1F); : : /* Set AVEE = -5.7V */ : ret = mipi_panel_reg_mask(0x01, 0x11, 0x1F); : : /* Disable AVDD & AVEE discharge when power on*/ : ret = mipi_panel_reg_mask(0x03, 0x30, 0xFF); do some error handling -- To view, visit https://review.coreboot.org/c/coreboot/+/72749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9 Gerrit-Change-Number: 72749 Gerrit-PatchSet: 1 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 09:18:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Add regulator VM18 support to supply power for BOE_...
by Rex-BC Chen (Code Review) 03 Feb '23

03 Feb '23

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023