coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Add support to configure 6bit color depth
by Venkat Thogaru (Code Review) 03 Feb '23

03 Feb '23

Venkat Thogaru has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72744 ) Change subject: soc/qualcomm/sc7280: Add support to configure 6bit color depth ...................................................................... soc/qualcomm/sc7280: Add support to configure 6bit color depth Some of the eDp panels use 6bit color depth as default. Set the default color depth configuration to 6 bit when there is no match with the supported color depths. BUG=b:255870643 TEST=Validated on sc7280 Zombie development board Change-Id: I2cea10ad417a05f020e4c418f15212fee06a2369 Signed-off-by: Vinod Polimera <quic_vpolimer(a)quicinc.com> --- M src/soc/qualcomm/sc7280/display/edp_ctrl.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/72744/1 diff --git a/src/soc/qualcomm/sc7280/display/edp_ctrl.c b/src/soc/qualcomm/sc7280/display/edp_ctrl.c index 1455cac..beedbaf 100644 --- a/src/soc/qualcomm/sc7280/display/edp_ctrl.c +++ b/src/soc/qualcomm/sc7280/display/edp_ctrl.c @@ -493,6 +493,9 @@ depth = EDP_12BIT; else if (ctrl->color_depth == 16) depth = EDP_16BIT; + else + depth = EDP_6BIT; + config |= depth << EDP_CONFIGURATION_CTRL_BPC_SHIFT; /* Num of Lanes */ -- To view, visit https://review.coreboot.org/c/coreboot/+/72744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cea10ad417a05f020e4c418f15212fee06a2369 Gerrit-Change-Number: 72744 Gerrit-PatchSet: 1 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/qualcomm/sc7280: update intf timing parameter calcualtion for eDP
by Venkat Thogaru (Code Review) 03 Feb '23

03 Feb '23

Venkat Thogaru has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72743 ) Change subject: soc/qualcomm/sc7280: update intf timing parameter calcualtion for eDP ...................................................................... soc/qualcomm/sc7280: update intf timing parameter calcualtion for eDP Correct the interface timing parameter calculation for eDP interface to avoid writing into the blanking region. BUG=b:255870643 TEST=Validated on sc7280 Zombie development board Change-Id: I069ca351d8c60d071debb23a5e48840701441977 Signed-off-by: Vinod Polimera <quic_vpolimer(a)quicinc.com> --- M src/soc/qualcomm/sc7280/display/disp.c 1 file changed, 24 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/72743/1 diff --git a/src/soc/qualcomm/sc7280/display/disp.c b/src/soc/qualcomm/sc7280/display/disp.c index 28356f2..fd3ed3c 100644 --- a/src/soc/qualcomm/sc7280/display/disp.c +++ b/src/soc/qualcomm/sc7280/display/disp.c @@ -28,13 +28,15 @@ hsync_period = edid->mode.ha + edid->mode.hbl; vsync_period = edid->mode.va + edid->mode.vbl; - display_vstart = edid->mode.vbl * hsync_period + edid->mode.hbl; - display_vend = (vsync_period * hsync_period) - 1; + display_vstart = (edid->mode.vbl - edid->mode.vso) * hsync_period + + edid->mode.hbl - edid->mode.hso; + display_vend = ((vsync_period - edid->mode.vso) * hsync_period) - edid->mode.hso - 1; hsync_ctl = (hsync_period << 16) | edid->mode.hspw; - display_hctl = edid->mode.hbl | (hsync_period - 1) << 16; - active_vstart = edid->mode.vbl * hsync_period; - active_vend = display_vend; - active_hctl = display_hctl; + active_vstart = display_vstart; + active_vend = active_vstart + (edid->mode.va * hsync_period) - 1; + active_hctl = ((edid->mode.hbl - edid->mode.hso + edid->mode.ha - 1) << 16) | + (edid->mode.hbl - edid->mode.hso); + display_hctl = active_hctl; write32(&mdp_intf->intf_active_v_start_f0, active_vstart); write32(&mdp_intf->intf_active_v_end_f0, active_vend); -- To view, visit https://review.coreboot.org/c/coreboot/+/72743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I069ca351d8c60d071debb23a5e48840701441977 Gerrit-Change-Number: 72743 Gerrit-PatchSet: 1 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: treewide: Remove unuseful "_ART : Active Cooling Relationship Table"
by Elyes Haouas (Code Review) 03 Feb '23

03 Feb '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72761 ) Change subject: treewide: Remove unuseful "_ART : Active Cooling Relationship Table" ...................................................................... treewide: Remove unuseful "_ART : Active Cooling Relationship Table" Change-Id: Ief8dd9c7f7b82e1cd62de5bc1a361432b0eac4ca Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/intel/common/acpi/dptf/dptf.asl M src/soc/intel/skylake/acpi/dptf/dptf.asl 2 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/72761/1 diff --git a/src/soc/intel/common/acpi/dptf/dptf.asl b/src/soc/intel/common/acpi/dptf/dptf.asl index 637dfed..77eb0ef 100644 --- a/src/soc/intel/common/acpi/dptf/dptf.asl +++ b/src/soc/intel/common/acpi/dptf/dptf.asl @@ -67,7 +67,6 @@ } #ifdef DPTF_ENABLE_FAN_CONTROL - /* _ART : Active Cooling Relationship Table */ Method (_ART) { Return (\_SB.DART) diff --git a/src/soc/intel/skylake/acpi/dptf/dptf.asl b/src/soc/intel/skylake/acpi/dptf/dptf.asl index e72437a..dd43011 100644 --- a/src/soc/intel/skylake/acpi/dptf/dptf.asl +++ b/src/soc/intel/skylake/acpi/dptf/dptf.asl @@ -63,7 +63,6 @@ } #ifdef DPTF_ENABLE_FAN_CONTROL - /* _ART : Active Cooling Relationship Table */ Method (_ART) { Return (\_SB.DART) -- To view, visit https://review.coreboot.org/c/coreboot/+/72761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief8dd9c7f7b82e1cd62de5bc1a361432b0eac4ca Gerrit-Change-Number: 72761 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/roda/rv11: Remove unuseful "_ALR: Ambient Light Response"
by Elyes Haouas (Code Review) 03 Feb '23

03 Feb '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72760 ) Change subject: mb/roda/rv11: Remove unuseful "_ALR: Ambient Light Response" ...................................................................... mb/roda/rv11: Remove unuseful "_ALR: Ambient Light Response" Change-Id: I3a846d8e4b70ccb3e6fde448c00376cd0088716c Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/roda/rv11/acpi/alsd.asl 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/72760/1 diff --git a/src/mainboard/roda/rv11/acpi/alsd.asl b/src/mainboard/roda/rv11/acpi/alsd.asl index a15b4d4..8bc61df 100644 --- a/src/mainboard/roda/rv11/acpi/alsd.asl +++ b/src/mainboard/roda/rv11/acpi/alsd.asl @@ -17,7 +17,7 @@ Return (Local0) } - Name (_ALR, Package (0x05) // _ALR: Ambient Light Response + Name (_ALR, Package (0x05) { Package (0x02) { -- To view, visit https://review.coreboot.org/c/coreboot/+/72760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a846d8e4b70ccb3e6fde448c00376cd0088716c Gerrit-Change-Number: 72760 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/rodarv11: Remove unuseful "_ALI: Ambient Light Illuminance"
by Elyes Haouas (Code Review) 03 Feb '23

03 Feb '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72759 ) Change subject: mb/rodarv11: Remove unuseful "_ALI: Ambient Light Illuminance" ...................................................................... mb/rodarv11: Remove unuseful "_ALI: Ambient Light Illuminance" Change-Id: I0cbdcd5a787d99e2579a312a51c63d7fc4120462 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/roda/rv11/acpi/alsd.asl 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/72759/1 diff --git a/src/mainboard/roda/rv11/acpi/alsd.asl b/src/mainboard/roda/rv11/acpi/alsd.asl index f01a1f0..a15b4d4 100644 --- a/src/mainboard/roda/rv11/acpi/alsd.asl +++ b/src/mainboard/roda/rv11/acpi/alsd.asl @@ -8,7 +8,7 @@ Return (0x0f) } - Method (_ALI, 0, NotSerialized) // _ALI: Ambient Light Illuminance + Method (_ALI, 0, NotSerialized) { Local0 = \_SB.PCI0.LPCB.EC0.LUXH Local0 = (Local0 << 8) | \_SB.PCI0.LPCB.EC0.LUXL -- To view, visit https://review.coreboot.org/c/coreboot/+/72759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cbdcd5a787d99e2579a312a51c63d7fc4120462 Gerrit-Change-Number: 72759 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: treewide: Remove unuseful "_AEI: ACPI Event Interrupts"
by Elyes Haouas (Code Review) 03 Feb '23

03 Feb '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72758 ) Change subject: treewide: Remove unuseful "_AEI: ACPI Event Interrupts" ...................................................................... treewide: Remove unuseful "_AEI: ACPI Event Interrupts" Change-Id: I58a4e4fbd1a43462147daa58a5fda767cfd59c06 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/cyan/acpi/mainboard.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/mainboard/protectli/vault_bsw/acpi/mainboard.asl 3 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/72758/1 diff --git a/src/mainboard/google/cyan/acpi/mainboard.asl b/src/mainboard/google/cyan/acpi/mainboard.asl index 6cdc42d..a8c9cfb 100644 --- a/src/mainboard/google/cyan/acpi/mainboard.asl +++ b/src/mainboard/google/cyan/acpi/mainboard.asl @@ -4,7 +4,7 @@ Scope (\_SB.GPNC) { - Method (_AEI, 0, Serialized) // _AEI: ACPI Event Interrupts + Method (_AEI, 0, Serialized) { Name (RBUF, ResourceTemplate () { diff --git a/src/mainboard/intel/strago/acpi/mainboard.asl b/src/mainboard/intel/strago/acpi/mainboard.asl index dcfb040..6c0ce02 100644 --- a/src/mainboard/intel/strago/acpi/mainboard.asl +++ b/src/mainboard/intel/strago/acpi/mainboard.asl @@ -180,7 +180,7 @@ Scope (\_SB.GPNC) { - Method (_AEI, 0, Serialized) // _AEI: ACPI Event Interrupts + Method (_AEI, 0, Serialized) { Name (RBUF, ResourceTemplate () { diff --git a/src/mainboard/protectli/vault_bsw/acpi/mainboard.asl b/src/mainboard/protectli/vault_bsw/acpi/mainboard.asl index 38779c2..2ff4075 100644 --- a/src/mainboard/protectli/vault_bsw/acpi/mainboard.asl +++ b/src/mainboard/protectli/vault_bsw/acpi/mainboard.asl @@ -2,7 +2,7 @@ Scope (\_SB.GPNC) { - Method (_AEI, 0, Serialized) // _AEI: ACPI Event Interrupts + Method (_AEI, 0, Serialized) { Name (RBUF, ResourceTemplate () { -- To view, visit https://review.coreboot.org/c/coreboot/+/72758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58a4e4fbd1a43462147daa58a5fda767cfd59c06 Gerrit-Change-Number: 72758 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: docs/contrib/gsoc: Move org admins to dedicated section
by David Hendricks (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel, Nicholas Chin. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72514 ) Change subject: docs/contrib/gsoc: Move org admins to dedicated section ...................................................................... Patch Set 2: (1 comment) File Documentation/contributing/gsoc.md: https://review.coreboot.org/c/coreboot/+/72514/comment/d24c9814_a8e1b4c6 PS1, Line 12: Please feel free to reach out to them directly if you have any questions > I'm find with the list of admins; I was referring to the "Please feel free to reach out to them dire […] Sorry I misunderstood your earlier comment. More general contact methods are appropriate IMO. Org admins are registered with GSoC so Google knows how to reach them if there's a problem from an organizational standpoint. I can't think of a reason people should contact an org admin directly rather than going through a regular forum or contacting GSoC. -- To view, visit https://review.coreboot.org/c/coreboot/+/72514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c84a80dabf516b2042af018f091204f0f853361 Gerrit-Change-Number: 72514 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 07:04:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Kapil Porwal (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70226 ) Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 07:00:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/acpigen.h: Fix ACPI OP codes
by Elyes Haouas (Code Review) 03 Feb '23

03 Feb '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72757 ) Change subject: acpi/acpigen.h: Fix ACPI OP codes ...................................................................... acpi/acpigen.h: Fix ACPI OP codes Change-Id: I51e7f8dc6c0bfef0816ab4da6d96cb0fac873ee8 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/acpi/acpigen.h 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/72757/1 diff --git a/src/include/acpi/acpigen.h b/src/include/acpi/acpigen.h index c506021..e11fb0a 100644 --- a/src/include/acpi/acpigen.h +++ b/src/include/acpi/acpigen.h @@ -46,9 +46,7 @@ MULTI_NAME_PREFIX = 0x2F, EXT_OP_PREFIX = 0x5B, MUTEX_OP = 0x01, - EVENT_OP = 0x01, - SF_RIGHT_OP = 0x10, - SF_LEFT_OP = 0x11, + EVENT_OP = 0x02, COND_REFOF_OP = 0x12, CREATEFIELD_OP = 0x13, LOAD_TABLE_OP = 0x1f, @@ -62,7 +60,6 @@ RELEASE_OP = 0x27, FROM_BCD_OP = 0x28, TO_BCD_OP = 0x29, - UNLOAD_OP = 0x2A, REVISON_OP = 0x30, DEBUG_OP = 0x31, FATAL_OP = 0x32, @@ -70,7 +67,6 @@ OPREGION_OP = 0x80, FIELD_OP = 0x81, DEVICE_OP = 0x82, - PROCESSOR_OP = 0x83, POWER_RES_OP = 0x84, THERMAL_ZONE_OP = 0x85, INDEX_FIELD_OP = 0x86, -- To view, visit https://review.coreboot.org/c/coreboot/+/72757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51e7f8dc6c0bfef0816ab4da6d96cb0fac873ee8 Gerrit-Change-Number: 72757 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: acpi/acpi.h: Add a comment for dsdt field
by Elyes Haouas (Code Review) 03 Feb '23

03 Feb '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72756 ) Change subject: acpi/acpi.h: Add a comment for dsdt field ...................................................................... acpi/acpi.h: Add a comment for dsdt field Change-Id: I75bae70ad8a027d2d3537d77c8902b7a848a24c1 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/acpi/acpi.h 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/72756/1 diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index b92c77e..4a70be3 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -772,7 +772,7 @@ typedef struct acpi_fadt { acpi_header_t header; u32 firmware_ctrl; - u32 dsdt; + u32 dsdt; /* 6.0 Errata: if x_dsdt != 0, dsdt should be ignored or deprecated */ u8 reserved; /* Should be 0 */ u8 preferred_pm_profile; u16 sci_int; -- To view, visit https://review.coreboot.org/c/coreboot/+/72756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75bae70ad8a027d2d3537d77c8902b7a848a24c1 Gerrit-Change-Number: 72756 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023