coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71860 ) Change subject: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU ...................................................................... mb/google/nissa/var/craask: Add DPTF settings for 15W CPU Add ADL-N 15W CPU thermal settings. BUG=b:265101768 TEST=emerge-nissa coreboot Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71860 Reviewed-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Reviewed-by: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Reviewed-by: Reka Norman <rekanorman(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 81 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved Ren Kuo: Looks good to me, but someone else must approve Vidya Gopalakrishnan: Looks good to me, but someone else must approve Tyler Wang: Looks good to me, but someone else must approve Reka Norman: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/craask/overridetree.cb b/src/mainboard/google/brya/variants/craask/overridetree.cb index dbf0942..45078c9 100644 --- a/src/mainboard/google/brya/variants/craask/overridetree.cb +++ b/src/mainboard/google/brya/variants/craask/overridetree.cb @@ -20,6 +20,10 @@ field AMP 6 7 option AMP_MX98360A 0 end + field THERMAL_SOLUTION 10 12 + option THERMAL_SOLUTION_6W 0 + option THERMAL_SOLUTION_15W 1 + end field WIFI_SAR_ID 13 15 option ID_0 0 end @@ -171,7 +175,61 @@ [3] = { 8, 500 } }" - device generic 0 on end + device generic 0 on + probe THERMAL_SOLUTION THERMAL_SOLUTION_6W + end + end + chip drivers/intel/dptf + ## sensor information + register "options.tsr[0].desc" = ""Memory"" + register "options.tsr[1].desc" = ""Charger"" + register "options.tsr[2].desc" = ""Ambient"" + + # TODO: below values are initial reference values only + ## Passive Policy + register "policies.passive" = "{ + [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000), + [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 75, 5000), + [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_1, 75, 5000), + [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 75, 5000), + }" + + ## Critical Policy + register "policies.critical" = "{ + [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 85, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 85, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 85, SHUTDOWN), + }" + + register "controls.power_limits" = "{ + .pl1 = { + .min_power = 15000, + .max_power = 15000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 28 * MSECS_PER_SEC, + .granularity = 125 + }, + .pl2 = { + .min_power = 35000, + .max_power = 35000, + .time_window_min = 1, + .time_window_max = 1, + .granularity = 1000 + } + }" + + ## Charger Performance Control (Control, mA) + register "controls.charger_perf" = "{ + [0] = { 255, 1700 }, + [1] = { 24, 1500 }, + [2] = { 16, 1000 }, + [3] = { 8, 500 } + }" + + device generic 1 on + probe THERMAL_SOLUTION THERMAL_SOLUTION_15W + end end end device ref ipu on -- To view, visit https://review.coreboot.org/c/coreboot/+/71860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Gerrit-Change-Number: 71860 Gerrit-PatchSet: 10 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Paul Menzel, Peter Ou. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 ) Change subject: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Gerrit-Change-Number: 71860 Gerrit-PatchSet: 9 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:17:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/marasov: Turn off camera power during S0ix
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Frank Chu, Paul Menzel. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72089 ) Change subject: mb/google/brya/var/marasov: Turn off camera power during S0ix ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie2b300783adfc1cab30bc897d086a3674436724a Gerrit-Change-Number: 72089 Gerrit-PatchSet: 10 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Kyle Lin <kylelinck(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:17:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: update touchscreen report EN pin setting
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/72725 ) Change subject: mb/google/rex: update touchscreen report EN pin setting ...................................................................... mb/google/rex: update touchscreen report EN pin setting Removed workaround since the latest schematics fixed. Power Sequencing of ELAN6918 (in ACPI) after this patch `POWER enabled -> RESET deasserted -> Report EN enabled` BUG=b:247029304 TEST=Verified ELAN touch panel is working as expected after booting Google/rex device to ChromeOS. Signed-off-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Change-Id: I19629262776f7e0cccbdebb2285890d177a8a8a6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72725 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/rex0/gpio.c 1 file changed, 25 insertions(+), 14 deletions(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved Kapil Porwal: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/rex0/gpio.c b/src/mainboard/google/rex/variants/rex0/gpio.c index 01fa95d..23732f2 100644 --- a/src/mainboard/google/rex/variants/rex0/gpio.c +++ b/src/mainboard/google/rex/variants/rex0/gpio.c @@ -107,20 +107,7 @@ /* GPP_C05 : [] ==> WWAN_PERST_L_STRAP */ PAD_CFG_GPO(GPP_C05, 1, PLTRST), /* GPP_C06 : [] ==> SOC_TCHSCR_RPT_EN */ - /* - * FIXME: Remove this code after resolving b/247029304. - * - * ELAN6918 Power Sequencing seems not perfectly matching - * with the previous platforms and setting GPP_C06 to high prior - * to the power sequencing is actually makes it work. - * - * Ideally Power Sequencing should be as below for ELAN6918 (in ACPI) - * `POWER enabled -> RESET deasserted -> Report EN enabled` - * - * But below sequence is only working currently: - * `Report EN enabled (ramstage) -> POWER enabled (ACPI) -> RESET deasserted (ACPI)` - */ - PAD_CFG_GPO(GPP_C06, 1, DEEP), + PAD_CFG_GPO(GPP_C06, 0, DEEP), /* GPP_C07 : [] ==> SOC_TCHSCR_INT */ PAD_CFG_GPI_APIC(GPP_C07, NONE, PLTRST, LEVEL, NONE), /* GPP_C08 : [] ==> SOCHOT_ODL */ -- To view, visit https://review.coreboot.org/c/coreboot/+/72725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19629262776f7e0cccbdebb2285890d177a8a8a6 Gerrit-Change-Number: 72725 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/rex: update touchscreen report EN pin setting
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72725 ) Change subject: mb/google/rex: update touchscreen report EN pin setting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19629262776f7e0cccbdebb2285890d177a8a8a6 Gerrit-Change-Number: 72725 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:16:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Hook up PchHdaAudioLinkHdaEnable to devicetree
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Sean Rhodes, Tarun Tuli, Michał Żygowski, Subrata Banik, Paul Menzel, Arthur Heymans. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71715 ) Change subject: soc/intel/alderlake: Hook up PchHdaAudioLinkHdaEnable to devicetree ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Looks like chrome doesn't need the HDA Link. But if your board needs it, it make sense to add it. Below is FSP log for HDA on chrome. [SPEW ] ------------------ HD Audio PreMem Config ------------------ [SPEW ] Enable = 1 [SPEW ] DSP Enable = 1 [SPEW ] DSP UAA Compliance = 0 [SPEW ] Audio Link: HDA Link = 0 [SPEW ] Audio Link: DMIC#0 = 0 [SPEW ] DMIC#0 Clock Select = 0 [SPEW ] Audio Link: DMIC#1 = 0 [SPEW ] DMIC#1 Clock Select = 0 [SPEW ] Audio Link: SSP#0 = 0 [SPEW ] Audio Link: SSP#1 = 0 [SPEW ] Audio Link: SSP#2 = 0 [SPEW ] Audio Link: SSP#3 = 0 [SPEW ] Audio Link: SSP#4 = 0 [SPEW ] Audio Link: SSP#5 = 0 [SPEW ] Audio Link: SoundWire#1 = 0 [SPEW ] Audio Link: SoundWire#2 = 0 [SPEW ] Audio Link: SoundWire#3 = 0 [SPEW ] Audio Link: SoundWire#4 = 0 [SPEW ] VC Type = 0 [SPEW ] iDisp Codec Disconnect = 0 [SPEW ] iDisp Link Frequency = 4 [SPEW ] iDisp Link T-Mode = 3 [SPEW ] ResetWaitTimer = 258 [SPEW ] Hda Sdi0 Enable = 1 [SPEW ] Hda Sdi1 Enable = 0 [SPEW ] SubSystemIds = 0 -- To view, visit https://review.coreboot.org/c/coreboot/+/71715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f27f41a4a4b3844a65d45d36aba37c3af1050a0 Gerrit-Change-Number: 71715 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:13:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Add a few missing definitions in iomap.h
by Jérémy Compostella (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Subrata Banik, Jérémy Compostella. Jérémy Compostella has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/72635 ) Change subject: soc/intel/alderlake: Add a few missing definitions in iomap.h ...................................................................... Removed -Code-Review by Jérémy Compostella <jeremy.compostella(a)intel.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/72635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14803a7297c8c5edefe564d92bfe7314f6769942 Gerrit-Change-Number: 72635 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: deleteVote

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Add a few missing definitions in iomap.h
by Jérémy Compostella (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Subrata Banik, Jérémy Compostella. Jérémy Compostella has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/72635 ) Change subject: soc/intel/alderlake: Add a few missing definitions in iomap.h ...................................................................... Removed Code-Review+2 by Jérémy Compostella <jeremy.compostella(a)intel.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/72635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14803a7297c8c5edefe564d92bfe7314f6769942 Gerrit-Change-Number: 72635 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: deleteVote

1 0

[S] Change in coreboot[master]: mb/google/brya0,skolas4es,skolas: disable Tccold Handshake
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Bora Guvendik, Tarun Tuli, Subrata Banik, Selma Bensaid, Tim Wawrzynczak, Angel Pons, Kane Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68636 ) Change subject: mb/google/brya0,skolas4es,skolas: disable Tccold Handshake ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > Brya0 is RPL now but the old device still ADL, and the FSP is different right? Not sure how will this going on Brya -- To view, visit https://review.coreboot.org/c/coreboot/+/68636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic184a61c27abd729667cd181d8f9954f58b67856 Gerrit-Change-Number: 68636 Gerrit-PatchSet: 6 Gerrit-Owner: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bora Guvendik <bora.guvendik(a)intel.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: docs/contrib/gsoc: Move org admins to dedicated section
by Nicholas Chin (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel, David Hendricks. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72514 ) Change subject: docs/contrib/gsoc: Move org admins to dedicated section ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File Documentation/contributing/gsoc.md: https://review.coreboot.org/c/coreboot/+/72514/comment/4f6fe362_6a84e9dd PS1, Line 12: Please feel free to reach out to them directly if you have any questions Do we still want to keep something like this or are we deciding that the more general contact methods (mailing list, IRC, etc) are more appropriate? -- To view, visit https://review.coreboot.org/c/coreboot/+/72514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c84a80dabf516b2042af018f091204f0f853361 Gerrit-Change-Number: 72514 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:10:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023