coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Subrata Banik (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70226 to look at the new patch set (#5). Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs This patch drops the WFC sensor OV8856 (reused from the Brya chassis) support for Rex and added support for Rex specific UFC sensor OV13B10. BUG=b/267264348 TEST=WFC MIPI cameras have been enabled using google/rex Proto 1. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 23 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/70226/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Subrata Banik (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70226 ) Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/70226/comment/d19fdc7a_3a6eb863 PS1, Line 268: register "ssdb.lanes_used" = "2" > > Just to confirm, all the config and sequencing/etc is identical on the DB10? > > looking at the linux OVB10 driver, I felt so. but we can always get this tested. validated on Proto 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 04:18:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/amdfwtool: add comment about reused PSP firmware type 0x5f
by Bao Zheng (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Arthur Heymans, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72713 ) Change subject: util/amdfwtool: add comment about reused PSP firmware type 0x5f ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5c125ec6a0eb548f58a457f9040278391d2101c Gerrit-Change-Number: 72713 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Feb 2023 04:16:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: security/vboot: Don't build with flashrom support
by Yu-Ping Wu (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Brian Norris, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72716 ) Change subject: security/vboot: Don't build with flashrom support ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Gerrit-Change-Number: 72716 Gerrit-PatchSet: 4 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:42:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwread: Extract the FWs in image.
by Bao Zheng (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Robert Zieba, Marshall Dawson, Zheng Bao, Arthur Heymans, Karthik Ramasubramanian, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72741 ) Change subject: amdfwread: Extract the FWs in image. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: WIP. -- To view, visit https://review.coreboot.org/c/coreboot/+/72741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4714c45dafc3d5e5c95bb15258711a061e2582c0 Gerrit-Change-Number: 72741 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:40:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwread: Extract the FWs in image.
by build bot (Jenkins) (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72741 ) Change subject: amdfwread: Extract the FWs in image. ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169785): https://review.coreboot.org/c/coreboot/+/72741/comment/8a7d454f_14313af7 PS1, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/72741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4714c45dafc3d5e5c95bb15258711a061e2582c0 Gerrit-Change-Number: 72741 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Fri, 03 Feb 2023 03:37:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()`
by Yu-Ping Wu (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Andrey Pronin, Paul Menzel, Christian Walter, Yi Chou. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 ) Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()` ...................................................................... Patch Set 6: (3 comments) File src/security/tpm/tss/tcg-2.0/tss.c: https://review.coreboot.org/c/coreboot/+/71885/comment/3c13cc25_b0d205d7 PS6, Line 504: case TPM_RC_HANDLE: Use `__attribute__((__fallthrough__))`, or `__fallthrough` defined in src/commonlib/bsd/include/commonlib/bsd/compiler.h. https://review.coreboot.org/c/coreboot/+/71885/comment/8c50ab0d_84879ec0 PS6, Line 505: ( No need for parentheses I think File src/security/tpm/tss/tcg-2.0/tss_marshaling.c: https://review.coreboot.org/c/coreboot/+/71885/comment/ded6ca63_c8d9a381 PS2, Line 550: "%s:%d - " : "size mismatch: expected %d, remaining %zd\n", > Done You modified the wrong function. -- To view, visit https://review.coreboot.org/c/coreboot/+/71885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79455b3ee73c265a9e4bf3d8b9c6562490efbf1c Gerrit-Change-Number: 71885 Gerrit-PatchSet: 6 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:37:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yi Chou <yich(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwread: Extract the FWs in image.
by Bao Zheng (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/72741 to review the following change. Change subject: amdfwread: Extract the FWs in image. ...................................................................... amdfwread: Extract the FWs in image. Prepare for replacement. Change-Id: I4714c45dafc3d5e5c95bb15258711a061e2582c0 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwread.c 1 file changed, 111 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/72741/1 diff --git a/util/amdfwtool/amdfwread.c b/util/amdfwtool/amdfwread.c index 711b158..f2d8590 100644 --- a/util/amdfwtool/amdfwread.c +++ b/util/amdfwtool/amdfwread.c @@ -82,6 +82,18 @@ return fw_header->signature != EMBEDDED_FW_SIGNATURE; } +static int write_bin(FILE *fw, void *data, size_t bin_size) +{ + fwrite(data, bin_size, 1, fw); + + return 0; +} + +static int read_bin(FILE *fw, uint32_t offset, void *binary, size_t bin_size) +{ + return read_header(fw, offset, binary, bin_size); +} + static int read_psp_directory(FILE *fw, uint32_t offset, uint32_t expected_cookie, psp_directory_header *header, psp_directory_entry **entries, size_t *num_entries) @@ -234,6 +246,28 @@ return 1; } +static void save_fws(FILE *fw, uint32_t type, uint32_t offset, uint32_t bytes) +{ + char filename[512]; + uint32_t *buffer; + + sprintf(filename, "PspDirL1_Typex%02x.bin", type); + buffer = malloc(bytes); + read_bin(fw, offset, buffer, bytes); + + FILE *mod_fd = fopen(filename, "wb"); + + if (mod_fd) { + write_bin(mod_fd, buffer, bytes); + fclose(mod_fd); + } else { + fprintf(stderr, "Error: could not open file: %s\n", filename); + } + + free(buffer); +} + + #define MAX_NUM_LEVELS 10 #define MAX_INDENT_PER_LEVEL 4 #define MAX_INDENTATION_LEN (MAX_NUM_LEVELS * MAX_INDENT_PER_LEVEL + 1) @@ -244,7 +278,8 @@ strcat(dest, "+-->"); } -static int amdfw_bios_dir_walk(FILE *fw, uint32_t bios_offset, uint32_t cookie, uint8_t level) +static int amdfw_bios_dir_walk(FILE *fw, uint32_t bios_offset, uint32_t cookie, uint8_t level, + uint8_t extract) { bios_directory_entry *current_entries = NULL; size_t num_current_entries = 0; @@ -271,11 +306,15 @@ indent, cookie == BHD_COOKIE ? "L1" : "L2", type, relative_offset(bios_offset, addr, AMD_ADDR_PHYSICAL), current_entries[i].size); - else + else { printf("%sBIOS%s: 0x%02x 0x%08lx 0x%08x\n", indent, cookie == BHD_COOKIE ? "L1" : "L2", type, relative_offset(bios_offset, addr, mode), current_entries[i].size); + if (extract) + save_fws(fw, type, relative_offset(bios_offset, addr, mode), + current_entries[i].size); + } if (type == AMD_BIOS_L2_PTR) { /* There's a second level BIOS directory to read */ @@ -288,7 +327,7 @@ l2_dir_offset = relative_offset(bios_offset, addr, mode); printf(" %sBIOSL2: Dir 0x%08x\n", indent, l2_dir_offset); - amdfw_bios_dir_walk(fw, l2_dir_offset, BHDL2_COOKIE, level + 2); + amdfw_bios_dir_walk(fw, l2_dir_offset, BHDL2_COOKIE, level + 2, extract); } } @@ -296,7 +335,8 @@ return 0; } -static int amdfw_psp_dir_walk(FILE *fw, uint32_t psp_offset, uint32_t cookie, uint8_t level) +static int amdfw_psp_dir_walk(FILE *fw, uint32_t psp_offset, uint32_t cookie, uint8_t level, + uint8_t extract) { psp_directory_entry *current_entries = NULL; size_t num_current_entries = 0; @@ -321,11 +361,15 @@ printf("%sPSP%s: 0x%02x 0x%lx(Soft-fuse)\n", indent, cookie == PSP_COOKIE ? "L1" : "L2", type, mode << 62 | addr); - else + else { printf("%sPSP%s: 0x%02x 0x%08lx 0x%08x\n", indent, cookie == PSP_COOKIE ? "L1" : "L2", type, relative_offset(psp_offset, addr, mode), current_entries[i].size); + if (extract) + save_fws(fw, type, relative_offset(psp_offset, addr, mode), + current_entries[i].size); + } switch (type) { case AMD_FW_L2_PTR: @@ -339,7 +383,7 @@ l2_dir_offset = relative_offset(psp_offset, addr, mode); printf(" %sPSPL2: Dir 0x%08x\n", indent, l2_dir_offset); - amdfw_psp_dir_walk(fw, l2_dir_offset, PSPL2_COOKIE, level + 2); + amdfw_psp_dir_walk(fw, l2_dir_offset, PSPL2_COOKIE, level + 2, extract); break; case AMD_FW_RECOVERYAB_A: @@ -359,13 +403,13 @@ l2_dir_offset = ish_dir.pl2_location; printf(" %sPSPL2: Dir 0x%08x\n", indent, l2_dir_offset); - amdfw_psp_dir_walk(fw, l2_dir_offset, PSPL2_COOKIE, level + 2); + amdfw_psp_dir_walk(fw, l2_dir_offset, PSPL2_COOKIE, level + 2, extract); break; case AMD_FW_BIOS_TABLE: bios_dir_offset = relative_offset(psp_offset, addr, mode); printf(" %sBIOSL2: Dir 0x%08x\n", indent, bios_dir_offset); - amdfw_bios_dir_walk(fw, bios_dir_offset, BHDL2_COOKIE, level + 2); + amdfw_bios_dir_walk(fw, bios_dir_offset, BHDL2_COOKIE, level + 2, extract); break; default: @@ -389,7 +433,7 @@ psp_offset = fw_header->new_psp_directory; printf("PSPL1: Dir 0x%08x\n", psp_offset); - amdfw_psp_dir_walk(fw, psp_offset, PSP_COOKIE, 0); + amdfw_psp_dir_walk(fw, psp_offset, PSP_COOKIE, 0, 0); return 0; } @@ -399,7 +443,7 @@ is present and that too as part of PSP L2 directory. */ if (fw_header->bios3_entry != 0xffffffff) { printf("BIOSL1: Dir 0x%08x\n", fw_header->bios3_entry); - amdfw_bios_dir_walk(fw, fw_header->bios3_entry, BHD_COOKIE, 0); + amdfw_bios_dir_walk(fw, fw_header->bios3_entry, BHD_COOKIE, 0, 0); } return 0; } @@ -413,10 +457,46 @@ return 0; } +static int extract_amdfw_psp_dir(FILE *fw, const embedded_firmware *fw_header) +{ + uint32_t psp_offset = 0; + + /* 0xffffffff indicates that the offset is in new_psp_directory */ + if (fw_header->psp_directory != 0xffffffff) + psp_offset = fw_header->psp_directory; + else + psp_offset = fw_header->new_psp_directory; + + printf("PSPL1: Dir 0x%08x\n", psp_offset); + amdfw_psp_dir_walk(fw, psp_offset, PSP_COOKIE, 0, 1); + return 0; +} + +static int extract_amdfw_bios_dir(FILE *fw, const embedded_firmware *fw_header) +{ + /* 0xffffffff implies that the SoC uses recovery A/B layout. Only BIOS L2 directory + is present and that too as part of PSP L2 directory. */ + if (fw_header->bios3_entry != 0xffffffff) { + printf("BIOSL1: Dir 0x%08x\n", fw_header->bios3_entry); + amdfw_bios_dir_walk(fw, fw_header->bios3_entry, BHD_COOKIE, 0, 1); + } + return 0; +} + + +static int extract_all(FILE *fw, const embedded_firmware *fw_header) +{ + extract_amdfw_psp_dir(fw, fw_header); + extract_amdfw_bios_dir(fw, fw_header); + + return 0; +} + enum { AMDFW_OPT_HELP = 'h', AMDFW_OPT_SOFT_FUSE = 1UL << 0, /* Print Softfuse */ AMDFW_OPT_RO_LIST = 1UL << 1, /* List entries in AMDFW RO */ + AMDFW_OPT_EXTRACT_ALL = 1UL << 2, /* Extract all FWs */ }; static char const optstring[] = {AMDFW_OPT_HELP}; @@ -425,6 +505,7 @@ {"help", no_argument, 0, AMDFW_OPT_HELP}, {"soft-fuse", no_argument, 0, AMDFW_OPT_SOFT_FUSE}, {"ro-list", no_argument, 0, AMDFW_OPT_RO_LIST}, + {"extract-all", no_argument, 0, AMDFW_OPT_EXTRACT_ALL}, }; static void print_usage(void) @@ -462,6 +543,7 @@ case AMDFW_OPT_SOFT_FUSE: case AMDFW_OPT_RO_LIST: + case AMDFW_OPT_EXTRACT_ALL: selected_functions |= opt; break; @@ -506,6 +588,13 @@ } } + if (selected_functions & AMDFW_OPT_EXTRACT_ALL) { + if (extract_all(fw, &fw_header) != 0) { + fclose(fw); + return 1; + } + } + fclose(fw); return 0; } -- To view, visit https://review.coreboot.org/c/coreboot/+/72741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4714c45dafc3d5e5c95bb15258711a061e2582c0 Gerrit-Change-Number: 72741 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya0,skolas4es,skolas: disable Tccold Handshake
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Bora Guvendik, Tarun Tuli, Subrata Banik, Selma Bensaid, Tim Wawrzynczak, Angel Pons, Kane Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68636 ) Change subject: mb/google/brya0,skolas4es,skolas: disable Tccold Handshake ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS5: > Same FW image/FSP can work on ADL silicon and RPL silicon. Got it, and this setting is for RPL FSP only. -- To view, visit https://review.coreboot.org/c/coreboot/+/68636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic184a61c27abd729667cd181d8f9954f58b67856 Gerrit-Change-Number: 68636 Gerrit-PatchSet: 6 Gerrit-Owner: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:37:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Bora Guvendik <bora.guvendik(a)intel.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya0,skolas4es,skolas: disable Tccold Handshake
by Bora Guvendik (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Selma Bensaid, Tim Wawrzynczak, Angel Pons, Eric Lai, Kane Chen. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68636 ) Change subject: mb/google/brya0,skolas4es,skolas: disable Tccold Handshake ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > but the old device still ADL, and the FSP is different right? Not sure how will this going on Brya Same FW image/FSP can work on ADL silicon and RPL silicon. -- To view, visit https://review.coreboot.org/c/coreboot/+/68636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic184a61c27abd729667cd181d8f9954f58b67856 Gerrit-Change-Number: 68636 Gerrit-PatchSet: 6 Gerrit-Owner: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 03:34:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bora Guvendik <bora.guvendik(a)intel.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023