February 2023 - coreboot-gerrit

[S] Change in coreboot[master]: soc/amd/mendocino: Force resets to be cold
by Felix Held (Code Review) Jan. 31, 2023

Jan. 31, 2023

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Tim Van Patten, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72486 ) Change subject: soc/amd/mendocino: Force resets to be cold ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1fbb4cc6eb6e6de9616d00d0191ccf3c0ac55278 Gerrit-Change-Number: 72486 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 00:35:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/mendocino: Force resets to be cold
by Felix Held (Code Review) Jan. 31, 2023

Jan. 31, 2023

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Tim Van Patten, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72486 ) Change subject: soc/amd/mendocino: Force resets to be cold ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/mendocino/fch.c: https://review.coreboot.org/c/coreboot/+/72486/comment/877ae74a_cd611567 PS3, Line 131: pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) | TOGGLE_ALL_PWR_GOOD); > It sounds like `fch_init_resets()` should be dropped from this CL then, since we aren't doing warm r […] no, fch_init_resets is essential to make sure that that bit to change the reset behavior is still set in the case when coreboot doesn't do a reset which should be the main case. i'd still set this bit in the do_*_rest functions, so that those also behave correctly before the fch_init_resets call -- To view, visit https://review.coreboot.org/c/coreboot/+/72486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1fbb4cc6eb6e6de9616d00d0191ccf3c0ac55278 Gerrit-Change-Number: 72486 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 00:33:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/cpu/amd/mtrr: drop unused TOP_MEM_MASK definitions
by Felix Held (Code Review) Jan. 31, 2023

Jan. 31, 2023

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72649 ) Change subject: include/cpu/amd/mtrr: drop unused TOP_MEM_MASK definitions ...................................................................... include/cpu/amd/mtrr: drop unused TOP_MEM_MASK definitions Neither TOP_MEM_MASK nor TOP_MEM_MASK_KB is used, so drop the two definitions. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I0b2dfb7be27884dffb948876aabb73f99834c281 --- M src/include/cpu/amd/mtrr.h 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/72649/1 diff --git a/src/include/cpu/amd/mtrr.h b/src/include/cpu/amd/mtrr.h index bc3f313..f1b95b6 100644 --- a/src/include/cpu/amd/mtrr.h +++ b/src/include/cpu/amd/mtrr.h @@ -37,9 +37,6 @@ #define TOP_MEM2 0xC001001Dul #endif -#define TOP_MEM_MASK 0x007fffff -#define TOP_MEM_MASK_KB (TOP_MEM_MASK >> 10) - #if !defined(__ASSEMBLER__) #include <cpu/x86/msr.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/72649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b2dfb7be27884dffb948876aabb73f99834c281 Gerrit-Change-Number: 72649 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/*: Remove lapic from devicetree
by Felix Held (Code Review) Jan. 31, 2023

Jan. 31, 2023

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69303 ) Change subject: mb/*: Remove lapic from devicetree ...................................................................... Patch Set 18: (1 comment) Patchset: PS18: > I get this on Apollo Lake based boards: […] CB:72599 should have fixed this problem -- To view, visit https://review.coreboot.org/c/coreboot/+/69303 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5258a769c0f0ee4bbc4facc19737eed187b68c73 Gerrit-Change-Number: 69303 Gerrit-PatchSet: 18 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 00:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: ec/google/chromeec: Add handles for ori, usb role switch
by Prashant Malani (Code Review) Jan. 31, 2023

Jan. 31, 2023

Attention is currently required from: Robert Zieba, Tarun Tuli, Subrata Banik, Caveh Jalali, Kapil Porwal, Nick Vaccaro, Boris Mittelberg. Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72370 ) Change subject: ec/google/chromeec: Add handles for ori, usb role switch ...................................................................... Patch Set 4: (1 comment) File src/ec/google/chromeec/ec_acpi.c: https://review.coreboot.org/c/coreboot/+/72370/comment/0eaa210b_7343c867 PS3, Line 195: .orientation_switch = config->ori_conn[i], : .usb_role_switch = config->usb_role_conn[i], > could you add the skyrim case as the next patch so we have some insight into what's coming up? i didn't see anything interesting USB related in the existing skyrim device tree. Sure. I can add a CL to the stack. It's still under development, so we don't want to enable it yet. > sounds like part of the problem is that you can't disable orientation_switch or usb_role_switch by just explicitly setting them to NULL in the device tree since that's indistinguishable from not being present. would it make sense to introduce explicit no_orientation_switch , no_usb_role_switch parameters to the device tree? fill_ssdt_typec_device() will have to check for those. I guess? I dunno, that seems like too many tags to be worth the trouble: - For Intel case: just define mux_conn. - For AMD case: define mux_conn but define no_usb_role_switch and no_orientation_switch - For potential use case where there is a mode-switch, and role/orientation-switch, but the two are distinct: define mux_conn, *and* define usb_role/orientation_switch That seems like overcomplicating things (as opposed to just always being explicit about the aliases). Then again, IANA-Coreboot expert, so if the other folks reviewing are OK with the "no_*" option, I don't mind adopting that approach. -- To view, visit https://review.coreboot.org/c/coreboot/+/72370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f5dff865db765693cde63a23173b215b20b6c02 Gerrit-Change-Number: 72370 Gerrit-PatchSet: 4 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 00:09:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robert Zieba <robertzieba(a)google.com> Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Prashant Malani <pmalani(a)chromium.org> Gerrit-MessageType: comment

1 0