February 2023 - coreboot-gerrit

[L] Change in coreboot[master]: ec/google/chromeec: Add handles for ori, usb role switch
by Prashant Malani (Code Review) Feb. 1, 2023

Feb. 1, 2023

Attention is currently required from: Robert Zieba, Tarun Tuli, Subrata Banik, Caveh Jalali, Kapil Porwal, Nick Vaccaro, Boris Mittelberg. Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72370 ) Change subject: ec/google/chromeec: Add handles for ori, usb role switch ...................................................................... Patch Set 4: (1 comment) File src/ec/google/chromeec/ec_acpi.c: https://review.coreboot.org/c/coreboot/+/72370/comment/190a1788_46c525b2 PS3, Line 195: .orientation_switch = config->ori_conn[i], : .usb_role_switch = config->usb_role_conn[i], > > could you add the skyrim case as the next patch so we have some insight > into what's coming up? i didn't see anything interesting USB related > in the existing skyrim device tree. > > Sure. I can add a CL to the stack. It's still under development, so we don't want to enable it yet. Done: https://review.coreboot.org/c/coreboot/+/72654/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f5dff865db765693cde63a23173b215b20b6c02 Gerrit-Change-Number: 72370 Gerrit-PatchSet: 4 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 01:59:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robert Zieba <robertzieba(a)google.com> Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Prashant Malani <pmalani(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/omnigul: Modify NVMe and UFS Storage support
by Dtrain Hsu (Code Review) Feb. 1, 2023

Feb. 1, 2023

Attention is currently required from: Marx Wang, Subrata Banik, Jamie Chen, Tarun Tuli, Ian Feng. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72090 ) Change subject: mb/google/brya/var/omnigul: Modify NVMe and UFS Storage support ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72090 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35c02ac9cbb8442d7b4aae57f6c7b576b2b5f77b Gerrit-Change-Number: 72090 Gerrit-PatchSet: 6 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marx Wang <marx.wang(a)intel.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Marx Wang <marx.wang(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 01:58:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold: Add support for AP-driven muxes
by Prashant Malani (Code Review) Feb. 1, 2023

Feb. 1, 2023

Prashant Malani has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72654 ) Change subject: mb/google/skyrim/var/winterhold: Add support for AP-driven muxes ...................................................................... mb/google/skyrim/var/winterhold: Add support for AP-driven muxes Add the platform ACPI devices needed for AP-driven Type-C mux and retimer programming. BUG=b:266218046 TEST=Tested on skyrim with Kconfig enabled, SSDT generated as expected. BRANCH=None Change-Id: I712a54e8b3bee8f4ead3b6cf2b495a8dda7962ad --- M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/72654/1 diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index d945474..19755cd 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -27,6 +27,7 @@ select DRIVERS_PCIE_GENERIC select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_ESPI + select EC_GOOGLE_CHROMEEC_MUX select EC_GOOGLE_CHROMEEC_SKUID select EC_GOOGLE_CHROMEEC_BOARDID select ELOG diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb index 04da26c..7f40e32 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb @@ -157,6 +157,31 @@ end end # XHCI1 controller end # Internal GPP Bridge 0 to Bus A + + device ref lpc_bridge on + chip ec/google/chromeec + use ecmux0 as retimer_conn[0] + use ecmux1 as retimer_conn[1] + use ecmux0 as mux_conn[0] + use ecmux1 as mux_conn[1] + device ref chrome_ec on + chip ec/google/chromeec/mux + device generic 0 on + chip ec/google/chromeec/mux/conn + register "mode_switch" = "true" + register "retimer_switch" = "true" + device generic 0 alias ecmux0 on end + end + chip ec/google/chromeec/mux/conn + register "mode_switch" = "true" + register "retimer_switch" = "true" + device generic 1 alias ecmux1 on end + end + end + end + end + end + end end # domain device ref i2c_0 on -- To view, visit https://review.coreboot.org/c/coreboot/+/72654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I712a54e8b3bee8f4ead3b6cf2b495a8dda7962ad Gerrit-Change-Number: 72654 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/google/dedede/var/dibbi: Update devicetree and GPIO table
by Liam Flaherty (Code Review) Feb. 1, 2023

Feb. 1, 2023

Attention is currently required from: Sam McNally, Adam Mills. Liam Flaherty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71882 ) Change subject: mb/google/dedede/var/dibbi: Update devicetree and GPIO table ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/dedede/variants/dibbi/overridetree.cb: https://review.coreboot.org/c/coreboot/+/71882/comment/463121a4_cbbfc9b2 PS5, Line 52: # Type-C Port A0 > is A0 the type-C port? Down further A0 refers to the first USB-A port. This is a typo in the comment here, fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/71882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4789be2eee1d01288031bc1e8ee5c9d6df71f9fe Gerrit-Change-Number: 71882 Gerrit-PatchSet: 6 Gerrit-Owner: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Reviewer: Adam Mills <adamjmills(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Adam Mills <adamjmills(a)google.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 01:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Adam Mills <adamjmills(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/dedede/var/dibbi: Update devicetree and GPIO table
by Liam Flaherty (Code Review) Feb. 1, 2023

Feb. 1, 2023

Attention is currently required from: Sam McNally, Liam Flaherty. Hello Sam McNally, build bot (Jenkins), Adam Mills, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71882 to look at the new patch set (#6). Change subject: mb/google/dedede/var/dibbi: Update devicetree and GPIO table ...................................................................... mb/google/dedede/var/dibbi: Update devicetree and GPIO table Create overridetree and GPIO config based on latest schematic: 1. Update PCIe ports 2. Update USB ports 3. Remove unused I2Cs 4. Remove unused peripherals (SD card, eDP, speakers) 5. Add LAN 6. Thermal policy for updated temp sensors BUG=b:260934185, b:260934719 BRANCH=dedede TEST=build Change-Id: I4789be2eee1d01288031bc1e8ee5c9d6df71f9fe Signed-off-by: Liam Flaherty <liamflaherty(a)chromium.org> --- M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/dibbi/Makefile.inc A src/mainboard/google/dedede/variants/dibbi/gpio.c M src/mainboard/google/dedede/variants/dibbi/overridetree.cb 4 files changed, 310 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/71882/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/71882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4789be2eee1d01288031bc1e8ee5c9d6df71f9fe Gerrit-Change-Number: 71882 Gerrit-PatchSet: 6 Gerrit-Owner: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Reviewer: Adam Mills <adamjmills(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Modify DPTF settings
by Ren Kuo (Code Review) Feb. 1, 2023

Feb. 1, 2023

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Reka Norman, Vidya Gopalakrishnan, Tyler Wang, Peter Ou. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 ) Change subject: mb/google/nissa/var/craask: Modify DPTF settings ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File src/mainboard/google/brya/variants/craask/overridetree.cb: https://review.coreboot.org/c/coreboot/+/71860/comment/2985ab97_069d3d77 PS3, Line 24: CPU_6W_DPTF0 > nit: `THERMAL_SOLUTION_6W` to match config. […] fixed. https://review.coreboot.org/c/coreboot/+/71860/comment/a263a93e_212ddc4d PS3, Line 25: CPU_15W_DPTF1 > nit: `THERMAL_SOLUTION_15W` to match config. […] fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/71860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Gerrit-Change-Number: 71860 Gerrit-PatchSet: 4 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 01:45:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Modify DPTF settings
by Ren Kuo (Code Review) Feb. 1, 2023

Feb. 1, 2023

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Vidya Gopalakrishnan, Tyler Wang, Peter Ou. Hello build bot (Jenkins), David Wu, Tarun Tuli, Kangheui Won, Reka Norman, Vidya Gopalakrishnan, Tyler Wang, Peter Ou, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71860 to look at the new patch set (#4). Change subject: mb/google/nissa/var/craask: Modify DPTF settings ...................................................................... mb/google/nissa/var/craask: Modify DPTF settings Add ADL-N 15W CPU Power Limit(PL) settings for Craasneto BUG=b:265101768 TEST=emerge-nissa coreboot Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 74 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/71860/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/71860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Gerrit-Change-Number: 71860 Gerrit-PatchSet: 4 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/cezanne/reset: deduplicate code
by Felix Held (Code Review) Feb. 1, 2023

Feb. 1, 2023

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72690 ) Change subject: soc/amd/cezanne/reset: deduplicate code ...................................................................... soc/amd/cezanne/reset: deduplicate code do_warm_reset does the same as do_cold_reset, since warm resets aren't supported on this platform. Instead of open coding the same cold reset functionality again, call do_cold_reset from do_warm_reset. This also brings do_warm_reset in line with do_board_reset. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ie3fe010a2b361ae9a1befeb4f07b12a80d978460 --- M src/soc/amd/cezanne/reset.c 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/72690/1 diff --git a/src/soc/amd/cezanne/reset.c b/src/soc/amd/cezanne/reset.c index 1360bd5..ac0c981 100644 --- a/src/soc/amd/cezanne/reset.c +++ b/src/soc/amd/cezanne/reset.c @@ -18,9 +18,7 @@ void do_warm_reset(void) { /* Warm resets are not supported and must be executed as cold */ - pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) | - TOGGLE_ALL_PWR_GOOD); - outb(RST_CPU | SYS_RST, RST_CNT); + do_cold_reset(); } void do_board_reset(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/72690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3fe010a2b361ae9a1befeb4f07b12a80d978460 Gerrit-Change-Number: 72690 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/mendocino: Force resets to be cold
by Felix Held (Code Review) Feb. 1, 2023

Feb. 1, 2023

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Tim Van Patten, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72486 ) Change subject: soc/amd/mendocino: Force resets to be cold ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1fbb4cc6eb6e6de9616d00d0191ccf3c0ac55278 Gerrit-Change-Number: 72486 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 00:35:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/mendocino: Force resets to be cold
by Felix Held (Code Review) Feb. 1, 2023

Feb. 1, 2023

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Tim Van Patten, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72486 ) Change subject: soc/amd/mendocino: Force resets to be cold ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/mendocino/fch.c: https://review.coreboot.org/c/coreboot/+/72486/comment/877ae74a_cd611567 PS3, Line 131: pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) | TOGGLE_ALL_PWR_GOOD); > It sounds like `fch_init_resets()` should be dropped from this CL then, since we aren't doing warm r […] no, fch_init_resets is essential to make sure that that bit to change the reset behavior is still set in the case when coreboot doesn't do a reset which should be the main case. i'd still set this bit in the do_*_rest functions, so that those also behave correctly before the fch_init_resets call -- To view, visit https://review.coreboot.org/c/coreboot/+/72486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1fbb4cc6eb6e6de9616d00d0191ccf3c0ac55278 Gerrit-Change-Number: 72486 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 00:33:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0