coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: raptorlake: Add c-state latencies and residencies in coreboot
by Shaik Sameeruddin (Code Review) 03 Feb '23

03 Feb '23

Shaik Sameeruddin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72746 ) Change subject: raptorlake: Add c-state latencies and residencies in coreboot ...................................................................... raptorlake: Add c-state latencies and residencies in coreboot Signed-off-by: Sameeruddin shaik <shaik.sameeruddin(a)intel.com> Change-Id: I49f37af2c8193f2dfb73c0fbe24528a53c5884ef --- M src/soc/intel/alderlake/acpi.c M src/soc/intel/alderlake/include/soc/cpu.h 2 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/72746/1 diff --git a/src/soc/intel/alderlake/acpi.c b/src/soc/intel/alderlake/acpi.c index 9e0e1bd..6122282 100644 --- a/src/soc/intel/alderlake/acpi.c +++ b/src/soc/intel/alderlake/acpi.c @@ -108,7 +108,9 @@ static int cstate_set_s0ix[] = { C_STATE_C1, - C_STATE_C6_LONG_LAT, + C_STATE_C1E, + C_STATE_C6_SHORT_LAT, + C_STATE_C8, C_STATE_C10 }; diff --git a/src/soc/intel/alderlake/include/soc/cpu.h b/src/soc/intel/alderlake/include/soc/cpu.h index 424e02a..bbbda02 100644 --- a/src/soc/intel/alderlake/include/soc/cpu.h +++ b/src/soc/intel/alderlake/include/soc/cpu.h @@ -5,11 +5,11 @@ /* Latency times in us */ #define C1_LATENCY 1 -#define C6_LATENCY 127 +#define C6_LATENCY 325 #define C7_LATENCY 253 -#define C8_LATENCY 260 +#define C8_LATENCY 425 #define C9_LATENCY 487 -#define C10_LATENCY 1048 +#define C10_LATENCY 525 /* Power in units of mW */ #define C1_POWER 0x3e8 -- To view, visit https://review.coreboot.org/c/coreboot/+/72746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49f37af2c8193f2dfb73c0fbe24528a53c5884ef Gerrit-Change-Number: 72746 Gerrit-PatchSet: 1 Gerrit-Owner: Shaik Sameeruddin <shaik.sameeruddin(a)intel.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: soc/amd/mendocino: Separate STAPM and STT for DPTC
by Chris Wang (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Tim Van Patten, Fred Reitberger, Felix Held. Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71909 ) Change subject: soc/amd/mendocino: Separate STAPM and STT for DPTC ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71909/comment/f9630e97_faffa237 PS10, Line 9: Separate the STAPM and STT for the DPTC parameter. To avoid unnecessary : parameters being applied to DPTC when STT is enabled, especially SPL. > What does this mean in practice? What boards have STT (STAPM) enabled, but not the other? The STAPM is the default performance/thermal management for the AMD CPUs. Before STT enable, the CPU is rely on this feature to manager the performance. The legacy generation CPU (like FT4 stoney) still use STPAM only,and STT have been introduced on Ryzen serials. > Why do we want to support this, since it appears to essentially double the maintenance burden? When the STT enabled, the SPL shouldn't be touch or change, it used for STAPM but not in STT, and it will confuse the STT calculation. > Can we state all boards must support/enable STT instead? The STT is the POR for MDN platform, but before STT enabled, the CPU still use STAPM. -- To view, visit https://review.coreboot.org/c/coreboot/+/71909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7999753dcbb5716a3b07ef22a096b55579b80b5 Gerrit-Change-Number: 71909 Gerrit-PatchSet: 10 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Feb 2023 08:40:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/skolas: update dptf thermal settings
by Sumeet R Pawnikar (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Jérémy Compostella, Nick Vaccaro. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71692 ) Change subject: mb/google/brya/var/skolas: update dptf thermal settings ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71692/comment/b5c7a2c7_8258a0c6 PS4, Line 14: BRANCH=None > don't we want this on the firmware branch ? Yes. I'll update BRANCH info with "firmware-brya-14505.B". -- To view, visit https://review.coreboot.org/c/coreboot/+/71692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeddce61b0d73d82a85f486e7cb5cbfa9568953c Gerrit-Change-Number: 71692 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 08:07:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Add support to configure 6bit color depth
by Venkat Thogaru (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Shelley Chen. Hello Shelley Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72744 to look at the new patch set (#2). Change subject: soc/qualcomm/sc7280: Add support to configure 6bit color depth ...................................................................... soc/qualcomm/sc7280: Add support to configure 6bit color depth Some of the eDp panels use 6bit color depth as default. Set the default color depth configuration to 6 bit when there is no match with the supported color depths. BUG=b:255870643 TEST=Validated on sc7280 Zombie development board Change-Id: I2cea10ad417a05f020e4c418f15212fee06a2369 Signed-off-by: Vinod Polimera <quic_vpolimer(a)quicinc.com> --- M src/soc/qualcomm/sc7280/display/edp_ctrl.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/72744/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cea10ad417a05f020e4c418f15212fee06a2369 Gerrit-Change-Number: 72744 Gerrit-PatchSet: 2 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Subrata Banik (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Ivy Jian, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70226 ) Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/70226/comment/85ecc391_29ef4b5f PS7, Line 276: b > nit: 13B10 most of the time, we ended up using smaller case in coreboot hence, use the same. I don't think there is anything right or wrong. I could see both example present in this file already. -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 07:50:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Add support to configure 6bit color depth
by build bot (Jenkins) (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Shelley Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72744 ) Change subject: soc/qualcomm/sc7280: Add support to configure 6bit color depth ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169798): https://review.coreboot.org/c/coreboot/+/72744/comment/7289a504_9c06ca01 PS1, Line 10: Set the default color depth configuration to 6 bit when there is no match Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/72744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cea10ad417a05f020e4c418f15212fee06a2369 Gerrit-Change-Number: 72744 Gerrit-PatchSet: 1 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 07:45:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable MRC Fast Boot
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72745 ) Change subject: soc/intel/meteorlake: Enable MRC Fast Boot ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4a621e55c853505f7a702181ae5a70dc56d5b5a Gerrit-Change-Number: 72745 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 07:44:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Eric Lai (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70226 ) Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/70226/comment/074e925e_bfa66297 PS7, Line 276: b nit: 13B10 -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 07:44:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Subrata Banik (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Tarun Tuli, Subrata Banik. Hello build bot (Jenkins), Tarun Tuli, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70226 to look at the new patch set (#7). Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs This patch drops the WFC sensor OV8856 (reused from the Brya chassis) support for Rex and added support for Rex specific UFC sensor OV13B10. BUG=b:267264348 TEST=WFC MIPI cameras have been enabled using google/rex Proto 1. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 23 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/70226/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable MRC Fast Boot
by Subrata Banik (Code Review) 03 Feb '23

03 Feb '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72745 ) Change subject: soc/intel/meteorlake: Enable MRC Fast Boot ...................................................................... soc/intel/meteorlake: Enable MRC Fast Boot This patch requests FSP to enable the MRC fast boot feature along with FSP v2473. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: If4a621e55c853505f7a702181ae5a70dc56d5b5a --- M src/soc/intel/meteorlake/romstage/fsp_params.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/72745/1 diff --git a/src/soc/intel/meteorlake/romstage/fsp_params.c b/src/soc/intel/meteorlake/romstage/fsp_params.c index c01896f..920eb53 100644 --- a/src/soc/intel/meteorlake/romstage/fsp_params.c +++ b/src/soc/intel/meteorlake/romstage/fsp_params.c @@ -124,6 +124,8 @@ { m_cfg->SaGv = config->sagv; m_cfg->RMT = config->rmt; + /* Enable MRC Fast Boot */ + m_cfg->MrcFastBoot = 1; } static void fill_fspm_cpu_params(FSP_M_CONFIG *m_cfg, -- To view, visit https://review.coreboot.org/c/coreboot/+/72745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4a621e55c853505f7a702181ae5a70dc56d5b5a Gerrit-Change-Number: 72745 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023