coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: tests: Allow specifying vboot source directory
by Felix Held (Code Review) 16 Nov '23

16 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78849?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tests: Allow specifying vboot source directory ...................................................................... tests: Allow specifying vboot source directory Respect VBOOT_SOURCE while including generic headers. BUG=none TEST=make clean-unit-tests && VBOOT_SOURCE=/path/to/vboot_reference/ make unit-tests -j TEST=make clean-unit-tests && make unit-tests -j BRANCH=none Change-Id: Id3bb3726c91167d2dd648d748763a3948787f28d Signed-off-by: roccochen(a)chromium.com <roccochen(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78849 Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M Makefile.inc M tests/Makefile.common 3 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/Makefile b/Makefile index 29597c8..b0a99146 100644 --- a/Makefile +++ b/Makefile @@ -15,6 +15,7 @@ additional-dirs := +VBOOT_SOURCE ?= $(abspath 3rdparty/vboot) VBOOT_HOST_BUILD ?= $(abspath $(objutil)/vboot_lib) COREBOOT_EXPORTS := COREBOOT_EXPORTS diff --git a/Makefile.inc b/Makefile.inc index e382518..2f810d5 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -460,7 +460,6 @@ endif CPPFLAGS_common := -Isrc -Isrc/include -Isrc/commonlib/include -Isrc/commonlib/bsd/include -I$(obj) -VBOOT_SOURCE ?= 3rdparty/vboot CPPFLAGS_common += -I$(VBOOT_SOURCE)/firmware/include CPPFLAGS_common += -include $(src)/include/kconfig.h CPPFLAGS_common += -include $(src)/include/rules.h diff --git a/tests/Makefile.common b/tests/Makefile.common index e51d253..9cc79d7 100644 --- a/tests/Makefile.common +++ b/tests/Makefile.common @@ -36,7 +36,7 @@ TEST_INCLUDES += -I$(src) -I$(src)/include -I$(src)/commonlib/include \ -I$(src)/commonlib/bsd/include -I$(src)/arch/x86/include \ - -I$(top)/3rdparty/vboot/firmware/include + -I$(VBOOT_SOURCE)/firmware/include # Path for Kconfig autoheader TEST_INCLUDES += -I$(dir $(TEST_KCONFIG_AUTOHEADER)) -- To view, visit https://review.coreboot.org/c/coreboot/+/78849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id3bb3726c91167d2dd648d748763a3948787f28d Gerrit-Change-Number: 78849 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: include/device/device: drop HAVE_ACPI_TABLES guards
by Felix Held (Code Review) 16 Nov '23

16 Nov '23

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78990?usp=email ) Change subject: include/device/device: drop HAVE_ACPI_TABLES guards ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iac20b6cdc44a5280566ee7003a5ef6fbe913b099 Gerrit-Change-Number: 78990 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Nov 2023 12:49:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: include/device/device: drop GENERATE_SMBIOS_TABLES guards
by Felix Held (Code Review) 16 Nov '23

16 Nov '23

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79092?usp=email ) Change subject: include/device/device: drop GENERATE_SMBIOS_TABLES guards ...................................................................... include/device/device: drop GENERATE_SMBIOS_TABLES guards There's no need to remove the corresponding fields from the device_operations struct when GENERATE_SMBIOS_TABLES isn't selected. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ifa24d1fd211c263b788046e63de3dd5c54cba801 --- M src/include/device/device.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/79092/1 diff --git a/src/include/device/device.h b/src/include/device/device.h index 68e2622..07b71ec 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -48,11 +48,11 @@ void (*enable)(struct device *dev); void (*vga_disable)(struct device *dev); void (*reset_bus)(struct bus *bus); -#if CONFIG(GENERATE_SMBIOS_TABLES) + int (*get_smbios_data)(struct device *dev, int *handle, unsigned long *current); void (*get_smbios_strings)(struct device *dev, struct smbios_type11 *t); -#endif + #if CONFIG(HAVE_ACPI_TABLES) unsigned long (*write_acpi_tables)(const struct device *dev, unsigned long start, struct acpi_rsdp *rsdp); -- To view, visit https://review.coreboot.org/c/coreboot/+/79092?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa24d1fd211c263b788046e63de3dd5c54cba801 Gerrit-Change-Number: 79092 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Nico Huber (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner, Yidi Lin, Yu-Ping Wu. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email ) Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/asurada/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/da76adaa_49f5ab34 : PS1, Line 11: config BOARD_SPECIFIC_OPTIONS > That's a separate discussion we can have if you want, but personally I think things are ordered bett […] Order is a very good argument. Note that I just wanted to point out that other people may want to discuss this. Maybe wait a little if somebody else chimes in. -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 12:33:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: acpi: Add PPTT support
by Nico Huber (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Arthur Heymans, Cliff Huang, David Milosevic, Lance Zhao, Martin L Roth, Maximilian Brune, Patrick Rudolph, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78071?usp=email ) Change subject: acpi: Add PPTT support ...................................................................... Patch Set 19: (2 comments) File src/acpi/acpi_pptt.c: https://review.coreboot.org/c/coreboot/+/78071/comment/9e687eaf_ff06df5c : PS17, Line 12: typedef > Removing typedefs would elongate the signatures even more, so I would like to keep them, if possible […] IMO, it's highly subjective. Upstream, code is more often read than worked on. The average reader probably wouldn't know about local conventions like using typedefs for internal things. It's true that we made an exception for ACPI tables. Maybe that's a bad idea. All the discussions around it could be avoided if we would clean up that code for good. https://review.coreboot.org/c/coreboot/+/78071/comment/d35abff8_a85bf2c5 : PS17, Line 131: cache_reference_t cache_refs[CONFIG_ACPI_PPTT_MAX_CACHES]; > Maybe we could add a small note for the user, that the PPTT code is sensitive to the pointers you pass in. Sounds good. Actually, after some sleep, I'm not convinced anymore if the deep comparison I proposed would work. There are cases where I'm not sure what the ACPI spec would want us to do. So leaving this to the platform code might be the only option anyway. >> Is this not more appropriate to declare this in setup_topology so that all siblings can reuse it? Now you create these references for each call of new_pptt_cpu. return reference_for_cache in pptt_cache if !0? > > I have moved the cache list to setup_topology, so this is done. Keeping the discussion open though, in case someone wants reply. Otherwise feel free to mark as done. But doesn't this suffer from the huge list size like you described above? (I find this hard to discuss btw. when numbers are hidden in undisclosed patches.) -- To view, visit https://review.coreboot.org/c/coreboot/+/78071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia119e1ba15756704668116bdbc655190ec94ff10 Gerrit-Change-Number: 78071 Gerrit-PatchSet: 19 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 12:09:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/geralt: Disable SD card support for Ciri
by Felix Held (Code Review) 16 Nov '23

16 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78958?usp=email ) Change subject: mb/google/geralt: Disable SD card support for Ciri ...................................................................... mb/google/geralt: Disable SD card support for Ciri According to proto schematics, the SD card is removed. BUG=b:308968270 TEST=emerge-geralt coreboot BRANCH=None Change-Id: Id4e021e7896d093560f39c40573ac616d76438c2 Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78958 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Reviewed-by: Yidi Lin <yidilin(a)google.com> --- M src/mainboard/google/geralt/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: cong yang: Looks good to me, but someone else must approve build bot (Jenkins): Verified Yidi Lin: Looks good to me, approved diff --git a/src/mainboard/google/geralt/Kconfig b/src/mainboard/google/geralt/Kconfig index ad3491f..c422441 100644 --- a/src/mainboard/google/geralt/Kconfig +++ b/src/mainboard/google/geralt/Kconfig @@ -68,7 +68,8 @@ config SDCARD_INIT bool - default y + default y if BOARD_GOOGLE_GERALT + default n if BOARD_GOOGLE_CIRI choice prompt "Speaker AMP for Geralt" -- To view, visit https://review.coreboot.org/c/coreboot/+/78958?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4e021e7896d093560f39c40573ac616d76438c2 Gerrit-Change-Number: 78958 Gerrit-PatchSet: 4 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: mb/google/geralt: Move backlight-related functions to common panel.c
by Felix Held (Code Review) 16 Nov '23

16 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78955?usp=email ) Change subject: mb/google/geralt: Move backlight-related functions to common panel.c ...................................................................... mb/google/geralt: Move backlight-related functions to common panel.c These backlight related functions can be reused in other variants, move them out to the panel.c. Also the panel_geralt.c should be used for Geralt, enable it on Geralt board only. BUG=b:308968270 TEST=emerge-geralt coreboot BRANCH=None Change-Id: I5d4035d5f480551c428c450826e23bf77f2fe08a Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78955 Reviewed-by: Yidi Lin <yidilin(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: cong yang <yangcong5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/Makefile.inc M src/mainboard/google/geralt/panel.c M src/mainboard/google/geralt/panel.h M src/mainboard/google/geralt/panel_geralt.c 4 files changed, 45 insertions(+), 38 deletions(-) Approvals: Yidi Lin: Looks good to me, approved cong yang: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/src/mainboard/google/geralt/Makefile.inc b/src/mainboard/google/geralt/Makefile.inc index a0ac297..2b1f313 100644 --- a/src/mainboard/google/geralt/Makefile.inc +++ b/src/mainboard/google/geralt/Makefile.inc @@ -23,6 +23,6 @@ ramstage-y += display.c ramstage-y += mainboard.c ramstage-y += panel.c -ramstage-y += panel_geralt.c ramstage-y += regulator.c ramstage-y += reset.c +ramstage-$(CONFIG_BOARD_GOOGLE_GERALT) += panel_geralt.c diff --git a/src/mainboard/google/geralt/panel.c b/src/mainboard/google/geralt/panel.c index 3174870..e25b5cb 100644 --- a/src/mainboard/google/geralt/panel.c +++ b/src/mainboard/google/geralt/panel.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <edid.h> #include <gpio.h> +#include <identity.h> #include <soc/gpio_common.h> #include <string.h> @@ -35,6 +36,13 @@ printk(BIOS_ERR, "Missing %s in CBFS.\n", cbfs_name); } +struct panel_description __weak *get_panel_description(uint32_t panel_id) +{ + printk(BIOS_WARNING, "%s: %s: the panel configuration is not ready\n", + __func__, mainboard_part_number); + return NULL; +} + struct panel_description *get_active_panel(void) { uint32_t active_panel_id = panel_id(); @@ -66,3 +74,38 @@ } return panel; } + +void configure_mipi_pwm_backlight(void) +{ + gpio_output(GPIO_AP_DISP_BKLTEN, 0); + gpio_output(GPIO_MIPI_BL_PWM_1V8, 0); +} + +void fill_lp_backlight_gpios(struct lb_gpios *gpios) +{ + struct panel_description *panel = get_active_panel(); + if (!panel || panel->disp_path == DISP_PATH_NONE) + return; + + struct lb_gpio mipi_pwm_gpios[] = { + {GPIO_MIPI_BL_PWM_1V8.id, ACTIVE_HIGH, -1, "PWM control"}, + }; + + struct lb_gpio edp_pwm_gpios[] = { + {GPIO_EDP_BL_PWM_1V8.id, ACTIVE_HIGH, -1, "PWM control"}, + }; + + if (panel->pwm_ctrl_gpio) { + /* PWM control for typical eDP and MIPI panels */ + if (panel->disp_path == DISP_PATH_MIPI) + lb_add_gpios(gpios, mipi_pwm_gpios, ARRAY_SIZE(mipi_pwm_gpios)); + else + lb_add_gpios(gpios, edp_pwm_gpios, ARRAY_SIZE(edp_pwm_gpios)); + } + + struct lb_gpio backlight_gpios[] = { + {GPIO_AP_DISP_BKLTEN.id, ACTIVE_HIGH, -1, "backlight enable"}, + }; + + lb_add_gpios(gpios, backlight_gpios, ARRAY_SIZE(backlight_gpios)); +} diff --git a/src/mainboard/google/geralt/panel.h b/src/mainboard/google/geralt/panel.h index 11b7fb0..71cecdf 100644 --- a/src/mainboard/google/geralt/panel.h +++ b/src/mainboard/google/geralt/panel.h @@ -16,6 +16,7 @@ bool pwm_ctrl_gpio; }; +void configure_mipi_pwm_backlight(void); void fill_lp_backlight_gpios(struct lb_gpios *gpios); uint32_t panel_id(void); struct panel_description *get_panel_description(uint32_t panel_id); diff --git a/src/mainboard/google/geralt/panel_geralt.c b/src/mainboard/google/geralt/panel_geralt.c index 455f759..2ca95be 100644 --- a/src/mainboard/google/geralt/panel_geralt.c +++ b/src/mainboard/google/geralt/panel_geralt.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <boardid.h> -#include <boot/coreboot_tables.h> #include <console/console.h> #include <delay.h> #include <gpio.h> @@ -12,18 +11,11 @@ #include <soc/pmif.h> #include <string.h> -#include "display.h" #include "gpio.h" #include "panel.h" #define PMIC_TPS65132_I2C I2C3 -static void configure_mipi_pwm_backlight(void) -{ - gpio_output(GPIO_AP_DISP_BKLTEN, 0); - gpio_output(GPIO_MIPI_BL_PWM_1V8, 0); -} - static void power_on_mipi_boe_tv110c9m_ll0(void) { const struct tps65132s_reg_setting reg_settings[] = { @@ -76,32 +68,3 @@ return &panels[id]; } - -void fill_lp_backlight_gpios(struct lb_gpios *gpios) -{ - struct panel_description *panel = get_active_panel(); - if (!panel || panel->disp_path == DISP_PATH_NONE) - return; - - struct lb_gpio mipi_pwm_gpios[] = { - {GPIO_MIPI_BL_PWM_1V8.id, ACTIVE_HIGH, -1, "PWM control"}, - }; - - struct lb_gpio edp_pwm_gpios[] = { - {GPIO_EDP_BL_PWM_1V8.id, ACTIVE_HIGH, -1, "PWM control"}, - }; - - if (panel->pwm_ctrl_gpio) { - /* PWM control for typical eDP and MIPI panels */ - if (panel->disp_path == DISP_PATH_MIPI) - lb_add_gpios(gpios, mipi_pwm_gpios, ARRAY_SIZE(mipi_pwm_gpios)); - else - lb_add_gpios(gpios, edp_pwm_gpios, ARRAY_SIZE(edp_pwm_gpios)); - } - - struct lb_gpio backlight_gpios[] = { - {GPIO_AP_DISP_BKLTEN.id, ACTIVE_HIGH, -1, "backlight enable"}, - }; - - lb_add_gpios(gpios, backlight_gpios, ARRAY_SIZE(backlight_gpios)); -} -- To view, visit https://review.coreboot.org/c/coreboot/+/78955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d4035d5f480551c428c450826e23bf77f2fe08a Gerrit-Change-Number: 78955 Gerrit-PatchSet: 6 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: lib/device_tree.c: Fix print_property
by Felix Held (Code Review) 16 Nov '23

16 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78025?usp=email ) Change subject: lib/device_tree.c: Fix print_property ...................................................................... lib/device_tree.c: Fix print_property This uses the size attribute to traverse the possible string. This patch traverses the entire property for non printable characters and not just until the first 0 is hit. Now numbers that start with a zero (memory wise) are not falsely recognized as strings: before the patch: clock-frequency = ""; after the patch: clock-frequency = < 0x1c2000 >; Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I229c07b76468fe54f90fa9df12f103d7c7c2859d Reviewed-on: https://review.coreboot.org/c/coreboot/+/78025 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M src/lib/device_tree.c 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index 352f254..ab9c937b 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -75,10 +75,14 @@ int is_string = prop->size > 0 && ((char *)prop->data)[prop->size - 1] == '\0'; - if (is_string) - for (const char *c = prop->data; *c != '\0'; c++) - if (!isprint(*c)) + if (is_string) { + for (int i = 0; i < prop->size - 1; i++) { + if (!isprint(((char *)prop->data)[i])) { is_string = 0; + break; + } + } + } print_indent(depth); if (is_string) { -- To view, visit https://review.coreboot.org/c/coreboot/+/78025?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I229c07b76468fe54f90fa9df12f103d7c7c2859d Gerrit-Change-Number: 78025 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: drivers: spi_flash: Add space before colon to fix coding style
by Felix Held (Code Review) 16 Nov '23

16 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79053?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers: spi_flash: Add space before colon to fix coding style ...................................................................... drivers: spi_flash: Add space before colon to fix coding style BUG=none TEST=build karis firmware pass Change-Id: I67b4ca4c8fde795d4206eaa0b9ea9d9bfc768ac6 Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79053 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- M src/drivers/spi/spi_flash_internal.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified David Wu: Looks good to me, approved diff --git a/src/drivers/spi/spi_flash_internal.h b/src/drivers/spi/spi_flash_internal.h index e388311..1927111 100644 --- a/src/drivers/spi/spi_flash_internal.h +++ b/src/drivers/spi/spi_flash_internal.h @@ -71,10 +71,10 @@ */ uint16_t id[2]; /* Log based 2 total number of sectors. */ - uint16_t nr_sectors_shift: 4; + uint16_t nr_sectors_shift : 4; uint16_t fast_read_dual_output_support : 1; /* 1-1-2 read */ uint16_t fast_read_dual_io_support : 1; /* 1-2-2 read */ - uint16_t _reserved_for_flags: 2; + uint16_t _reserved_for_flags : 2; /* Block protection. Currently used by Winbond. */ uint16_t protection_granularity_shift : 5; uint16_t bp_bits : 3; -- To view, visit https://review.coreboot.org/c/coreboot/+/79053?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I67b4ca4c8fde795d4206eaa0b9ea9d9bfc768ac6 Gerrit-Change-Number: 79053 Gerrit-PatchSet: 4 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/brya/var/anraggar: Modify LTE GPIO port of A8&D6
by Weimin Wu (Code Review) 16 Nov '23

16 Nov '23

Weimin Wu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79091?usp=email ) Change subject: mb/google/brya/var/anraggar: Modify LTE GPIO port of A8&D6 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/79091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9847029fc7cc5b2c13f2674e4ce26ed9d4f84ae7 Gerrit-Change-Number: 79091 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023