November 2023 - coreboot-gerrit

[XS] Change in coreboot[main]: Revert "Update vboot submodule to upstream main"
by Martin L Roth (Code Review) Nov. 1, 2023

Nov. 1, 2023

Attention is currently required from: Eric Lai, Julius Werner, Martin L Roth, Yu-Ping Wu. Martin L Roth has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/78844?usp=email ) Change subject: Revert "Update vboot submodule to upstream main" ...................................................................... Removed Verified-1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/c/coreboot/+/78844?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I726e2e1ce7dc3350a281dc30256b116580fd63c0 Gerrit-Change-Number: 78844 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: deleteVote

1 0

[XS] Change in coreboot[main]: Revert "vboot: Add catchall recovery reason for unspecified phase 4 e...
by Martin L Roth (Code Review) Nov. 1, 2023

Nov. 1, 2023

Attention is currently required from: Julius Werner, Yu-Ping Wu. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78845?usp=email ) Change subject: Revert "vboot: Add catchall recovery reason for unspecified phase 4 errors" ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78845?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8ef853d81ee9b1f18d36dfd82cdf687381ece2c6 Gerrit-Change-Number: 78845 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 00:33:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Revert "vboot: Add catchall recovery reason for unspecified phase 4 e...
by Martin L Roth (Code Review) Nov. 1, 2023

Nov. 1, 2023

Attention is currently required from: Julius Werner, Martin L Roth, Yu-Ping Wu. Martin L Roth has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/78845?usp=email ) Change subject: Revert "vboot: Add catchall recovery reason for unspecified phase 4 errors" ...................................................................... Removed Verified-1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/c/coreboot/+/78845?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8ef853d81ee9b1f18d36dfd82cdf687381ece2c6 Gerrit-Change-Number: 78845 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: deleteVote

1 0

[S] Change in coreboot[main]: commonlib/fsp_relocate: Fix potential NULL pointer dereference
by Bora Guvendik (Code Review) Nov. 1, 2023

Nov. 1, 2023

Attention is currently required from: Arthur Heymans, Ed Sharma, Elyes Haouas, Jérémy Compostella, Nathaniel L Desimone. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78501?usp=email ) Change subject: commonlib/fsp_relocate: Fix potential NULL pointer dereference ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9fad90a60854d5f050aa044a5c0b3af91c99df4a Gerrit-Change-Number: 78501 Gerrit-PatchSet: 5 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 01 Nov 2023 00:31:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: acpi: Move HPET generation to a common location
by Nico Huber (Code Review) Nov. 1, 2023

Nov. 1, 2023

Attention is currently required from: Arthur Heymans, Cliff Huang, Felix Singer, Fred Reitberger, Jason Glenesk, Jeff Daly, Lance Zhao, Matt DeVillier, Raul Rangel, Tim Wawrzynczak, Vanessa Eusebio. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76128?usp=email ) Change subject: acpi: Move HPET generation to a common location ...................................................................... Patch Set 9: Code-Review+1 (4 comments) Patchset: PS9: Looks good overall and I like it! File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/76128/comment/2e3c94ca_dc2d5253 : PS9, Line 1266: #endif A `static inline` with these guards in the header file at the forward declaration might look better than #if in a C file. File src/acpi/acpi_hpet.c: https://review.coreboot.org/c/coreboot/+/76128/comment/134a514c_42532e9c : PS9, Line 13: return; It's already guarded in the Makefile, so not necessary here, right? (I guess we could also keep this, remove the guard in the Makefile and safe us the #if'ed stub above?) File src/southbridge/intel/i82371eb/Kconfig: https://review.coreboot.org/c/coreboot/+/76128/comment/16eed369_e5c1bbc8 : PS9, Line 12: config ACPI_HPET There's no I82371EB specific guard here, so this could be leaking, right? Why not have a `select ACPI_HPET if HAVE_ACPI_TABLES` above? -- To view, visit https://review.coreboot.org/c/coreboot/+/76128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38b9962a8d568267356256a3edc51348b9417e20 Gerrit-Change-Number: 76128 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 00:26:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/nissa/var/craaskov: Disable storage devices based on fw_config
by Rex Chou (Code Review) Nov. 1, 2023

Nov. 1, 2023

Attention is currently required from: Dtrain Hsu, Eric Lai, Kenny Pan, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik. Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78843?usp=email ) Change subject: mb/google/nissa/var/craaskov: Disable storage devices based on fw_config ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5993049ac63520c4dfd057c38b566fc69502d825 Gerrit-Change-Number: 78843 Gerrit-PatchSet: 1 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 00:15:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: vboot: Add catchall recovery reason for unspecified phase 4 errors
by Martin L Roth (Code Review) Nov. 1, 2023

Nov. 1, 2023

Martin L Roth has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/78821?usp=email ) Change subject: vboot: Add catchall recovery reason for unspecified phase 4 errors ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/78821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If00f8f8a5d17aa113e0325aad58d367f244aca49 Gerrit-Change-Number: 78821 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: revert

1 0

[XS] Change in coreboot[main]: Revert "vboot: Add catchall recovery reason for unspecified phase 4 e...
by Martin L Roth (Code Review) Nov. 1, 2023

Nov. 1, 2023

Attention is currently required from: Julius Werner, Yu-Ping Wu. Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/78845?usp=email to review the following change. Change subject: Revert "vboot: Add catchall recovery reason for unspecified phase 4 errors" ...................................................................... Revert "vboot: Add catchall recovery reason for unspecified phase 4 errors" This reverts commit 7499d9610016c4a89b722498885f196ed6d217aa. Reason for revert: coreboot build fails Change-Id: I8ef853d81ee9b1f18d36dfd82cdf687381ece2c6 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M src/security/vboot/vboot_logic.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/78845/1 diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c index 93a188c..11983b9 100644 --- a/src/security/vboot/vboot_logic.c +++ b/src/security/vboot/vboot_logic.c @@ -374,7 +374,7 @@ } if (rv) - vboot_fail_and_reboot(ctx, VB2_RECOVERY_FW_GET_FW_BODY, rv); + vboot_save_and_reboot(ctx, rv); vboot_save_data(ctx); /* Only extend PCRs once on boot. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/78845?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8ef853d81ee9b1f18d36dfd82cdf687381ece2c6 Gerrit-Change-Number: 78845 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0