coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[S] Change in coreboot[main]: mb/google/corsola: Configure I2C and I2S interface for ALC5650
by Ruihai Zhou (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Hung-Te Lin, Jiaxin Yu, Yang Wu. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email ) Change subject: mb/google/corsola: Configure I2C and I2S interface for ALC5650 ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Gerrit-Change-Number: 79064 Gerrit-PatchSet: 10 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 09:36:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/corsola: Configure I2C and I2S interface for ALC5650
by Yidi Lin (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Hung-Te Lin, Jiaxin Yu, Ruihai Zhou, Yang Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email ) Change subject: mb/google/corsola: Configure I2C and I2S interface for ALC5650 ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Gerrit-Change-Number: 79064 Gerrit-PatchSet: 10 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 09:28:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/corsola: Configure I2C and I2S interface for ALC5650
by Yu-Ping Wu (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Hung-Te Lin, Jiaxin Yu, Ruihai Zhou, Yang Wu, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email ) Change subject: mb/google/corsola: Configure I2C and I2S interface for ALC5650 ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Gerrit-Change-Number: 79064 Gerrit-PatchSet: 10 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 09:26:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/geralt: Create variant Ciri
by Yu-Ping Wu (Code Review) 16 Nov '23

16 Nov '23

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email ) Change subject: mb/google/geralt: Create variant Ciri ...................................................................... mb/google/geralt: Create variant Ciri Create the variant Ciri and enable MAX98390 AMP for it. The panel related support will be added in the follow up CLs. BUG=b:308968270 TEST=emerge-geralt coreboot BRANCH=None Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25 Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78954 Reviewed-by: Yidi Lin <yidilin(a)google.com> Reviewed-by: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/Kconfig.name 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified cong yang: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/geralt/Kconfig b/src/mainboard/google/geralt/Kconfig index 6817143..ad3491f 100644 --- a/src/mainboard/google/geralt/Kconfig +++ b/src/mainboard/google/geralt/Kconfig @@ -7,6 +7,9 @@ config BOARD_GOOGLE_GERALT select BOARD_GOOGLE_GERALT_COMMON +config BOARD_GOOGLE_CIRI + select BOARD_GOOGLE_GERALT_COMMON + if BOARD_GOOGLE_GERALT_COMMON config VBOOT @@ -45,6 +48,7 @@ config MAINBOARD_PART_NUMBER string default "Geralt" if BOARD_GOOGLE_GERALT + default "Ciri" if BOARD_GOOGLE_CIRI config BOOT_DEVICE_SPI_FLASH_BUS int @@ -68,7 +72,7 @@ choice prompt "Speaker AMP for Geralt" - default USE_MAX98390 if BOARD_GOOGLE_GERALT + default USE_MAX98390 if BOARD_GOOGLE_GERALT || BOARD_GOOGLE_CIRI config USE_MAX98390 bool "MAX98390" diff --git a/src/mainboard/google/geralt/Kconfig.name b/src/mainboard/google/geralt/Kconfig.name index e699ac2..631a884 100644 --- a/src/mainboard/google/geralt/Kconfig.name +++ b/src/mainboard/google/geralt/Kconfig.name @@ -2,3 +2,6 @@ config BOARD_GOOGLE_GERALT bool "-> Geralt" + +config BOARD_GOOGLE_CIRI + bool "-> Ciri" -- To view, visit https://review.coreboot.org/c/coreboot/+/78954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25 Gerrit-Change-Number: 78954 Gerrit-PatchSet: 5 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/geralt: Create variant Ciri
by Yu-Ping Wu (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email ) Change subject: mb/google/geralt: Create variant Ciri ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78954/comment/0c6a4642_191697a0 : PS2, Line 9: and enable MAX98390 AMP for it. > Acknowledged I agree that it's not necessary, as eventually the new variant will become different from Geralt. -- To view, visit https://review.coreboot.org/c/coreboot/+/78954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25 Gerrit-Change-Number: 78954 Gerrit-PatchSet: 4 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 09:24:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/geralt: Create variant Ciri
by Yu-Ping Wu (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email ) Change subject: mb/google/geralt: Create variant Ciri ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78954/comment/80281c71_8d5fa94a : PS2, Line 9: and enable MAX98390 AMP for it. > Paul, I appreciate your work making sure that coreboot has good commit messages. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/78954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25 Gerrit-Change-Number: 78954 Gerrit-PatchSet: 4 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 09:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/corsola: Configure I2C and I2S interface for ALC5650
by Yang Wu (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Hung-Te Lin, Jiaxin Yu, Ruihai Zhou, Yidi Lin, Yu-Ping Wu. Yang Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email ) Change subject: mb/google/corsola: Configure I2C and I2S interface for ALC5650 ...................................................................... Patch Set 10: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79064/comment/a70791c1_9ecd3e49 : PS9, Line 7: /var/chinchou > remove Done File src/mainboard/google/corsola/mainboard.c: https://review.coreboot.org/c/coreboot/+/79064/comment/9d434351_f23fb118 : PS9, Line 16: audio > configure_alc1019 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Gerrit-Change-Number: 79064 Gerrit-PatchSet: 10 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 09:23:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/corsola: Configure I2C and I2S interface for ALC5650
by Yang Wu (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Hung-Te Lin, Jiaxin Yu, Ruihai Zhou, Yang Wu, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Jiaxin Yu, Ruihai Zhou, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79064?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Code-Review+1 by Jiaxin Yu, Code-Review+1 by Ruihai Zhou, Code-Review+2 by Yidi Lin, Verified+1 by build bot (Jenkins) Change subject: mb/google/corsola: Configure I2C and I2S interface for ALC5650 ...................................................................... mb/google/corsola: Configure I2C and I2S interface for ALC5650 Configure I2S1 and I2C5 for ALC5650 to support beep sound in depthcharge. BRANCH=corsola BUG=b:305828247 TEST=Verify devbeep in depthcharge console Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/mainboard.c 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/79064/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/79064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Gerrit-Change-Number: 79064 Gerrit-PatchSet: 10 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/supermicro/x11: Make use of chipset devicetree
by Michael Niewöhner (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78594?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/supermicro/x11: Make use of chipset devicetree ...................................................................... Patch Set 14: Code-Review+2 (1 comment) File src/mainboard/supermicro/x11-lga1151-series/devicetree.cb: https://review.coreboot.org/c/coreboot/+/78594/comment/09fd636b_3bc46f1f : PS14, Line 35: you missed one, sorry 😄 -- To view, visit https://review.coreboot.org/c/coreboot/+/78594?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5176aa56ecaa52d0f42455bc7176b0415a6199ec Gerrit-Change-Number: 78594 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 09:20:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Support loading OP-TEE via an SMC
by Kiwi Liu (Code Review) 16 Nov '23

16 Nov '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu. Kiwi Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78801?usp=email ) Change subject: soc/mediatek/mt8188: Support loading OP-TEE via an SMC ...................................................................... Patch Set 16: (1 comment) File src/soc/mediatek/mt8188/Makefile.inc: https://review.coreboot.org/c/coreboot/+/78801/comment/8ebfc1e5_52c76398 : PS15, Line 62: BL31_MAKEARGS > YES, I will provide patch later https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/24879 -- To view, visit https://review.coreboot.org/c/coreboot/+/78801?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic38c8beb59c090ae56c5be6821dd8625435609e9 Gerrit-Change-Number: 78801 Gerrit-PatchSet: 16 Gerrit-Owner: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 09:04:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023