coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[S] Change in coreboot[master]: mb/google/guybrush: enable display backlight in ramstage
by Matt DeVillier (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Raul Rangel, Jason Nien, Rob Barnes, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67246 ) Change subject: mb/google/guybrush: enable display backlight in ramstage ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/guybrush/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/67246/comment/18cf170d_2807f80f PS1, Line 141: PAD_GPO > The pin seems to be in the S5 domain, so it should retain its value looking at the original bug, it seemed that some SKUs were having issues with the backlight being restored at min value coming out of Si0x, and using ACPI to set the backlight was part of the workaround. I'm unable to reproduce that problem on Dewatt though. -- To view, visit https://review.coreboot.org/c/coreboot/+/67246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2519d779954ed89486045aa7de0b18f1c31a4374 Gerrit-Change-Number: 67246 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 15:16:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: guybrush: remove RO_GSCVD area from FMAP
by Himanshu Sahdev (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Nien, Martin Roth. Hello build bot (Jenkins), Jason Nien, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67376 to look at the new patch set (#2). Change subject: guybrush: remove RO_GSCVD area from FMAP ...................................................................... guybrush: remove RO_GSCVD area from FMAP This area relates to storing of AP RO verification information. CONFIG_VBOOT_GSCVD is enabled by default for TPM_GOOGLE_TI50 and guybrush is using TPM_GOOGLE_CR50. Signed-off-by: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Change-Id: I896b871bf2ac64e334514b979add9b8ac2c43945 --- M src/mainboard/google/guybrush/chromeos.fmd 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/67376/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896b871bf2ac64e334514b979add9b8ac2c43945 Gerrit-Change-Number: 67376 Gerrit-PatchSet: 2 Gerrit-Owner: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: guybrush: remove RO_GSCVD area from FMAP
by build bot (Jenkins) (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Nien, Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67376 ) Change subject: guybrush: remove RO_GSCVD area from FMAP ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158134): https://review.coreboot.org/c/coreboot/+/67376/comment/dff5e755_88f1d9ce PS1, Line 9: This area relates to storing of AP RO verification information. Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/67376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896b871bf2ac64e334514b979add9b8ac2c43945 Gerrit-Change-Number: 67376 Gerrit-PatchSet: 1 Gerrit-Owner: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 14:53:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: guybrush: remove RO_GSCVD area from FMAP
by Himanshu Sahdev (Code Review) 06 Sep '22

06 Sep '22

Himanshu Sahdev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67376 ) Change subject: guybrush: remove RO_GSCVD area from FMAP ...................................................................... guybrush: remove RO_GSCVD area from FMAP This area relates to storing of AP RO verification information. CONFIG_VBOOT_GSCVD is enabled by default for TPM_GOOGLE_TI50 and guybrush is using TPM_GOOGLE_CR50. Signed-off-by: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Change-Id: I896b871bf2ac64e334514b979add9b8ac2c43945 --- M src/mainboard/google/guybrush/chromeos.fmd 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/67376/1 diff --git a/src/mainboard/google/guybrush/chromeos.fmd b/src/mainboard/google/guybrush/chromeos.fmd index a6dbc2c..3875700 100644 --- a/src/mainboard/google/guybrush/chromeos.fmd +++ b/src/mainboard/google/guybrush/chromeos.fmd @@ -22,7 +22,6 @@ RW_LEGACY(CBFS) WP_RO@8M 8M { RO_VPD(PRESERVE) 16K - RO_GSCVD 8K RO_SECTION { FMAP 2K RO_FRID 64 -- To view, visit https://review.coreboot.org/c/coreboot/+/67376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896b871bf2ac64e334514b979add9b8ac2c43945 Gerrit-Change-Number: 67376 Gerrit-PatchSet: 1 Gerrit-Owner: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Add support for PSP NVRAM base addr and size
by Bao Zheng (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Glenesk, ritul guru, Matt DeVillier, Paul Menzel, Fred Reitberger, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67137 ) Change subject: Add support for PSP NVRAM base addr and size ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File util/amdfwtool/amdfwtool.h: https://review.coreboot.org/c/coreboot/+/67137/comment/031422b9_10c625ac PS4, Line 279: uint64_t dest; : size_t size; > But this amd_fw_entry is for legacy XHCI,IMC firmware, not for PSP FW. Done. you are right. -- To view, visit https://review.coreboot.org/c/coreboot/+/67137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1664893db6f6dcdc588aeaf9448c2d81390af5fa Gerrit-Change-Number: 67137 Gerrit-PatchSet: 5 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Sep 2022 14:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: ritul guru <ritul.bits(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/intel/adlrvp: Make SOC_INTEL_CSE_LITE_SKU configurable
by Angel Pons (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Kapil Porwal, Nick Vaccaro, Maximilian Brune. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67078 ) Change subject: mb/intel/adlrvp: Make SOC_INTEL_CSE_LITE_SKU configurable ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4da7feab881ae43528c9d852cc842ac93fa9c6de Gerrit-Change-Number: 67078 Gerrit-PatchSet: 12 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 14:16:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC
by Lean Sheng Tan (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Maximilian Brune. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66545 ) Change subject: mainboard/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1f62d6dd0b00d26f8c8a71b624ba5fba4c63774 Gerrit-Change-Number: 66545 Gerrit-PatchSet: 10 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 14:13:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4}
by Elyes Haouas (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Martin L Roth, Jakub Czapiga, Arthur Heymans, Patrick Rudolph, Elyes Haouas. Hello build bot (Jenkins), Nico Huber, Martin L Roth, Jakub Czapiga, Paul Menzel, Angel Pons, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62181 to look at the new patch set (#9). Change subject: device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4} ...................................................................... device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4} Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/device/dram/ddr2.c M src/device/dram/ddr3.c M src/device/dram/ddr4.c M src/device/dram/spd.c M src/include/device/dram/ddr2.h M src/include/device/dram/ddr3.h M src/include/device/dram/ddr4.h M src/include/spd.h M src/mainboard/scaleway/tagada/ramstage.c M src/northbridge/intel/haswell/haswell_mrc/raminit.c M src/northbridge/intel/sandybridge/raminit_mrc.c M tests/lib/dimm_info_util-test.c 12 files changed, 106 insertions(+), 180 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/62181/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/62181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621 Gerrit-Change-Number: 62181 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Enable ASPM for SD
by Felix Held (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Nien, Martin Roth, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67304 ) Change subject: mb/google/skyrim: Enable ASPM for SD ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/skyrim/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/67304/comment/307f5e1a_188e552f PS1, Line 31: 2 i'd use ASPM_L1 from enum dxio_aspm_type instead. same for the other two descriptors, but that's probably something for another patch -- To view, visit https://review.coreboot.org/c/coreboot/+/67304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45a290c8ceddd39f65c6fe1390e3a753cad99899 Gerrit-Change-Number: 67304 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 13:00:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/zork: Enable AC wake
by Rob Barnes (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Nien, Diana Zigterman, Daisuke Nojiri, Martin Roth. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67262 ) Change subject: mb/google/zork: Enable AC wake ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Will this be a full wake or a dark resume? Was this also tested with the lid closed? i.e. Does the Ezkinil go back to sleep properly when inserting AC while the lid is closed? -- To view, visit https://review.coreboot.org/c/coreboot/+/67262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1af6ff9f18544ec6a86e34588fb4d9e8cd3bab2 Gerrit-Change-Number: 67262 Gerrit-PatchSet: 4 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Diana Zigterman <dzigterman(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Diana Zigterman <dzigterman(a)google.com> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 12:46:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022