Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67050 )
Change subject: soc/amd: Recalculate the field power in PSS table entry
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/cezanne/acpi.c:
https://review.coreboot.org/c/coreboot/+/67050/comment/9b6f574c_b4c27e80
PS2, Line 198: power_in_mw
> I'm fine with keeping the code to match AGESA. […]
How about we change AGESA?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib43103cc62c18debea3fd2c23d9c30fb0ecd781b
Gerrit-Change-Number: 67050
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com>
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67263 )
Change subject: Makefile.inc: Fix build hang if file-size is run on empty string
......................................................................
Makefile.inc: Fix build hang if file-size is run on empty string
Currently, if for some reason, the file-size command is called on an
empty string, the build will hang waiting for stdin input to cat.
Since wc accepts a file, this cat was unnecessary anyway. Put the file
name in quotes so an empty string will result in calling wc on an
actual null file instead of just leaving the filename blank. This
results in an error, and will probably halt the build.
BUG=214790407
TEST=Build default build.
Signed-off-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Change-Id: I3dacf1968ed897a8ebd00f95583c2f254a7fb55a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67263
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M Makefile.inc
1 file changed, 24 insertions(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc
index 0dd4864..0ed205f 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -153,7 +153,7 @@
int-eq=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) = $(call _toint,$(word 2,$1))))
int-align=$(shell A=$(call _toint,$1) B=$(call _toint,$2); expr $$A + \( \( $$B - \( $$A % $$B \) \) % $$B \) )
int-align-down=$(shell A=$(call _toint,$1) B=$(call _toint,$2); expr $$A - \( $$A % $$B \) )
-file-size=$(strip $(shell cat $1 | wc -c))
+file-size=$(strip $(shell wc -c "$1" | cut -f 1 -d ' '))
tolower=$(shell echo '$1' | tr '[:upper:]' '[:lower:]')
toupper=$(shell echo '$1' | tr '[:lower:]' '[:upper:]')
ws_to_under=$(shell echo '$1' | tr ' \t' '_')
--
To view, visit https://review.coreboot.org/c/coreboot/+/67263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dacf1968ed897a8ebd00f95583c2f254a7fb55a
Gerrit-Change-Number: 67263
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: merged
Attention is currently required from: Martin L Roth, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67263 )
Change subject: Makefile.inc: Fix build hang if file-size is run on empty string
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dacf1968ed897a8ebd00f95583c2f254a7fb55a
Gerrit-Change-Number: 67263
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:48:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Fred Reitberger, Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67050 )
Change subject: soc/amd: Recalculate the field power in PSS table entry
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/soc/amd/cezanne/acpi.c:
https://review.coreboot.org/c/coreboot/+/67050/comment/9c452843_d99138c3
PS2, Line 198: power_in_mw
> Please vote should we change code or keep it as it is in AGESA. […]
I'm fine with keeping the code to match AGESA. Raul?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib43103cc62c18debea3fd2c23d9c30fb0ecd781b
Gerrit-Change-Number: 67050
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:39:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com>
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth, Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67119 )
Change subject: /: Update and rewrite README.md
......................................................................
Patch Set 2: Code-Review+1
(5 comments)
File README.md:
https://review.coreboot.org/c/coreboot/+/67119/comment/f2dd755a_cd0cccc1
PS2, Line 4: replacing the proprietary
: BIOS (firmware)
how about: replacing the proprietary firmware (BIOS/UEFI) ...
https://review.coreboot.org/c/coreboot/+/67119/comment/c5c45ea7_817ea799
PS2, Line 7: a different executable, referred to in coreboot as the payload.
perhaps add something like: Most often, the primary function of the payload is to boot the operating system (OS)
https://review.coreboot.org/c/coreboot/+/67119/comment/13795e99_4170dd21
PS2, Line 10: can scale from
perhaps: can be scaled down to
https://review.coreboot.org/c/coreboot/+/67119/comment/c8cd4c8a_bac5f30e
PS2, Line 24: `git clone https://review.coreboot.org/coreboot.git`.
mention the github mirror as an alternative?
https://review.coreboot.org/c/coreboot/+/67119/comment/b074a68a_bfc22e32
PS2, Line 68: become unavailable in the future.
perhaps add a note that releases are simply snapshots / no guarantee of stability
--
To view, visit https://review.coreboot.org/c/coreboot/+/67119
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cd59d75da47b287029a9fc5eeddefaf99198965
Gerrit-Change-Number: 67119
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:32:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67259 )
Change subject: soc/amd/mendocino: Add svc_set_fw_hash_table
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67259
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I512d359967eae925098973e90250111d6f59dd39
Gerrit-Change-Number: 67259
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:27:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Ahamed Husni, Tim Wawrzynczak.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67340 )
Change subject: bd82x6x/early_pch: enable smbus in bootblock stage
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67340/comment/45488ea4_7f091500
PS2, Line 8:
Can you add the reason why.
File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/c/coreboot/+/67340/comment/2d48193b_c8c33cde
PS2, Line 316: ENV_RAMINIT
no need to use the pre-processor:
`if (ENV_RAMINIT || (CONFIG(CONSOLE_I2C_SMBUS) && (ENV_RAMINIT || ENV_INITIAL_STAGE))`
--
To view, visit https://review.coreboot.org/c/coreboot/+/67340
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97d0afb013ede428383acaa0aa97ab04fe80e2a4
Gerrit-Change-Number: 67340
Gerrit-PatchSet: 2
Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67339 )
Change subject: drivers/smbus: smbus console driver
......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67339/comment/db1a29cb_e5ed6494
PS1, Line 8:
Can you add a description explaining what you are adding and why.
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/67339/comment/6e5823de_dc6252b4
PS1, Line 314: 0x48
This is specific to the hardware you are using. Maybe add a comment in the `help` explaining why this default is used.
https://review.coreboot.org/c/coreboot/+/67339/comment/013e20e1_37dd10e5
PS1, Line 315: CONSOLE_I2C_SMBUS
No need for the depends if it's in the `if` block
File src/drivers/smbus/i2c_smbus_console.c:
https://review.coreboot.org/c/coreboot/+/67339/comment/67bcd384_e35807b9
PS1, Line 16: (ENV_BOOTBLOCK || ENV_ROMSTAGE || ENV_RAMSTAGE))
Don't we want console in all stages?
https://review.coreboot.org/c/coreboot/+/67339/comment/1f2933b8_30fe3c15
PS1, Line 17: do_smbus_write_byte(CONFIG_FIXED_SMBUS_IO_BASE, \
> Avoid unnecessary line continuations
Please fix.
File src/include/console/i2c_smbus.h:
https://review.coreboot.org/c/coreboot/+/67339/comment/a380a1bc_dd64fc7a
PS1, Line 15:
newline
--
To view, visit https://review.coreboot.org/c/coreboot/+/67339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife77fb2c3e1cc77678a4972701317d50624ceb95
Gerrit-Change-Number: 67339
Gerrit-PatchSet: 1
Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment