coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4675 discussions

[M] Change in coreboot[master]: mb/google/skyrim/var/winterhold: Add gpio override settings
by Raul Rangel (Code Review) 06 Sep '22

06 Sep '22

Raul Rangel has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67209 ) Change subject: mb/google/skyrim/var/winterhold: Add gpio override settings ...................................................................... mb/google/skyrim/var/winterhold: Add gpio override settings Follow FT6_SOC_GPIO_PM&Strap_20220815A.XLSX update Gpio setting BUG=b:240824497 BRANCH=None Signed-off-by: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Change-Id: I2086c326cbf46ba6378d18d37dcbbe9fafa6b2bc Reviewed-on: https://review.coreboot.org/c/coreboot/+/67209 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Reviewed-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> --- M src/mainboard/google/skyrim/variants/winterhold/Makefile.inc A src/mainboard/google/skyrim/variants/winterhold/gpio.c 2 files changed, 51 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Frank Wu: Looks good to me, approved Raul Rangel: Looks good to me, approved Dtrain Hsu: Looks good to me, approved diff --git a/src/mainboard/google/skyrim/variants/winterhold/Makefile.inc b/src/mainboard/google/skyrim/variants/winterhold/Makefile.inc index 88e75bd..db72b15 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/Makefile.inc +++ b/src/mainboard/google/skyrim/variants/winterhold/Makefile.inc @@ -1,3 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-or-later subdirs-y += ./memory + +ramstage-y += gpio.c diff --git a/src/mainboard/google/skyrim/variants/winterhold/gpio.c b/src/mainboard/google/skyrim/variants/winterhold/gpio.c new file mode 100644 index 0000000..bed7f4b --- /dev/null +++ b/src/mainboard/google/skyrim/variants/winterhold/gpio.c @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <commonlib/helpers.h> +#include <soc/gpio.h> + +/* GPIO configuration in ramstage */ +static const struct soc_amd_gpio override_gpio_table[] = { + + /* SOC_PEN_DETECT_ODL */ + PAD_NC(GPIO_3), + + /* EN_PWR_WWAN_X */ + PAD_NC(GPIO_8), + + /* SD_AUX_RST_SOC_L */ + PAD_NC(GPIO_27), + + /* WWAN_RST_L */ + PAD_NC(GPIO_42), + +}; + +void variant_override_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) +{ + *size = ARRAY_SIZE(override_gpio_table); + *gpio = override_gpio_table; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/67209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2086c326cbf46ba6378d18d37dcbbe9fafa6b2bc Gerrit-Change-Number: 67209 Gerrit-PatchSet: 7 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold: Add gpio override settings
by Raul Rangel (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Martin L Roth, Jason Nien, EricKY Cheng, Isaac Lee, Jon Murphy, Martin Roth, Eric Peers, Moises Garcia, Tim Van Patten, Karthikeyan Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67209 ) Change subject: mb/google/skyrim/var/winterhold: Add gpio override settings ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2086c326cbf46ba6378d18d37dcbbe9fafa6b2bc Gerrit-Change-Number: 67209 Gerrit-PatchSet: 6 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:52:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/block/apob: Add hashed APOB support
by Raul Rangel (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 ) Change subject: soc/amd/common/block/apob: Add hashed APOB support ...................................................................... Patch Set 4: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67301/comment/db1c388c_8993512a PS4, Line 15: chausie Can you try it on a guybrush device? File src/soc/amd/common/block/apob/apob_cache.c: https://review.coreboot.org/c/coreboot/+/67301/comment/e203a733_f248556b PS4, Line 57: apob_header_ptr->size + MRC_HASH_SIZE You could probably do this as a `_Static_assert` above https://review.coreboot.org/c/coreboot/+/67301/comment/dd58bcc8_c1dc8df4 PS4, Line 195: xxh64 I wonder if coreboot has an existing has function. I know vboot has sha2*, but now sure if that's easy to use. https://review.coreboot.org/c/coreboot/+/67301/comment/e9176f71_7ab090ed PS4, Line 214: !update_needed && You can probably skip this part since `apob_rom` will be `NULL` if `update_needed == true` -- To view, visit https://review.coreboot.org/c/coreboot/+/67301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I241968b115aaf41af63445410660bdd5199ceaba Gerrit-Change-Number: 67301 Gerrit-PatchSet: 4 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:48:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/smbus: SC16IS750 I2C to UART converter chip initialization
by Paul Menzel (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 ) Change subject: drivers/smbus: SC16IS750 I2C to UART converter chip initialization ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67342/comment/eb16c546_d9eca97d PS5, Line 7: drivers/smbus: SC16IS750 I2C to UART converter chip initialization Please make it a statement [1]. Maybe: > Support SC16IS750 I2C to UART converter chip [1]: https://cbea.ms/git-commit/ File src/drivers/smbus/sc16is750_init.c: https://review.coreboot.org/c/coreboot/+/67342/comment/b1fd6736_76aeb275 PS5, Line 4: Mention the datasheet name and revision somewhere? -- To view, visit https://review.coreboot.org/c/coreboot/+/67342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31188b8c0f9b0ce9454da984e630eca9101d145 Gerrit-Change-Number: 67342 Gerrit-PatchSet: 5 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:47:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/zork: Enable AC wake
by Daisuke Nojiri (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Nien, Diana Zigterman, Rob Barnes. Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67262 ) Change subject: mb/google/zork: Enable AC wake ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Will this be a full wake or a dark resume? […] This will be handled as a dark resume (followed by an immediate suspend) because AC plug/unplug are not categorized as input device events. Verified on DUT. -- To view, visit https://review.coreboot.org/c/coreboot/+/67262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1af6ff9f18544ec6a86e34588fb4d9e8cd3bab2 Gerrit-Change-Number: 67262 Gerrit-PatchSet: 4 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Diana Zigterman <dzigterman(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Diana Zigterman <dzigterman(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:46:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/console: attach smbus console driver
by Paul Menzel (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67341 ) Change subject: src/console: attach smbus console driver ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67341/comment/a3e066b9_7c2de993 PS3, Line 7: src/ Not needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/67341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a9bf64e59d529253bfdcdfa565bb2bb92975728 Gerrit-Change-Number: 67341 Gerrit-PatchSet: 3 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:44:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/smbus: smbus console driver
by Paul Menzel (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67339 ) Change subject: drivers/smbus: smbus console driver ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67339/comment/b92b33fb_6ff22c73 PS1, Line 7: drivers/smbus: smbus console driver Please make that a statement by adding a verb in imperative mood [1]. [1]: https://cbea.ms/git-commit/ Patchset: PS1: Nice work! File src/console/Kconfig: https://review.coreboot.org/c/coreboot/+/67339/comment/ec5d8b9e_51985c1f PS1, Line 305: Send coreboot debug output to the SMBus Please add a dot/period at the end. https://review.coreboot.org/c/coreboot/+/67339/comment/db283ade_77b7717e PS1, Line 307: The output can be read with an I2C slave device connected the SMBus. Please refer to some documentation, or elaborate. -- To view, visit https://review.coreboot.org/c/coreboot/+/67339 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife77fb2c3e1cc77678a4972701317d50624ceb95 Gerrit-Change-Number: 67339 Gerrit-PatchSet: 1 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:44:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/block/apob: Add hashed APOB support
by Fred Reitberger (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 ) Change subject: soc/amd/common/block/apob: Add hashed APOB support ...................................................................... Patch Set 4: (1 comment) File src/soc/amd/common/block/apob/apob_cache.c: https://review.coreboot.org/c/coreboot/+/67301/comment/2007723a_47dafe2f PS2, Line 22: RW_MRC_HASH > Done. […] Missed the last comment - if we want to store it in the GSC, that should be a new patch -- To view, visit https://review.coreboot.org/c/coreboot/+/67301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I241968b115aaf41af63445410660bdd5199ceaba Gerrit-Change-Number: 67301 Gerrit-PatchSet: 4 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:41:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/block/apob: Add hashed APOB support
by Fred Reitberger (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 ) Change subject: soc/amd/common/block/apob: Add hashed APOB support ...................................................................... Patch Set 4: (1 comment) File src/soc/amd/common/block/apob/apob_cache.c: https://review.coreboot.org/c/coreboot/+/67301/comment/080f0eab_85e4c676 PS2, Line 22: RW_MRC_HASH > Okay, I'll give that a test and see if I can simplify this even more. […] Done. Set the hash to the last 8 bytes of the MRC_CACHE and the ABL loaded the APOB_NV without error. -- To view, visit https://review.coreboot.org/c/coreboot/+/67301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I241968b115aaf41af63445410660bdd5199ceaba Gerrit-Change-Number: 67301 Gerrit-PatchSet: 4 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:39:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/intel/adlrvp: Make SOC_INTEL_CSE_LITE_SKU configurable
by Angel Pons (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Kapil Porwal, Nick Vaccaro, Maximilian Brune. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67078 ) Change subject: mb/intel/adlrvp: Make SOC_INTEL_CSE_LITE_SKU configurable ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4da7feab881ae43528c9d852cc842ac93fa9c6de Gerrit-Change-Number: 67078 Gerrit-PatchSet: 13 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 16:35:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022