coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[M] Change in coreboot[master]: [WIP] tests: Add support for tests build failures detection
by Jakub Czapiga (Code Review) 06 Sep '22

06 Sep '22

Jakub Czapiga has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67372 ) Change subject: [WIP] tests: Add support for tests build failures detection ...................................................................... [WIP] tests: Add support for tests build failures detection This patch introduces new target: junit.xml-unit-tests, which creates report containing tests biuld logs and allows Jenkins to show, which test failed to build. Failing tests should no longer require digging in the raw console output in order to find, why they failed. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I94184379dcc2ac10f1a47f4a9d205cacbeb640fe --- M tests/Makefile.inc M tests/lib/uuid-test.c M util/testing/Makefile.inc 3 files changed, 62 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/67372/1 diff --git a/tests/Makefile.inc b/tests/Makefile.inc index 10caf0a..2b7e3f9 100644 --- a/tests/Makefile.inc +++ b/tests/Makefile.inc @@ -60,22 +60,63 @@ DEPENDENCIES += $(addsuffix .d,$(basename $(all-test-objs))) -include $(DEPENDENCIES) -.PHONY: $(alltests) $(addprefix clean-,$(alltests)) +.PHONY: $(alltests) $(addprefix build-,$(alltests)) +.PHONY: $(addprefix run-,$(alltests)) $(addprefix clean-,$(alltests)) .PHONY: unit-tests build-unit-tests run-unit-tests clean-unit-tests # %g in CMOCKA_XML_FILE will be replaced with "__TEST_NAME__(<test-group-name>)" # by macro cb_run_group_tests(), which should be used for running tests. # __TEST_NAME__ contains test name including path e.g. tests_lib_rtc-test ifeq ($(JUNIT_OUTPUT),y) -$(alltests): export CMOCKA_MESSAGE_OUTPUT=xml -$(alltests): export CMOCKA_XML_FILE=$(testobj)/junit-%g.xml +$(addprefix run-,$(alltests)): export CMOCKA_MESSAGE_OUTPUT=xml +$(addprefix run-,$(alltests)): export CMOCKA_XML_FILE=$(testobj)/junit-%g.xml endif -$(alltests): $$($$(@)-bin) +$(addprefix run-,$(alltests)): run-%: $$(%-bin) rm -f $(testobj)/junit-$(subst /,_,$(patsubst $(testobj)/%/,%,$(dir $^)))$*$.xml rm -f $(testobj)/$(subst /,_,$^).failed -$^ || echo failed > $(testobj)/$(subst /,_,$^).failed +$(addprefix build-,$(alltests)): build-%: $$(%-bin) + echo "Building $<" + +$(alltests): run-$$(@) + +TESTS_BUILD_XML_FILE := $(testobj)/junit-tests-build.xml + +$(TESTS_BUILD_XML_FILE): + mkdir -p $(dir $@) + echo '<?xml version="1.0" encoding="utf-8"?><testsuite>' > $@.tmp + for tst in $(alltests); do \ + $(MAKE) V=$(V) Q=$(Q) COV=$(COV) "clean-$$tst"; \ + echo "<testcase classname='coreboot_build_unit_test' name='$$tst'>" >> $@.tmp; \ + $(MAKE) V=$(V) Q=$(Q) COV=$(COV) JUNIT_OUTPUT=y "build-$$tst" >> $@.tmp.2 2>&1 \ + && type="system-out" || type="failure"; \ + if [ $$type = "failure" ]; then \ + echo "<failure type='buildFailed'>" >> $@.tmp; \ + else \ + echo "<$$type>" >> $@.tmp; \ + fi; \ + echo '<![CDATA[' >> $@.tmp; \ + cat $@.tmp.2 >> $@.tmp; \ + echo "]]></$$type>" >>$@.tmp; \ + rm -f $@.tmp.2; \ + echo "</testcase>" >> $@.tmp; \ + if [ $$type != 'failure' ]; then \ + $(MAKE) V=$(V) Q=$(Q) COV=$(COV) JUNIT_OUTPUT=y "run-$$tst"; \ + fi; \ + done + echo "</testsuite>" >> $@.tmp + mv $@.tmp $@ + +.PHONY: junit.xml-unit-tests clean-junit.xml-unit-tests + +junit.xml-unit-tests: clean-junit.xml-unit-tests $(TESTS_BUILD_XML_FILE) + +clean-junit.xml-unit-tests: + rm -f $(TESTS_BUILD_XML_FILE) + + # Build a code coverage report by collecting all the gcov files into a single # report. If COV is not set, this might be a user error, and they're trying # to generate a coverage report without first having built and run the code diff --git a/tests/lib/uuid-test.c b/tests/lib/uuid-test.c index 6b56842..12f5719 100644 --- a/tests/lib/uuid-test.c +++ b/tests/lib/uuid-test.c @@ -63,7 +63,7 @@ const guid_t guid_bin = { { 0xBB, 0x66, 0x4D, 0x1F, 0xAD, 0xDE, - 0xEF, 0xBE, + 0xEF, 0xBE 0x08, 0xAB, 0x21, 0x37, 0xBB, 0x07, 0xDD, 0x4C } }; diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index df6a25e..afe4d11 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -104,7 +104,7 @@ $(MAKE) xcompile=$(COREBOOT_BUILD_DIR)/xcompile $(COREBOOT_BUILD_DIR)/xcompile $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=src/soc/nvidia/tegra124/lp0 BLD=tegra124_lp0 MFLAGS= MAKEFLAGS=xcompile=$(COREBOOT_BUILD_DIR)/xcompile MAKETARGET=all junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=src/soc/nvidia/tegra210/lp0 BLD=tegra120_lp0 MFLAGS= MAKEFLAGS=xcompile=$(COREBOOT_BUILD_DIR)/xcompile MAKETARGET=all junit.xml - $(MAKE) unit-tests JUNIT_OUTPUT=y COV=1 + $(MAKE) junit.xml-unit-tests COV=1 (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) unit-tests coverage-report JUNIT_OUTPUT=y COV=1) $(MAKE) coverage-report JUNIT_OUTPUT=y COV=1 find . -name 'tests.info' -exec cat {} + >$(COREBOOT_BUILD_DIR)/coverage.info -- To view, visit https://review.coreboot.org/c/coreboot/+/67372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94184379dcc2ac10f1a47f4a9d205cacbeb640fe Gerrit-Change-Number: 67372 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: tests/commonlib/rational-test: Use test group runner wrapper
by Jakub Czapiga (Code Review) 06 Sep '22

06 Sep '22

Jakub Czapiga has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67371 ) Change subject: tests/commonlib/rational-test: Use test group runner wrapper ...................................................................... tests/commonlib/rational-test: Use test group runner wrapper coreboot unit-tests framework requires tests to use cb_run_group_tests() instead of cmocka_run_group_tests() for Jenkins to work correctly. Wrapper ensures that each test has its own report file and does not overwrite results of other tests. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: Iead63cab0465f37b2da0c7b3ef256057e3a191a2 --- M tests/commonlib/rational-test.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/67371/1 diff --git a/tests/commonlib/rational-test.c b/tests/commonlib/rational-test.c index 4d6c215..a64997e 100644 --- a/tests/commonlib/rational-test.c +++ b/tests/commonlib/rational-test.c @@ -52,6 +52,6 @@ cmocka_unit_test(test_rational), }; - return cmocka_run_group_tests(tests, NULL, NULL); + return cb_run_group_tests(tests, NULL, NULL); } -- To view, visit https://review.coreboot.org/c/coreboot/+/67371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iead63cab0465f37b2da0c7b3ef256057e3a191a2 Gerrit-Change-Number: 67371 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Xi Chen. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... Patch Set 7: (1 comment) File src/soc/mediatek/common/include/soc/bl31.h: https://review.coreboot.org/c/coreboot/+/67359/comment/25e48f26_040ac422 PS6, Line 6: bool > to use bool you need #include <stdbool. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 7 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 08:39:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Xi Chen, Rex-BC Chen. Rex-BC Chen has uploaded a new patch set (#7) to the change originally created by Hung-Te Lin. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... soc/mediatek: a common implementation to register BL31 reset The implementations of register_reset_to_bl31() are the same for MedaiTek platforms, so we extract them to soc/common/bl31.c. BUG=None TEST=build pass Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Signed-off-by: Hung-Te Lin <hungte(a)chromium.org> Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> --- M src/mainboard/google/asurada/mainboard.c M src/mainboard/google/cherry/mainboard.c M src/mainboard/google/corsola/mainboard.c M src/mainboard/google/kukui/mainboard.c A src/soc/mediatek/common/bl31.c A src/soc/mediatek/common/include/soc/bl31.h M src/soc/mediatek/mt8183/Makefile.inc M src/soc/mediatek/mt8186/Makefile.inc M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8195/Makefile.inc 10 files changed, 66 insertions(+), 60 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/67359/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 7 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Hung-Te Lin (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Xi Chen, Rex-BC Chen. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... Patch Set 6: (1 comment) File src/soc/mediatek/common/include/soc/bl31.h: https://review.coreboot.org/c/coreboot/+/67359/comment/0fbead2b_035a4bae PS6, Line 6: bool to use bool you need #include <stdbool.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 6 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 08:31:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold: Add gpio override settings
by Dtrain Hsu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Martin L Roth, Jason Nien, EricKY Cheng, Isaac Lee, Jon Murphy, Martin Roth, Eric Peers, Moises Garcia, Tim Van Patten, Karthikeyan Ramasubramanian. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67209 ) Change subject: mb/google/skyrim/var/winterhold: Add gpio override settings ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2086c326cbf46ba6378d18d37dcbbe9fafa6b2bc Gerrit-Change-Number: 67209 Gerrit-PatchSet: 6 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Comment-Date: Tue, 06 Sep 2022 08:29:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add audio parts ALC5682I-VD and MAX9835
by Subrata Banik (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Kapil Porwal. Subrata Banik has uploaded a new patch set (#20) to the change originally created by Eran Mitrani. ( https://review.coreboot.org/c/coreboot/+/66919 ) Change subject: mb/google/rex: Add audio parts ALC5682I-VD and MAX9835 ...................................................................... mb/google/rex: Add audio parts ALC5682I-VD and MAX9835 adding ALC5682I-VD and MAX98357 for rex TEST=None yet. Awaiting Hardware Change-Id: Ia8dfc79e7e4d27828726145156c870733d716899 Signed-off-by: Eran Mitrani <mitrani(a)google.com> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/rex0/overridetree.cb 2 files changed, 39 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/66919/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/66919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8dfc79e7e4d27828726145156c870733d716899 Gerrit-Change-Number: 66919 Gerrit-PatchSet: 20 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/brya/var/kinox: Update the DPTF parameters and fan table
by Frank Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Dtrain Hsu, Tim Wawrzynczak, Ricky Chang. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67314 ) Change subject: mb/google/brya/var/kinox: Update the DPTF parameters and fan table ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I751bc5442f64428c383034755cd5d74fbd0ea91e Gerrit-Change-Number: 67314 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 08:16:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kinox: Modify fan speed/duty table
by Frank Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Dtrain Hsu, Tim Wawrzynczak, Ricky Chang. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67307 ) Change subject: mb/google/brya/var/kinox: Modify fan speed/duty table ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458 Gerrit-Change-Number: 67307 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 08:16:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Enable ARM Trusted Firmware integration
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67356 ) Change subject: soc/mediatek/mt8188: Enable ARM Trusted Firmware integration ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: need to wait for this patch https://review.coreboot.org/c/coreboot/+/67358 -- To view, visit https://review.coreboot.org/c/coreboot/+/67356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id16405c84f6e0a2e21f95cc45babf85bd980b43e Gerrit-Change-Number: 67356 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Tue, 06 Sep 2022 08:15:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022