coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu, Yidi Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67359/comment/50ba4437_38613c86 PS4, Line 10: abstract > extract Done https://review.coreboot.org/c/coreboot/+/67359/comment/6b03d4ae_530bd971 PS4, Line 10: platform > platforms Done File src/soc/mediatek/common/bl31.c: https://review.coreboot.org/c/coreboot/+/67359/comment/8db3bd42_9e8e9c71 PS4, Line 10: int gpio_polarity > How about `bool active_high`? The `ACTIVE_LOW` and `ACTIVE_HIGH` constants are defined for coreboot […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 6 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 07:52:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Pass reset gpio parameter to BL31
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67357 to look at the new patch set (#6). Change subject: mb/google/geralt: Pass reset gpio parameter to BL31 ...................................................................... mb/google/geralt: Pass reset gpio parameter to BL31 Pass the reset gpio parameter to BL31 to support SoC reset. TEST=build pass. BUG=b:233720142 Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> Change-Id: Ifdfbd6bd82f64b084f6349cb617443053c89a3f1 --- M src/mainboard/google/geralt/mainboard.c M src/soc/mediatek/mt8188/Makefile.inc 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/67357/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/67357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfbd6bd82f64b084f6349cb617443053c89a3f1 Gerrit-Change-Number: 67357 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen, Yidi Lin. Rex-BC Chen has uploaded a new patch set (#6) to the change originally created by Hung-Te Lin. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... soc/mediatek: a common implementation to register BL31 reset The implementations of register_reset_to_bl31() are the same for MedaiTek platforms, so we extract them to soc/common/bl31.c. BUG=None TEST=build pass Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Signed-off-by: Hung-Te Lin <hungte(a)chromium.org> Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> --- M src/mainboard/google/asurada/mainboard.c M src/mainboard/google/cherry/mainboard.c M src/mainboard/google/corsola/mainboard.c M src/mainboard/google/kukui/mainboard.c A src/soc/mediatek/common/bl31.c A src/soc/mediatek/common/include/soc/bl31.h M src/soc/mediatek/mt8183/Makefile.inc M src/soc/mediatek/mt8186/Makefile.inc M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8195/Makefile.inc 10 files changed, 64 insertions(+), 60 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/67359/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 6 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Enable mfgpll properly and fix SPMI muxes
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67355 ) Change subject: soc/mediatek/mt8188: Enable mfgpll properly and fix SPMI muxes ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67355 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I971109a5f72e3307899daaf5a5f26022124b559b Gerrit-Change-Number: 67355 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 07:39:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Pass reset gpio parameter to BL31
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67357 ) Change subject: mb/google/geralt: Pass reset gpio parameter to BL31 ...................................................................... Patch Set 5: -Code-Review (1 comment) File src/mainboard/google/geralt/mainboard.c: https://review.coreboot.org/c/coreboot/+/67357/comment/635d2f93_9c91a438 PS4, Line 3: #include <boot/coreboot_tables.h> > yes, it's for ACTIVE_HIGH. Since this is unrelated to coreboot tables, we should avoid using ACTIVE_HIGH. See the other comment of mine. -- To view, visit https://review.coreboot.org/c/coreboot/+/67357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfbd6bd82f64b084f6349cb617443053c89a3f1 Gerrit-Change-Number: 67357 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 07:39:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Pass reset gpio parameter to BL31
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67357 ) Change subject: mb/google/geralt: Pass reset gpio parameter to BL31 ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfbd6bd82f64b084f6349cb617443053c89a3f1 Gerrit-Change-Number: 67357 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 07:38:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Pass reset gpio parameter to BL31
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67357 ) Change subject: mb/google/geralt: Pass reset gpio parameter to BL31 ...................................................................... Patch Set 5: (1 comment) Patchset: PS1: > if most MTK google boards will all do this, I wonder if we can move this to common (leave the GPIO d […] https://review.coreboot.org/c/coreboot/+/67359/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/67357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfbd6bd82f64b084f6349cb617443053c89a3f1 Gerrit-Change-Number: 67357 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 07:38:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67359/comment/14d00228_2552b6ee PS4, Line 10: abstract extract https://review.coreboot.org/c/coreboot/+/67359/comment/2f71a994_9859a84f PS4, Line 10: platform platforms File src/soc/mediatek/common/bl31.c: https://review.coreboot.org/c/coreboot/+/67359/comment/8ce9b2c0_05d0db95 PS4, Line 10: int gpio_polarity How about `bool active_high`? The `ACTIVE_LOW` and `ACTIVE_HIGH` constants are defined for coreboot tables. -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 5 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 07:38:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Xi Chen, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... Patch Set 5: (1 comment) File src/soc/mediatek/mt8183/Makefile.inc: https://review.coreboot.org/c/coreboot/+/67359/comment/8aa7f27f_3ccec59b PS4, Line 28: ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c > move to ramstage section in the below Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 5 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 07:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Xi Chen, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... Patch Set 5: (1 comment) File src/soc/mediatek/common/bl31.c: https://review.coreboot.org/c/coreboot/+/67359/comment/b8f54664_b7492fed PS4, Line 3: #include <bl31.h> : #include <console/console.h> : #include <soc/bl31.h> : #include <boot/coreboot_tables.h> : #include <gpio.h> > in alphabet order Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 5 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 07:37:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022