coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: soc/amd: Do SMM relocation via MSR
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64872 ) Change subject: soc/amd: Do SMM relocation via MSR ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9729fb94ed5c18cfd57b8098c838c08a04490e4b Gerrit-Change-Number: 64872 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd: Move locking SMM as part of SMM init
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64871 ) Change subject: cpu/amd: Move locking SMM as part of SMM init ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcdfc0f9ae211644cf0911790b0b0c5d1b0b7dc9 Gerrit-Change-Number: 64871 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/smm: Move MP & SMM init in a common place
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64870 ) Change subject: cpu/amd/smm: Move MP & SMM init in a common place ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c457ab69581f8c29f2d79c054ca3bc7e58a896e Gerrit-Change-Number: 64870 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Align get_cpu_count to other targets
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Marshall Dawson, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64869 ) Change subject: soc/amd/stoneyridge: Align get_cpu_count to other targets ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28bff875ea2df7837e4495787cf8a4c2d522d43d Gerrit-Change-Number: 64869 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/*: Make mtrr decision based on syscfg
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64868 ) Change subject: soc/amd/*: Make mtrr decision based on syscfg ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbacae28e272ab2f39f268ad034354a9c590d035 Gerrit-Change-Number: 64868 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/*: Move apm call out of MP init code
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64867 ) Change subject: soc/amd/*: Move apm call out of MP init code ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb6808edf96a17ec0b3073ba2486b3345a4a66ea Gerrit-Change-Number: 64867 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd: Add common helpers for TSEG and SMM
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64866 ) Change subject: cpu/amd: Add common helpers for TSEG and SMM ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73174766980e0405e7b8efd4f059bb400c0c0a25 Gerrit-Change-Number: 64866 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/smm_relocate.c: Improve TSEG programming
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64865 ) Change subject: soc/amd/smm_relocate.c: Improve TSEG programming ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30854111bb47f0cb14b07f71cedacd629432e0f4 Gerrit-Change-Number: 64865 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/mtl: Add GPIOs for Meteo Lake SOC
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Noga Smith, Tarun Tuli, Jamie Ryu, Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Kapil Porwal, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64169 ) Change subject: soc/intel/mtl: Add GPIOs for Meteo Lake SOC ...................................................................... Patch Set 15: Verified+1 (4 comments) File src/soc/intel/meteorlake/gpio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496): https://review.coreboot.org/c/coreboot/+/64169/comment/05930523_f21b7c0c PS15, Line 79: INTEL_GPP_BASE(GPP_B0, GPP_D0, GPP_BOOTHALT_B, 256, "D"), /* GPP_D */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496): https://review.coreboot.org/c/coreboot/+/64169/comment/96d896d0_63fc853b PS15, Line 79: INTEL_GPP_BASE(GPP_B0, GPP_D0, GPP_BOOTHALT_B, 256, "D"), /* GPP_D */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496): https://review.coreboot.org/c/coreboot/+/64169/comment/be33874c_01bf6495 PS15, Line 80: INTEL_GPP(GPP_B0, GPP_VGPIO0, GPP_VGPIO47, "VGPIO0"), /* GPP_VGPIO0 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496): https://review.coreboot.org/c/coreboot/+/64169/comment/eef88483_10bbd34a PS15, Line 80: INTEL_GPP(GPP_B0, GPP_VGPIO0, GPP_VGPIO47, "VGPIO0"), /* GPP_VGPIO0 */ please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/64169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7fe9654f22b074a9af18eb7bcdc21812dee77035 Gerrit-Change-Number: 64169 Gerrit-PatchSet: 15 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Noga Smith <nogasmith(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Noga Smith <nogasmith(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:16:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/mtl: Do initial Meteor Lake SoC commit till ramstage
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Noga Smith, Tarun Tuli, Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Kapil Porwal, Angel Pons, Nick Vaccaro, Raj Astekar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63364 ) Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till ramstage ...................................................................... Patch Set 22: Verified+1 (24 comments) File src/soc/intel/meteorlake/acpi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/1eb2f4a2_2d8258e6 PS22, Line 180: printk(BIOS_DEBUG, "%s - gfxvtbar:0x%llx 0x%x \n", __func__, gfxvtbar, MCHBAR32(GFXVTBAR)); line length of 100 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/e3bf042e_596b6f89 PS22, Line 180: printk(BIOS_DEBUG, "%s - gfxvtbar:0x%llx 0x%x \n", __func__, gfxvtbar, MCHBAR32(GFXVTBAR)); unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/f61201ee_3bc38366 PS22, Line 201: if (is_dev_enabled(igfx_dev) && gfxvtbar && gfxvten ) { space prohibited before that close parenthesis ')' File src/soc/intel/meteorlake/cpu.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/75ffbfc7_82b3f434 PS22, Line 36: case MTLM: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment File src/soc/intel/meteorlake/fsp_params.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/a077d52f_19fb2e0e PS22, Line 336: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite() code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/b77ebdb9_3a9ce7b1 PS22, Line 336: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite() please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/734d78fc_0cae1664 PS22, Line 337: && vboot_recovery_mode_enabled() && !cse_is_hfs1_com_normal()) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/2c69dcda_79b9c3c8 PS22, Line 337: && vboot_recovery_mode_enabled() && !cse_is_hfs1_com_normal()) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/df32d5b2_c4b6523f PS22, Line 338: /* code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/d1cc65d4_08fda194 PS22, Line 339: * CSE Lite SKU does not support hybrid storage dynamic configuration code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/7716b391_06a5f840 PS22, Line 340: * in CSE RO boot, and FSP does not allow to send the strap override code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/6b160d65_69176d10 PS22, Line 341: * HECI commands if CSE is not in normal mode; hence, hybrid storage code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/ddd478f4_48ef0475 PS22, Line 342: * mode is disabled on CSE RO boot in recovery boot mode. code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/b7a8d398_cec1656b PS22, Line 343: */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/9a230297_977e292e PS22, Line 344: printk(BIOS_INFO, "cse_lite: CSE RO boot. HybridStorageMode disabled\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/03393bc2_5a417c82 PS22, Line 344: printk(BIOS_INFO, "cse_lite: CSE RO boot. HybridStorageMode disabled\n"); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/2ae9582c_33ab4e9a PS22, Line 345: s_cfg->HybridStorageMode = 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/6f3d878d_c1b3d7b6 PS22, Line 345: s_cfg->HybridStorageMode = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/9b8c7933_d0582ff2 PS22, Line 346: } else { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/6b1a00cc_82a9be82 PS22, Line 346: } else { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/a7373d0f_ec2e32e1 PS22, Line 347: s_cfg->HybridStorageMode = config->HybridStorageMode; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/2e1ad5d7_3906f7a0 PS22, Line 347: s_cfg->HybridStorageMode = config->HybridStorageMode; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/83082ec9_25a82d61 PS22, Line 348: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/43724cf8_1dbb8cc6 PS22, Line 348: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/63364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie746c0bfcf1f315a4ab6f540cc7c4933157551d7 Gerrit-Change-Number: 63364 Gerrit-PatchSet: 22 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Noga Smith <nogasmith(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Ethan Tsao <ethan.tsao(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Noga Smith <nogasmith(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:15:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022