Attention is currently required from: Ravi Kumar Bokka, Paul Menzel, Julius Werner, Sudheer Amrabadi.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61342 )
Change subject: qualcomm/sc7280: Add support for edp and mdp driver
......................................................................
Patch Set 33:
(2 comments)
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150529):
https://review.coreboot.org/c/coreboot/+/61342/comment/3d650527_7640949a
PS33, Line 187: #define DP_CHANNEL_EQ_BITS (DP_LANE_CR_DONE | \
please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/display/mdssreg.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150529):
https://review.coreboot.org/c/coreboot/+/61342/comment/fd9ca624_c44f97c2
PS33, Line 469: SW_PIX_EXT_OVERRIDE = BIT(31),
please, no space before tabs
--
To view, visit https://review.coreboot.org/c/coreboot/+/61342
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If89abb76028766b19450e756889a5d7776106f95
Gerrit-Change-Number: 61342
Gerrit-PatchSet: 33
Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Comment-Date: Thu, 02 Jun 2022 11:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi Kumar Bokka, Nico Huber, Furquan Shaikh, Paul Menzel, Sudheer Amrabadi, Julius Werner, Prasad Malisetty, mturney mturney.
Sudheer Amrabadi has uploaded a new patch set (#100) to the change originally created by Ravi Kumar Bokka. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe host controller driver
......................................................................
sc7280: Add PCIe host controller driver
Add support for PCIe host driver to configure
in RC (root complex) mode. Host driver will power on
the PHY, enable the PCIe link and start the bus enumeration.
BUG=b:182963902,b:216686574,b:181098581
TEST=Validated on qualcomm sc7280 development board
Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631
Signed-off-by: Prasad Malisetty <quic_pmaliset(a)quicinc.com>
---
M src/mainboard/google/herobrine/mainboard.c
M src/soc/qualcomm/sc7280/Makefile.inc
M src/soc/qualcomm/sc7280/include/soc/addressmap.h
A src/soc/qualcomm/sc7280/include/soc/pcie.h
A src/soc/qualcomm/sc7280/include/soc/qcom_qmp_phy.h
A src/soc/qualcomm/sc7280/pcie_host.c
6 files changed, 1,591 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/53902/100
--
To view, visit https://review.coreboot.org/c/coreboot/+/53902
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631
Gerrit-Change-Number: 53902
Gerrit-PatchSet: 100
Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi Kumar Bokka, Paul Menzel, Julius Werner, Sudheer Amrabadi.
Sudheer Amrabadi has uploaded a new patch set (#33) to the change originally created by Ravi Kumar Bokka. ( https://review.coreboot.org/c/coreboot/+/61342 )
Change subject: qualcomm/sc7280: Add support for edp and mdp driver
......................................................................
qualcomm/sc7280: Add support for edp and mdp driver
- Add support for edp aux read and write.
- Update edp panel properties based on edid read.
- Configure edp controller and edp phy.
BUG=b:182963902,b:216687885
TEST=Validated on qualcomm sc7280 development board.
Signed-off-by: Vinod Polimera <quic_vpolimer(a)quicinc.com>
Change-Id: If89abb76028766b19450e756889a5d7776106f95
---
M src/soc/qualcomm/sc7280/Kconfig
M src/soc/qualcomm/sc7280/Makefile.inc
A src/soc/qualcomm/sc7280/display/disp.c
A src/soc/qualcomm/sc7280/display/edp_aux.c
A src/soc/qualcomm/sc7280/display/edp_ctrl.c
A src/soc/qualcomm/sc7280/display/edp_phy_7nm.c
A src/soc/qualcomm/sc7280/include/soc/display/edp_aux.h
A src/soc/qualcomm/sc7280/include/soc/display/edp_ctrl.h
A src/soc/qualcomm/sc7280/include/soc/display/edp_phy.h
A src/soc/qualcomm/sc7280/include/soc/display/edp_reg.h
A src/soc/qualcomm/sc7280/include/soc/display/mdssreg.h
11 files changed, 2,964 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/61342/33
--
To view, visit https://review.coreboot.org/c/coreboot/+/61342
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If89abb76028766b19450e756889a5d7776106f95
Gerrit-Change-Number: 61342
Gerrit-PatchSet: 33
Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Knox Chiou, Yidi Lin, Yu-Ping Wu.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64790 )
Change subject: mb/google/corsola: Enable ps8640 for steelix
......................................................................
Patch Set 5:
(4 comments)
Patchset:
PS5:
Thanks Yu-Ping, so much.
Have verified in steelix board in proto phase.
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/64790/comment/5c02eb5a_7e38d6e4
PS3, Line 125: CONFIG(BOARD_GOOGLE_KINGLER_COMMON) + CONFIG(BOARD_GOOGLE_KRABBY_COMMON) == 1
> You'll also need to change this to […]
Done
https://review.coreboot.org/c/coreboot/+/64790/comment/91f6be06_522b4c51
PS3, Line 136: else if (CONFIG(BOARD_GOOGLE_KRABBY) || CONFIG(BOARD_GOOGLE_STEELIX))
> If this starts getting complicated, we should make it a Kconfig option. […]
Done
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/64790/comment/a6e42b15_ce150232
PS4, Line 126: "Exactly one of KINGLER and KRABBY must be set");
> The string also needs to be updated.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/64790
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c6310794c89fc8aa0e69e114c1f7ebd5479c549
Gerrit-Change-Number: 64790
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Yidi Lin <airken(a)gmail.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com>
Gerrit-CC: Yuqing Huang <huangyuqing(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Yidi Lin <airken(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 11:39:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Arthur Heymans, Fred Reitberger, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64864 )
Change subject: amdblocks/smm.h: Add header guards
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64864
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d01c36fa4695ee42d18701a90d1b96bceb5045f
Gerrit-Change-Number: 64864
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 02 Jun 2022 11:24:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Sean Rhodes, Arthur Heymans, Andrey Petrov.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64889 )
Change subject: soc/intel/apollolake: Allow configuring the LPC IO registers
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64889/comment/74f81071_35495403
PS1, Line 9: devices tree
devicetree
--
To view, visit https://review.coreboot.org/c/coreboot/+/64889
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a7ab3faf927cda76640227feff4e19017442897
Gerrit-Change-Number: 64889
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 11:21:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment