coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: tree-wide: Translate KiB variants of memory allocators
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Arthur Heymans, Hung-Te Lin, Jeff Daly, Raul Rangel, Philipp Hug, Mariusz Szafrański, Julius Werner, Angel Pons, Andrey Petrov, Patrick Rudolph, Xi Chen, Jason Glenesk, Damien Zammit, Marshall Dawson, Christian Walter, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Fred Reitberger, ron minnich, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55937 ) Change subject: tree-wide: Translate KiB variants of memory allocators ...................................................................... Patch Set 4: (8 comments) File src/soc/intel/common/block/systemagent/systemagent.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544): https://review.coreboot.org/c/coreboot/+/55937/comment/f80aa8fa_0bdd492e PS4, Line 272: CONFIG_EXT_BIOS_WIN_SIZE); code indent should use tabs where possible File src/soc/qualcomm/sc7180/soc.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544): https://review.coreboot.org/c/coreboot/+/55937/comment/ef73c37e_a9833652 PS4, Line 17: REGION_SIZE(dram_aop)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544): https://review.coreboot.org/c/coreboot/+/55937/comment/e6687514_b2959f67 PS4, Line 19: REGION_SIZE(dram_soc)); code indent should use tabs where possible File src/soc/qualcomm/sc7280/soc.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544): https://review.coreboot.org/c/coreboot/+/55937/comment/c476e20c_ddc48429 PS4, Line 17: REGION_SIZE(dram_soc)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544): https://review.coreboot.org/c/coreboot/+/55937/comment/5b126aa3_8128ba6b PS4, Line 19: REGION_SIZE(dram_wlan)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544): https://review.coreboot.org/c/coreboot/+/55937/comment/cdf124fe_1c7d98d3 PS4, Line 21: REGION_SIZE(dram_wpss)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544): https://review.coreboot.org/c/coreboot/+/55937/comment/610a4146_c50c7710 PS4, Line 23: REGION_SIZE(dram_aop)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544): https://review.coreboot.org/c/coreboot/+/55937/comment/6636229c_9475c46c PS4, Line 25: REGION_SIZE(dram_cpucp)); code indent should use tabs where possible -- To view, visit https://review.coreboot.org/c/coreboot/+/55937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I903c0183e7fc6b14aeb00325cd10cd48682c2e85 Gerrit-Change-Number: 55937 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 12:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/resource: Drop KiB variants of allocators
by Kyösti Mälkki (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jeff Daly, Damien Zammit, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons. Hello build bot (Jenkins), Jeff Daly, Damien Zammit, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64754 to look at the new patch set (#8). Change subject: device/resource: Drop KiB variants of allocators ...................................................................... device/resource: Drop KiB variants of allocators Change-Id: Idcaf9ee26a6324c825b8493f31166658fae95ad4 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/include/device/device.h 1 file changed, 0 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/64754/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/64754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcaf9ee26a6324c825b8493f31166658fae95ad4 Gerrit-Change-Number: 64754 Gerrit-PatchSet: 8 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tree-wide: Translate KiB variants of memory allocators
by Kyösti Mälkki (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Arthur Heymans, Hung-Te Lin, Jeff Daly, Raul Rangel, Philipp Hug, Mariusz Szafrański, Julius Werner, Angel Pons, Andrey Petrov, Patrick Rudolph, Xi Chen, Jason Glenesk, Damien Zammit, Marshall Dawson, Christian Walter, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Fred Reitberger, ron minnich, Felix Held. Hello Hung-Te Lin, build bot (Jenkins), Jeff Daly, Raul Rangel, Philipp Hug, Mariusz Szafrański, Julius Werner, Angel Pons, Andrey Petrov, Patrick Rudolph, Xi Chen, Jason Glenesk, Damien Zammit, Marshall Dawson, Suresh Bellampalli, Tim Wawrzynczak, Christian Walter, Vanessa Eusebio, Michal Motyl, Fred Reitberger, ron minnich, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55937 to look at the new patch set (#4). Change subject: tree-wide: Translate KiB variants of memory allocators ...................................................................... tree-wide: Translate KiB variants of memory allocators TBD: Check base & (size - 1) == 0 Change-Id: I903c0183e7fc6b14aeb00325cd10cd48682c2e85 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/cpu/amd/mtrr/amd_mtrr.c M src/drivers/aspeed/ast2050/ast2050.c M src/drivers/pc80/tpm/tis.c M src/mainboard/emulation/qemu-aarch64/mainboard.c M src/mainboard/emulation/qemu-i440fx/mainboard.c M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/emulation/qemu-power9/mainboard.c M src/mainboard/emulation/qemu-q35/mainboard.c M src/mainboard/emulation/qemu-riscv/mainboard.c M src/mainboard/emulation/spike-riscv/mainboard.c M src/mainboard/sifive/hifive-unleashed/mainboard.c M src/northbridge/amd/agesa/family14/northbridge.c M src/northbridge/amd/agesa/family15tn/northbridge.c M src/northbridge/amd/agesa/family16kb/northbridge.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/northbridge/intel/e7505/northbridge.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/i440bx/northbridge.c M src/northbridge/intel/i945/northbridge.c M src/northbridge/intel/ironlake/northbridge.c M src/northbridge/intel/pineview/northbridge.c M src/northbridge/intel/sandybridge/northbridge.c M src/northbridge/intel/x4x/northbridge.c M src/soc/amd/cezanne/root_complex.c M src/soc/amd/cezanne/uart.c M src/soc/amd/common/block/i2c/i2c.c M src/soc/amd/picasso/root_complex.c M src/soc/amd/picasso/uart.c M src/soc/amd/sabrina/root_complex.c M src/soc/amd/sabrina/uart.c M src/soc/amd/stoneyridge/northbridge.c M src/soc/intel/alderlake/pmc.c M src/soc/intel/apollolake/systemagent.c M src/soc/intel/baytrail/lpe.c M src/soc/intel/baytrail/northcluster.c M src/soc/intel/braswell/lpe.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/northbridge.c M src/soc/intel/cannonlake/pmc.c M src/soc/intel/common/block/fast_spi/fast_spi.c M src/soc/intel/common/block/p2sb/ioe_p2sb.c M src/soc/intel/common/block/p2sb/p2sb.c M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/denverton_ns/systemagent.c M src/soc/intel/elkhartlake/pmc.c M src/soc/intel/jasperlake/pmc.c M src/soc/intel/tigerlake/pmc.c M src/soc/mediatek/mt8173/soc.c M src/soc/mediatek/mt8183/soc.c M src/soc/mediatek/mt8186/soc.c M src/soc/mediatek/mt8192/soc.c M src/soc/mediatek/mt8195/soc.c M src/soc/qualcomm/qcs405/soc.c M src/soc/qualcomm/sc7180/soc.c M src/soc/qualcomm/sc7280/soc.c M src/soc/rockchip/rk3399/soc.c M src/soc/ti/am335x/soc.c M util/coccinelle/new-resource/0005-mmio.cocci 59 files changed, 208 insertions(+), 235 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/55937/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/55937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I903c0183e7fc6b14aeb00325cd10cd48682c2e85 Gerrit-Change-Number: 55937 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tree-wide: Use mmio_resource() and fixed_mem_resource()
by Kyösti Mälkki (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jeff Daly, Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Fred Reitberger, Felix Held. Hello build bot (Jenkins), Jeff Daly, Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Angel Pons, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55428 to look at the new patch set (#17). Change subject: tree-wide: Use mmio_resource() and fixed_mem_resource() ...................................................................... tree-wide: Use mmio_resource() and fixed_mem_resource() Change-Id: I24a99e93b4067347c080ec025a49d141172817c6 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/drivers/generic/ioapic/ioapic.c M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/ironlake/northbridge.c M src/northbridge/intel/pineview/northbridge.c M src/soc/amd/cezanne/root_complex.c M src/soc/amd/common/block/lpc/lpc.c M src/soc/amd/picasso/root_complex.c M src/soc/amd/sabrina/root_complex.c M src/soc/amd/stoneyridge/northbridge.c M src/soc/intel/broadwell/northbridge.c M src/soc/intel/broadwell/pch/lpc.c M src/soc/intel/common/block/sram/sram.c M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/denverton_ns/lpc.c M src/soc/intel/denverton_ns/systemagent.c M src/southbridge/amd/agesa/hudson/lpc.c M src/southbridge/amd/cimx/sb800/lpc.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82371eb/isa.c M src/southbridge/intel/i82801dx/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c M util/coccinelle/new-resource/0002-mmio.cocci 30 files changed, 74 insertions(+), 314 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/55428/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/55428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24a99e93b4067347c080ec025a49d141172817c6 Gerrit-Change-Number: 55428 Gerrit-PatchSet: 17 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tree-wide: Use fixed_io_range/resource()
by Kyösti Mälkki (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Mariusz Szafrański, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Alexander Couzens, Patrick Rudolph, Felix Held. Hello build bot (Jenkins), Mariusz Szafrański, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Alexander Couzens, Patrick Rudolph, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55461 to look at the new patch set (#11). Change subject: tree-wide: Use fixed_io_range/resource() ...................................................................... tree-wide: Use fixed_io_range/resource() Change-Id: I0a75ba2c5214d02f909649f1e856eaa9ddf3c79b Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/drivers/ipmi/ipmi_kcs_ops.c M src/drivers/ipmi/ocp/ipmi_ocp.c M src/drivers/net/ne2k.c M src/ec/google/chromeec/ec_lpc.c M src/ec/google/wilco/chip.c M src/ec/kontron/kempld/kempld.c M src/ec/lenovo/pmh7/pmh7.c M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/soc/intel/alderlake/pmc.c M src/soc/intel/baytrail/southcluster.c M src/soc/intel/braswell/southcluster.c M src/soc/intel/broadwell/pch/lpc.c M src/soc/intel/cannonlake/pmc.c M src/soc/intel/elkhartlake/pmc.c M src/soc/intel/jasperlake/pmc.c M src/soc/intel/quark/lpc.c M src/soc/intel/tigerlake/pmc.c M src/southbridge/intel/common/smbus_ops.c M src/southbridge/intel/i82371eb/isa.c M src/southbridge/intel/i82371eb/smbus.c M src/southbridge/intel/lynxpoint/lpc.c M src/superio/common/generic.c 22 files changed, 39 insertions(+), 176 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/55461/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/55461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a75ba2c5214d02f909649f1e856eaa9ddf3c79b Gerrit-Change-Number: 55461 Gerrit-PatchSet: 11 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/kontron/kempld: Move some resource lines
by Kyösti Mälkki (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Maxim Polyakov. Hello build bot (Jenkins), Maxim Polyakov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64699 to look at the new patch set (#4). Change subject: ec/kontron/kempld: Move some resource lines ...................................................................... ec/kontron/kempld: Move some resource lines This makes coccinelle script happy. It's not possible for new_resource() to return NULL. Change-Id: I66811b36b44f06cb39df8e9cdab87be0e2ef8eb9 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/ec/kontron/kempld/kempld.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/64699/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/64699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66811b36b44f06cb39df8e9cdab87be0e2ef8eb9 Gerrit-Change-Number: 64699 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] resource: Swap some resource initialisation lines
by Kyösti Mälkki (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons. Hello build bot (Jenkins), Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64698 to look at the new patch set (#4). Change subject: [WIP] resource: Swap some resource initialisation lines ...................................................................... [WIP] resource: Swap some resource initialisation lines This makes coccinelle happy. Change-Id: I83f3ef38b8663640594b4d726838f7a6f96a58a2 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/ec/google/wilco/chip.c M src/northbridge/intel/haswell/northbridge.c M src/soc/intel/broadwell/northbridge.c M src/soc/intel/denverton_ns/lpc.c M src/soc/intel/denverton_ns/systemagent.c 5 files changed, 13 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/64698/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/64698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83f3ef38b8663640594b4d726838f7a6f96a58a2 Gerrit-Change-Number: 64698 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload: Add support for PCI MMIO CONFIG access.
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Ravi Kumar Bokka, Shelley Chen, Furquan Shaikh, Venkat Thogaru, Sudheer Amrabadi, Arthur Heymans, Prasad Malisetty. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57615 ) Change subject: libpayload: Add support for PCI MMIO CONFIG access. ...................................................................... Patch Set 65: Verified-1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150534): https://review.coreboot.org/c/coreboot/+/57615/comment/cc525ab7_240ce347 PS65, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/57615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d1217502cbd7d4d0cdd298919ae82435630d61c Gerrit-Change-Number: 57615 Gerrit-PatchSet: 65 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 11:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: Add PCI config base address and length.
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Ravi Kumar Bokka, Venkat Thogaru, Sudheer Amrabadi, Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61773 ) Change subject: sc7280: Add PCI config base address and length. ...................................................................... Patch Set 49: Verified-1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150532): https://review.coreboot.org/c/coreboot/+/61773/comment/d6637335_17b477dc PS49, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/61773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I492b2b5fb97e775e5928b1326209270f719f5651 Gerrit-Change-Number: 61773 Gerrit-PatchSet: 49 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Jun 2022 11:44:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine: Add support to enable display
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Sudheer Amrabadi. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64885 ) Change subject: mb/google/herobrine: Add support to enable display ...................................................................... Patch Set 3: Verified-1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150530): https://review.coreboot.org/c/coreboot/+/64885/comment/32a8c41b_4980614a PS3, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/64885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01dbe23afbb3d41d87f24cb7dcfa456cb7f133fb Gerrit-Change-Number: 64885 Gerrit-PatchSet: 3 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Thu, 02 Jun 2022 11:43:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022