coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: cpu/amd/smm: Move MP & SMM init in a common place
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64870 ) Change subject: cpu/amd/smm: Move MP & SMM init in a common place ...................................................................... Patch Set 5: (1 comment) File src/cpu/amd/smm/smm_helper.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150523): https://review.coreboot.org/c/coreboot/+/64870/comment/85cc9280_f42ae090 PS5, Line 88: static void get_smm_info(uintptr_t *perm_smbase, size_t *perm_smsize, size_t *smm_save_state_size) line length of 98 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/64870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c457ab69581f8c29f2d79c054ca3bc7e58a896e Gerrit-Change-Number: 64870 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:59:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd: Do SMM relocation via MSR
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Hello Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64872 to look at the new patch set (#7). Change subject: soc/amd: Do SMM relocation via MSR ...................................................................... soc/amd: Do SMM relocation via MSR AMD CPUs have a convenient MSR that allows to set the SMBASE in the save state without ever entering SMM (e.g. at the default 0x30000 address). This has been a feature in all AMD CPUs since at least AMD K8. This allows to do relocation in parallel in ramstage and without setting up a relocation handler, which likely results in a speedup. The more cores the higher the speedup as relocation was happening sequentially. On a 4 core AMD picasso system this results in 33ms boot speedup. TESTED on google/vilboz (Picasso) with CONFIG_SMI_DEBUG: verify that SMM is correctly relocated with the BSP correctly entering the smihandler. Change-Id: I9729fb94ed5c18cfd57b8098c838c08a04490e4b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/amd/smm/smm_helper.c M src/cpu/x86/Kconfig M src/cpu/x86/mp_init.c M src/soc/amd/common/Kconfig.common 4 files changed, 27 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/64872/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/64872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9729fb94ed5c18cfd57b8098c838c08a04490e4b Gerrit-Change-Number: 64872 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/amd: Move locking SMM as part of SMM init
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Hello Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64871 to look at the new patch set (#5). Change subject: cpu/amd: Move locking SMM as part of SMM init ...................................................................... cpu/amd: Move locking SMM as part of SMM init Change-Id: Ibcdfc0f9ae211644cf0911790b0b0c5d1b0b7dc9 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/amd/smm/smm_helper.c M src/include/cpu/amd/smm.h M src/soc/amd/common/block/cpu/smm/finalize.c 3 files changed, 4 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/64871/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/64871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcdfc0f9ae211644cf0911790b0b0c5d1b0b7dc9 Gerrit-Change-Number: 64871 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/amd/smm: Move MP & SMM init in a common place
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Hello Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64870 to look at the new patch set (#5). Change subject: cpu/amd/smm: Move MP & SMM init in a common place ...................................................................... cpu/amd/smm: Move MP & SMM init in a common place Change-Id: I7c457ab69581f8c29f2d79c054ca3bc7e58a896e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/amd/smm/smm_helper.c M src/include/cpu/amd/smm.h M src/soc/amd/cezanne/cpu.c M src/soc/amd/common/block/cpu/smm/Makefile.inc D src/soc/amd/common/block/cpu/smm/smm_relocate.c M src/soc/amd/common/block/include/amdblocks/smm.h M src/soc/amd/picasso/cpu.c M src/soc/amd/sabrina/cpu.c M src/soc/amd/stoneyridge/cpu.c 9 files changed, 68 insertions(+), 189 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/64870/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/64870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c457ab69581f8c29f2d79c054ca3bc7e58a896e Gerrit-Change-Number: 64870 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/smm_relocate.c: Improve TSEG programming
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64865 to look at the new patch set (#4). Change subject: soc/amd/smm_relocate.c: Improve TSEG programming ...................................................................... soc/amd/smm_relocate.c: Improve TSEG programming TSEG does not need to be aligned to 128KiB but to it's size, as the MSR work like an MTRR. 128KiB is a minimum TSEG size however. TESTED on google/vilboz. Change-Id: I30854111bb47f0cb14b07f71cedacd629432e0f4 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/amd/common/block/cpu/smm/smm_relocate.c M src/soc/amd/common/block/include/amdblocks/smm.h 2 files changed, 26 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/64865/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/64865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30854111bb47f0cb14b07f71cedacd629432e0f4 Gerrit-Change-Number: 64865 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: treewide: Remove unused <cpu/x86/msr.h>
by Elyes Haouas (Code Review) 02 Jun '22

02 Jun '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64890 ) Change subject: treewide: Remove unused <cpu/x86/msr.h> ...................................................................... treewide: Remove unused <cpu/x86/msr.h> Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I187c2482dd82c6c6d1fe1cbda71710ae1a2f54ad --- M src/arch/x86/c_exit.S M src/arch/x86/postcar_loader.c M src/security/intel/txt/ramstage.c M src/soc/amd/common/block/cpu/tsc/monotonic_timer.c M src/soc/amd/picasso/cpu.c M src/soc/amd/picasso/fch.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/broadwell/acpi.c 8 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/64890/1 diff --git a/src/arch/x86/c_exit.S b/src/arch/x86/c_exit.S index bb1df28..a83573d 100644 --- a/src/arch/x86/c_exit.S +++ b/src/arch/x86/c_exit.S @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/ram_segs.h> -#include <cpu/x86/msr.h> #include <cpu/x86/cr.h> diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c index af8152d..c6576a2 100644 --- a/src/arch/x86/postcar_loader.c +++ b/src/arch/x86/postcar_loader.c @@ -3,7 +3,6 @@ #include <arch/romstage.h> #include <cbmem.h> #include <console/console.h> -#include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> #include <cpu/x86/smm.h> #include <program_loading.h> diff --git a/src/security/intel/txt/ramstage.c b/src/security/intel/txt/ramstage.c index 265f81e..744b05e 100644 --- a/src/security/intel/txt/ramstage.c +++ b/src/security/intel/txt/ramstage.c @@ -7,7 +7,6 @@ #include <cbfs.h> #include <console/console.h> #include <cpu/intel/common/common.h> -#include <cpu/x86/msr.h> #include <cpu/x86/smm.h> #include <device/pci_ops.h> #include <security/intel/cbnt/cbnt.h> diff --git a/src/soc/amd/common/block/cpu/tsc/monotonic_timer.c b/src/soc/amd/common/block/cpu/tsc/monotonic_timer.c index 941532c..4cedc3d 100644 --- a/src/soc/amd/common/block/cpu/tsc/monotonic_timer.c +++ b/src/soc/amd/common/block/cpu/tsc/monotonic_timer.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <timer.h> #include <timestamp.h> diff --git a/src/soc/amd/picasso/cpu.c b/src/soc/amd/picasso/cpu.c index f14ee49..b8f7e5a 100644 --- a/src/soc/amd/picasso/cpu.c +++ b/src/soc/amd/picasso/cpu.c @@ -8,7 +8,6 @@ #include <cpu/cpu.h> #include <cpu/x86/mp.h> #include <cpu/x86/mtrr.h> -#include <cpu/x86/msr.h> #include <cpu/x86/smm.h> #include <acpi/acpi.h> #include <device/device.h> diff --git a/src/soc/amd/picasso/fch.c b/src/soc/amd/picasso/fch.c index 0040221..c4d34a53 100644 --- a/src/soc/amd/picasso/fch.c +++ b/src/soc/amd/picasso/fch.c @@ -4,7 +4,6 @@ #include <bootstate.h> #include <cpu/amd/msr.h> #include <cpu/x86/smm.h> -#include <cpu/x86/msr.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> diff --git a/src/soc/intel/apollolake/pmutil.c b/src/soc/intel/apollolake/pmutil.c index fbb2345..4623017 100644 --- a/src/soc/intel/apollolake/pmutil.c +++ b/src/soc/intel/apollolake/pmutil.c @@ -7,7 +7,6 @@ #include <arch/io.h> #include <device/mmio.h> #include <console/console.h> -#include <cpu/x86/msr.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c index 00e6807..a9b47cc 100644 --- a/src/soc/intel/broadwell/acpi.c +++ b/src/soc/intel/broadwell/acpi.c @@ -10,7 +10,6 @@ #include <console/console.h> #include <device/device.h> #include <types.h> -#include <cpu/x86/msr.h> #include <cpu/intel/turbo.h> #include <soc/acpi.h> #include <soc/device_nvs.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/64890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I187c2482dd82c6c6d1fe1cbda71710ae1a2f54ad Gerrit-Change-Number: 64890 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: vendorcode/intel/fsp/fsp2_0/mtl: Add FSP header files for Meteor Lake
by Subrata Banik (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Tarun Tuli, Wonkyu Kim, Ravishankar Sarawadi, Tim Wawrzynczak, Kapil Porwal, Srinidhi N Kaushik, Raj Astekar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64883 ) Change subject: vendorcode/intel/fsp/fsp2_0/mtl: Add FSP header files for Meteor Lake ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @Srinidhi, many required UPDs are missing, refer to b:234701164 -- To view, visit https://review.coreboot.org/c/coreboot/+/64883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1caa4bc09f09005859e6c8853d14b8f96a26ff Gerrit-Change-Number: 64883 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:39:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apollolake: Allow configuring the LPC IO registers
by Sean Rhodes (Code Review) 02 Jun '22

02 Jun '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64889 ) Change subject: soc/intel/apollolake: Allow configuring the LPC IO registers ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a7ab3faf927cda76640227feff4e19017442897 Gerrit-Change-Number: 64889 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:31:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/smm: Move MP & SMM init in a common place
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64870 ) Change subject: cpu/amd/smm: Move MP & SMM init in a common place ...................................................................... Patch Set 4: (1 comment) File src/cpu/amd/smm/smm_helper.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150513): https://review.coreboot.org/c/coreboot/+/64870/comment/88d8a6b6_26a46b7c PS4, Line 88: static void get_smm_info(uintptr_t *perm_smbase, size_t *perm_smsize, size_t *smm_save_state_size) line length of 98 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/64870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c457ab69581f8c29f2d79c054ca3bc7e58a896e Gerrit-Change-Number: 64870 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:27:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/smm_relocate.c: Improve TSEG programming
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64865 ) Change subject: soc/amd/smm_relocate.c: Improve TSEG programming ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/common/block/cpu/smm/smm_relocate.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150508): https://review.coreboot.org/c/coreboot/+/64865/comment/6e56ebfb_641f9df3 PS3, Line 25: /* Minumum granularity for TSEG MSRs */ 'Minumum' may be misspelled - perhaps 'Minimum'? -- To view, visit https://review.coreboot.org/c/coreboot/+/64865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30854111bb47f0cb14b07f71cedacd629432e0f4 Gerrit-Change-Number: 64865 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 10:25:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022