coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: libpayload: Add support for PCI MMIO CONFIG access.
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Ravi Kumar Bokka, Shelley Chen, Furquan Shaikh, Venkat Thogaru, Sudheer Amrabadi, Arthur Heymans, Prasad Malisetty. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57615 ) Change subject: libpayload: Add support for PCI MMIO CONFIG access. ...................................................................... Patch Set 64: Verified-1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150479): https://review.coreboot.org/c/coreboot/+/57615/comment/c2719114_b01c2eac PS64, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/57615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d1217502cbd7d4d0cdd298919ae82435630d61c Gerrit-Change-Number: 57615 Gerrit-PatchSet: 64 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 08:46:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: Add PCI config base address and length.
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Ravi Kumar Bokka, Venkat Thogaru, Sudheer Amrabadi, Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61773 ) Change subject: sc7280: Add PCI config base address and length. ...................................................................... Patch Set 48: Verified-1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150477): https://review.coreboot.org/c/coreboot/+/61773/comment/31f0db5c_cd3cb9b5 PS48, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/61773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I492b2b5fb97e775e5928b1326209270f719f5651 Gerrit-Change-Number: 61773 Gerrit-PatchSet: 48 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Jun 2022 08:46:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: qualcomm/sc7280: Add support for edp and mdp driver
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Sudheer Amrabadi. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64884 ) Change subject: qualcomm/sc7280: Add support for edp and mdp driver ...................................................................... Patch Set 2: (2 comments) File src/soc/qualcomm/sc7280/display/edp_ctrl.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150473): https://review.coreboot.org/c/coreboot/+/64884/comment/6b4cc18b_c1ab787c PS2, Line 187: #define DP_CHANNEL_EQ_BITS (DP_LANE_CR_DONE | \ please, no space before tabs File src/soc/qualcomm/sc7280/include/soc/display/mdssreg.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150473): https://review.coreboot.org/c/coreboot/+/64884/comment/fc3d5557_26b94e38 PS2, Line 469: SW_PIX_EXT_OVERRIDE = BIT(31), please, no space before tabs -- To view, visit https://review.coreboot.org/c/coreboot/+/64884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae7ede75e8e20991b7ba126059867f241e16dd4f Gerrit-Change-Number: 64884 Gerrit-PatchSet: 2 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Thu, 02 Jun 2022 08:45:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine: Add support to enable display
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Sudheer Amrabadi. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64885 ) Change subject: mb/google/herobrine: Add support to enable display ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150474): https://review.coreboot.org/c/coreboot/+/64885/comment/d42b471c_ffe91af4 PS2, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/64885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01dbe23afbb3d41d87f24cb7dcfa456cb7f133fb Gerrit-Change-Number: 64885 Gerrit-PatchSet: 2 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Thu, 02 Jun 2022 08:45:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: Add PCIe host controller driver
by Sudheer Amrabadi (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Ravi Kumar Bokka, Nico Huber, Furquan Shaikh, Paul Menzel, Julius Werner, Prasad Malisetty, mturney mturney. Sudheer Amrabadi has uploaded a new patch set (#99) to the change originally created by Ravi Kumar Bokka. ( https://review.coreboot.org/c/coreboot/+/53902 ) Change subject: sc7280: Add PCIe host controller driver ...................................................................... sc7280: Add PCIe host controller driver Add support for PCIe host driver to configure in RC (root complex) mode. Host driver will power on the PHY, enable the PCIe link and start the bus enumeration. BUG=b:182963902,b:216686574,b:181098581 TEST=Validated on qualcomm sc7280 development board Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631 Signed-off-by: Prasad Malisetty <quic_pmaliset(a)quicinc.com> --- M src/mainboard/google/herobrine/mainboard.c M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/include/soc/addressmap.h A src/soc/qualcomm/sc7280/include/soc/pcie.h A src/soc/qualcomm/sc7280/include/soc/qcom_qmp_phy.h A src/soc/qualcomm/sc7280/pcie_host.c 6 files changed, 1,590 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/53902/99 -- To view, visit https://review.coreboot.org/c/coreboot/+/53902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631 Gerrit-Change-Number: 53902 Gerrit-PatchSet: 99 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/herobrine: Add support to enable display
by Sudheer Amrabadi (Code Review) 02 Jun '22

02 Jun '22

1 0

Change in coreboot[master]: qualcomm/sc7280: Add support for edp and mdp driver
by Sudheer Amrabadi (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Sudheer Amrabadi. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64884 to look at the new patch set (#2). Change subject: qualcomm/sc7280: Add support for edp and mdp driver ...................................................................... qualcomm/sc7280: Add support for edp and mdp driver - Add support for edp aux read and write. - Update edp panel properties based on edid read. - Configure edp controller and edp phy. BUG=b:182963902,b:216687885 TEST=Validated on qualcomm sc7280 development board. Change-Id: Iae7ede75e8e20991b7ba126059867f241e16dd4f Signed-off-by: Vinod Polimera <quic_vpolimer(a)quicinc.com> --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc A src/soc/qualcomm/sc7280/display/disp.c A src/soc/qualcomm/sc7280/display/edp_aux.c A src/soc/qualcomm/sc7280/display/edp_ctrl.c A src/soc/qualcomm/sc7280/display/edp_phy_7nm.c A src/soc/qualcomm/sc7280/include/soc/display/edp_aux.h A src/soc/qualcomm/sc7280/include/soc/display/edp_ctrl.h A src/soc/qualcomm/sc7280/include/soc/display/edp_phy.h A src/soc/qualcomm/sc7280/include/soc/display/edp_reg.h A src/soc/qualcomm/sc7280/include/soc/display/mdssreg.h 11 files changed, 2,965 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/64884/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae7ede75e8e20991b7ba126059867f241e16dd4f Gerrit-Change-Number: 64884 Gerrit-PatchSet: 2 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/lenovo/haswell/Kconfig: VGA_BIOS_ID depends on the installed CPU
by Peter Lemenkov (Code Review) 02 Jun '22

02 Jun '22

Peter Lemenkov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/64887 ) Change subject: mb/lenovo/haswell/Kconfig: VGA_BIOS_ID depends on the installed CPU ...................................................................... Abandoned Ok disregard. According to https://github.com/linuxhw/LsPCI all Haswells have the same 8086:0416 -- To view, visit https://review.coreboot.org/c/coreboot/+/64887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73463e00badf520f44834e4d19919fed0646deac Gerrit-Change-Number: 64887 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "util/crossgcc: Update gcc to 11.2"
by Arthur Heymans (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Nico Huber, Branden Waldner, Idwer Vollering, Jacob Garber, Mike Banon, Werner Zeh, Iru Cai, Elyes Haouas, Harshit Sharma. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59636 ) Change subject: Revert "util/crossgcc: Update gcc to 11.2" ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: > Elyes, thank you for trying, unfortunately GCC 11.3 doesn't work too. Possible outcomes when attempting to use a coreboot+SeaBIOS on AMD Lenovo G505S built with GCC 11.3 : > > 1) black screen, doesn't show anything - even a SeaBIOS text interface; > 2) shows a SeaBIOS interface which hangs on "Press ESC" (pressing ESC doesn't do anything); > 3) shows a SeaBIOS interface which works; if I didn't choose anything, then runs a default entry (a KolibriOS ramdisk, which launched successfully the times I tried); if I chose a HDD, see "4)" and "5)" > 4) loads GRUB from HDD - it gets a password from keyboard but hangs while decrypting a /boot; > 5) successfully decrypts /boot and shows a GRUB menu, but later hangs on "Loading initial ramdisk" ! This booting step precedes a step of entering a key and decrypting a "/" partition of a Full Disk Encryption instal of Artix Linux (user-friendly Arch without SystemD) which I did by this manual - https://wiki.artixlinux.org/Main/InstallationWithFullDiskEncryption > > Meanwhile, an equal coreboot+SeaBIOS build with GCC 8.3.0 and the same contents of HDD - works perfectly all the time. I haven't yet tried a mixed build of "coreboot by new GCC, SeaBIOS by old GCC" It looks like GCC11 aligns packed structs differently which can cause problems when writing to hardware registers. As #pragma pack is used for all the AGESA code I can see why this goes south... Maybe you can see how removing '#pragma pack(1)' from Porting.h fares? -- To view, visit https://review.coreboot.org/c/coreboot/+/59636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44 Gerrit-Change-Number: 59636 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Martin L Roth <gaumless(a)tutanota.com> Gerrit-CC: Michal Zygowski <miczyg94(a)gmail.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 08:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Mike Banon <mikebdp2(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/haswell/Kconfig: VGA_BIOS_ID depends on the installed CPU
by Peter Lemenkov (Code Review) 02 Jun '22

02 Jun '22

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64887 ) Change subject: mb/lenovo/haswell/Kconfig: VGA_BIOS_ID depends on the installed CPU ...................................................................... mb/lenovo/haswell/Kconfig: VGA_BIOS_ID depends on the installed CPU VGA_BIOS_ID depends on the installed CPU. It's better to remove it. UNTESTED. Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> Change-Id: I73463e00badf520f44834e4d19919fed0646deac --- M src/mainboard/lenovo/haswell/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/64887/1 diff --git a/src/mainboard/lenovo/haswell/Kconfig b/src/mainboard/lenovo/haswell/Kconfig index 126e92d..8d2bf99 100644 --- a/src/mainboard/lenovo/haswell/Kconfig +++ b/src/mainboard/lenovo/haswell/Kconfig @@ -47,10 +47,6 @@ config MAINBOARD_PART_NUMBER default "ThinkPad T440p" -config VGA_BIOS_ID - string - default "8086,0416" - config USBDEBUG_HCD_INDEX int default 2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73463e00badf520f44834e4d19919fed0646deac Gerrit-Change-Number: 64887 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022