coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1232 discussions

Change in coreboot[master]: mb/google/corsola: Enable ps8640 for steelix
by Yu-Ping Wu (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Knox Chiou, zanxi chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64790 ) Change subject: mb/google/corsola: Enable ps8640 for steelix ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/corsola/display.c: https://review.coreboot.org/c/coreboot/+/64790/comment/284346ad_802a901a PS3, Line 125: CONFIG(BOARD_GOOGLE_KINGLER_COMMON) + CONFIG(BOARD_GOOGLE_KRABBY_COMMON) == 1 You'll also need to change this to CONFIG(DRIVER_ANALOGIX_ANX7625) + CONFIG(DRIVER_PARADE_PS8640) == 1 or ensure the same thing using `choice` in Kconfig. https://review.coreboot.org/c/coreboot/+/64790/comment/76473abb_fb327b06 PS3, Line 136: else if (CONFIG(BOARD_GOOGLE_KRABBY) || CONFIG(BOARD_GOOGLE_STEELIX)) If this starts getting complicated, we should make it a Kconfig option. In corsola/Kconfig, we can select only one of DRIVER_ANALOGIX_ANX7625 and DRIVER_PARADE_PS8640 (not both). Then here use them to determine the bridge to initialize. -- To view, visit https://review.coreboot.org/c/coreboot/+/64790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c6310794c89fc8aa0e69e114c1f7ebd5479c549 Gerrit-Change-Number: 64790 Gerrit-PatchSet: 3 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-CC: Yuqing Huang <huangyuqing(a)huaqin.corp-partner.google.com> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)chromium.org> Gerrit-Comment-Date: Thu, 02 Jun 2022 07:28:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vendorcode/intel/fsp/fsp2_0/mtl: Update FSP header files for Meteor Lake
by Srinidhi N Kaushik (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Raj Astekar. Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64878 ) Change subject: vendorcode/intel/fsp/fsp2_0/mtl: Update FSP header files for Meteor Lake ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > Can you please help to submit FSP header for 2173 what we have in MTL branch as off now. […] Done, https://review.coreboot.org/c/coreboot/+/64883/1 File src/vendorcode/intel/fsp/fsp2_0/meteorlake/MemInfoHob.h: https://review.coreboot.org/c/coreboot/+/64878/comment/bb5efda4_64059393 PS1, Line 7: INTEL CONFIDENTIAL : Copyright 1999 - 2022 Intel Corporation. > please check the header license here https://github. […] Fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/64878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I529118c35fa9f851ee2b5f23712ac70e2a5b53c5 Gerrit-Change-Number: 64878 Gerrit-PatchSet: 2 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 07:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vendorcode/intel/fsp/fsp2_0/mtl: Update FSP header files for Meteor Lake
by Srinidhi N Kaushik (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Srinidhi N Kaushik, Raj Astekar. Hello build bot (Jenkins), Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Raj Astekar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64878 to look at the new patch set (#2). Change subject: vendorcode/intel/fsp/fsp2_0/mtl: Update FSP header files for Meteor Lake ...................................................................... vendorcode/intel/fsp/fsp2_0/mtl: Update FSP header files for Meteor Lake Update header files for FSP for Meteor Lake platform to version 2221_01, previous version being 2173_00 Signed-off-by: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Change-Id: I529118c35fa9f851ee2b5f23712ac70e2a5b53c5 --- M src/vendorcode/intel/fsp/fsp2_0/meteorlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/meteorlake/FspsUpd.h 2 files changed, 1,514 insertions(+), 1,457 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/64878/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I529118c35fa9f851ee2b5f23712ac70e2a5b53c5 Gerrit-Change-Number: 64878 Gerrit-PatchSet: 2 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb,soc/intel: Handle upper RAM boundary
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jeff Daly, Damien Zammit, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michal Motyl, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55929 ) Change subject: nb,soc/intel: Handle upper RAM boundary ...................................................................... Patch Set 5: Verified+1 (1 comment) File src/northbridge/intel/sandybridge/northbridge.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150458): https://review.coreboot.org/c/coreboot/+/55929/comment/4f605c7a_451ac445 PS5, Line 216: printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", (touud - 4ull * GiB) / MiB); line length of 101 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/55929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d99523647dfb43265db8f2701b525afd1870fc5 Gerrit-Change-Number: 55929 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 02 Jun 2022 06:37:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/baytrail,braswell,quark: Drop RES_IN_KIB
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55926 ) Change subject: soc/intel/baytrail,braswell,quark: Drop RES_IN_KIB ...................................................................... Patch Set 4: Verified+1 (1 comment) File src/soc/intel/braswell/northcluster.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150456): https://review.coreboot.org/c/coreboot/+/55926/comment/0b6ebc4e_52cb727e PS4, Line 92: /* If no FSP reserverd area */ 'reserverd' may be misspelled - perhaps 'reserved'? -- To view, visit https://review.coreboot.org/c/coreboot/+/55926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2360a1a79f07ff8466ed01aa7f180d410e019292 Gerrit-Change-Number: 55926 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 02 Jun 2022 06:36:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: resource: Fix resource helpers
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Kyösti Mälkki. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64785 ) Change subject: resource: Fix resource helpers ...................................................................... Patch Set 3: Verified+1 (2 comments) File src/include/device/device.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150443): https://review.coreboot.org/c/coreboot/+/64785/comment/1fc4f2ea_7432edcc PS3, Line 380: return fixed_mem_resource_f(dev, index, base, size, IORESOURCE_CACHEABLE | IORESOURCE_STORED); line length of 102 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150443): https://review.coreboot.org/c/coreboot/+/64785/comment/f573e73c_14a6a5d4 PS3, Line 431: return fixed_mem_resource_f(dev, index, base, size, IORESOURCE_RESERVE | IORESOURCE_STORED); line length of 100 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/64785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cca5ee5973e8c85f0956c417b59691eab283ecc Gerrit-Change-Number: 64785 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 06:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [NOTFORMERGE] Add _kb postfix for resources taking KiB arguments
by build bot (Jenkins) (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Hung-Te Lin, Raul Rangel, Jeff Daly, Philipp Hug, Mariusz Szafrański, Jonathan Zhang, Julius Werner, Angel Pons, Arthur Heymans, Andrey Petrov, Xi Chen, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Christian Walter, Suresh Bellampalli, Tim Wawrzynczak, Vanessa Eusebio, Fred Reitberger, ron minnich, Felix Held, Tim Chu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64658 ) Change subject: [NOTFORMERGE] Add _kb postfix for resources taking KiB arguments ...................................................................... Patch Set 2: Verified+1 (6 comments) File src/northbridge/intel/ironlake/northbridge.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437): https://review.coreboot.org/c/coreboot/+/64658/comment/d45cd612_0392014d PS2, Line 57: mmio_resource_kb(dev, index++, legacy_hole_base_k, (0xc0000 / KiB) - legacy_hole_base_k); line length of 97 exceeds 96 columns File src/northbridge/intel/pineview/northbridge.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437): https://review.coreboot.org/c/coreboot/+/64658/comment/fd7ae19d_30b0dba9 PS2, Line 38: mmio_resource_kb(dev, index++, legacy_hole_base_k, (0xc0000 / KiB) - legacy_hole_base_k); line length of 97 exceeds 96 columns File src/northbridge/intel/sandybridge/northbridge.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437): https://review.coreboot.org/c/coreboot/+/64658/comment/623ee32f_adc8dfa6 PS2, Line 69: mmio_resource_kb(dev, index++, legacy_hole_base_k, (0xc0000 >> 10) - legacy_hole_base_k); line length of 97 exceeds 96 columns File src/soc/amd/cezanne/root_complex.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437): https://review.coreboot.org/c/coreboot/+/64658/comment/b99ced43_cf29e130 PS2, Line 167: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB); line length of 97 exceeds 96 columns File src/soc/amd/picasso/root_complex.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437): https://review.coreboot.org/c/coreboot/+/64658/comment/0fa19fa7_021b43bb PS2, Line 165: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB); line length of 97 exceeds 96 columns File src/soc/amd/sabrina/root_complex.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437): https://review.coreboot.org/c/coreboot/+/64658/comment/e7a4f244_f7eb44fc PS2, Line 169: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB); line length of 97 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/64658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I329864d36137e9a99b5640f4f504c45a02060a40 Gerrit-Change-Number: 64658 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 06:30:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/rex: Add memory init
by Subrata Banik (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Tarun Tuli, Tim Wawrzynczak, Kapil Porwal, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64850 ) Change subject: mb/google/rex: Add memory init ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt: https://review.coreboot.org/c/coreboot/+/64850/comment/5c1307fe_74b8ed14 PS2, Line 1: MT53E512M32D2NP-046 WT:F : H9HCNNNBKMMLXR-NEE : MT53E1G32D2NP-046 WT:A : MT53E2G32D4NQ-046 WT:A : H9HCNNNCPMMLXR-NEE : MT53E1G32D2NP-046 WT:B > oh I forgot delete this... I will do that, in middle of rebase -- To view, visit https://review.coreboot.org/c/coreboot/+/64850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5baa87411c28a20602eb5a7077f00664ccab3ade Gerrit-Change-Number: 64850 Gerrit-PatchSet: 3 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 06:28:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/rex: Add memory init
by Eric Lai (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Kapil Porwal. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64850 ) Change subject: mb/google/rex: Add memory init ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt: https://review.coreboot.org/c/coreboot/+/64850/comment/4b3c692e_dfa96c2e PS2, Line 1: MT53E512M32D2NP-046 WT:F : H9HCNNNBKMMLXR-NEE : MT53E1G32D2NP-046 WT:A : MT53E2G32D4NQ-046 WT:A : H9HCNNNCPMMLXR-NEE : MT53E1G32D2NP-046 WT:B > @Eric, did u pick this from Rex AVL list ? oh I forgot delete this... -- To view, visit https://review.coreboot.org/c/coreboot/+/64850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5baa87411c28a20602eb5a7077f00664ccab3ade Gerrit-Change-Number: 64850 Gerrit-PatchSet: 3 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 06:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdblocks/smm.h: Add header guards
by Elyes Haouas (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Arthur Heymans, Fred Reitberger, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64864 ) Change subject: amdblocks/smm.h: Add header guards ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d01c36fa4695ee42d18701a90d1b96bceb5045f Gerrit-Change-Number: 64864 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jun 2022 06:22:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022