Attention is currently required from: Tarun Tuli, Tim Wawrzynczak, Kapil Porwal, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64850 )
Change subject: mb/google/rex: Add memory init
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/64850/comment/d7b9f068_ad008dd5
PS2, Line 1: MT53E512M32D2NP-046 WT:F
: H9HCNNNBKMMLXR-NEE
: MT53E1G32D2NP-046 WT:A
: MT53E2G32D4NQ-046 WT:A
: H9HCNNNCPMMLXR-NEE
: MT53E1G32D2NP-046 WT:B
@Eric, did u pick this from Rex AVL list ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/64850
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5baa87411c28a20602eb5a7077f00664ccab3ade
Gerrit-Change-Number: 64850
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 05:56:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64864 )
Change subject: amdblocks/smm.h: Add header guards
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/smm.h:
https://review.coreboot.org/c/coreboot/+/64864/comment/e9aa2a9f_eb36baac
PS1, Line 3: _AMDBLOCKS_SMM_H_
> Is there a standard format for the header guards?
>
> Looking over other headers in this folder, most are in the form "AMD_BLOCK_foo_H"
The tree is inconsistent. The guard just has to be unique.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64864
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d01c36fa4695ee42d18701a90d1b96bceb5045f
Gerrit-Change-Number: 64864
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 02 Jun 2022 05:52:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Srinidhi N Kaushik, Raj Astekar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64878 )
Change subject: vendorcode/intel/fsp/fsp2_0/mtl: Add FSP header files for Meteor Lake
......................................................................
Patch Set 1:
(1 comment)
File src/vendorcode/intel/fsp/fsp2_0/meteorlake/MemInfoHob.h:
https://review.coreboot.org/c/coreboot/+/64878/comment/9d384a08_a21dd0a9
PS1, Line 7: INTEL CONFIDENTIAL
: Copyright 1999 - 2022 Intel Corporation.
please check the header license here https://github.com/coreboot/coreboot/blob/master/src/vendorcode/intel/fsp/f…
The current license is not supporting open sourcing as tag as `INTEL CONFIDENTIAL`
--
To view, visit https://review.coreboot.org/c/coreboot/+/64878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I529118c35fa9f851ee2b5f23712ac70e2a5b53c5
Gerrit-Change-Number: 64878
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 05:52:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Srinidhi N Kaushik, Raj Astekar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64878 )
Change subject: vendorcode/intel/fsp/fsp2_0/mtl: Add FSP header files for Meteor Lake
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Can you please help to submit FSP header for 2173 what we have in MTL branch as off now. https://chrome-internal.googlesource.com/chromeos/third_party/intel-fsp/mtl…
--
To view, visit https://review.coreboot.org/c/coreboot/+/64878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I529118c35fa9f851ee2b5f23712ac70e2a5b53c5
Gerrit-Change-Number: 64878
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 05:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64461 )
Change subject: mb/google/nissa/var/craask: Disable PCIe WLAN pins
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/craask/gpio.c:
https://review.coreboot.org/c/coreboot/+/64461/comment/9aad1149_094e60f7
PS2, Line 15: PAD_CFG_GPO(GPP_F12, 1, DEEP),
> No, I think this is fine. Without CB:64270, Nick's comment would be correct. […]
Roger that.
Thanks for your support and help!
--
To view, visit https://review.coreboot.org/c/coreboot/+/64461
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bcf041503dcee448758dac46b1c9711d0b02ba3
Gerrit-Change-Number: 64461
Gerrit-PatchSet: 2
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 05:19:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Comment-In-Reply-To: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: V Sowmya, Martin L Roth, Tim Wawrzynczak, Vidya Gopalakrishnan, Tyler Wang.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64632 )
Change subject: mb/google/nissa/craask: Configure the external V1p05/Vnn/VnnSx
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/64632
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95d24c0836f3ee02006868341ccc72d762c155d3
Gerrit-Change-Number: 64632
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 05:12:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64857 )
Change subject: intelblocks/gpio.c: Handle NULL return values from child functions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This CL not help the NULL dereference. suspect it come from MRC
--
To view, visit https://review.coreboot.org/c/coreboot/+/64857
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97fad72cdd92f70c7c5e6fdd23fbecf535a6e388
Gerrit-Change-Number: 64857
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 02 Jun 2022 04:50:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment