build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64884 )
Change subject: qualcomm/sc7280: Add support for edp and mdp driver
......................................................................
Patch Set 1:
(2 comments)
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150468):
https://review.coreboot.org/c/coreboot/+/64884/comment/fa7a9322_26b83657
PS1, Line 187: #define DP_CHANNEL_EQ_BITS (DP_LANE_CR_DONE | \
please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/display/mdssreg.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150468):
https://review.coreboot.org/c/coreboot/+/64884/comment/739b98c2_fb23e5c9
PS1, Line 469: SW_PIX_EXT_OVERRIDE = BIT(31),
please, no space before tabs
--
To view, visit https://review.coreboot.org/c/coreboot/+/64884
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae7ede75e8e20991b7ba126059867f241e16dd4f
Gerrit-Change-Number: 64884
Gerrit-PatchSet: 1
Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 02 Jun 2022 08:02:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi Kumar Bokka, Venkat Thogaru, Sudheer Amrabadi, Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61773 )
Change subject: sc7280: Add PCI config base address and length.
......................................................................
Patch Set 47: Verified-1
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150463):
https://review.coreboot.org/c/coreboot/+/61773/comment/5764d109_a7925967
PS47, Line 6:
Subject line should not end with a period.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61773
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I492b2b5fb97e775e5928b1326209270f719f5651
Gerrit-Change-Number: 61773
Gerrit-PatchSet: 47
Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 02 Jun 2022 08:01:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Ravi Kumar Bokka, Nico Huber, Furquan Shaikh, Paul Menzel, Julius Werner, Prasad Malisetty, mturney mturney.
Sudheer Amrabadi has uploaded a new patch set (#98) to the change originally created by Ravi Kumar Bokka. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe host controller driver
......................................................................
sc7280: Add PCIe host controller driver
Add support for PCIe host driver to configure
in RC (root complex) mode. Host driver will power on
the PHY, enable the PCIe link and start the bus enumeration.
BUG=b:182963902,b:216686574,b:181098581
TEST=Validated on qualcomm sc7280 development board
Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631
Signed-off-by: Prasad Malisetty <quic_pmaliset(a)quicinc.com>
---
M src/mainboard/google/herobrine/mainboard.c
M src/soc/qualcomm/sc7280/Makefile.inc
M src/soc/qualcomm/sc7280/include/soc/addressmap.h
A src/soc/qualcomm/sc7280/include/soc/pcie.h
A src/soc/qualcomm/sc7280/include/soc/qcom_qmp_phy.h
A src/soc/qualcomm/sc7280/pcie_host.c
6 files changed, 1,594 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/53902/98
--
To view, visit https://review.coreboot.org/c/coreboot/+/53902
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631
Gerrit-Change-Number: 53902
Gerrit-PatchSet: 98
Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Branden Waldner, Idwer Vollering, Arthur Heymans, Jacob Garber, Mike Banon, Werner Zeh, Iru Cai, Elyes Haouas, Harshit Sharma.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59636 )
Change subject: Revert "util/crossgcc: Update gcc to 11.2"
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Martin, maybe this should be documented in the release notes for 4.17?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44
Gerrit-Change-Number: 59636
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-CC: Michal Zygowski <miczyg94(a)gmail.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 07:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth, Elyes Haouas.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63807 )
Change subject: util/crossgcc: Update to GCC 11.3
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Any reason, this wasn’t merged before the 4.17 release?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c0aa0952f85afee59a955593c63fcfac756cc60
Gerrit-Change-Number: 63807
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 02 Jun 2022 07:46:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Srinidhi N Kaushik, Raj Astekar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64878 )
Change subject: vendorcode/intel/fsp/fsp2_0/mtl: Update FSP header files for Meteor Lake
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> Done, https://review.coreboot.org/c/coreboot/+/64883/1
Thanks, can we mark this CL, WIP for now ? I will pick 2173 into the buildable recipe and share my feedback.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I529118c35fa9f851ee2b5f23712ac70e2a5b53c5
Gerrit-Change-Number: 64878
Gerrit-PatchSet: 2
Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 07:29:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-MessageType: comment