coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: commonlib: Clean up compiler.h
by Elyes Haouas (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Philipp Hug, Patrick Georgi, Jakub Czapiga, Julius Werner, ron minnich. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64737 ) Change subject: commonlib: Clean up compiler.h ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9644da594bb69133843c6b7f12ce50b2e45fd24b Gerrit-Change-Number: 64737 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 02:49:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req()
by Rex-BC Chen (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64861 ) Change subject: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d Gerrit-Change-Number: 64861 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 02:37:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req()
by Rex-BC Chen (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64861 ) Change subject: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() ...................................................................... Patch Set 3: (1 comment) File src/soc/mediatek/common/include/soc/wdt.h: https://review.coreboot.org/c/coreboot/+/64861/comment/4402fdf6_b1de16e1 PS2, Line 44: void mtk_wdt_set_req(void); > Move it right below mtk_wdt_clr_status to be consistent with common/wdt.c. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d Gerrit-Change-Number: 64861 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 02:37:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req()
by Rex-BC Chen (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Rex-BC Chen. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64861 to look at the new patch set (#3). Change subject: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() ...................................................................... soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() To simplify the calling sequence for mtk_wdt_preinit() and we always adjust request setting in mtk_wdt_preinit(), we rename mtk_wdt_preinit() to mtk_wdt_set_req() and call it in mtk_wdt_init(). From this modification, we can also enable thermal hardware reset feature (CB:64676, CB:64675) in MT8192 and MT8195. BUG=none TEST=build pass Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d --- M src/soc/mediatek/common/include/soc/wdt.h M src/soc/mediatek/common/wdt.c M src/soc/mediatek/mt8186/bootblock.c M src/soc/mediatek/mt8186/wdt.c M src/soc/mediatek/mt8192/wdt.c M src/soc/mediatek/mt8195/wdt.c 6 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/64861/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/64861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d Gerrit-Change-Number: 64861 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req()
by Yidi Lin (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Rex-BC Chen. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64861 ) Change subject: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d Gerrit-Change-Number: 64861 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 02:29:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req()
by Yu-Ping Wu (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Yidi Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64861 ) Change subject: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/soc/mediatek/common/include/soc/wdt.h: https://review.coreboot.org/c/coreboot/+/64861/comment/1d192b15_8b14a257 PS2, Line 44: void mtk_wdt_set_req(void); Move it right below mtk_wdt_clr_status to be consistent with common/wdt.c. -- To view, visit https://review.coreboot.org/c/coreboot/+/64861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d Gerrit-Change-Number: 64861 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 02:25:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Update vboot submodule to upstream main
by Yu-Ping Wu (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Edward O'Callaghan, Julius Werner, Tim Wawrzynczak, Karthik Ramasubramanian. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64706 ) Change subject: Update vboot submodule to upstream main ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id542f555732b58e1205e757393f9d5fdbde2de68 Gerrit-Change-Number: 64706 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 02:22:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req()
by Rex-BC Chen (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64861 ) Change subject: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS1: > If the register definition of `req_mode` and `req_irq_en` and the set value are the same on those pl […] Rename mtk_wdt_preinit() to mtk_wdt_set_req() File src/soc/mediatek/mt8192/bootblock.c: https://review.coreboot.org/c/coreboot/+/64861/comment/a4aa9675_b7b1233c PS1, Line 14: mtk_wdt_preinit(); > Maybe `mtk_wdt_set_req()`? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d Gerrit-Change-Number: 64861 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 02 Jun 2022 02:14:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yidi Lin <yidilin(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req()
by Rex-BC Chen (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Yidi Lin, Rex-BC Chen. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64861 to look at the new patch set (#2). Change subject: soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() ...................................................................... soc/mediatek: Rename mtk_wdt_preinit() to mtk_wdt_set_req() To simplify the calling sequence for mtk_wdt_preinit() and we always adjust request setting in mtk_wdt_preinit(), we rename mtk_wdt_preinit() to mtk_wdt_set_req() and call it in mtk_wdt_init(). From this modification, we can also enable thermal hardware reset feature (CB:64676, CB:64675) in MT8192 and MT8195. BUG=none TEST=build pass Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d --- M src/soc/mediatek/common/include/soc/wdt.h M src/soc/mediatek/common/wdt.c M src/soc/mediatek/mt8186/bootblock.c M src/soc/mediatek/mt8186/wdt.c M src/soc/mediatek/mt8192/wdt.c M src/soc/mediatek/mt8195/wdt.c 6 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/64861/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1904ff9387f7677a077068f2c3df923bd642ea3d Gerrit-Change-Number: 64861 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Update vboot submodule to upstream main
by Edward O'Callaghan (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Edward O'Callaghan, Tim Wawrzynczak, Yu-Ping Wu, Karthik Ramasubramanian. Edward O'Callaghan has uploaded a new patch set (#3) to the change originally created by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/64706 ) Change subject: Update vboot submodule to upstream main ...................................................................... Update vboot submodule to upstream main Updating from commit id 25b94935: vboot_ref/futility: Wrap flashrom_drv behind USE_FLASHROM to commit id 6dba972b: futility: [deferredupdates] Defer setting firmware cookies This brings in 83 new commits. Squash in, util/cbfstool/elogtool.c: Convert args into struct in flashrom helper vboot signatures for flashrom r/w helpers changed in the upstream commit bd2971326ee94fc5. Reflect the change here to allow vboot ref and coreboot to realign. BUG=b:207808292,b:231152447 TEST=builds with vboot_ref uprev. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Change-Id: Id542f555732b58e1205e757393f9d5fdbde2de68 --- M 3rdparty/vboot M util/cbfstool/elogtool.c 2 files changed, 14 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/64706/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/64706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id542f555732b58e1205e757393f9d5fdbde2de68 Gerrit-Change-Number: 64706 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022