Attention is currently required from: Felix Singer, Sean Rhodes, Werner Zeh, Nicholas Chin.
Hello Felix Singer, build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64846
to look at the new patch set (#5).
Change subject: Documentation: Update coreboot 4.17 release notes
......................................................................
Documentation: Update coreboot 4.17 release notes
These are the final release notes before the release. They will be
updated immediately following the release with final numbers and
the commit ids that the release spans.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2
---
M Documentation/releases/coreboot-4.17-relnotes.md
1 file changed, 325 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/64846/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/64846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2
Gerrit-Change-Number: 64846
Gerrit-PatchSet: 5
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Sean Rhodes, Werner Zeh, Nicholas Chin.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64846 )
Change subject: Documentation: Update coreboot 4.17 release notes
......................................................................
Patch Set 4:
(5 comments)
File Documentation/releases/coreboot-4.17-relnotes.md:
https://review.coreboot.org/c/coreboot/+/64846/comment/c1730bde_82687389
PS3, Line 11: successful
> Add a dot.
Done
https://review.coreboot.org/c/coreboot/+/64846/comment/15e6f6b6_d9a5a452
PS3, Line 122:
> nit: Add second empty line
Done
https://review.coreboot.org/c/coreboot/+/64846/comment/751ac858_cf7700c1
PS3, Line 141: (because it is part of another firmware section (IFWI or a different
: CBFS), the CRTM measurement fails.
> I would replace the outer brackets with commas.
Done
https://review.coreboot.org/c/coreboot/+/64846/comment/c80171f1_bb7e0c9a
PS3, Line 246:
> nit: Add second empty line
Done
https://review.coreboot.org/c/coreboot/+/64846/comment/513360ba_97f12db2
PS3, Line 285: linux
> nit: Uppercase L
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/64846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2
Gerrit-Change-Number: 64846
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 22:55:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes, Werner Zeh, Nicholas Chin.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64846 )
Change subject: Documentation: Update coreboot 4.17 release notes
......................................................................
Patch Set 3:
(1 comment)
File Documentation/releases/coreboot-4.17-relnotes.md:
https://review.coreboot.org/c/coreboot/+/64846/comment/927f4275_792ded9f
PS3, Line 30: Star Labs Star Labs
> Ideally: […]
Yes, they're generated from the directory structure.
Fixed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2
Gerrit-Change-Number: 64846
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 22:47:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Werner Zeh, Nicholas Chin.
Hello Felix Singer, build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64846
to look at the new patch set (#4).
Change subject: Documentation: Update coreboot 4.17 release notes
......................................................................
Documentation: Update coreboot 4.17 release notes
These are the final release notes before the release. They will be
updated immediately following the release with final numbers and
the commit ids that the release spans.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2
---
M Documentation/releases/coreboot-4.17-relnotes.md
1 file changed, 322 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/64846/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/64846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2
Gerrit-Change-Number: 64846
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro.
Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64677
to look at the new patch set (#15).
Change subject: soc/intel/adl: Add missing claimed memory regions
......................................................................
soc/intel/adl: Add missing claimed memory regions
The Alder Lake chipset has several more reserved memory regions that
are unavailable to the resource allocator than are currently
marked as such in the system agent code. This CL adds the
following regions:
MMSPI
CRAB_ABORT
TPM
LT_SECURITY
APIC
MMCONF
DSM
TSEG
PMRR
GSM
DPR
BUG=b:149830546
Change-Id: I80df95f9146934d6a2d23e525c22be3a9a7e2b9f
Signed-off-by: Eran Mitrani <mitrani(a)google.com>
---
M src/soc/intel/alderlake/Makefile.inc
M src/soc/intel/alderlake/include/soc/systemagent.h
M src/soc/intel/alderlake/systemagent.c
M src/soc/intel/common/block/include/intelblocks/systemagent.h
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/common/block/systemagent/systemagent_def.h
6 files changed, 261 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/64677/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/64677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80df95f9146934d6a2d23e525c22be3a9a7e2b9f
Gerrit-Change-Number: 64677
Gerrit-PatchSet: 15
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro.
Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64677
to look at the new patch set (#14).
Change subject: soc/intel/adl: Add missing claimed memory regions
......................................................................
soc/intel/adl: Add missing claimed memory regions
This CL adds the missing regions from this list in the bug mentioned
below
The Alder Lake chipset has several more reserved memory regions that
are unavailable to the resource allocator than are currently
marked as such in the system agent code. This CL adds the
following regions:
MMSPI
CRAB_ABORT
TPM
LT_SECURITY
APIC
MMCONF
DSM
TSEG
PMRR
GSM
DPR
BUG=b:149830546
Change-Id: I80df95f9146934d6a2d23e525c22be3a9a7e2b9f
Signed-off-by: Eran Mitrani <mitrani(a)google.com>
---
M src/soc/intel/alderlake/Makefile.inc
M src/soc/intel/alderlake/include/soc/systemagent.h
M src/soc/intel/alderlake/systemagent.c
M src/soc/intel/common/block/include/intelblocks/systemagent.h
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/common/block/systemagent/systemagent_def.h
6 files changed, 261 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/64677/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/64677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80df95f9146934d6a2d23e525c22be3a9a7e2b9f
Gerrit-Change-Number: 64677
Gerrit-PatchSet: 14
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset