Attention is currently required from: Noga Smith, Tarun Tuli, Jamie Ryu, Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Kapil Porwal, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64169 )
Change subject: soc/intel/mtl: Add GPIOs for Meteo Lake SOC ......................................................................
Patch Set 15: Verified+1
(4 comments)
File src/soc/intel/meteorlake/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496): https://review.coreboot.org/c/coreboot/+/64169/comment/05930523_f21b7c0c PS15, Line 79: INTEL_GPP_BASE(GPP_B0, GPP_D0, GPP_BOOTHALT_B, 256, "D"), /* GPP_D */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496): https://review.coreboot.org/c/coreboot/+/64169/comment/96d896d0_63fc853b PS15, Line 79: INTEL_GPP_BASE(GPP_B0, GPP_D0, GPP_BOOTHALT_B, 256, "D"), /* GPP_D */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496): https://review.coreboot.org/c/coreboot/+/64169/comment/be33874c_01bf6495 PS15, Line 80: INTEL_GPP(GPP_B0, GPP_VGPIO0, GPP_VGPIO47, "VGPIO0"), /* GPP_VGPIO0 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496): https://review.coreboot.org/c/coreboot/+/64169/comment/eef88483_10bbd34a PS15, Line 80: INTEL_GPP(GPP_B0, GPP_VGPIO0, GPP_VGPIO47, "VGPIO0"), /* GPP_VGPIO0 */ please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)