Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Paul Menzel, Sugnan Prabhu S, Arec Kao.
Arec has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64415 )
Change subject: mb/google/brya/var/redrix: Configure camera EEPROM power always on
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64415/comment/00508652_74b7a1d4
PS2, Line 8:
> suggestion: add the problem statement here, e.g. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/64415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9efab9bb65632a73c1c2635729c38a2aa14c69b2
Gerrit-Change-Number: 64415
Gerrit-PatchSet: 3
Gerrit-Owner: Arec <arec.kao(a)intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-CC: Arec Kao <arec.kao(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Arec Kao <arec.kao(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 05:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Sumeet R Pawnikar, Vidya Gopalakrishnan.
Vidya Gopalakrishnan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64468 )
Change subject: mb/google/brya/variants/nereid: Add DPTF passive and critical policies for Nereid
......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64468/comment/0b3c2be3_1a8ab30a
PS7, Line 11: Verified thermal throttling successfully when participant reaches temp threshold as per Passive Policy.
> Possible unwrapped commit description (prefer a maximum 72 chars per line)
Please fix.
https://review.coreboot.org/c/coreboot/+/64468/comment/4ff24800_1c7aa49f
PS7, Line 12: Also, verified system shutdown when Temperature of participants are reaching threshold as per Critical policy.
> Possible unwrapped commit description (prefer a maximum 72 chars per line)
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64468
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I195f4b507ee57948751f0119735d8350dfce984b
Gerrit-Change-Number: 64468
Gerrit-PatchSet: 9
Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Jesper Lin <jesper_lin(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 05:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arec, Chen Wisley, Paul Menzel, Sugnan Prabhu S, Arec Kao.
Hello build bot (Jenkins), Chen Wisley, Sugnan Prabhu S, Tim Wawrzynczak, Andy Yeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64415
to look at the new patch set (#3).
Change subject: mb/google/brya/var/redrix: Configure camera EEPROM power always on
......................................................................
mb/google/brya/var/redrix: Configure camera EEPROM power always on
Remove EEPROM power source interconnect with camera power on/off
and keep it always on.
There appears to be a rare case where the camera EEPROM is not
able to be read from. As a workaround, this patch leaves the
EEPROM power rail on in S0.
BUG=b:229049914
TEST=tested the changes with redrix 5MP(ov5675/hi556) camera.
Change-Id: I9efab9bb65632a73c1c2635729c38a2aa14c69b2
Signed-off-by: Arec Kao <arec.kao(a)intel.com>
---
M src/mainboard/google/brya/variants/redrix/gpio.c
M src/mainboard/google/brya/variants/redrix/overridetree.cb
2 files changed, 17 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/64415/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/64415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9efab9bb65632a73c1c2635729c38a2aa14c69b2
Gerrit-Change-Number: 64415
Gerrit-PatchSet: 3
Gerrit-Owner: Arec <arec.kao(a)intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-CC: Arec Kao <arec.kao(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arec <arec.kao(a)intel.com>
Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Arec Kao <arec.kao(a)intel.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Sumeet R Pawnikar, Vidya Gopalakrishnan.
Hello Jesper Lin, build bot (Jenkins), Tim Wawrzynczak, Sumeet R Pawnikar, Vidya Gopalakrishnan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64468
to look at the new patch set (#9).
Change subject: mb/google/brya/variants/nereid: Add DPTF passive and critical policies for Nereid
......................................................................
mb/google/brya/variants/nereid: Add DPTF passive and critical policies for Nereid
BUG=b:233030505
BRANCH=None
TEST=Build FW and test on Nereid board.
Verified thermal throttling successfully when participant reaches temp
threshold as per Passive Policy.
Also, verified system shutdown when Temperature of participants are
reaching threshold as per Critical policy.
Signed-off-by: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Change-Id: I195f4b507ee57948751f0119735d8350dfce984b
---
M src/mainboard/google/brya/variants/nereid/overridetree.cb
1 file changed, 52 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/64468/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/64468
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I195f4b507ee57948751f0119735d8350dfce984b
Gerrit-Change-Number: 64468
Gerrit-PatchSet: 9
Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Jesper Lin <jesper_lin(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Sumeet R Pawnikar, Vidya Gopalakrishnan.
Hello Jesper Lin, build bot (Jenkins), Tim Wawrzynczak, Sumeet R Pawnikar, Vidya Gopalakrishnan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64468
to look at the new patch set (#8).
Change subject: mb/google/brya/variants/nereid: Add DPTF passive and critical policies for Nereid
......................................................................
mb/google/brya/variants/nereid: Add DPTF passive and critical policies for Nereid
BUG=b:233030505
BRANCH=None
TEST=Build FW and test on Nereid board.
Verified thermal throttling successfully when participant reaches temp threshold as per Passive Policy.
Also, verified system shutdown when Temperature of participants are reaching threshold as per Critical policy.
Signed-off-by: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Change-Id: I195f4b507ee57948751f0119735d8350dfce984b
---
M src/mainboard/google/brya/variants/nereid/overridetree.cb
1 file changed, 52 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/64468/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/64468
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I195f4b507ee57948751f0119735d8350dfce984b
Gerrit-Change-Number: 64468
Gerrit-PatchSet: 8
Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Jesper Lin <jesper_lin(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Sumeet R Pawnikar, Vidya Gopalakrishnan.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64472 )
Change subject: soc/intel/alderlake: add power limits for Alder Lake-N SKUs
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/64472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24c18a27a4a2c68c78bc3dc728c45ba04f57205d
Gerrit-Change-Number: 64472
Gerrit-PatchSet: 6
Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 05:15:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Vidya Gopalakrishnan, Sumeet R Pawnikar, Eric Lai.
Hello build bot (Jenkins), Tim Wawrzynczak, Sumeet R Pawnikar, Vidya Gopalakrishnan, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64570
to look at the new patch set (#5).
Change subject: mb/intel/adlrvp: Enable DPTF for ADL-N RVP
......................................................................
mb/intel/adlrvp: Enable DPTF for ADL-N RVP
BUG=None
BRANCH=None
TEST=Build FW and test on adln_rvp board
Verified thermal throttling successfully when participant reaches temp threshold as per Passive Policy.
Verified fan control successfully when participant reaches temp threshold as per Active Policy.
Also, verified system shutdown when Temperature of participants are reaching threshold as per Critical policy.
Signed-off-by: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Change-Id: Icafacfca6a026ec3b42906790831f11fd2f1b085
---
M src/mainboard/intel/adlrvp/devicetree_n.cb
1 file changed, 101 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/64570/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/64570
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafacfca6a026ec3b42906790831f11fd2f1b085
Gerrit-Change-Number: 64570
Gerrit-PatchSet: 5
Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Vidya Gopalakrishnan, Sumeet R Pawnikar, Eric Lai.
Hello build bot (Jenkins), Tim Wawrzynczak, Sumeet R Pawnikar, Vidya Gopalakrishnan, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64570
to look at the new patch set (#4).
Change subject: mb/intel/adlrvp: Enable DPTF for ADL-N RVP
......................................................................
mb/intel/adlrvp: Enable DPTF for ADL-N RVP
BUG=None
BRANCH=None
TEST=Build FW and test on adln_rvp board
Verified thermal throttling successfully when participant reaches temp threshold as per Passive Policy.
Also, verified system shutdown when Temperature of participants are reaching threshold as per Critical policy.
Signed-off-by: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Change-Id: Icafacfca6a026ec3b42906790831f11fd2f1b085
---
M src/mainboard/intel/adlrvp/devicetree_n.cb
1 file changed, 101 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/64570/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/64570
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafacfca6a026ec3b42906790831f11fd2f1b085
Gerrit-Change-Number: 64570
Gerrit-PatchSet: 4
Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Vidya Gopalakrishnan, Sumeet R Pawnikar, Eric Lai.
Vidya Gopalakrishnan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64570 )
Change subject: mb/intel/adlrvp: Enable DPTF for ADL-N RVP
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64570
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafacfca6a026ec3b42906790831f11fd2f1b085
Gerrit-Change-Number: 64570
Gerrit-PatchSet: 3
Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 05:14:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment