coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: Makefile.inc: Add bootblock to CBFS before others
by Arthur Heymans (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Yu-Ping Wu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64547 ) Change subject: Makefile.inc: Add bootblock to CBFS before others ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/64547/comment/c068e757_9cbc2190 PS2, Line 9: cbfstool > The problem is that it still needs to be updated again every time a new CBFS file is added. We want images where even after the coreboot build system is done with them, you can still run `cbfstool add` to put more files in them (e.g. an out-of-tree payload) without breaking the verification chain. I think the only way that can work is if cbfstool knows how to find and update the bootblock in place, wherever it is on each platform. Any thoughts on how to solve this? cbfstool would need to detect whether the bootblock is inside IFWI (Intel) or PSP firmware (AMD) and have capabilities to extract it. -- To view, visit https://review.coreboot.org/c/coreboot/+/64547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I385deb8231e44310ee139c3f69f449e75b92b2be Gerrit-Change-Number: 64547 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 07:12:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "cpu/x86/smm: Remove heap"
by Reka Norman (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Nico Huber, Arthur Heymans, Eric Lai, Kyösti Mälkki, Felix Held. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64853 ) Change subject: Revert "cpu/x86/smm: Remove heap" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Let's find the root cause instead of jumping to reverts. […] No, we don't have any logs. When we try to suspend/reboot/poweroff the kernel finishes cleanly and then it just hangs. We'll try to debug it as soon as possible, but could we please still revert the change in the mean time? Having reboot and S0ix broken on nissa will block a lot of testing and be very disruptive to the program. -- To view, visit https://review.coreboot.org/c/coreboot/+/64853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd782159b43091fff66fe075b77a3dc20d5e6e32 Gerrit-Change-Number: 64853 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 01 Jun 2022 07:02:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "cpu/x86/smm: Remove heap"
by Arthur Heymans (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Nico Huber, Reka Norman, Eric Lai, Kyösti Mälkki, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64853 ) Change subject: Revert "cpu/x86/smm: Remove heap" ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: Let's find the root cause instead of jumping to reverts. Do you have a log? -- To view, visit https://review.coreboot.org/c/coreboot/+/64853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd782159b43091fff66fe075b77a3dc20d5e6e32 Gerrit-Change-Number: 64853 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 01 Jun 2022 06:48:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "cpu/x86/smm: Remove heap"
by Kangheui Won (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Nico Huber, Reka Norman, Arthur Heymans, Eric Lai, Kyösti Mälkki, Felix Held. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64853 ) Change subject: Revert "cpu/x86/smm: Remove heap" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd782159b43091fff66fe075b77a3dc20d5e6e32 Gerrit-Change-Number: 64853 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 01 Jun 2022 06:43:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/nereid: Add DPTF passive and critical policie...
by Sumeet R Pawnikar (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Tim Wawrzynczak, Vidya Gopalakrishnan. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64468 ) Change subject: mb/google/brya/variants/nereid: Add DPTF passive and critical policies for Nereid ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I195f4b507ee57948751f0119735d8350dfce984b Gerrit-Change-Number: 64468 Gerrit-PatchSet: 9 Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jesper Lin <jesper_lin(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 06:34:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Remove heap
by Reka Norman (Code Review) 01 Jun '22

01 Jun '22

Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64521 ) Change subject: cpu/x86/smm: Remove heap ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Somehow this CL broken the s0xi on ADL-N. Created a revert here to unblock nissa while we debug this: CB:64853 -- To view, visit https://review.coreboot.org/c/coreboot/+/64521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70cd822be17c1efe13c94a9dbd2e1038808b9c56 Gerrit-Change-Number: 64521 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 06:31:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Enable DPTF for ADL-N RVP
by Sumeet R Pawnikar (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Tim Wawrzynczak, Vidya Gopalakrishnan, Eric Lai. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64570 ) Change subject: mb/intel/adlrvp: Enable DPTF for ADL-N RVP ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64570 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icafacfca6a026ec3b42906790831f11fd2f1b085 Gerrit-Change-Number: 64570 Gerrit-PatchSet: 5 Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 06:28:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Set power limits dynamically for ADL-N SKUs
by Sumeet R Pawnikar (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Tim Wawrzynczak, Vidya Gopalakrishnan. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64569 ) Change subject: mb/intel/adlrvp: Set power limits dynamically for ADL-N SKUs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie49398b8a7de8d8cff3536eae6a5e893980f9c26 Gerrit-Change-Number: 64569 Gerrit-PatchSet: 3 Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 06:28:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "cpu/x86/smm: Remove heap"
by Reka Norman (Code Review) 01 Jun '22

01 Jun '22

Reka Norman has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64853 ) Change subject: Revert "cpu/x86/smm: Remove heap" ...................................................................... Revert "cpu/x86/smm: Remove heap" This reverts commit ea2c1d357cccf4ee84473d304c880250fbd97080. This change breaks S0ix, reboot and poweroff on nissa (ADL-N). Revert it while we try to figure out why. BUG=b:234398643 TEST=S0ix works on nivviks Signed-off-by: Reka Norman <rekanorman(a)chromium.org> Change-Id: Icd782159b43091fff66fe075b77a3dc20d5e6e32 --- M src/cpu/x86/Kconfig M src/cpu/x86/smm/Makefile.inc M src/lib/Makefile.inc 3 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/64853/1 diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig index 5b92795..4db6c36 100644 --- a/src/cpu/x86/Kconfig +++ b/src/cpu/x86/Kconfig @@ -136,6 +136,13 @@ if HAVE_SMI_HANDLER && !SMM_LEGACY_ASEG +config SMM_MODULE_HEAP_SIZE + hex + default 0x4000 + help + This option determines the size of the heap within the SMM handler + modules. + config SMM_MODULE_STACK_SIZE hex default 0x800 if ARCH_RAMSTAGE_X86_64 diff --git a/src/cpu/x86/smm/Makefile.inc b/src/cpu/x86/smm/Makefile.inc index 5f69590..cd920da 100644 --- a/src/cpu/x86/smm/Makefile.inc +++ b/src/cpu/x86/smm/Makefile.inc @@ -67,9 +67,9 @@ # C-based SMM handler. ifeq ($(CONFIG_ARCH_RAMSTAGE_X86_32),y) -$(eval $(call rmodule_link,$(obj)/smm/smm.elf, $(obj)/smm/smm.o, 0,x86_32)) +$(eval $(call rmodule_link,$(obj)/smm/smm.elf, $(obj)/smm/smm.o, $(CONFIG_SMM_MODULE_HEAP_SIZE),x86_32)) else -$(eval $(call rmodule_link,$(obj)/smm/smm.elf, $(obj)/smm/smm.o, 0,x86_64)) +$(eval $(call rmodule_link,$(obj)/smm/smm.elf, $(obj)/smm/smm.o, $(CONFIG_SMM_MODULE_HEAP_SIZE),x86_64)) endif $(obj)/smm/smm: $(obj)/smm/smm.elf.rmod diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 68a2960..505dc46 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -215,6 +215,7 @@ ramstage-y += boot_device.c smm-y += boot_device.c +smm-y += malloc.c smm-y += delay.c smm-y += fmap.c smm-y += cbfs.c memcmp.c -- To view, visit https://review.coreboot.org/c/coreboot/+/64853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd782159b43091fff66fe075b77a3dc20d5e6e32 Gerrit-Change-Number: 64853 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/alderlake: add power limits for Alder Lake-N SKUs
by Sumeet R Pawnikar (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Tim Wawrzynczak, Vidya Gopalakrishnan. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64472 ) Change subject: soc/intel/alderlake: add power limits for Alder Lake-N SKUs ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24c18a27a4a2c68c78bc3dc728c45ba04f57205d Gerrit-Change-Number: 64472 Gerrit-PatchSet: 6 Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 06:27:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022