coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: mainboard/msi/ms7d25: Add default vboot configuration
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Żygowski. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64222 ) Change subject: mainboard/msi/ms7d25: Add default vboot configuration ...................................................................... Patch Set 6: Verified-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9590a33e828906de083cb23c8b647ed2da0750ee Gerrit-Change-Number: 64222 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 10:00:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/mrc_cache: Do not verify TPM MRC hash if secdata is mocked
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Żygowski. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64221 ) Change subject: drivers/mrc_cache: Do not verify TPM MRC hash if secdata is mocked ...................................................................... Patch Set 6: Verified-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0cf04b129fe1c5e94cd8a803bb21aa350c3f8da Gerrit-Change-Number: 64221 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 09:59:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/nissa/var/craask: Generate SPD ID for supported memory part
by Tyler Wang (Code Review) 01 Jun '22

01 Jun '22

Tyler Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64858 ) Change subject: mb/google/nissa/var/craask: Generate SPD ID for supported memory part ...................................................................... mb/google/nissa/var/craask: Generate SPD ID for supported memory part Add supported memory parts in mem_parts_used.txt, and generate SPD id for this part. K3LKBKB0BM-MGCP H9JCNNNCP3MLYR-N6E BUG=b:229938024 TEST=emerge-nissa coreboot Change-Id: I5f6d1b1b988468d0918df20a34a3145af30a65d2 --- M src/mainboard/google/brya/variants/craask/memory/Makefile.inc M src/mainboard/google/brya/variants/craask/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/craask/memory/mem_parts_used.txt 3 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/64858/1 diff --git a/src/mainboard/google/brya/variants/craask/memory/Makefile.inc b/src/mainboard/google/brya/variants/craask/memory/Makefile.inc index ce6db23..f6b4736 100644 --- a/src/mainboard/google/brya/variants/craask/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/craask/memory/Makefile.inc @@ -4,6 +4,7 @@ # util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/craask/memory src/mainboard/google/brya/variants/craask/memory/mem_parts_used.txt SPD_SOURCES = -SPD_SOURCES += spd/lp5/set-0/spd-2.hex # ID = 0(0b0000) Parts = MT62F1G32D4DR-031 WT:B +SPD_SOURCES += spd/lp5/set-0/spd-2.hex # ID = 0(0b0000) Parts = MT62F1G32D4DR-031 WT:B, H9JCNNNCP3MLYR-N6E SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 1(0b0001) Parts = MT62F512M32D2DR-031 WT:B, H9JCNNNBK3MLYR-N6E SPD_SOURCES += spd/lp5/set-0/spd-5.hex # ID = 2(0b0010) Parts = K3LKLKL0EM-MGCN +SPD_SOURCES += spd/lp5/set-0/spd-3.hex # ID = 2(0b0010) Parts = K3LKBKB0BM-MGCP diff --git a/src/mainboard/google/brya/variants/craask/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/craask/memory/dram_id.generated.txt index ecce170..323cf19 100644 --- a/src/mainboard/google/brya/variants/craask/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/craask/memory/dram_id.generated.txt @@ -8,3 +8,5 @@ MT62F512M32D2DR-031 WT:B 1 (0001) H9JCNNNBK3MLYR-N6E 1 (0001) K3LKLKL0EM-MGCN 2 (0010) +K3LKBKB0BM-MGCP 2 (0010) +H9JCNNNCP3MLYR-N6E 0 (0000) diff --git a/src/mainboard/google/brya/variants/craask/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/craask/memory/mem_parts_used.txt index 58c6996..a3368e9 100644 --- a/src/mainboard/google/brya/variants/craask/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/craask/memory/mem_parts_used.txt @@ -13,3 +13,5 @@ MT62F512M32D2DR-031 WT:B H9JCNNNBK3MLYR-N6E K3LKLKL0EM-MGCN +K3LKBKB0BM-MGCP +H9JCNNNCP3MLYR-N6E -- To view, visit https://review.coreboot.org/c/coreboot/+/64858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f6d1b1b988468d0918df20a34a3145af30a65d2 Gerrit-Change-Number: 64858 Gerrit-PatchSet: 1 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/crb: Add SMBIOS hook to generate type 43 TPM Device
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Christian Walter. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64049 ) Change subject: drivers/crb: Add SMBIOS hook to generate type 43 TPM Device ...................................................................... Patch Set 5: Verified-1 (1 comment) File src/drivers/crb/tis.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150221): https://review.coreboot.org/c/coreboot/+/64049/comment/2c7c35bf_c835ed35 PS5, Line 211: #endif trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/64049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05289f98969bd431017aff1aa77be5806d6f1838 Gerrit-Change-Number: 64049 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 09:58:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: smbios: Add API to generate SMBIOS type 43 TPM Device
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Żygowski. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64048 ) Change subject: smbios: Add API to generate SMBIOS type 43 TPM Device ...................................................................... Patch Set 5: Verified-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2db29f8bc4cfbc6648bb2cabad074d9ea583ca9 Gerrit-Change-Number: 64048 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 09:58:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/crb: Initialize Intel PTT control area
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Żygowski. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63957 ) Change subject: drivers/crb: Initialize Intel PTT control area ...................................................................... Patch Set 6: Verified-1 (2 comments) File src/drivers/crb/tpm.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150219): https://review.coreboot.org/c/coreboot/+/63957/comment/567c452b_260d416a PS6, Line 205: * some precious miliseconds which would be wasted in crb_activate_locality polling 'miliseconds' may be misspelled - perhaps 'milliseconds'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150219): https://review.coreboot.org/c/coreboot/+/63957/comment/405c1350_f61de752 PS6, Line 264: * Initialize CRB adresses and sizes for PTT. It seems to be possible 'adresses' may be misspelled - perhaps 'addresses'? -- To view, visit https://review.coreboot.org/c/coreboot/+/63957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8e473ecc1a520851d6d48ccad9da35c6f91005d Gerrit-Change-Number: 63957 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 09:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/ptt: Use the correct detection method
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Żygowski. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63956 ) Change subject: drivers/intel/ptt: Use the correct detection method ...................................................................... Patch Set 6: Verified-1 (1 comment) File src/security/intel/txt/txt_register.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150218): https://review.coreboot.org/c/coreboot/+/63956/comment/d5335506_6d2dfc6f PS6, Line 98: #define TXT_STS_FTIF (TXT_BASE + 0x800) trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/63956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a55c9f38f5bb94fb1186592446a28e675c1207c Gerrit-Change-Number: 63956 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 09:57:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake/iomap: Correct the ADL-S reserved range
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63929 ) Change subject: soc/intel/alderlake/iomap: Correct the ADL-S reserved range ...................................................................... Patch Set 6: Verified-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b1f79cc351de422acf182c27870c29dbe57fe4a Gerrit-Change-Number: 63929 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 09:56:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: superio/nuvoton/nct6687d: Add ramstage driver and ACPI
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63927 ) Change subject: superio/nuvoton/nct6687d: Add ramstage driver and ACPI ...................................................................... Patch Set 5: Verified-1 (2 comments) File src/superio/nuvoton/nct6687d/superio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150215): https://review.coreboot.org/c/coreboot/+/63927/comment/c5cf5b74_3ae1d550 PS5, Line 42: printk(BIOS_INFO, "set power %s after power fail\n", power_status ? "on" : "off"); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150215): https://review.coreboot.org/c/coreboot/+/63927/comment/1754979a_5828dfa6 PS5, Line 60: { NULL, NCT6687D_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1 | PNP_MSC0, trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/63927 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia489a39956c1448c7f11845ecc9e1df83ccb25ff Gerrit-Change-Number: 63927 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 01 Jun 2022 09:56:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake/vr_config.c: Add VR params for ADL-S
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63840 ) Change subject: soc/intel/alderlake/vr_config.c: Add VR params for ADL-S ...................................................................... Patch Set 6: Verified-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib50db521e4d127a773f903b45d4bec5c5cc180d4 Gerrit-Change-Number: 63840 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 09:55:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022