Attention is currently required from: Nico Huber, Reka Norman, Arthur Heymans, Eric Lai, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64853 )
Change subject: Revert "cpu/x86/smm: Remove heap"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> > No, we don't have any logs. […]
Do you have CB:63475 in your build?
--
To view, visit https://review.coreboot.org/c/coreboot/+/64853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd782159b43091fff66fe075b77a3dc20d5e6e32
Gerrit-Change-Number: 64853
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 01 Jun 2022 10:22:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Igor Bagnucki, Michał Kopeć.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63463 )
Change subject: mainboard/msi/ms7d25: Add early support for MSI PRO Z690-A DDR4 WIFI
......................................................................
Patch Set 10:
(5 comments)
File src/mainboard/msi/ms7d25/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/63463/comment/a59eb0a4_8374e2e3
PS10, Line 11: /* OEM revision */
It's not the OEM revision, this is just copy-pasta. Please drop the comment.
File src/mainboard/msi/ms7d25/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/63463/comment/95a6cd02_2469dc85
PS10, Line 14: .resistor = 100,
Seems OK.
https://review.coreboot.org/c/coreboot/+/63463/comment/24d95ef2_4184b2ae
PS10, Line 17: 50, 20, 25, 25, 25
I think this should be `40, 30, 33, 33, 30`. If you have access to FSP sources, grep for `RcompTargetHDdr4`.
https://review.coreboot.org/c/coreboot/+/63463/comment/528eec53_3b190bae
PS10, Line 20: .ect = true, /* Early Command Training */
I think this doesn't do anything on DDR4. At least, it doesn't on SKL/KBL/CFL.
https://review.coreboot.org/c/coreboot/+/63463/comment/7854c1c7_3df2488c
PS10, Line 24: .LpDdrDqDqsReTraining = 1,
This shouldn't be needed with DDR4
--
To view, visit https://review.coreboot.org/c/coreboot/+/63463
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5df69822dbb3ff79e087408a0693de37df2142e8
Gerrit-Change-Number: 63463
Gerrit-PatchSet: 10
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 10:15:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Tim Wawrzynczak.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63467 )
Change subject: soc/intel/alderlake: add GPIO definitions for PCH-S
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/alderlake/include/soc/gpio_soc_defs_pch_s.h:
https://review.coreboot.org/c/coreboot/+/63467/comment/0cb55e7b_7c8483c5
PS11, Line 485: INC(GPP_D2)
> INC(GPP_D20)
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63467
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fd1dc645c19c33bf14424703f966271e884ed3d
Gerrit-Change-Number: 63467
Gerrit-PatchSet: 14
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 10:13:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63499 )
Change subject: mb/msi/ms7d25: add basic FSP configuration in devicetree
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/msi/ms7d25/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63499/comment/705cd972_c72f78fe
PS7, Line 12: OC_SKIP
> Also we need to pass OC pins
Already done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff227c70d0155ac27d6ffa50a069d154bb7fce3c
Gerrit-Change-Number: 63499
Gerrit-PatchSet: 15
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 10:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Tim Wawrzynczak, Zhuohao Lee, Felix Held.
Hello build bot (Jenkins), YH Lin, Tim Wawrzynczak, Zhuohao Lee, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64819
to look at the new patch set (#7).
Change subject: mb/google/brask/variants/moli: correct ddi_ports_config
......................................................................
mb/google/brask/variants/moli: correct ddi_ports_config
1. enable DDI_PORT_1, DDI_PORT_3 hot plug detection
2. remove DDI_ENABLE_DDC for Port 2.
BUG=b:234521799
TEST=emerge-brask coreboot.
Signed-off-by: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Change-Id: I1354b82d881ebd838c310b32ae28ac2628ab8c9e
---
M src/mainboard/google/brya/variants/moli/overridetree.cb
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/64819/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/64819
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1354b82d881ebd838c310b32ae28ac2628ab8c9e
Gerrit-Change-Number: 64819
Gerrit-PatchSet: 7
Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Michał Żygowski, Subrata Banik.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63493 )
Change subject: soc/intel/alderlake: add chipset devicetree for ADL-S
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/alderlake/chipset_pch_s.cb:
https://review.coreboot.org/c/coreboot/+/63493/comment/f2ba5325_fe3629bb
PS8, Line 84: 2.10
> This is hex, should be 2. […]
Already done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63493
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1dd72465c458b718ecfcb29c2f7e433a63b89807
Gerrit-Change-Number: 63493
Gerrit-PatchSet: 14
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 10:11:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: comment