coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6166 discussions

Change in coreboot[master]: arch/x86: Add support for catching null dereferences through debug regs
by Robert Zieba (Code Review) 03 May '22

03 May '22

Attention is currently required from: Robert Zieba, Raul Rangel, Nico Huber, Paul Menzel, Angel Pons, Arthur Heymans, Tim Wawrzynczak, Kyösti Mälkki, Karthik Ramasubramanian. Hello build bot (Jenkins), Nico Huber, Raul Rangel, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Tim Wawrzynczak, Kyösti Mälkki, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63657 to look at the new patch set (#12). Change subject: arch/x86: Add support for catching null dereferences through debug regs ...................................................................... arch/x86: Add support for catching null dereferences through debug regs This commit adds support for catching null dereferences and execution through x86's debug registers. This is particularly useful when running 32-bit coreboot as paging is not enabled to catch these through page faults. This commit adds three new configs to support this feature: DEBUG_HW_BREAKPOINTS, DEBUG_NULL_DEREF_BREAKPOINTS and DEBUG_NULL_DEREF_HALT. BUG=b:223902046 TEST=Ran on nipperkin device, verifying that HW breakpoints work as expected. Change-Id: I113590689046a13c2a552741bbfe7668a834354a Signed-off-by: Robert Zieba <robertzieba(a)google.com> --- M src/arch/x86/Kconfig M src/arch/x86/Makefile.inc A src/arch/x86/breakpoint.c M src/arch/x86/exception.c A src/arch/x86/include/arch/breakpoint.h A src/arch/x86/include/arch/null_breakpoint.h A src/arch/x86/null_breakpoint.c 7 files changed, 454 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/63657/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/63657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I113590689046a13c2a552741bbfe7668a834354a Gerrit-Change-Number: 63657 Gerrit-PatchSet: 12 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in qc_blobs[master]: sc7180/boot: Update qclib blobs binaries from 37 to 42
by Julius Werner (Code Review) 03 May '22

03 May '22

Julius Werner has submitted this change. ( https://review.coreboot.org/c/qc_blobs/+/63958 ) Change subject: sc7180/boot: Update qclib blobs binaries from 37 to 42 ...................................................................... sc7180/boot: Update qclib blobs binaries from 37 to 42 TEST=Validated on qualcomm sc7180 development board Signed-off-by: Sudheer Kumar Amrabadi <samrabad(a)codeaurora.org> Change-Id: Ib419b72733d8a4829d70632f537d3de87c72f7d2 --- M sc7180/boot/QcLib.elf M sc7180/boot/Release_Notes.txt 2 files changed, 23 insertions(+), 0 deletions(-) Approvals: Julius Werner: Verified; Looks good to me, approved diff --git a/sc7180/boot/QcLib.elf b/sc7180/boot/QcLib.elf index bfa4235..ee03d68 100644 --- a/sc7180/boot/QcLib.elf +++ b/sc7180/boot/QcLib.elf Binary files differ diff --git a/sc7180/boot/Release_Notes.txt b/sc7180/boot/Release_Notes.txt index 536a937..215c38a 100644 --- a/sc7180/boot/Release_Notes.txt +++ b/sc7180/boot/Release_Notes.txt @@ -1,3 +1,26 @@ +=================== Release 00042 ================================ +This Release Notes file covers these blobs: + * QcLib.elf + * dcb.bin + +Version : 00042 + +Release Date : Apr, 2022 + +Supported Silicon : SC7180 + +No special instructions, requirements or dependencies, files must be +present in this folder to be pulled in during coreboot build + +Changes since last version : + * Basetools to update for python3 + +Errata : Nothing to report + +Toolchain Version : LLVM 12.0.0 + +ABI Info : see qclib-interface.txt + =================== Release 00037 ================================ This Release Notes file covers these blobs: * QcLib.elf -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: Ib419b72733d8a4829d70632f537d3de87c72f7d2 Gerrit-Change-Number: 63958 Gerrit-PatchSet: 1 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: merged

1 0

Change in qc_blobs[master]: sc7180/boot: Update qclib blobs binaries from 37 to 42
by Julius Werner (Code Review) 03 May '22

03 May '22

Attention is currently required from: Sudheer Amrabadi. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/63958 ) Change subject: sc7180/boot: Update qclib blobs binaries from 37 to 42 ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: Ib419b72733d8a4829d70632f537d3de87c72f7d2 Gerrit-Change-Number: 63958 Gerrit-PatchSet: 1 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Tue, 03 May 2022 23:23:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/usb4: Add Type-C port device attachment check
by John Zhao (Code Review) 03 May '22

03 May '22

Attention is currently required from: Name of user not set #1002003, Tim Wawrzynczak, Paul Menzel, John Zhao, Rajmohan Mani. John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63848 ) Change subject: drivers/intel/usb4: Add Type-C port device attachment check ...................................................................... Patch Set 8: (1 comment) File src/drivers/intel/usb4/retimer/retimer.c: https://review.coreboot.org/c/coreboot/+/63848/comment/8a3a4193_c0b7d917 PS8, Line 71: acpigen_disable_tx_gpio(power_gpio); > This GPIO was already disabled on line 40, and I don't see anything different happening to it since […] This GPIO was disabled on line 40 while EC reports error. CB would return -1 to OS and exit which is exclusive here. -- To view, visit https://review.coreboot.org/c/coreboot/+/63848 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5392d0d3a947dbf172cadfe03fc708f6e2e87210 Gerrit-Change-Number: 63848 Gerrit-PatchSet: 8 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Name of user not set #1002003 Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: John Zhao <jzhao80(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Name of user not set #1002003 Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Comment-Date: Tue, 03 May 2022 21:15:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: provide a list of D-states to enter LPM
by Tarun Tuli (Code Review) 03 May '22

03 May '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 ) Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM ...................................................................... Patch Set 18: (4 comments) File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/63969/comment/3ca46d5d_004ef9bb PS14, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; } > nit: move after line 1483? Ack File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/63969/comment/98aafe65_c2d19eb7 PS17, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; } > > Another option is the weak implementation does the single device/dummy entry creation and that get […] In patchset 18 File src/soc/intel/alderlake/acpi.c: https://review.coreboot.org/c/coreboot/+/63969/comment/c6127cb7_9446f5de PS13, Line 440: if (dev && dev->enabled) { : switch (dev->path.type) { : case DEVICE_PATH_PCI: : return (min_pci_d_states[dev->path.pci.devfn] != UNDEF); : : case DEVICE_PATH_APIC: : return true; : : default: : return false; : } : } : return false; > I believe we would still want to add a check in here that the entry we're interested in actually exi […] Ack File src/soc/intel/common/block/acpi/pep.c: https://review.coreboot.org/c/coreboot/+/63969/comment/0edde040_91acacb4 PS17, Line 74: { > nit: brace goes to previous line Ack. No longer relevant with latest patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/63969 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437 Gerrit-Change-Number: 63969 Gerrit-PatchSet: 18 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 03 May 2022 21:08:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: provide a list of D-states to enter LPM
by Tarun Tuli (Code Review) 03 May '22

03 May '22

Attention is currently required from: Tarun Tuli, Angel Pons. Hello Lance Zhao, build bot (Jenkins), Subrata Banik, Matt DeVillier, Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63969 to look at the new patch set (#18). Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM ...................................................................... soc/intel/alderlake: provide a list of D-states to enter LPM Implement sub-function 1 (Get Device Constraints) of the Low Power S0 Idle Device-Specific Method (_DSM). This provides a way in which to describe various devices required D-states to enter LPM (S0ix). The information can be used to help in diagnostics and understanding of S0ix entry failure. This implementation adds support for ADL. Other SoC's could be ported to be included as well. If they aren't, they will default to the existing behavior of a single hardcoded device to ensure compatibility with Windows. TEST=Built and tested on brya by verifying SSDT contents Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437 Signed-off-by: Tarun Tuli <taruntuli(a)google.com> --- M src/include/acpi/acpi.h M src/soc/intel/alderlake/acpi.c M src/soc/intel/common/block/acpi/pep.c 3 files changed, 177 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/63969/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/63969 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437 Gerrit-Change-Number: 63969 Gerrit-PatchSet: 18 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/usb4: Add Type-C port device attachment check
by Tim Wawrzynczak (Code Review) 03 May '22

03 May '22

Attention is currently required from: Name of user not set #1002003, Paul Menzel, John Zhao, Rajmohan Mani. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63848 ) Change subject: drivers/intel/usb4: Add Type-C port device attachment check ...................................................................... Patch Set 8: (1 comment) File src/drivers/intel/usb4/retimer/retimer.c: https://review.coreboot.org/c/coreboot/+/63848/comment/ca865a21_4d8f9ffa PS8, Line 71: acpigen_disable_tx_gpio(power_gpio); This GPIO was already disabled on line 40, and I don't see anything different happening to it since then, does it need to be disabled again? -- To view, visit https://review.coreboot.org/c/coreboot/+/63848 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5392d0d3a947dbf172cadfe03fc708f6e2e87210 Gerrit-Change-Number: 63848 Gerrit-PatchSet: 8 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Name of user not set #1002003 Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: John Zhao <jzhao80(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Name of user not set #1002003 Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Comment-Date: Tue, 03 May 2022 20:30:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google: Add support for ARTG method
by Tim Wawrzynczak (Code Review) 03 May '22

03 May '22

Attention is currently required from: Varshit B Pandya, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63949 ) Change subject: ec/google: Add support for ARTG method ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/acpi/emem.asl: https://review.coreboot.org/c/coreboot/+/63949/comment/ff27b150_ce6345b5 PS2, Line 52: ARTG, 16, // Adapter Rating where is the corresponding EC CL? -- To view, visit https://review.coreboot.org/c/coreboot/+/63949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I501ce59fd9e7f39d8b68f7e757b953ec7fb7f072 Gerrit-Change-Number: 63949 Gerrit-PatchSet: 2 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 03 May 2022 20:13:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Configure PROP value for brya
by Tim Wawrzynczak (Code Review) 03 May '22

03 May '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Rizwan Qureshi, Sumeet R Pawnikar. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63698 ) Change subject: mb/google/brya: Configure PROP value for brya ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/brya/variants/brya0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/63698/comment/411c2734_71bbd11e PS6, Line 198: 20000 where did this number come from? -- To view, visit https://review.coreboot.org/c/coreboot/+/63698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id39c1e7bf35b537fca0b97bfe77b2ae3c3cf4ecc Gerrit-Change-Number: 63698 Gerrit-PatchSet: 6 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Tue, 03 May 2022 20:12:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: add fan speed rpm control
by Tim Wawrzynczak (Code Review) 03 May '22

03 May '22

Attention is currently required from: Paul Menzel, Sumeet R Pawnikar, Eric Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62789 ) Change subject: ec/google/chromeec: add fan speed rpm control ...................................................................... Patch Set 4: (2 comments) File src/ec/google/chromeec/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/62789/comment/3ce6556f_be05bafd PS3, Line 85: CFSP, 16, // Set Fan speed in rpm > If required, we might update EC offset later for the conflict with this above CL (if this will get m […] Can Active 2 Policy support more than 1 fan? File src/ec/google/chromeec/ec_dptf_helpers.c: https://review.coreboot.org/c/coreboot/+/62789/comment/1d8a9a51_58d1e3c7 PS4, Line 112: acpigen_write_store(); : acpigen_emit_namestring(acpi_device_path_join(ec, "CFSP")); : acpigen_emit_byte(INDEX_OP); : acpigen_emit_namestring("TFST"); : acpigen_write_integer(2); : acpigen_emit_byte(ZERO_OP); : acpigen_emit_byte(RETURN_OP); The current version of https://crrev.com/c/3533300 does not support writing to this value -- To view, visit https://review.coreboot.org/c/coreboot/+/62789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb1646b1fb1659fd853ece97d97bb9dee2a3f57e Gerrit-Change-Number: 62789 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 03 May 2022 20:07:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022