coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6164 discussions

Change in coreboot[master]: mb/google/brask/variants/moli: fix tcss_usb3 port
by Casper Chang (Code Review) 03 May '22

03 May '22

Attention is currently required from: Tim Wawrzynczak. Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64039 ) Change subject: mb/google/brask/variants/moli: fix tcss_usb3 port ...................................................................... mb/google/brask/variants/moli: fix tcss_usb3 port fix tcss_usb3_port to meet Moli's proto schematic design. BUG=b:220814038 TEST=emerge-brask coreboot, Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Change-Id: Ib8faa4a353d8d617fce7aa70922bf027e6e11b38 --- M src/mainboard/google/brya/variants/moli/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/64039/1 diff --git a/src/mainboard/google/brya/variants/moli/overridetree.cb b/src/mainboard/google/brya/variants/moli/overridetree.cb index 944bb1c..2c859f9 100644 --- a/src/mainboard/google/brya/variants/moli/overridetree.cb +++ b/src/mainboard/google/brya/variants/moli/overridetree.cb @@ -162,7 +162,7 @@ register "desc" = ""USB3 Type-C Port C2 (MLB)"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "custom_pld" = "ACPI_PLD_TYPE_C(FRONT, RIGHT, ACPI_PLD_GROUP(2, 1))" - device ref tcss_usb3_port2 on end + device ref tcss_usb3_port3 on end end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/64039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8faa4a353d8d617fce7aa70922bf027e6e11b38 Gerrit-Change-Number: 64039 Gerrit-PatchSet: 1 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: enable BT offload
by Casper Chang (Code Review) 03 May '22

03 May '22

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64020 to look at the new patch set (#3). Change subject: mb/google/brask/variants/moli: enable BT offload ...................................................................... mb/google/brask/variants/moli: enable BT offload Enable BT offload of NAU88L25B on Moli with fw_config NAU88L25B_I2S. BUG=b:220814038 TEST=emerge-brask coreboot, Check BT offload enabled in CPU log and audio works. Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Change-Id: I72d91d2dafffa7d9604b7dd3d697cb3b2b04b152 --- M src/mainboard/google/brya/variants/moli/Makefile.inc A src/mainboard/google/brya/variants/moli/fw_config.c M src/mainboard/google/brya/variants/moli/overridetree.cb A src/mainboard/google/brya/variants/moli/variant.c 4 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/64020/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/64020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72d91d2dafffa7d9604b7dd3d697cb3b2b04b152 Gerrit-Change-Number: 64020 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Change the power-down time slot from 0xA to 0xF
by Rex-BC Chen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64038 ) Change subject: soc/mediatek/mt8186: Change the power-down time slot from 0xA to 0xF ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Hung-Te and Yu-Ping, I think we can review the commit message and driver first. -- To view, visit https://review.coreboot.org/c/coreboot/+/64038 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I537fe87740f0f8c25b923d7d536e81503b71762b Gerrit-Change-Number: 64038 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 04 May 2022 02:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Change the power-down time slot from 0xA to 0xF
by Rex-BC Chen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64038 ) Change subject: soc/mediatek/mt8186: Change the power-down time slot from 0xA to 0xF ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: wait for testing. -- To view, visit https://review.coreboot.org/c/coreboot/+/64038 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I537fe87740f0f8c25b923d7d536e81503b71762b Gerrit-Change-Number: 64038 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Wed, 04 May 2022 02:49:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Change the power-down time slot from 0xA to 0xF
by Rex-BC Chen (Code Review) 03 May '22

03 May '22

Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64038 ) Change subject: soc/mediatek/mt8186: Change the power-down time slot from 0xA to 0xF ...................................................................... soc/mediatek/mt8186: Change the power-down time slot from 0xA to 0xF We encountered a delay issue when powering down. The root cause is the incorrect setting for delay time. The meaning of PMIC_CPSDSA4[4:0] is: power down at specified time slot. If PMIC_CPSDSA4[4:0] is 0xA, in this time slot, it cause delay 20ms comparing with 0xF. To resolve this issue, we need to change to correct time slot. Therefore, we change the value from 0xA to 0xF. This modification is based on chapter 3.7 in the MT8186 functional specification. BUG=b:218630683, b:218630684 TEST=the power-off waveform is correct. Signed-off-by: zhiyong tao <zhiyong.tao(a)mediatek.corp-partner.google.com> Change-Id: I537fe87740f0f8c25b923d7d536e81503b71762b --- M src/soc/mediatek/mt8186/mt6366.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/64038/1 diff --git a/src/soc/mediatek/mt8186/mt6366.c b/src/soc/mediatek/mt8186/mt6366.c index 8dd2997..af5403a 100644 --- a/src/soc/mediatek/mt8186/mt6366.c +++ b/src/soc/mediatek/mt8186/mt6366.c @@ -807,8 +807,8 @@ static void wk_power_down_seq(void) { mt6366_protect_control(false); - /* Set VPROC12 sequence to VA12 */ - pwrap_write_field(PMIC_CPSDSA4, 0xA, 0x1F, 0); + /* Set VPROC12 power-down time slot to 0xF to avoid 20ms delay */ + pwrap_write_field(PMIC_CPSDSA4, 0xF, 0x1F, 0); mt6366_protect_control(true); } -- To view, visit https://review.coreboot.org/c/coreboot/+/64038 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I537fe87740f0f8c25b923d7d536e81503b71762b Gerrit-Change-Number: 64038 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: enable BT offload
by Casper Chang (Code Review) 03 May '22

03 May '22

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64020 ) Change subject: mb/google/brask/variants/moli: enable BT offload ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/64020/comment/77aae759_7bb69b0b PS1, Line 7: on Moli > Already in prefix. Done https://review.coreboot.org/c/coreboot/+/64020/comment/24d03923_19296bd3 PS1, Line 9: Enable BT offload on moli > Mention fw_config, NAU88L25B, and what needs to be done to hook them up. Done https://review.coreboot.org/c/coreboot/+/64020/comment/ffbca971_b7fdf900 PS1, Line 12: TEST=emerge-brask coreboot. Check BT offload enabled and audio works. > How can this be checked in the OS? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72d91d2dafffa7d9604b7dd3d697cb3b2b04b152 Gerrit-Change-Number: 64020 Gerrit-PatchSet: 2 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 04 May 2022 02:34:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/mtl: Do initial Meteor Lake SoC commit till bootblock
by Ravishankar Sarawadi (Code Review) 03 May '22

03 May '22

Attention is currently required from: Felix Singer, Jamie Ryu, Subrata Banik, Wonkyu Kim, Ethan Tsao, Tim Wawrzynczak, Paul Menzel, Angel Pons, Raj Astekar, Ravishankar Sarawadi. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62772 ) Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till bootblock ...................................................................... Patch Set 13: (1 comment) Patchset: PS4: > > SOC incremental code is WIP, I will update asap. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62772 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26479fcc3a3f9c6f8ebf5f198ab0809f0b4a2cc4 Gerrit-Change-Number: 62772 Gerrit-PatchSet: 13 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ethan Tsao <ethan.tsao(a)intel.corp-partner.google.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 May 2022 02:15:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Comment-In-Reply-To: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/crota: Enable Bluetooth offload support
by Terry Chen (Code Review) 03 May '22

03 May '22

Attention is currently required from: Tim Wawrzynczak, Paul Menzel. Terry Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64019 ) Change subject: mb/google/brya/variants/crota: Enable Bluetooth offload support ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/brya/variants/crota/variant.c: PS5: > This file is unnecessary, if this is on all SKUs, you can just set `register "cnvi_bt_audio_offload" […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ac54156cc4a8d824ed1c549d66fc369698a352c Gerrit-Change-Number: 64019 Gerrit-PatchSet: 6 Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 04 May 2022 02:06:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
by Simon Yang (Code Review) 03 May '22

03 May '22

Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Paul Menzel, Aseda Aboagye, Simon Yang, Ivan Chen, Karthik Ramasubramanian, Felix Held. Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 ) Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/dedede/variants/beadrix/overridetree.cb: https://review.coreboot.org/c/coreboot/+/63652/comment/420fae07_5a19f630 PS8, Line 17: Digitizer Please correct I2C1/I2C3 either. -- To view, visit https://review.coreboot.org/c/coreboot/+/63652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888 Gerrit-Change-Number: 63652 Gerrit-PatchSet: 8 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Attention: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 04 May 2022 01:21:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: enable BT offload
by Casper Chang (Code Review) 03 May '22

03 May '22

Attention is currently required from: Tim Wawrzynczak, Casper Chang. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64020 to look at the new patch set (#2). Change subject: mb/google/brask/variants/moli: enable BT offload ...................................................................... mb/google/brask/variants/moli: enable BT offload Enable BT offload of NAU88L25B on Moli with fw_config NAU88L25B_I2S. BUG=b:220814038 TEST=emerge-brask coreboot, Check BT offload enabled in CPU log and audio works. Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Change-Id: I72d91d2dafffa7d9604b7dd3d697cb3b2b04b152 --- M src/mainboard/google/brya/variants/moli/Makefile.inc A src/mainboard/google/brya/variants/moli/fw_config.c M src/mainboard/google/brya/variants/moli/overridetree.cb A src/mainboard/google/brya/variants/moli/variant.c 4 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/64020/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72d91d2dafffa7d9604b7dd3d697cb3b2b04b152 Gerrit-Change-Number: 64020 Gerrit-PatchSet: 2 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022