coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6166 discussions

Change in coreboot[master]: mb/google/brya/var/crota: setting for codec reset pin in overridetree
by Tim Wawrzynczak (Code Review) 04 May '22

04 May '22

Attention is currently required from: Terry Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64043 ) Change subject: mb/google/brya/var/crota: setting for codec reset pin in overridetree ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/64043/comment/30791ff6_4a678d78 PS1, Line 7: setting for codec reset pin in overridetree `Fix codec reset pin in overridetree` -- To view, visit https://review.coreboot.org/c/coreboot/+/64043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica3467fbc8639526bee071d56af854de5e07091e Gerrit-Change-Number: 64043 Gerrit-PatchSet: 1 Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 May 2022 15:45:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Add enum for `DdiPortXConfig`
by Angel Pons (Code Review) 04 May '22

04 May '22

Attention is currently required from: Felix Singer, Tim Crawford, Jeremy Soller, Tim Wawrzynczak, Nick Vaccaro, Michael Niewöhner. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64047 ) Change subject: soc/intel/tigerlake: Add enum for `DdiPortXConfig` ...................................................................... soc/intel/tigerlake: Add enum for `DdiPortXConfig` Add an enum for `DdiPortXConfig` devicetree options. Note that setting these options to zero does not disable the corresponding DDI port, but instead indicates that no LFP (Local Flat Panel, i.e. internal LCD) is connected to it. Change-Id: I9ea10141e51bf29ea44199dcd1b55b63ec771c0a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb M src/mainboard/system76/darp7/devicetree.cb M src/mainboard/system76/galp5/devicetree.cb M src/mainboard/system76/gaze16/devicetree.cb M src/mainboard/system76/lemp10/devicetree.cb M src/mainboard/system76/oryp8/devicetree.cb M src/soc/intel/tigerlake/chip.h 11 files changed, 25 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/64047/1 diff --git a/src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb b/src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb index 3809754..e89414b 100644 --- a/src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb +++ b/src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb @@ -23,11 +23,11 @@ device ref igpu on register "gfx" = "GMA_DEFAULT_PANEL(0)" # eDP - register "DdiPortAConfig" = "1" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortAHpd" = "1" register "DdiPortADdc" = "0" # HDMI - register "DdiPortBConfig" = "0" + register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP" register "DdiPortBHpd" = "1" register "DdiPortBDdc" = "1" end diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index f5dc019..6603baf 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -116,7 +116,7 @@ register "TcssXhciEn" = "1" # DisplayPort - register "DdiPortAConfig" = "1" # eDP + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortAHpd" = "1" # Disable PM to allow for shorter irq pulses diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 5e5a586..9f3987e 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -239,8 +239,8 @@ register "TcssAuxOri" = "0" # DP port - register "DdiPortAConfig" = "1" # eDP - register "DdiPortBConfig" = "0" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" + register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP" register "DdiPortAHpd" = "1" register "DdiPortBHpd" = "1" diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index 2c9a548..1af05c4 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -68,7 +68,7 @@ register "SataPortsEnable[1]" = "1" # enabling EDP in PortA - register "DdiPortAConfig" = "1" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortBHpd" = "1" register "DdiPort1Hpd" = "1" diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index d19747a..ad1a45d 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -65,7 +65,7 @@ register "PcieClkSrcUsage[3]" = "0x8" # enabling EDP in PortA - register "DdiPortAConfig" = "1" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortAHpd" = "1" register "DdiPortADdc" = "0" diff --git a/src/mainboard/system76/darp7/devicetree.cb b/src/mainboard/system76/darp7/devicetree.cb index 4b7ad23..dd35616 100644 --- a/src/mainboard/system76/darp7/devicetree.cb +++ b/src/mainboard/system76/darp7/devicetree.cb @@ -94,12 +94,12 @@ device ref system_agent on end device ref igpu on # DDIA is eDP - register "DdiPortAConfig" = "1" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortAHpd" = "1" register "DdiPortADdc" = "0" # DDIB is HDMI - register "DdiPortBConfig" = "0" + register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP" register "DdiPortBHpd" = "1" register "DdiPortBDdc" = "1" diff --git a/src/mainboard/system76/galp5/devicetree.cb b/src/mainboard/system76/galp5/devicetree.cb index 81163b6..5650f20 100644 --- a/src/mainboard/system76/galp5/devicetree.cb +++ b/src/mainboard/system76/galp5/devicetree.cb @@ -94,12 +94,12 @@ device ref system_agent on end device ref igpu on # DDIA is eDP - register "DdiPortAConfig" = "1" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortAHpd" = "1" register "DdiPortADdc" = "0" # DDIB is HDMI - register "DdiPortBConfig" = "0" + register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP" register "DdiPortBHpd" = "1" register "DdiPortBDdc" = "1" diff --git a/src/mainboard/system76/gaze16/devicetree.cb b/src/mainboard/system76/gaze16/devicetree.cb index a92f044..fbab7fb 100644 --- a/src/mainboard/system76/gaze16/devicetree.cb +++ b/src/mainboard/system76/gaze16/devicetree.cb @@ -87,12 +87,12 @@ device ref system_agent on end device ref igpu on # DDIA is eDP - register "DdiPortAConfig" = "1" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortAHpd" = "1" register "DdiPortADdc" = "0" # DDIB is HDMI - register "DdiPortBConfig" = "0" + register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP" register "DdiPortBHpd" = "1" register "DdiPortBDdc" = "1" end diff --git a/src/mainboard/system76/lemp10/devicetree.cb b/src/mainboard/system76/lemp10/devicetree.cb index e84c405..74bd7da 100644 --- a/src/mainboard/system76/lemp10/devicetree.cb +++ b/src/mainboard/system76/lemp10/devicetree.cb @@ -94,12 +94,12 @@ device ref system_agent on end device ref igpu on # DDIA is eDP - register "DdiPortAConfig" = "1" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortAHpd" = "1" register "DdiPortADdc" = "0" # DDIB is HDMI - register "DdiPortBConfig" = "0" + register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP" register "DdiPortBHpd" = "1" register "DdiPortBDdc" = "1" diff --git a/src/mainboard/system76/oryp8/devicetree.cb b/src/mainboard/system76/oryp8/devicetree.cb index 65b6e87..ec01d8a 100644 --- a/src/mainboard/system76/oryp8/devicetree.cb +++ b/src/mainboard/system76/oryp8/devicetree.cb @@ -105,7 +105,7 @@ end device ref igpu on # DDIA is eDP - register "DdiPortAConfig" = "1" + register "DdiPortAConfig" = "DDI_PORT_CFG_EDP" register "DdiPortAHpd" = "1" register "DdiPortADdc" = "0" end diff --git a/src/soc/intel/tigerlake/chip.h b/src/soc/intel/tigerlake/chip.h index 1f36e27..746cfa2 100644 --- a/src/soc/intel/tigerlake/chip.h +++ b/src/soc/intel/tigerlake/chip.h @@ -92,6 +92,12 @@ SLEW_FAST_16 }; +enum ddi_port_config { + DDI_PORT_CFG_NO_LFP = 0, + DDI_PORT_CFG_EDP = 1, + DDI_PORT_CFG_MIPI_DSI = 2, +}; + struct soc_intel_tigerlake_config { /* Common struct containing soc config data required by common code */ @@ -367,13 +373,9 @@ */ uint8_t gpio_pm[TOTAL_GPIO_COMM]; - /* DP config */ - /* - * Port config - * 0:Disabled, 1:eDP, 2:MIPI DSI - */ - uint8_t DdiPortAConfig; - uint8_t DdiPortBConfig; + /* DDI port config */ + enum ddi_port_config DdiPortAConfig; + enum ddi_port_config DdiPortBConfig; /* Enable(1)/Disable(0) HPD */ uint8_t DdiPortAHpd; -- To view, visit https://review.coreboot.org/c/coreboot/+/64047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ea10141e51bf29ea44199dcd1b55b63ec771c0a Gerrit-Change-Number: 64047 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: cpu/intel/model_2065x: Drop unused function declaration
by Angel Pons (Code Review) 04 May '22

04 May '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64046 ) Change subject: cpu/intel/model_2065x: Drop unused function declaration ...................................................................... cpu/intel/model_2065x: Drop unused function declaration Looks like the `set_power_limits()` declaration is copy-pasta leftovers from `cpu/intel/model_206ax`. As it's unused, get rid of it. Change-Id: I81704e883e52fea42488f52be116b6fcc2c6af4b Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/cpu/intel/model_2065x/model_2065x.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/64046/1 diff --git a/src/cpu/intel/model_2065x/model_2065x.h b/src/cpu/intel/model_2065x/model_2065x.h index 251fd75..92cc55c 100644 --- a/src/cpu/intel/model_2065x/model_2065x.h +++ b/src/cpu/intel/model_2065x/model_2065x.h @@ -53,9 +53,6 @@ /* Lock MSRs */ void intel_model_2065x_finalize_smm(void); -/* Configure power limits for turbo mode */ -void set_power_limits(u8 power_limit_1_time); - /* Sanity check config options. */ #if (CONFIG_SMM_TSEG_SIZE <= CONFIG_SMM_RESERVED_SIZE) # error "CONFIG_SMM_TSEG_SIZE <= CONFIG_SMM_RESERVED_SIZE" -- To view, visit https://review.coreboot.org/c/coreboot/+/64046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81704e883e52fea42488f52be116b6fcc2c6af4b Gerrit-Change-Number: 64046 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/amdfwtool: Add IKEK key for Trusted Application
by Felix Held (Code Review) 04 May '22

04 May '22

Attention is currently required from: Bao Zheng, Avinash Alevoor, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64040 ) Change subject: util/amdfwtool: Add IKEK key for Trusted Application ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d05792cfd98fa9c38f5deef1ac3282625983eeb Gerrit-Change-Number: 64040 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Avinash Alevoor Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-CC: Mohan Viswanathan Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Avinash Alevoor Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 04 May 2022 15:27:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/amdfwtool: Add amdfwread utility
by Raul Rangel (Code Review) 04 May '22

04 May '22

Attention is currently required from: Robert Zieba, Bao Zheng, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 ) Change subject: util/amdfwtool: Add amdfwread utility ...................................................................... Patch Set 13: (1 comment) File util/amdfwtool/Makefile: https://review.coreboot.org/c/coreboot/+/62795/comment/e6980745_4020711d PS10, Line 21: HEADER > This doesn't look like it's defined. Define HEADER as `amdfwtool.h` -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 13 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 04 May 2022 15:27:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
by Angel Pons (Code Review) 04 May '22

04 May '22

Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 ) Change subject: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support ...................................................................... Patch Set 6: Code-Review+1 (9 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62498/comment/fc873107_67c576d0 PS6, Line 8: Are there any known problems? File src/mainboard/clevo/tgl-u/Kconfig: https://review.coreboot.org/c/coreboot/+/62498/comment/e7cb17a2_18f3d6ae PS3, Line 13: MAINBOARD_HAS_LPC_TPM > MEMORY_MAPPED_TPM Done File src/mainboard/clevo/tgl-u/Kconfig.name: https://review.coreboot.org/c/coreboot/+/62498/comment/e6e25245_84d40d5e PS1, Line 5: select BOARD_CLEVO_NV4X_BASE > I saw patches shifting these selects to the Kconfig.name to Kconfig files, e.g. CB:62816 […] Done File src/mainboard/clevo/tgl-u/variants/nv40mz/devicetree.cb: https://review.coreboot.org/c/coreboot/+/62498/comment/7c8728b8_a1c750b4 PS6, Line 13: # Disable DPTF : register "dptf_enable" = "0" This can be dropped, default is 0 https://review.coreboot.org/c/coreboot/+/62498/comment/5c13f335_5f0efc7d PS6, Line 22: required Is S0ix actually required? https://review.coreboot.org/c/coreboot/+/62498/comment/d188f389_4cbd7601 PS6, Line 115: device ref peg on Add "smbios_slot_desc"? https://review.coreboot.org/c/coreboot/+/62498/comment/48a10365_95451794 PS6, Line 261: Pantone ROM I wonder what this EEPROM is used for. https://review.coreboot.org/c/coreboot/+/62498/comment/6f9080e5_948c6f29 PS6, Line 308: register "PcieRpEnable[10]" = "1" register "PcieRpSlotImplemented[10]" = "1" Also, add "smbios_slot_desc"? File src/mainboard/clevo/tgl-u/variants/nv40mz/ramstage.c: https://review.coreboot.org/c/coreboot/+/62498/comment/cb2398dc_dc924644 PS6, Line 12: params->CpuPcieRpAdvancedErrorReporting[0] = 0; I'd also add this: params->CpuPcieRpSlotImplemented[0] = 1; -- To view, visit https://review.coreboot.org/c/coreboot/+/62498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Gerrit-Change-Number: 62498 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 04 May 2022 15:25:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
by Karthik Ramasubramanian (Code Review) 04 May '22

04 May '22

Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Paul Menzel, Simon Yang, Aseda Aboagye, Ivan Chen, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 ) Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888 Gerrit-Change-Number: 63652 Gerrit-PatchSet: 9 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Attention: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 04 May 2022 15:16:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/amdfwtool: Add IKEK key for Trusted Application
by Raul Rangel (Code Review) 04 May '22

04 May '22

Attention is currently required from: Bao Zheng, Avinash Alevoor, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64040 ) Change subject: util/amdfwtool: Add IKEK key for Trusted Application ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d05792cfd98fa9c38f5deef1ac3282625983eeb Gerrit-Change-Number: 64040 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Avinash Alevoor Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-CC: Mohan Viswanathan Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Avinash Alevoor Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 04 May 2022 15:07:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/amdfwtool: Add IKEK key for Trusted Application
by Karthik Ramasubramanian (Code Review) 04 May '22

04 May '22

Attention is currently required from: Bao Zheng, Raul Rangel, Avinash Alevoor, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64040 ) Change subject: util/amdfwtool: Add IKEK key for Trusted Application ...................................................................... Patch Set 3: (1 comment) File util/amdfwtool/data_parse.c: https://review.coreboot.org/c/coreboot/+/64040/comment/b84845cb_9661ac9d PS1, Line 332: AMD_WRAPPED_IKEK > My bad :(. Thanks for catching it. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d05792cfd98fa9c38f5deef1ac3282625983eeb Gerrit-Change-Number: 64040 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Avinash Alevoor Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-CC: Mohan Viswanathan Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Avinash Alevoor Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 04 May 2022 14:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Avinash Alevoor Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/amdfwtool: Add IKEK key for Trusted Application
by Karthik Ramasubramanian (Code Review) 04 May '22

04 May '22

Attention is currently required from: Bao Zheng, Raul Rangel, Avinash Alevoor, Felix Held. Hello build bot (Jenkins), Bao Zheng, Raul Rangel, Avinash Alevoor, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64040 to look at the new patch set (#3). Change subject: util/amdfwtool: Add IKEK key for Trusted Application ...................................................................... util/amdfwtool: Add IKEK key for Trusted Application This binary file is required for use by Trusted Applications that execute in PSP. BUG=b:229947314 TEST=Build and boot to OS in Skyrim. Change-Id: I2d05792cfd98fa9c38f5deef1ac3282625983eeb Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 3 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/64040/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/64040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d05792cfd98fa9c38f5deef1ac3282625983eeb Gerrit-Change-Number: 64040 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Avinash Alevoor Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-CC: Mohan Viswanathan Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Avinash Alevoor Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022