Attention is currently required from: Robert Zieba, Bao Zheng, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 )
Change subject: util/amdfwtool: Add amdfwread utility
......................................................................
Patch Set 13:
(1 comment)
File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/62795/comment/e6980745_4020711d
PS10, Line 21: HEADER
> This doesn't look like it's defined.
Define HEADER as `amdfwtool.h`
--
To view, visit https://review.coreboot.org/c/coreboot/+/62795
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850
Gerrit-Change-Number: 62795
Gerrit-PatchSet: 13
Gerrit-Owner: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Eric Peers <epeers(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Robert Zieba <robertzieba(a)google.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 04 May 2022 15:27:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )
Change subject: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
......................................................................
Patch Set 6: Code-Review+1
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62498/comment/fc873107_67c576d0
PS6, Line 8:
Are there any known problems?
File src/mainboard/clevo/tgl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/62498/comment/e7cb17a2_18f3d6ae
PS3, Line 13: MAINBOARD_HAS_LPC_TPM
> MEMORY_MAPPED_TPM
Done
File src/mainboard/clevo/tgl-u/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62498/comment/e6e25245_84d40d5e
PS1, Line 5: select BOARD_CLEVO_NV4X_BASE
> I saw patches shifting these selects to the Kconfig.name to Kconfig files, e.g. CB:62816 […]
Done
File src/mainboard/clevo/tgl-u/variants/nv40mz/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62498/comment/7c8728b8_a1c750b4
PS6, Line 13: # Disable DPTF
: register "dptf_enable" = "0"
This can be dropped, default is 0
https://review.coreboot.org/c/coreboot/+/62498/comment/5c13f335_5f0efc7d
PS6, Line 22: required
Is S0ix actually required?
https://review.coreboot.org/c/coreboot/+/62498/comment/d188f389_4cbd7601
PS6, Line 115: device ref peg on
Add "smbios_slot_desc"?
https://review.coreboot.org/c/coreboot/+/62498/comment/48a10365_95451794
PS6, Line 261: Pantone ROM
I wonder what this EEPROM is used for.
https://review.coreboot.org/c/coreboot/+/62498/comment/6f9080e5_948c6f29
PS6, Line 308: register "PcieRpEnable[10]" = "1"
register "PcieRpSlotImplemented[10]" = "1"
Also, add "smbios_slot_desc"?
File src/mainboard/clevo/tgl-u/variants/nv40mz/ramstage.c:
https://review.coreboot.org/c/coreboot/+/62498/comment/cb2398dc_dc924644
PS6, Line 12: params->CpuPcieRpAdvancedErrorReporting[0] = 0;
I'd also add this:
params->CpuPcieRpSlotImplemented[0] = 1;
--
To view, visit https://review.coreboot.org/c/coreboot/+/62498
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc
Gerrit-Change-Number: 62498
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Wed, 04 May 2022 15:25:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Paul Menzel, Simon Yang, Aseda Aboagye, Ivan Chen, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 )
Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63652
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888
Gerrit-Change-Number: 63652
Gerrit-PatchSet: 9
Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Teddy Shih <teddyshihau(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com>
Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com>
Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Attention: Teddy Shih <teddyshihau(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 04 May 2022 15:16:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Raul Rangel, Avinash Alevoor, Felix Held.
Hello build bot (Jenkins), Bao Zheng, Raul Rangel, Avinash Alevoor, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64040
to look at the new patch set (#3).
Change subject: util/amdfwtool: Add IKEK key for Trusted Application
......................................................................
util/amdfwtool: Add IKEK key for Trusted Application
This binary file is required for use by Trusted Applications that
execute in PSP.
BUG=b:229947314
TEST=Build and boot to OS in Skyrim.
Change-Id: I2d05792cfd98fa9c38f5deef1ac3282625983eeb
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
---
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
M util/amdfwtool/data_parse.c
3 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/64040/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/64040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d05792cfd98fa9c38f5deef1ac3282625983eeb
Gerrit-Change-Number: 64040
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: Mohan Viswanathan
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Avinash Alevoor
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bao Zheng, Raul Rangel, Avinash Alevoor, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64040 )
Change subject: util/amdfwtool: Add IKEK key for Trusted Application
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/64040/comment/9daca5ea_fddded70
PS1, Line 332: AMD_WRAPPED_IKEK
> This should be TA_IKEK_FILE.
My bad :(. Thanks for catching it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d05792cfd98fa9c38f5deef1ac3282625983eeb
Gerrit-Change-Number: 64040
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: Mohan Viswanathan
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Avinash Alevoor
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 04 May 2022 14:24:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Avinash Alevoor
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Marc Jones, Patrick Rudolph, Jonathan Zhang, Johnny Lin, lichenchen.carl, Nill Ge, Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64041 )
Change subject: include/memory_info.h: Make DIMM_INFO_TOTAL a Kconfig variable
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Another option is to just increase the value for DIMM_INFO_TOTAL define without adding a Kconfig. […]
Where does `struct memory_info` get saved? I guess it's saved into CBMEM? If so, then space usage isn't an issue so increasing the value of the define for everything shouldn't be an issue.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64041
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If72a8622ac1e7e67646aa4dd24b99637fb8b1297
Gerrit-Change-Number: 64041
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: lichenchen.carl <lichenchen.carl(a)bytedance.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: lichenchen.carl <lichenchen.carl(a)bytedance.com>
Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Wed, 04 May 2022 14:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-MessageType: comment