Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64046 )
Change subject: cpu/intel/model_2065x: Drop unused function declaration
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/64046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81704e883e52fea42488f52be116b6fcc2c6af4b
Gerrit-Change-Number: 64046
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 04 May 2022 17:21:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Gaggery Tsai, Shon Wang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63892 )
Change subject: mb/google/brya/var/vell: Remove unused i2c7 settings
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> That's WIP for DVT. In EVT hardware design, i2c7 is preserved. […]
Thanks for the explanation. In the future, let's please try to leave board phases out of public
--
To view, visit https://review.coreboot.org/c/coreboot/+/63892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc1e0085064a13149ebc7e70184d1f40462e0fff
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com>
Gerrit-Reviewer: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Gaggery Tsai <gaggery.tsai(a)intel.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 04 May 2022 16:52:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Gaggery Tsai <gaggery.tsai(a)intel.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Shon Wang.
Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63892 )
Change subject: mb/google/brya/var/vell: Remove unused i2c7 settings
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm confused, is https://review.coreboot. […]
That's WIP for DVT. In EVT hardware design, i2c7 is preserved. There should be no problem to enable i27 even it doesn't connect to anything but the i2c6/7 pci id currently are not in kernel support list (WIP for upstream). No driver to handle i2c7 runtime d3 and it blocks s0ix. So we have to remove the i2c7 for EVT.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc1e0085064a13149ebc7e70184d1f40462e0fff
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com>
Gerrit-Reviewer: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 04 May 2022 16:46:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gaggery Tsai <gaggery.tsai(a)intel.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Gaggery Tsai, Shon Wang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63892 )
Change subject: mb/google/brya/var/vell: Remove unused i2c7 settings
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> @Tim: Do we still need further clarification for this patch?
I'm confused, is https://review.coreboot.org/c/coreboot/+/63756 still in play?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc1e0085064a13149ebc7e70184d1f40462e0fff
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com>
Gerrit-Reviewer: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Gaggery Tsai <gaggery.tsai(a)intel.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 04 May 2022 16:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gaggery Tsai <gaggery.tsai(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans, Kyösti Mälkki, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64009 )
Change subject: nb/amd/agesa/family14: Clean up fx_devs stuff
......................................................................
Patch Set 1:
(3 comments)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/64009/comment/f092a0b3_e4c59214
PS1, Line 78: if (fx_devs == 0)
> I'm not sure if fx_devs have been populated when this gets called. […]
It's redundant with the `if` inside get_fx_devs(). Anyway, doesn't
matter if the cleanup continues.
https://review.coreboot.org/c/coreboot/+/64009/comment/71860ced_06a64f60
PS1, Line 86: if (fx_devs == 0)
> I'm not sure if fx_devs have been populated when this gets called. […]
Same.
https://review.coreboot.org/c/coreboot/+/64009/comment/91a73434_8727581e
PS1, Line 88: for (i = 0; i < fx_devs; i++) {
> I'm not sure if fx_devs have been populated when this gets called. […]
After calling get_fx_devs() above, `fx_devs` is always `>= 1` (unless we are dead). Anyway...
--
To view, visit https://review.coreboot.org/c/coreboot/+/64009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8475d42627c48336c98afdfe659f3bbfb173c3c
Gerrit-Change-Number: 64009
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 04 May 2022 16:33:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Angel Pons, Arthur Heymans, Tim Chu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64036 )
Change subject: soc/intel/xeon_sp/cpx: Allow creating meminfo for empty DIMM slots
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64036/comment/1fdf29cd_0813233f
PS1, Line 9: Introduce the mainboard-defined `mainboard_dimm_slot_exists()` function
> > Wouldn't a simple Kconfig number do? It's hard to tell without seeing […]
I imagined something like this but didn't know if it exists :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/64036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d9c41dd7d981842ca6f0294d9e6b0fedc0c98e4
Gerrit-Change-Number: 64036
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Wed, 04 May 2022 16:27:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Marc Jones, Jonathan Zhang, Angel Pons, lichenchen.carl, Nill Ge.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 )
Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots
......................................................................
Patch Set 1:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/64035/comment/78c36aa5_5ad615c8
PS1, Line 281: *current
> I just reused the signature of `create_smbios_type17_for_dimm()`. […]
Ack. I just noticed the whole file is full of such odd patterns.
https://review.coreboot.org/c/coreboot/+/64035/comment/b144c163_46969ae6
PS1, Line 291: t->form_factor = 0x2; /* Unknown */
> It could be SO-DIMM in some cases.
Hmmm, if we expect that location info is filled for empty slots, should
we expect `form_factor` to be filled too?
--
To view, visit https://review.coreboot.org/c/coreboot/+/64035
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17ae83edf94483bd2eeef5524ff82721c196b8ba
Gerrit-Change-Number: 64035
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: lichenchen.carl <lichenchen.carl(a)bytedance.com>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: lichenchen.carl <lichenchen.carl(a)bytedance.com>
Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 04 May 2022 16:25:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 )
Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM
......................................................................
Patch Set 18:
(4 comments)
Patchset:
PS18:
Resolving these as the changes have been made. Feel free to comment on the updated approaches if needed.
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/bef44188_49a94090
PS17, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; }
> In patchset 18
Done
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/55168402_aa6dbc42
PS12, Line 179: min_pci_d_states
> Implemented in patch set #15
Done
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/156ce4c7_daa1d8ff
PS13, Line 116: typedef enum {
: D0, /* 0 */
: D1, /* 1 */
: D2, /* 2 */
: D3, /* 3 */
: UNDEF
: } D_STATES;
> I didn't ultimately use it as it also it doesn't seem safe as it also has unsupported values (ACPI_D […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437
Gerrit-Change-Number: 63969
Gerrit-PatchSet: 18
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 04 May 2022 16:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment