coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6166 discussions

Change in coreboot[master]: coreboot_tables: Add PCIe info to coreboot table
by Shelley Chen (Code Review) 04 May '22

04 May '22

Attention is currently required from: Ravi Kumar Bokka, Hung-Te Lin, Nico Huber, Tim Wawrzynczak, Paul Menzel, Rex-BC Chen, Julius Werner, Arthur Heymans, Yu-Ping Wu, Jianjun Wang. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 ) Change subject: coreboot_tables: Add PCIe info to coreboot table ...................................................................... Patch Set 20: (1 comment) Patchset: PS9: > Hi Yu-ping, Tim and I have a meeting scheduled with Qualcomm Tuesday to discuss this, so hopefully […] Hi Yu-ping. We had a meeting with Prasad and he said that he would discuss with the internal QC team and respond by his EOD today. Please stay tuned for his response. -- To view, visit https://review.coreboot.org/c/coreboot/+/63251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6cdce21efc66aa441ec077e6fc1d5d1c6a9aafb0 Gerrit-Change-Number: 63251 Gerrit-PatchSet: 20 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Comment-Date: Wed, 04 May 2022 18:05:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/amdfwtool: Add amdfwread utility
by Robert Zieba (Code Review) 04 May '22

04 May '22

Attention is currently required from: Bao Zheng, Raul Rangel, Marshall Dawson, Felix Held. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 ) Change subject: util/amdfwtool: Add amdfwread utility ...................................................................... Patch Set 14: (5 comments) File util/amdfwtool/Makefile: https://review.coreboot.org/c/coreboot/+/62795/comment/c1562c78_a4336801 PS10, Line 21: HEADER > Define HEADER as `amdfwtool. […] Done File util/amdfwtool/amdfwread.c: https://review.coreboot.org/c/coreboot/+/62795/comment/43f583a6_cbc6e194 PS10, Line 15: begging > beginning? Done https://review.coreboot.org/c/coreboot/+/62795/comment/5e42e128_48b0048d PS10, Line 122: current_entries > clang-format Done https://review.coreboot.org/c/coreboot/+/62795/comment/1fda03d1_2dd8b634 PS10, Line 141: current_entries > clang-format Done https://review.coreboot.org/c/coreboot/+/62795/comment/f336676d_201ca29c PS10, Line 153: current_entries > clang-format Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 14 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 04 May 2022 18:02:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/amdfwtool: Add amdfwread utility
by Robert Zieba (Code Review) 04 May '22

04 May '22

Attention is currently required from: Robert Zieba, Bao Zheng, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Bao Zheng, Raul Rangel, Marshall Dawson, Rob Barnes, Karthik Ramasubramanian, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62795 to look at the new patch set (#14). Change subject: util/amdfwtool: Add amdfwread utility ...................................................................... util/amdfwtool: Add amdfwread utility Amdfwtool creates AMD firmware images however there is currently no way to get information from an existing image. This commit adds amdfwread to support that functionality. At the moment only reading PSP soft fuse flags is supported. BUG=b:202397678 TEST=Ran amdfwread and verified that it correctly reads the soft fuse bits Signed-off-by: Robert Zieba <robertzieba(a)google.com> Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 --- M util/amdfwtool/.gitignore M util/amdfwtool/Makefile A util/amdfwtool/amdfwread.c M util/testing/Makefile.inc 4 files changed, 255 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/62795/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 14 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Fix compilation issues
by Anil Kumar K (Code Review) 04 May '22

04 May '22

Anil Kumar K has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62277 ) Change subject: drivers/intel/fsp2_0: Fix compilation issues ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62277 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f372e4c1aae0a78dbf96931c694882acaf0f0e9 Gerrit-Change-Number: 62277 Gerrit-PatchSet: 5 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: cpu/intel/model_2065x: Drop unused function declaration
by Arthur Heymans (Code Review) 04 May '22

04 May '22

Attention is currently required from: Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64046 ) Change subject: cpu/intel/model_2065x: Drop unused function declaration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81704e883e52fea42488f52be116b6fcc2c6af4b Gerrit-Change-Number: 64046 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 04 May 2022 17:21:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
by Michael Niewöhner (Code Review) 04 May '22

04 May '22

Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 ) Change subject: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support ...................................................................... Patch Set 6: (12 comments) File src/mainboard/clevo/tgl-u/Kconfig: https://review.coreboot.org/c/coreboot/+/62498/comment/6f4bb8e9_9b99da49 PS6, Line 60: GPP_C14 GPP_C14_IRQ File src/mainboard/clevo/tgl-u/Kconfig.name: https://review.coreboot.org/c/coreboot/+/62498/comment/0e7d1192_a332e8a7 PS6, Line 7: MB/ME/MZ nit: MZ at first, since it's the base for the other two? File src/mainboard/clevo/tgl-u/variants/nv40mz/Makefile.inc: https://review.coreboot.org/c/coreboot/+/62498/comment/1e842f25_a65fae78 PS6, Line 3: bootblock-y += gpio.c : : romstage-y += romstage.c : : ramstage-y += gpio.c : ramstage-y += hda_verb.c : not needed. covered by tgl-u/Makefile.inc File src/mainboard/clevo/tgl-u/variants/nv40mz/devicetree.cb: https://review.coreboot.org/c/coreboot/+/62498/comment/b2422dc4_024d9a56 PS6, Line 17: register "external_bypass" = "1" could you check if PU5, PU8 are populated on the board? https://review.coreboot.org/c/coreboot/+/62498/comment/67a9a59d_cc5348c1 PS6, Line 22: required > Is S0ix actually required? S3 is deprecated on TGl https://review.coreboot.org/c/coreboot/+/62498/comment/d601b788_bae157c8 PS6, Line 83: register "CnviBtCore" = "true" move down to cnvi dev https://review.coreboot.org/c/coreboot/+/62498/comment/9fd58a95_f477e606 PS6, Line 86: GPE configuration : register "pmc_gpe0_dw0" = "PMC_GPP_C" : register "pmc_gpe0_dw1" = "PMC_GPP_E" : register "pmc_gpe0_dw2" = "PMC_GPD" : move down to pmc dev? File src/mainboard/clevo/tgl-u/variants/nv40mz/gpio.c: https://review.coreboot.org/c/coreboot/+/62498/comment/152560df_a6f1058d PS6, Line 9: add some comments? https://review.coreboot.org/c/coreboot/+/62498/comment/8e609dbd_8d46bfba PS6, Line 129: //PAD_CFG_TERM_GPO(GPP_U4, 1, NONE, DEEP), /* DGPU_RST#_PCH */ : //PAD_CFG_TERM_GPO(GPP_U5, 1, NONE, DEEP), /* DGPU_PWR_EN */ : configured in gpio_early https://review.coreboot.org/c/coreboot/+/62498/comment/3fbe94d7_8833a213 PS6, Line 210: PAD_CFG_GPI_SMI(GPP_E7, NONE, PLTRST, EDGE_SINGLE, INVERT), board uses espi vwire -> don't configure the gpio File src/mainboard/clevo/tgl-u/variants/nv40mz/ramstage.c: https://review.coreboot.org/c/coreboot/+/62498/comment/a7748900_d2bd98af PS6, Line 9: * Disable AER for the SSD slot to support S0ix with SSDs running : * buggy firmware : any more details on this? https://review.coreboot.org/c/coreboot/+/62498/comment/a10fe5fe_37e41abd PS6, Line 12: params->CpuPcieRpAdvancedErrorReporting[0] = 0; > I'd also add this: […] also params->CpuPcieRpLtrEnable[0] = 1; -- To view, visit https://review.coreboot.org/c/coreboot/+/62498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Gerrit-Change-Number: 62498 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 04 May 2022 17:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/model_2065x: Drop unused function declaration
by Elyes Haouas (Code Review) 04 May '22

04 May '22

Attention is currently required from: Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64046 ) Change subject: cpu/intel/model_2065x: Drop unused function declaration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81704e883e52fea42488f52be116b6fcc2c6af4b Gerrit-Change-Number: 64046 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 04 May 2022 17:06:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Remove unused i2c7 settings
by Tim Wawrzynczak (Code Review) 04 May '22

04 May '22

Attention is currently required from: Gaggery Tsai, Shon Wang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63892 ) Change subject: mb/google/brya/var/vell: Remove unused i2c7 settings ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > That's WIP for DVT. In EVT hardware design, i2c7 is preserved. […] Thanks for the explanation. In the future, let's please try to leave board phases out of public -- To view, visit https://review.coreboot.org/c/coreboot/+/63892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc1e0085064a13149ebc7e70184d1f40462e0fff Gerrit-Change-Number: 63892 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 May 2022 16:52:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Gaggery Tsai <gaggery.tsai(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Remove unused i2c7 settings
by Gaggery Tsai (Code Review) 04 May '22

04 May '22

Attention is currently required from: Tim Wawrzynczak, Shon Wang. Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63892 ) Change subject: mb/google/brya/var/vell: Remove unused i2c7 settings ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm confused, is https://review.coreboot. […] That's WIP for DVT. In EVT hardware design, i2c7 is preserved. There should be no problem to enable i27 even it doesn't connect to anything but the i2c6/7 pci id currently are not in kernel support list (WIP for upstream). No driver to handle i2c7 runtime d3 and it blocks s0ix. So we have to remove the i2c7 for EVT. -- To view, visit https://review.coreboot.org/c/coreboot/+/63892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc1e0085064a13149ebc7e70184d1f40462e0fff Gerrit-Change-Number: 63892 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 May 2022 16:46:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Gaggery Tsai <gaggery.tsai(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Remove unused i2c7 settings
by Tim Wawrzynczak (Code Review) 04 May '22

04 May '22

Attention is currently required from: Gaggery Tsai, Shon Wang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63892 ) Change subject: mb/google/brya/var/vell: Remove unused i2c7 settings ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @Tim: Do we still need further clarification for this patch? I'm confused, is https://review.coreboot.org/c/coreboot/+/63756 still in play? -- To view, visit https://review.coreboot.org/c/coreboot/+/63892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc1e0085064a13149ebc7e70184d1f40462e0fff Gerrit-Change-Number: 63892 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 May 2022 16:35:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022