Attention is currently required from: Tim Wawrzynczak, Ivy Jian, Nick Vaccaro.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62384 )
Change subject: mb/google/brya/var/agah: Add GPU power sequencing
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1072be12ef58af5859e2a2d19c4a9c1adc0b0f88
Gerrit-Change-Number: 62384
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 05 May 2022 00:20:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64018 )
Change subject: ec/compal/ene932: Refactor to use common EC/KBC library functions
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64018
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic25f0477963f55a32a44e3020882bd5b70164827
Gerrit-Change-Number: 64018
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64017 )
Change subject: ec/hp/kbc1126: Refactor to use common EC/KBC functions
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea97eb0b6d810a3d0d1d11a12b3c4dd2ed3897ab
Gerrit-Change-Number: 64017
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64016 )
Change subject: ec/quanta/ene_kb3940q: Refactor to use EC/KBC library functions
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8ccc0ea144d94151b1004255509dd74417db9fa
Gerrit-Change-Number: 64016
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64015 )
Change subject: ec/quanta/it8518: Refactor to use common EC/KBC library functions
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64015
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I158b1d0e20330c836cc4de7eaf66d85aaec91c0e
Gerrit-Change-Number: 64015
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64014 )
Change subject: ec/roda/it8518: Refactor to use common EC polling/constants
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64014
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3effa112dcbec75907a4dacc8d6ab63047b6a03a
Gerrit-Change-Number: 64014
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64013 )
Change subject: drivers/pc80: Add public I/O space API and refactor
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib858fa569648520a8b623cbb5b55bfd07e096aa0
Gerrit-Change-Number: 64013
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64012 )
Change subject: ec/acpi: Refactor to reduce code duplication, use named constants
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifda5c030ff81f1046be58aa1fcafdcf71a27cd41
Gerrit-Change-Number: 64012
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:23:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Shou-Chieh Hsu.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64045 )
Change subject: util/mb/google: add support for nissa
......................................................................
Patch Set 1:
(1 comment)
File util/mainboard/google/nissa/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/64045/comment/85f9b902_fa47323a
PS1, Line 5: placeholder
Have you tested that we can build a new variant with this template? I think this will cause make to fail until you add parts to `mem_parts_used.txt` but that shouldn't be required until a follow-on CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04f75ff91f9851b82641f703ba950b04c22e2e72
Gerrit-Change-Number: 64045
Gerrit-PatchSet: 1
Gerrit-Owner: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 04 May 2022 23:08:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment