Attention is currently required from: Paul Menzel.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64016 )
Change subject: ec/quanta/ene_kb3940q: Refactor to use EC/KBC library functions
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8ccc0ea144d94151b1004255509dd74417db9fa
Gerrit-Change-Number: 64016
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64015 )
Change subject: ec/quanta/it8518: Refactor to use common EC/KBC library functions
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64015
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I158b1d0e20330c836cc4de7eaf66d85aaec91c0e
Gerrit-Change-Number: 64015
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64014 )
Change subject: ec/roda/it8518: Refactor to use common EC polling/constants
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64014
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3effa112dcbec75907a4dacc8d6ab63047b6a03a
Gerrit-Change-Number: 64014
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64013 )
Change subject: drivers/pc80: Add public I/O space API and refactor
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib858fa569648520a8b623cbb5b55bfd07e096aa0
Gerrit-Change-Number: 64013
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:24:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64012 )
Change subject: ec/acpi: Refactor to reduce code duplication, use named constants
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifda5c030ff81f1046be58aa1fcafdcf71a27cd41
Gerrit-Change-Number: 64012
Gerrit-PatchSet: 2
Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 04 May 2022 23:23:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Shou-Chieh Hsu.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64045 )
Change subject: util/mb/google: add support for nissa
......................................................................
Patch Set 1:
(1 comment)
File util/mainboard/google/nissa/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/64045/comment/85f9b902_fa47323a
PS1, Line 5: placeholder
Have you tested that we can build a new variant with this template? I think this will cause make to fail until you add parts to `mem_parts_used.txt` but that shouldn't be required until a follow-on CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04f75ff91f9851b82641f703ba950b04c22e2e72
Gerrit-Change-Number: 64045
Gerrit-PatchSet: 1
Gerrit-Owner: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 04 May 2022 23:08:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Jon Murphy, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for external USB hub
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/usb/ext_hub/Kconfig:
https://review.coreboot.org/c/coreboot/+/63968/comment/af261524_669e334e
PS3, Line 1: EXTERNAL
Should we remove the EXTERNAL? The help text says `soldered down`, so it's kind of confusing since it's internal to the device.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11d7ccc42d3dce8e136eb771f120825980e5c027
Gerrit-Change-Number: 63968
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 04 May 2022 22:46:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Jon Murphy, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for external USB hub
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63968/comment/c376d3a0_1112edf6
PS3, Line 9: ACPI
nit: too long
File src/drivers/usb/ext_hub/acpi.c:
https://review.coreboot.org/c/coreboot/+/63968/comment/45410b76_5cdbaf92
PS3, Line 44: if (parent->path.type == DEVICE_PATH_USB && parent->path.usb.port_type == 2)
: format = "HS%02d";
: else if (parent->path.type == DEVICE_PATH_USB && parent->path.usb.port_type == 3)
: format = "SS%02d";
: else
: return;
Can you reuse usb_ext_hub_acpi_name?
File src/drivers/usb/ext_hub/chip.h:
https://review.coreboot.org/c/coreboot/+/63968/comment/16cbb7c8_7d523b1e
PS3, Line 6: drivers_usb_ext_hub_config
Should we support support acpi_upc_type?
https://review.coreboot.org/c/coreboot/+/63968/comment/e8afc2ef_092d3b10
PS3, Line 9: port_count
Can you add a comment stating this is both super speed and high speed ports?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11d7ccc42d3dce8e136eb771f120825980e5c027
Gerrit-Change-Number: 63968
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 04 May 2022 22:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Paul Menzel, Tim Wawrzynczak, Jon Murphy.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for external USB hub
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS2:
> What datasheet did you ues?
It is made a generic USB hub now.
File src/drivers/usb/vl/acpi_vl822.c:
https://review.coreboot.org/c/coreboot/+/63968/comment/638e1388_da274429
PS2, Line 91: ViaLabs
> Via Labs
It is made a generic external USB now.
https://review.coreboot.org/c/coreboot/+/63968/comment/74a8b1bf_42093856
PS2, Line 91: ViaLabs VL822
> I agree. There is nothing specific about this driver for VL822. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11d7ccc42d3dce8e136eb771f120825980e5c027
Gerrit-Change-Number: 63968
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Comment-Date: Wed, 04 May 2022 21:51:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment