Attention is currently required from: Paul Fagerburg, Shou-Chieh Hsu.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64045 )
Change subject: util/mb/google: add support for nissa
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04f75ff91f9851b82641f703ba950b04c22e2e72
Gerrit-Change-Number: 64045
Gerrit-PatchSet: 1
Gerrit-Owner: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Thu, 05 May 2022 06:22:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Paul Menzel, Tim Wawrzynczak, Ivy Jian, Julius Werner, Eric Lai.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63774 )
Change subject: lib/spd: Demote log about using default DDR4 params to NOTICE
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55f0968b78baaa2fc9a6bbebf6712fb8bfd349f6
Gerrit-Change-Number: 63774
Gerrit-PatchSet: 5
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 May 2022 06:21:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Paul Menzel, Tim Wawrzynczak, Ivy Jian, Julius Werner.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63774 )
Change subject: lib/spd: Demote log about using default DDR4 params to NOTICE
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> I don't have a strong opinion on what the log level should be. […]
sure, it's fine :p
--
To view, visit https://review.coreboot.org/c/coreboot/+/63774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55f0968b78baaa2fc9a6bbebf6712fb8bfd349f6
Gerrit-Change-Number: 63774
Gerrit-PatchSet: 5
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 05 May 2022 05:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63949 )
Change subject: ec/google: Add support for ARTG method
......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/acpi/emem.asl:
https://review.coreboot.org/c/coreboot/+/63949/comment/cb213be3_6d837794
PS2, Line 52: ARTG, 16, // Adapter Rating
> where is the corresponding EC CL?
here it is, https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3545780
--
To view, visit https://review.coreboot.org/c/coreboot/+/63949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I501ce59fd9e7f39d8b68f7e757b953ec7fb7f072
Gerrit-Change-Number: 63949
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 May 2022 05:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Angel Pons, Aamir Bohra, Fred Reitberger, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Angel Pons, Aamir Bohra, Fred Reitberger, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60968
to look at the new patch set (#20).
Change subject: soc/amd/common/block/psp: Add platform secure boot support
......................................................................
soc/amd/common/block/psp: Add platform secure boot support
Add Platform Secure Boot (PSB) enablement via the PSP if it is not
already enabled. Upon receiving psb command, PSP will program PSB fuses
as long as BIOS signing key token is valid.
Refer AMD PSB user guide doc# 56654, Revision# 1.00, this document is
only available with NDA customers.
Change-Id: I30aac29a22a5800d5995a78c50fdecd660a3d4eb
Signed-off-by: Ritul Guru <ritul.bits(a)gmail.com>
---
M src/soc/amd/common/block/psp/Kconfig
M src/soc/amd/common/block/psp/Makefile.inc
A src/soc/amd/common/block/psp/psb.c
M src/soc/amd/common/block/psp/psp_def.h
M src/soc/amd/common/block/psp/psp_gen2.c
5 files changed, 241 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/60968/20
--
To view, visit https://review.coreboot.org/c/coreboot/+/60968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30aac29a22a5800d5995a78c50fdecd660a3d4eb
Gerrit-Change-Number: 60968
Gerrit-PatchSet: 20
Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Reviewer: Aamir Bohra <aamirbohra(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Aamir Bohra <aamirbohra(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Ivy Jian, Julius Werner, Eric Lai.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63774 )
Change subject: lib/spd: Demote log about using default DDR4 params to NOTICE
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Yes, so I think error is not necessary, warning or notice should be fine.
I don't have a strong opinion on what the log level should be. So I don't object, but I also don't feel comfortable +2ing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55f0968b78baaa2fc9a6bbebf6712fb8bfd349f6
Gerrit-Change-Number: 63774
Gerrit-PatchSet: 5
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 May 2022 04:13:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Name of user not set #1002003, Tim Wawrzynczak, Paul Menzel, John Zhao, Rajmohan Mani.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63848 )
Change subject: drivers/intel/usb4: Add Type-C port device attachment check
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63848/comment/6485c9f2_a8818cbe
PS6, Line 10: This change adds support to query
: devices attachment.
> The existing code has the flow as Coreboot sends query command to EC and polls status while EC proce […]
Done
https://review.coreboot.org/c/coreboot/+/63848/comment/aafa15f6_d8bcd5d9
PS6, Line 18: Type-C ports under DA successfully.
> The point is the behavior was erroneous before when there was a device attached (DA), but worked OK […]
Done
Patchset:
PS3:
> We have got no regression result for Retimer FW update. […]
The test results show no regression for Retimer FW update under NDA and successful TBT3 docks enumeration under DA.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5392d0d3a947dbf172cadfe03fc708f6e2e87210
Gerrit-Change-Number: 63848
Gerrit-PatchSet: 9
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Name of user not set #1002003
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: John Zhao <jzhao80(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Name of user not set #1002003
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Comment-Date: Thu, 05 May 2022 04:09:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1002003
Comment-In-Reply-To: John Zhao <jzhao80(a)gmail.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Name of user not set #1002003, Tim Wawrzynczak, Paul Menzel, John Zhao, Rajmohan Mani.
John Zhao has uploaded a new patch set (#9) to the change originally created by John Zhao. ( https://review.coreboot.org/c/coreboot/+/63848 )
Change subject: drivers/intel/usb4: Add Type-C port device attachment check
......................................................................
drivers/intel/usb4: Add Type-C port device attachment check
When fwupd Retimer firmware update is enabled, it needs to
differentiate the Type-C port NDA and USB/DP/TBT/USB4 DA scenarios.
This change adds support to query devices attachment. If DA, it
deasserts the Retimer power and promptly returns -1 accordingly without
impacting the flow of Retimer firmware update under NDA. Additionally,
this patch deasserts the Retimer power during error conditions.
BUG=b:212235056, 224923449, 211790542
TEST=Validated Retimer firmware update under NDA and TBT3 docks
enumeration on Type-C ports under DA.
Change-Id: I5392d0d3a947dbf172cadfe03fc708f6e2e87210
Signed-off-by: John Zhao <john.zhao(a)intel.com>
---
M src/drivers/intel/usb4/retimer/retimer.c
M src/drivers/intel/usb4/retimer/retimer.h
2 files changed, 51 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/63848/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/63848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5392d0d3a947dbf172cadfe03fc708f6e2e87210
Gerrit-Change-Number: 63848
Gerrit-PatchSet: 9
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Name of user not set #1002003
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: John Zhao <jzhao80(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Name of user not set #1002003
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-MessageType: newpatchset