coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/amd/stoneyridge/acpi: generate PPKG object in generate_cpu_entries
by Felix Held (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Raul Rangel, Marshall Dawson. Hello Raul Rangel, Marshall Dawson, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62539 to look at the new patch set (#2). Change subject: soc/amd/stoneyridge/acpi: generate PPKG object in generate_cpu_entries ...................................................................... soc/amd/stoneyridge/acpi: generate PPKG object in generate_cpu_entries Generate the PPKG object in the generate_cpu_entries function instead of generating the PCNT object that is the used in the PPKG method in cpu.asl to provide the PPKG object. This both simplifies the code and aligns Stoneyridge with the other AMD SoCs. This will also make the code behave correctly in a case where the number of CPU cores/threads isn't a power of two. TEST=None, but equivalent change on Picasso was verified to not break anything on Mandolin. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ib42d718102151a72a5fe812e83eb2eb4f9e7b611 --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/acpi/cpu.asl 3 files changed, 3 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/62539/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib42d718102151a72a5fe812e83eb2eb4f9e7b611 Gerrit-Change-Number: 62539 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/picasso/acpi: generate PPKG object in generate_cpu_entries call
by Felix Held (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger. Hello Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62517 to look at the new patch set (#2). Change subject: soc/amd/picasso/acpi: generate PPKG object in generate_cpu_entries call ...................................................................... soc/amd/picasso/acpi: generate PPKG object in generate_cpu_entries call Generate the PPKG object in the generate_cpu_entries function instead of generating the PCNT object that is the used in the PPKG method in cpu.asl to provide the PPKG object. This both simplifies the code and aligns Picasso with Cezanne and Sabrina. This will also make the code behave correctly in a case where the number of CPU cores/threads isn't a power of two. TEST=Mandolin still boots successfully to Linux desktop and dmesg doesn't show any any possibly related problems. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ifb84435345c6d8c5d11a8b42e5538cfb86432780 --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/acpi/cpu.asl 3 files changed, 3 insertions(+), 54 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/62517/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb84435345c6d8c5d11a8b42e5538cfb86432780 Gerrit-Change-Number: 62517 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Revert "util/amdtools: Add script to update the SPI speed in the EFS ...
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62525 ) Change subject: Revert "util/amdtools: Add script to update the SPI speed in the EFS header" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie89290decbbfdb0b766dfb15f11ce7053e6bf6bc Gerrit-Change-Number: 62525 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "util/docker/coreboot-jenkins-node: add linkchecker"
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62526 ) Change subject: Revert "util/docker/coreboot-jenkins-node: add linkchecker" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8aaf5e9477bb6b8a0f0d79e9e08f364ee81f836e Gerrit-Change-Number: 62526 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "Update intel-microcode submodule to upstream master"
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62527 ) Change subject: Revert "Update intel-microcode submodule to upstream master" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I073bbb16f49e4547fe09e92f5f27aa1618641793 Gerrit-Change-Number: 62527 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "mb: Remove dot from end of non-sentence comment"
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62528 ) Change subject: Revert "mb: Remove dot from end of non-sentence comment" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaec2ef07f37bb3baa4d1f69d78258d7717919e8 Gerrit-Change-Number: 62528 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "sb/intel/lynxpoint: Fix up comment"
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62522 ) Change subject: Revert "sb/intel/lynxpoint: Fix up comment" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62522 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87c7c27abf36e5f4b0c1a3aded75bc92ba9a2e7c Gerrit-Change-Number: 62522 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "soc/intel/common/cse: skip heci_init() if HECI1 is disabled"
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62524 ) Change subject: Revert "soc/intel/common/cse: skip heci_init() if HECI1 is disabled" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67433336959e23e7b12afa4978f02ec928f4bb36 Gerrit-Change-Number: 62524 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "soc/intel/common/block/cse: move cse_disable_mei_devices() in...
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62523 ) Change subject: Revert "soc/intel/common/block/cse: move cse_disable_mei_devices() into disable_heci.c" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifab2dc957a83106b0c777b61297e605cbf607759 Gerrit-Change-Number: 62523 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "util/docker/coreboot-jenkins-node: Alphabetize installed tools"
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62529 ) Change subject: Revert "util/docker/coreboot-jenkins-node: Alphabetize installed tools" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8922f82d5d7ed193fa94ddf81e0e699c86a3eb78 Gerrit-Change-Number: 62529 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022