coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/zork: fix SMMSTORE size, alignment in default FMAP
by Matt DeVillier (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62443 ) Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/zork/chromeos.fmd: https://review.coreboot.org/c/coreboot/+/62443/comment/7b108900_ef7809b1 PS1, Line 15: RW_ELOG(PRESERVE) 4K : RW_SHARED 16K { : SHARED_DATA 8K : VBLOCK_DEV 8K : } : RW_VPD(PRESERVE) 8K : RW_NVRAM(PRESERVE) 20K > sure, I Will do that instead Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8 Gerrit-Change-Number: 62443 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:02:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork: fix SMMSTORE size, alignment in default FMAP
by Matt DeVillier (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian. Hello build bot (Jenkins), Raul Rangel, Arthur Heymans, Karthik Ramasubramanian, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62443 to look at the new patch set (#2). Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP ...................................................................... mb/google/zork: fix SMMSTORE size, alignment in default FMAP SMMSTORE needs to have 64k size (minimum) and have 64k alignment as enforced by asserts added in commit 1ba6049 [drivers/smmstore/store.c: Add static assertion based on fmap]. Adjust size and alignment of SMMSTORE region in FMAP to ensure those conditions are met. Test: build google/morphius without asserts being tripped for above conditions. Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/zork/chromeos.fmd 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/62443/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8 Gerrit-Change-Number: 62443 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/intel/i82801ix/smihandler.c: Comment out dead increment
by Elyes Haouas (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Patrick Rudolph. Hello Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62541 to look at the new patch set (#2). Change subject: sb/intel/i82801ix/smihandler.c: Comment out dead increment ...................................................................... sb/intel/i82801ix/smihandler.c: Comment out dead increment The value stored to 'data' is never read. Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Ifef67fc6415af1260d1a1df54f53fbe67f8860bb --- M src/southbridge/intel/i82801ix/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/62541/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifef67fc6415af1260d1a1df54f53fbe67f8860bb Gerrit-Change-Number: 62541 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload: cbmem_console: Drop loglevel markers from snapshot
by Raul Rangel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Julius Werner, Yu-Ping Wu. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62506 ) Change subject: libpayload: cbmem_console: Drop loglevel markers from snapshot ...................................................................... Patch Set 1: Code-Review+2 (4 comments) Patchset: PS1: I'm fine landing this as is and adding callback functionality later if necessary. File payloads/libpayload/drivers/cbmem_console.c: https://review.coreboot.org/c/coreboot/+/62506/comment/cfdd5984_0303961a PS1, Line 120: /* Slight memory corruption may occur between reboots and give us a few : unprintable characters like '\0'. Replace them with '?' on output. */ : for (cursor = 0; cursor < size; cursor++) : if (!isprint(console_c[cursor]) && !isspace(console_c[cursor])) : console_c[cursor] = '?'; > Maybe we should just keep the non-printable characters, and let payloads decide how to deal with the […] Are you suggesting a callback? https://review.coreboot.org/c/coreboot/+/62506/comment/f190b539_730ec93c PS1, Line 85: Due to stupid : licensing restrictions Why can you add a BSD version in libpayload? You are the copyright holder. Or maybe extract it into a dual licenced file? https://review.coreboot.org/c/coreboot/+/62506/comment/f96eeb5b_7f279d48 PS1, Line 90: memory corruption may occur between reboots Side note: I just learned that the kernel ramoops has an ECC function to correct errors like this. It might be interesting to add such functionality down the line. -- To view, visit https://review.coreboot.org/c/coreboot/+/62506 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a9e5d464508320cf43ea572d62896d38c2a128d Gerrit-Change-Number: 62506 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 15:54:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spd/lp5: Add new part MT62F2G32D8DR-031
by Amanda Hwang (Code Review) 02 Mar '22

02 Mar '22

Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62542 ) Change subject: spd/lp5: Add new part MT62F2G32D8DR-031 ...................................................................... spd/lp5: Add new part MT62F2G32D8DR-031 Micron MT62F2G32D8DR-031 will be used for skyrim P1. Add it to the parts list and regenerate the SPDs using spd_gen. BUG=b:213926260 TEST=util/spd_tools/bin/spd_gen spd/lp5/memory_parts.json lp5 Change-Id: Iad2bb53de2b54648d5dd66808973f26b1c8a5df7 Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com> --- M spd/lp5/memory_parts.json M spd/lp5/set-0/parts_spd_manifest.generated.txt A spd/lp5/set-0/spd-4.hex M spd/lp5/set-1/parts_spd_manifest.generated.txt A spd/lp5/set-1/spd-4.hex 5 files changed, 76 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/62542/1 diff --git a/spd/lp5/memory_parts.json b/spd/lp5/memory_parts.json index 164d837..37e31d2 100644 --- a/spd/lp5/memory_parts.json +++ b/spd/lp5/memory_parts.json @@ -49,6 +49,16 @@ "ranksPerChannel": 1, "speedMbps": 6400 } + }, + { + "name": "MT62F2G32D8DR-031 WT:B", + "attribs": { + "densityPerDieGb": 8, + "diesPerPackage": 8, + "bitWidthPerChannel": 8, + "ranksPerChannel": 2, + "speedMbps": 6400 + } } ] } diff --git a/spd/lp5/set-0/parts_spd_manifest.generated.txt b/spd/lp5/set-0/parts_spd_manifest.generated.txt index 2d1c643..f6539a2 100644 --- a/spd/lp5/set-0/parts_spd_manifest.generated.txt +++ b/spd/lp5/set-0/parts_spd_manifest.generated.txt @@ -6,3 +6,4 @@ H9JCNNNCP3MLYR-N6E,spd-2.hex K3LKBKB0BM-MGCP,spd-3.hex H9JCNNNBK3MLYR-N6E,spd-1.hex +MT62F2G32D8DR-031 WT:B,spd-4.hex diff --git a/spd/lp5/set-0/spd-4.hex b/spd/lp5/set-0/spd-4.hex new file mode 100644 index 0000000..851957f --- /dev/null +++ b/spd/lp5/set-0/spd-4.hex @@ -0,0 +1,32 @@ +23 10 13 0E 15 22 F9 08 00 00 00 00 09 01 00 00 +00 00 0A 00 00 00 00 00 AA 00 90 A8 90 90 06 C0 +03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 20 20 20 20 20 20 20 +20 20 20 20 20 20 20 20 20 20 20 20 20 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/spd/lp5/set-1/parts_spd_manifest.generated.txt b/spd/lp5/set-1/parts_spd_manifest.generated.txt index 2d1c643..f6539a2 100644 --- a/spd/lp5/set-1/parts_spd_manifest.generated.txt +++ b/spd/lp5/set-1/parts_spd_manifest.generated.txt @@ -6,3 +6,4 @@ H9JCNNNCP3MLYR-N6E,spd-2.hex K3LKBKB0BM-MGCP,spd-3.hex H9JCNNNBK3MLYR-N6E,spd-1.hex +MT62F2G32D8DR-031 WT:B,spd-4.hex diff --git a/spd/lp5/set-1/spd-4.hex b/spd/lp5/set-1/spd-4.hex new file mode 100644 index 0000000..9fe7576 --- /dev/null +++ b/spd/lp5/set-1/spd-4.hex @@ -0,0 +1,32 @@ +23 11 13 0E 85 21 F9 18 00 40 00 00 09 02 00 00 +00 00 0A 00 00 00 00 00 AA 00 90 A8 90 90 06 C0 +03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 20 20 20 20 20 20 20 +20 20 20 20 20 20 20 20 20 20 20 20 20 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/c/coreboot/+/62542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad2bb53de2b54648d5dd66808973f26b1c8a5df7 Gerrit-Change-Number: 62542 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/zork: fix SMMSTORE size, alignment in default FMAP
by Matt DeVillier (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62443 ) Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62443/comment/0e1144bc_f30acc7d PS1, Line 12: asserts > Which asserts? src/drivers/smmstore/store.c lines 15 and 18 File src/mainboard/google/zork/chromeos.fmd: https://review.coreboot.org/c/coreboot/+/62443/comment/0546b0d8_7c56eab7 PS1, Line 15: RW_ELOG(PRESERVE) 4K : RW_SHARED 16K { : SHARED_DATA 8K : VBLOCK_DEV 8K : } : RW_VPD(PRESERVE) 8K : RW_NVRAM(PRESERVE) 20K > This is going to invalidate all this data. […] sure, I Will do that instead -- To view, visit https://review.coreboot.org/c/coreboot/+/62443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8 Gerrit-Change-Number: 62443 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 15:51:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/i82801ix/smihandler.c: Comment oiut dead increment
by Elyes Haouas (Code Review) 02 Mar '22

02 Mar '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62541 ) Change subject: sb/intel/i82801ix/smihandler.c: Comment oiut dead increment ...................................................................... sb/intel/i82801ix/smihandler.c: Comment oiut dead increment The value stored to 'data' is never read. Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Ifef67fc6415af1260d1a1df54f53fbe67f8860bb --- M src/southbridge/intel/i82801ix/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/62541/1 diff --git a/src/southbridge/intel/i82801ix/smihandler.c b/src/southbridge/intel/i82801ix/smihandler.c index e02b396..70e0f86 100644 --- a/src/southbridge/intel/i82801ix/smihandler.c +++ b/src/southbridge/intel/i82801ix/smihandler.c @@ -62,7 +62,7 @@ if (!(trap_cycle & (1 << 24))) { // It's a write printk(BIOS_DEBUG, "SMI1 command\n"); data = RCBA32(0x1e18); - data &= mask; + // data &= mask; // if (smi1) // southbridge_smi_command(data); // return; -- To view, visit https://review.coreboot.org/c/coreboot/+/62541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifef67fc6415af1260d1a1df54f53fbe67f8860bb Gerrit-Change-Number: 62541 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/zork: fix SMMSTORE size, alignment in default FMAP
by Arthur Heymans (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Raul Rangel, Matt DeVillier, Karthik Ramasubramanian. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62443 ) Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62443/comment/e15894fe_2f952d60 PS1, Line 9: 64k > Where is this documented? https://doc.coreboot.org/drivers/smmstorev2.html -- To view, visit https://review.coreboot.org/c/coreboot/+/62443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8 Gerrit-Change-Number: 62443 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 15:47:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/crossgcc: Update binutils to 2.37
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Marina Michelle has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/54049 ) Change subject: util/crossgcc: Update binutils to 2.37 ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/54049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia68d4d9f836ad23fb8f6a7203a78b4ea40c7c43b Gerrit-Change-Number: 54049 Gerrit-PatchSet: 14 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: xin hua wang <xinhuawang0101(a)gmail.com> Gerrit-MessageType: revert

1 0

Change in coreboot[master]: Revert "util/crossgcc: Update binutils to 2.37"
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Nico Huber, Patrick Georgi, Paul Menzel. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Paul Menzel, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62531 to review the following change. Change subject: Revert "util/crossgcc: Update binutils to 2.37" ...................................................................... Revert "util/crossgcc: Update binutils to 2.37" This reverts commit f28e368d583b0ee1b5297f4d4d0288a1b38f06e0. Reason for revert: <INSERT REASONING HERE> Ng Change-Id: I8652ce621cde940eb54fadb96acebbddabd736e1 --- M util/crossgcc/buildgcc R util/crossgcc/patches/binutils-2.35.1_as-ipxe.patch R util/crossgcc/patches/binutils-2.35.1_mips-gold.patch R util/crossgcc/patches/binutils-2.35.1_no-bfd-doc.patch R util/crossgcc/patches/binutils-2.35.1_no-makeinfo.patch A util/crossgcc/sum/binutils-2.35.1.tar.xz.cksum D util/crossgcc/sum/binutils-2.37.tar.xz.cksum 7 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/62531/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 99e342d..7176e6b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -37,7 +37,7 @@ MPC_VERSION=1.2.1 GCC_VERSION=8.3.0 GCC_AUTOCONF_VERSION=2.69 -BINUTILS_VERSION=2.37 +BINUTILS_VERSION=2.35.1 GDB_VERSION=9.2 IASL_VERSION=20210331 PYTHON_VERSION=3.8.5 diff --git a/util/crossgcc/patches/binutils-2.37_as-ipxe.patch b/util/crossgcc/patches/binutils-2.35.1_as-ipxe.patch similarity index 100% rename from util/crossgcc/patches/binutils-2.37_as-ipxe.patch rename to util/crossgcc/patches/binutils-2.35.1_as-ipxe.patch diff --git a/util/crossgcc/patches/binutils-2.37_mips-gold.patch b/util/crossgcc/patches/binutils-2.35.1_mips-gold.patch similarity index 100% rename from util/crossgcc/patches/binutils-2.37_mips-gold.patch rename to util/crossgcc/patches/binutils-2.35.1_mips-gold.patch diff --git a/util/crossgcc/patches/binutils-2.37_no-bfd-doc.patch b/util/crossgcc/patches/binutils-2.35.1_no-bfd-doc.patch similarity index 100% rename from util/crossgcc/patches/binutils-2.37_no-bfd-doc.patch rename to util/crossgcc/patches/binutils-2.35.1_no-bfd-doc.patch diff --git a/util/crossgcc/patches/binutils-2.37_no-makeinfo.patch b/util/crossgcc/patches/binutils-2.35.1_no-makeinfo.patch similarity index 99% rename from util/crossgcc/patches/binutils-2.37_no-makeinfo.patch rename to util/crossgcc/patches/binutils-2.35.1_no-makeinfo.patch index e0ba01f..4834016 100644 --- a/util/crossgcc/patches/binutils-2.37_no-makeinfo.patch +++ b/util/crossgcc/patches/binutils-2.35.1_no-makeinfo.patch @@ -25,7 +25,7 @@ +MAKEINFO = true EXPECT = @EXPECT@ RUNTEST = @RUNTEST@ - + diff --git binutils-2.34/Makefile.tpl binutils-2.34/Makefile.tpl index 5b118a8ba4..2b41fa28ce 100644 --- binutils-2.34/Makefile.tpl @@ -38,7 +38,7 @@ +MAKEINFO = true EXPECT = @EXPECT@ RUNTEST = @RUNTEST@ - + diff --git binutils-2.34/bfd/Makefile.in binutils-2.34/bfd/Makefile.in index 7d3b9c1c5a..c062314063 100644 --- binutils-2.34/bfd/Makefile.in @@ -202,11 +202,11 @@ @@ -56,7 +56,7 @@ CC = @CC@ CFLAGS = @CFLAGS@ CPPFLAGS = @CPPFLAGS@ - RANLIB = @RANLIB@ @RANLIB_PLUGIN_OPTION@ + RANLIB = @RANLIB@ -MAKEINFO = @MAKEINFO@ +MAKEINFO = true PERL = @PERL@ - + PICFLAG = @PICFLAG@ diff --git binutils-2.34/opcodes/Makefile.in binutils-2.34/opcodes/Makefile.in index 8564803fc7..fa790026ac 100644 diff --git a/util/crossgcc/sum/binutils-2.35.1.tar.xz.cksum b/util/crossgcc/sum/binutils-2.35.1.tar.xz.cksum new file mode 100644 index 0000000..b1abda8 --- /dev/null +++ b/util/crossgcc/sum/binutils-2.35.1.tar.xz.cksum @@ -0,0 +1 @@ +45f7a96a2580a422f44b78317f0abf13935fecb6 tarballs/binutils-2.35.1.tar.xz diff --git a/util/crossgcc/sum/binutils-2.37.tar.xz.cksum b/util/crossgcc/sum/binutils-2.37.tar.xz.cksum deleted file mode 100644 index c9a5e55..0000000 --- a/util/crossgcc/sum/binutils-2.37.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -e9cf391b000010d6c752771974b394c9c743c928 tarballs/binutils-2.37.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/62531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8652ce621cde940eb54fadb96acebbddabd736e1 Gerrit-Change-Number: 62531 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: xin hua wang <xinhuawang0101(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022