coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/amd/picasso/acpi: rename cpu.asl to pnot.asl
by Felix Held (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62538 ) Change subject: soc/amd/picasso/acpi: rename cpu.asl to pnot.asl ...................................................................... soc/amd/picasso/acpi: rename cpu.asl to pnot.asl After the patch that moved the generation of the PPKG object to Picasso's acpi.c, only the PNOT object remained in its cpu.asl, so rename it to pnot.asl. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ic77dacb146aa823fc99f779f465fff28b2aead68 --- M src/mainboard/amd/bilby/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/google/zork/dsdt.asl R src/soc/amd/picasso/acpi/pnot.asl 4 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/62538/1 diff --git a/src/mainboard/amd/bilby/dsdt.asl b/src/mainboard/amd/bilby/dsdt.asl index 3b33adc..f1f0fd9 100644 --- a/src/mainboard/amd/bilby/dsdt.asl +++ b/src/mainboard/amd/bilby/dsdt.asl @@ -21,8 +21,8 @@ /* PCI IRQ mapping for the Southbridge */ #include <pcie.asl> - /* Describe the processor tree (\_PR) */ - #include <cpu.asl> + /* Power state notification to ALIB */ + #include <pnot.asl> /* Contains the supported sleep states for this chipset */ #include <soc/amd/common/acpi/sleepstates.asl> diff --git a/src/mainboard/amd/mandolin/dsdt.asl b/src/mainboard/amd/mandolin/dsdt.asl index 3b33adc..f1f0fd9 100644 --- a/src/mainboard/amd/mandolin/dsdt.asl +++ b/src/mainboard/amd/mandolin/dsdt.asl @@ -21,8 +21,8 @@ /* PCI IRQ mapping for the Southbridge */ #include <pcie.asl> - /* Describe the processor tree (\_PR) */ - #include <cpu.asl> + /* Power state notification to ALIB */ + #include <pnot.asl> /* Contains the supported sleep states for this chipset */ #include <soc/amd/common/acpi/sleepstates.asl> diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl index c11052a..c2df9b7 100644 --- a/src/mainboard/google/zork/dsdt.asl +++ b/src/mainboard/google/zork/dsdt.asl @@ -22,8 +22,8 @@ /* PCI IRQ mapping for the Southbridge */ #include <pcie.asl> - /* Describe the processor tree (\_PR) */ - #include <cpu.asl> + /* Power state notification to ALIB */ + #include <pnot.asl> /* Contains the supported sleep states for this chipset */ #include <soc/amd/common/acpi/sleepstates.asl> diff --git a/src/soc/amd/picasso/acpi/cpu.asl b/src/soc/amd/picasso/acpi/pnot.asl similarity index 100% rename from src/soc/amd/picasso/acpi/cpu.asl rename to src/soc/amd/picasso/acpi/pnot.asl -- To view, visit https://review.coreboot.org/c/coreboot/+/62538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic77dacb146aa823fc99f779f465fff28b2aead68 Gerrit-Change-Number: 62538 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/picasso/acpi: generate PPKG object in generate_cpu_entries call
by Felix Held (Code Review) 02 Mar '22

02 Mar '22

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62517 ) Change subject: soc/amd/picasso/acpi: generate PPKG object in generate_cpu_entries call ...................................................................... soc/amd/picasso/acpi: generate PPKG object in generate_cpu_entries call Generate the PPKG object in the generate_cpu_entries function instead of generating the PCNT object that is the used in the PPKG method in cpu.asl to provide the PPKG object. This both simplifies the code and aligns Picasso with Cezanne and Sabrina. This will also make the code behave correctly in a case where the number of CPU cores/threads isn't a power of two. TEST=Mandolin still boots successfully to Linux desktop and dmesg doesn't show any any possibly related problems. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ifb84435345c6d8c5d11a8b42e5538cfb86432780 --- M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/acpi/cpu.asl 2 files changed, 1 insertion(+), 54 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/62517/1 diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index cd8a0a0..9c798ca 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -355,7 +355,5 @@ acpigen_pop_len(); } - acpigen_write_scope("\\"); - acpigen_write_name_integer("PCNT", logical_cores); - acpigen_pop_len(); + acpigen_write_processor_package("PPKG", 0, logical_cores); } diff --git a/src/soc/amd/picasso/acpi/cpu.asl b/src/soc/amd/picasso/acpi/cpu.asl index b7395fc..29b5b5a 100644 --- a/src/soc/amd/picasso/acpi/cpu.asl +++ b/src/soc/amd/picasso/acpi/cpu.asl @@ -7,54 +7,3 @@ /* Report AC/DC state to ALIB using WAL1() */ \WAL1 () } - -/* - * Processor Object - */ -/* These devices are created at runtime */ -External (\PCNT, IntObj) -External (\_SB.C000, DeviceObj) -External (\_SB.C001, DeviceObj) -External (\_SB.C002, DeviceObj) -External (\_SB.C003, DeviceObj) -External (\_SB.C004, DeviceObj) -External (\_SB.C005, DeviceObj) -External (\_SB.C006, DeviceObj) -External (\_SB.C007, DeviceObj) - -/* Return a package containing enabled processor entries */ -Method (PPKG) -{ - If (\PCNT >= 8) { - Return (Package () - { - \_SB.C000, - \_SB.C001, - \_SB.C002, - \_SB.C003, - \_SB.C004, - \_SB.C005, - \_SB.C006, - \_SB.C007 - }) - } ElseIf (\PCNT >= 4) { - Return (Package () - { - \_SB.C000, - \_SB.C001, - \_SB.C002, - \_SB.C003 - }) - } ElseIf (\PCNT >= 2) { - Return (Package () - { - \_SB.C000, - \_SB.C001 - }) - } Else { - Return (Package () - { - \_SB.C000 - }) - } -} -- To view, visit https://review.coreboot.org/c/coreboot/+/62517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb84435345c6d8c5d11a8b42e5538cfb86432780 Gerrit-Change-Number: 62517 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path
by Michał Kopeć (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Michał Żygowski, Matt DeVillier, Paul Menzel, Christian Walter, Michael Niewöhner. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62493 ) Change subject: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62493/comment/802e4c96_d5ab06bb PS1, Line 9: Windows 11 expect the TPM to reside under \\_SB_.PCI0 in ACPI device : hierarchy, otherwise the TPM is not detected. > It affects the Windows 11 installer, which requires a TPM to proceed. […] Updated -- To view, visit https://review.coreboot.org/c/coreboot/+/62493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0b3136e3eb8eb1bb132132a5f3a7034bdd3b424 Gerrit-Change-Number: 62493 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 15:14:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support
by Michał Kopeć (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Michał Żygowski. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62498 to look at the new patch set (#3). Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support ...................................................................... mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc --- A configs/config.clevo_nv4x A src/mainboard/clevo/tgl-u/Kconfig A src/mainboard/clevo/tgl-u/Kconfig.name A src/mainboard/clevo/tgl-u/Makefile.inc A src/mainboard/clevo/tgl-u/acpi/mainboard.asl A src/mainboard/clevo/tgl-u/acpi/sleep.asl A src/mainboard/clevo/tgl-u/board.fmd A src/mainboard/clevo/tgl-u/board_info.txt A src/mainboard/clevo/tgl-u/bootblock.c A src/mainboard/clevo/tgl-u/cmos.default A src/mainboard/clevo/tgl-u/cmos.layout A src/mainboard/clevo/tgl-u/dsdt.asl A src/mainboard/clevo/tgl-u/memory.c A src/mainboard/clevo/tgl-u/ramstage.c A src/mainboard/clevo/tgl-u/romstage.c A src/mainboard/clevo/tgl-u/smihandler.c A src/mainboard/clevo/tgl-u/variants/baseboard/devicetree.cb A src/mainboard/clevo/tgl-u/variants/baseboard/include/baseboard/gpio.h A src/mainboard/clevo/tgl-u/variants/baseboard/include/baseboard/variants.h A src/mainboard/clevo/tgl-u/variants/nv4x/Makefile.inc A src/mainboard/clevo/tgl-u/variants/nv4x/board_info.txt A src/mainboard/clevo/tgl-u/variants/nv4x/data.vbt A src/mainboard/clevo/tgl-u/variants/nv4x/gpio.c A src/mainboard/clevo/tgl-u/variants/nv4x/gpio_early.c A src/mainboard/clevo/tgl-u/variants/nv4x/hda_verb.c A src/mainboard/clevo/tgl-u/variants/nv4x/overridetree.cb A src/mainboard/clevo/tgl-u/vboot-rwa.fmd 27 files changed, 1,237 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/62498/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Gerrit-Change-Number: 62498 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NS50 Tiger Lake laptop support
by Michał Kopeć (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Felix Singer, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62499 to look at the new patch set (#3). Change subject: mb/clevo/tgl-u: Add Clevo NS50 Tiger Lake laptop support ...................................................................... mb/clevo/tgl-u: Add Clevo NS50 Tiger Lake laptop support Change-Id: I90ad6ec1c174aa09329b4979205c41a3ec458849 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- A configs/config.clevo_ns50mu M src/mainboard/clevo/tgl-u/Kconfig M src/mainboard/clevo/tgl-u/Kconfig.name A src/mainboard/clevo/tgl-u/variants/ns5x/Makefile.inc A src/mainboard/clevo/tgl-u/variants/ns5x/board_info.txt A src/mainboard/clevo/tgl-u/variants/ns5x/data.vbt A src/mainboard/clevo/tgl-u/variants/ns5x/gpio.c A src/mainboard/clevo/tgl-u/variants/ns5x/hda_verb.c A src/mainboard/clevo/tgl-u/variants/ns5x/overridetree.cb 9 files changed, 957 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/62499/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90ad6ec1c174aa09329b4979205c41a3ec458849 Gerrit-Change-Number: 62499 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: intelblocks/pep: Add display on/off notifications and handle TBT disp...
by Michał Kopeć (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Michał Żygowski, Patrick Rudolph. Hello build bot (Jenkins), Michał Żygowski, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62494 to look at the new patch set (#3). Change subject: intelblocks/pep: Add display on/off notifications and handle TBT displays ...................................................................... intelblocks/pep: Add display on/off notifications and handle TBT displays Add display on and off notifications which call mainboard hooks if present. This allows to handle some board specific functions in user absence or presence (whe ndisplay goes off from inactivity or on from activity). Additionally notify IOM to enable or disable TBT displays on S0ix exit and entry respectively. TEST=Use Display on/off notification on Clevo NV41 to tell EC about laptop inactivity. It is necessary to properly handle S0ix entry (stop the fans and start blinking the power led). Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ie80f631ecffa74467ab6d6162e552ba977f7e3f4 --- M src/soc/intel/common/block/acpi/pep.c 1 file changed, 33 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/62494/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie80f631ecffa74467ab6d6162e552ba977f7e3f4 Gerrit-Change-Number: 62494 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/tianocore: Allow custom build parameters for custom builds
by Michał Kopeć (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Michał Żygowski, Martin Roth, Stefan Reinauer, Michael Niewöhner. Hello build bot (Jenkins), Martin Roth, Michał Żygowski, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62497 to look at the new patch set (#3). Change subject: payloads/tianocore: Allow custom build parameters for custom builds ...................................................................... payloads/tianocore: Allow custom build parameters for custom builds Currently, custom TianoCore builds are allowed, but those may need different parameters. Add a Kconfig option to specify additional parameters to be appended to build command. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: I025459ae94592103b4be0c68b422100b7c649d34 --- M payloads/external/Makefile.inc M payloads/external/tianocore/Kconfig M payloads/external/tianocore/Makefile 3 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/62497/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I025459ae94592103b4be0c68b422100b7c649d34 Gerrit-Change-Number: 62497 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/gfx/nvidia: Add Optimus driver based on Intel PCIe RTD3
by Michał Kopeć (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Michał Kopeć. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62496 to look at the new patch set (#3). Change subject: drivers/gfx/nvidia: Add Optimus driver based on Intel PCIe RTD3 ...................................................................... drivers/gfx/nvidia: Add Optimus driver based on Intel PCIe RTD3 Driver provides the Nvidia switchable graphics functionality. Supports S0ix and switching the graphics to on and off state. TEST=Test the Nvidia graphics on Clevo NV41 under Windows with Nvidia drivers. Check the power consumption on Linux when manually toggling _ON and _OFF methods with acpi_exec and draw sample shapes in 3D with dGPU. Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: I7bc6ec7a6a3e18417537b1f092a29972e9875282 --- A src/drivers/gfx/nvidia/optimus/Kconfig A src/drivers/gfx/nvidia/optimus/Makefile.inc A src/drivers/gfx/nvidia/optimus/chip.h A src/drivers/gfx/nvidia/optimus/optimus.c 4 files changed, 447 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/62496/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7bc6ec7a6a3e18417537b1f092a29972e9875282 Gerrit-Change-Number: 62496 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/clevo/it5570: Add Clevo EC implementation found on Clevo laptops
by Michał Kopeć (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Hello build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62495 to look at the new patch set (#3). Change subject: ec/clevo/it5570: Add Clevo EC implementation found on Clevo laptops ...................................................................... ec/clevo/it5570: Add Clevo EC implementation found on Clevo laptops This is IT5570 EC implementation for Clevo laptops with Insyde firmware. The driver and ACPI code support all functionalities, including dGPU, FN keys, Type-C UCSI and S0ix. The only issue is with TP toggle hotkey when TP works in I2C HID mode under Linux. One needs to add udev rules as specified in: https://docs.dasharo.com/variants/clevo_nv41/post_install/ Windows can handle the EC query function that toggles the TP's _STA field and OS disables/enabels the touchpad accordingly. TEST=Boot Ubuntu and Windows 11 on Clevo NV41 and see battery/AC is detected, S0ix is working and FN keys are functional. Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I07c7d1d4f86d764bd10cfa3b0da23d1116281f3b --- A src/ec/clevo/it5570/Kconfig A src/ec/clevo/it5570/Makefile.inc A src/ec/clevo/it5570/acpi/ac.asl A src/ec/clevo/it5570/acpi/battery.asl A src/ec/clevo/it5570/acpi/buttons.asl A src/ec/clevo/it5570/acpi/ec.asl A src/ec/clevo/it5570/acpi/ec_ram.asl A src/ec/clevo/it5570/acpi/gpe.asl A src/ec/clevo/it5570/acpi/hid.asl A src/ec/clevo/it5570/acpi/lid.asl A src/ec/clevo/it5570/acpi/ucsi.asl A src/ec/clevo/it5570/chip.c A src/ec/clevo/it5570/chip.h A src/ec/clevo/it5570/ec.c A src/ec/clevo/it5570/ec.h 15 files changed, 1,667 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/62495/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07c7d1d4f86d764bd10cfa3b0da23d1116281f3b Gerrit-Change-Number: 62495 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path
by Michał Kopeć (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Michał Żygowski, Matt DeVillier, Paul Menzel, Christian Walter, Michael Niewöhner. Hello build bot (Jenkins), Michał Żygowski, Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62493 to look at the new patch set (#3). Change subject: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path ...................................................................... drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path Windows 11 installer expects the TPM to reside under \\_SB_.PCI0 in ACPI device hierarchy, otherwise the TPM is not detected. Hardcode the path to fix the issue. TEST=Boot Windows 11 on Clevo NV41MZ and see the TPM is detected correctly TEST=Boot Ubuntu 20.04 on Clevo NV41MZ and see the TPM is detected correctly Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: If0b3136e3eb8eb1bb132132a5f3a7034bdd3b424 --- M src/drivers/pc80/tpm/tis.c 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/62493/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0b3136e3eb8eb1bb132132a5f3a7034bdd3b424 Gerrit-Change-Number: 62493 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022