coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: i2c: Configurable I2C transfer timeout
by Hung-Te Lin (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Jes Klinke, Patrick Rudolph. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 ) Change subject: i2c: Configurable I2C transfer timeout ...................................................................... Patch Set 7: (1 comment) File src/soc/mediatek/common/i2c.c: https://review.coreboot.org/c/coreboot/+/62278/comment/d1f1adb5_b91e21b6 PS7, Line 242: CONFIG_I2C_TRANSFER_TIMEOUT_US > nit: so we are changing the timeout from 100ms to 500m? can you also update the config value in each […] Just saw Julius' comment about (transfer timeout) "but that's the one really generic kind of timeout we have in I2C". I'm not an I2C expert but if 500ms is a generic value then I'm ok with this change. Please state that in the commit description so we know the changes to timeout values are expected. -- To view, visit https://review.coreboot.org/c/coreboot/+/62278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6423122f32aad1dbcee0bfe240cdaa8cb512791f Gerrit-Change-Number: 62278 Gerrit-PatchSet: 7 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Qii Wang <qii.wang(a)mediatek.corp-partner.google.com> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 14:03:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: i2c: Configurable I2C transfer timeout
by Hung-Te Lin (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Jes Klinke, Patrick Rudolph. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 ) Change subject: i2c: Configurable I2C transfer timeout ...................................................................... Patch Set 7: (1 comment) File src/soc/mediatek/common/i2c.c: https://review.coreboot.org/c/coreboot/+/62278/comment/3ad7f735_be18dd5e PS7, Line 242: CONFIG_I2C_TRANSFER_TIMEOUT_US nit: so we are changing the timeout from 100ms to 500m? can you also update the config value in each platform's Kconfigs if they have a different default value, so we won't be causing expected results? -- To view, visit https://review.coreboot.org/c/coreboot/+/62278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6423122f32aad1dbcee0bfe240cdaa8cb512791f Gerrit-Change-Number: 62278 Gerrit-PatchSet: 7 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Qii Wang <qii.wang(a)mediatek.corp-partner.google.com> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 13:59:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb: Remove dot from end of non-sentence comment
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Marina Michelle has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/60248 ) Change subject: mb: Remove dot from end of non-sentence comment ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/60248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84669341e2c8976953284dbaf113da3397857de3 Gerrit-Change-Number: 60248 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: revert

1 0

Change in coreboot[master]: Revert "mb: Remove dot from end of non-sentence comment"
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Tim Crawford, Patrick Rudolph, Jeremy Soller, Paul Menzel, Christian Walter, Angel Pons, Felix Held. Hello build bot (Jenkins), Tim Crawford, Patrick Rudolph, Jeremy Soller, Paul Menzel, Christian Walter, Angel Pons, Felix Held, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62528 to review the following change. Change subject: Revert "mb: Remove dot from end of non-sentence comment" ...................................................................... Revert "mb: Remove dot from end of non-sentence comment" This reverts commit 520a4a618f117a0a8e84bef0206fdca69633ef05. Reason for revert: <INSERT REASONING HERE> Don't like this Change-Id: Idaec2ef07f37bb3baa4d1f69d78258d7717919e8 --- M src/mainboard/google/glados/variants/asuka/include/variant/gpio.h M src/mainboard/google/glados/variants/caroline/include/variant/gpio.h M src/mainboard/google/glados/variants/cave/include/variant/gpio.h M src/mainboard/google/glados/variants/chell/include/variant/gpio.h M src/mainboard/google/glados/variants/glados/include/variant/gpio.h M src/mainboard/google/glados/variants/lars/include/variant/gpio.h M src/mainboard/google/glados/variants/sentry/include/variant/gpio.h M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h M src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h M src/mainboard/intel/kunimitsu/gpio.h M src/mainboard/intel/saddlebrook/gpio.h M src/mainboard/prodrive/hermes/gpio.c M src/mainboard/starlabs/labtop/variants/tgl/gpio.c M src/mainboard/system76/lemp9/gpio.h 16 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/62528/1 diff --git a/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h b/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h index 758b7cc..3ee5532 100644 --- a/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h +++ b/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h @@ -214,7 +214,7 @@ /* LANPHYC */ PAD_NC(GPD11, NONE), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* SPI_WP_STATUS */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP), /* GD_UART2_RXD */ PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), diff --git a/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h b/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h index fe31102..7f8787c 100644 --- a/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h +++ b/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h @@ -231,7 +231,7 @@ /* LANPHYC */ PAD_NC(GPD11, NONE), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* UART2_CTS# */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP), /* PCH_WP */ /* GD_UART2_RXD */ PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), diff --git a/src/mainboard/google/glados/variants/cave/include/variant/gpio.h b/src/mainboard/google/glados/variants/cave/include/variant/gpio.h index e96a78a..0eb7de7 100644 --- a/src/mainboard/google/glados/variants/cave/include/variant/gpio.h +++ b/src/mainboard/google/glados/variants/cave/include/variant/gpio.h @@ -223,7 +223,7 @@ /* LANPHYC */ PAD_NC(GPD11, NONE), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* UART2_CTS# */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP), /* PCH_WP */ /* GD_UART2_RXD */ PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), diff --git a/src/mainboard/google/glados/variants/chell/include/variant/gpio.h b/src/mainboard/google/glados/variants/chell/include/variant/gpio.h index 3260472..e152862 100644 --- a/src/mainboard/google/glados/variants/chell/include/variant/gpio.h +++ b/src/mainboard/google/glados/variants/chell/include/variant/gpio.h @@ -217,7 +217,7 @@ /* LANPHYC */ PAD_NC(GPD11, NONE), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* SRCCLKREQ2# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */ /* UART0_CTS# */ PAD_CFG_GPO(GPP_C11, 0, DEEP), /* EN_PP3300_KEPLER */ diff --git a/src/mainboard/google/glados/variants/glados/include/variant/gpio.h b/src/mainboard/google/glados/variants/glados/include/variant/gpio.h index b812fb7..248e7dd 100644 --- a/src/mainboard/google/glados/variants/glados/include/variant/gpio.h +++ b/src/mainboard/google/glados/variants/glados/include/variant/gpio.h @@ -220,7 +220,7 @@ /* LANPHYC */ /* GPD11 */ }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* SRCCLKREQ2# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */ /* UART0_CTS# */ PAD_CFG_GPO(GPP_C11, 0, DEEP), /* EN_PP3300_KEPLER */ diff --git a/src/mainboard/google/glados/variants/lars/include/variant/gpio.h b/src/mainboard/google/glados/variants/lars/include/variant/gpio.h index 7cf56aa..ee55512 100644 --- a/src/mainboard/google/glados/variants/lars/include/variant/gpio.h +++ b/src/mainboard/google/glados/variants/lars/include/variant/gpio.h @@ -208,7 +208,7 @@ /* LANPHYC */ PAD_NC(GPD11, NONE), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* SRCCLKREQ2# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */ /* UART0_CTS# */ PAD_CFG_GPO(GPP_C11, 0, DEEP), /* EN_PP3300_KEPLER */ diff --git a/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h b/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h index 10291b0..06f6cd8 100644 --- a/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h +++ b/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h @@ -216,7 +216,7 @@ /* LANPHYC */ PAD_NC(GPD11, NONE), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* SRCCLKREQ2# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */ /* SPI_WP_STATUS */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP), diff --git a/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h b/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h index fb47e6f..aaec3eb 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h +++ b/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h @@ -257,7 +257,7 @@ /* LANPHYC */ PAD_CFG_NF(GPD11, NONE, DEEP, NF1), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* UART0_RXD */ PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), /* UART0_TXD */ PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), diff --git a/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h b/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h index 11a6b82..26eb1d9 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h +++ b/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h @@ -193,7 +193,7 @@ /* LANPHYC */ PAD_CFG_NF(GPD11, NONE, DEEP, NF1), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* UART2_RXD */ PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), /* UART2_TXD */ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), diff --git a/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h b/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h index 9c252e2..d2e76d9 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h +++ b/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h @@ -193,7 +193,7 @@ /* LANPHYC */ PAD_CFG_NF(GPD11, NONE, DEEP, NF1), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* UART0_RXD */ PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), /* UART0_TXD */ PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), diff --git a/src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h b/src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h index 1c112df..44997c7 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h +++ b/src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h @@ -159,7 +159,7 @@ }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* UART0_RXD */ PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), /* UART0_TXD */ PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), diff --git a/src/mainboard/intel/kunimitsu/gpio.h b/src/mainboard/intel/kunimitsu/gpio.h index c4628f2..a436d8f 100644 --- a/src/mainboard/intel/kunimitsu/gpio.h +++ b/src/mainboard/intel/kunimitsu/gpio.h @@ -217,7 +217,7 @@ /* LANPHYC */ PAD_NC(GPD11, NONE), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* SRCCLKREQ2# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */ /* SPI_WP_STATUS */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP), diff --git a/src/mainboard/intel/saddlebrook/gpio.h b/src/mainboard/intel/saddlebrook/gpio.h index da9c27e..b012462 100644 --- a/src/mainboard/intel/saddlebrook/gpio.h +++ b/src/mainboard/intel/saddlebrook/gpio.h @@ -245,7 +245,7 @@ /* LANPHYC */ PAD_CFG_NF(GPD11, NONE, DEEP, NF1), }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { /* UART0_CTS# */ PAD_CFG_GPO(GPP_C11, 1, DEEP), /* EN_PP3300_KEPLER */ }; diff --git a/src/mainboard/prodrive/hermes/gpio.c b/src/mainboard/prodrive/hermes/gpio.c index 5cb901d..f228ef8 100644 --- a/src/mainboard/prodrive/hermes/gpio.c +++ b/src/mainboard/prodrive/hermes/gpio.c @@ -369,7 +369,7 @@ }; -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ const struct pad_config early_gpio_table[] = { /* Get PCIe out of reset */ PAD_CFG_GPO(GPP_K0, 1, DEEP), /* PERST_PCH_SLOTS_n */ diff --git a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c index a0fc12c..81f6cb7 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c @@ -7,7 +7,7 @@ * using the stock BIOS and with coreboot. */ -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ const struct pad_config early_gpio_table[] = { PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), diff --git a/src/mainboard/system76/lemp9/gpio.h b/src/mainboard/system76/lemp9/gpio.h index 518a500..60cc7b6 100644 --- a/src/mainboard/system76/lemp9/gpio.h +++ b/src/mainboard/system76/lemp9/gpio.h @@ -10,7 +10,7 @@ /* Name format: <pad name> / <net/pin name in schematics> */ -/* Early pad configuration in bootblock */ +/* Early pad configuration in bootblock. */ static const struct pad_config early_gpio_table[] = { PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), /* UART2_RXD */ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), /* UART2_TXD */ -- To view, visit https://review.coreboot.org/c/coreboot/+/62528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaec2ef07f37bb3baa4d1f69d78258d7717919e8 Gerrit-Change-Number: 62528 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Update intel-microcode submodule to upstream master
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Marina Michelle has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/61769 ) Change subject: Update intel-microcode submodule to upstream master ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/61769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb2dcd3e3ef9692e21109ac0e8bdfa9f61740f14 Gerrit-Change-Number: 61769 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: revert

1 0

Change in coreboot[master]: Revert "Update intel-microcode submodule to upstream master"
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Felix Singer, Martin Roth, Subrata Banik, Tim Wawrzynczak, Elyes Haouas. Hello Felix Singer, build bot (Jenkins), Martin Roth, Subrata Banik, Tim Wawrzynczak, Tim Wawrzynczak, Elyes Haouas, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62527 to review the following change. Change subject: Revert "Update intel-microcode submodule to upstream master" ...................................................................... Revert "Update intel-microcode submodule to upstream master" This reverts commit caa1d41d5ccdf63c81b0789fd4617f1ddb0acd95. Reason for revert: <INSERT REASONING HERE> Not running Change-Id: I073bbb16f49e4547fe09e92f5f27aa1618641793 --- M 3rdparty/intel-microcode 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/62527/1 diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 115c3e4..3f97690 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 115c3e4cdad6a9d84bf06e066162c5c546a9d2c3 +Subproject commit 3f97690f0da8011f52209b232450a1e5c4f2e1f6 -- To view, visit https://review.coreboot.org/c/coreboot/+/62527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I073bbb16f49e4547fe09e92f5f27aa1618641793 Gerrit-Change-Number: 62527 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/docker/coreboot-jenkins-node: add linkchecker
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Marina Michelle has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/62445 ) Change subject: util/docker/coreboot-jenkins-node: add linkchecker ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/62445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac2246b5378e556b5cd9f2107fc5a7e51d583b5b Gerrit-Change-Number: 62445 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: revert

1 0

Change in coreboot[master]: Revert "util/docker/coreboot-jenkins-node: add linkchecker"
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Felix Singer, Martin Roth, Felix Held. Hello Felix Singer, build bot (Jenkins), Martin Roth, Felix Held, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62526 to review the following change. Change subject: Revert "util/docker/coreboot-jenkins-node: add linkchecker" ...................................................................... Revert "util/docker/coreboot-jenkins-node: add linkchecker" This reverts commit c8a1195b7706ae73a59e5e4afc326f38e3bd93da. Reason for revert: <INSERT REASONING HERE> Not running Change-Id: I8aaf5e9477bb6b8a0f0d79e9e08f364ee81f836e --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/62526/1 diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 2926163..19670b4 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -28,7 +28,6 @@ parallel \ meson ninja-build \ sdcc \ - linkchecker \ lua5.3 liblua5.3-dev default-jre-headless openssh-server && \ apt-get clean -- To view, visit https://review.coreboot.org/c/coreboot/+/62526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8aaf5e9477bb6b8a0f0d79e9e08f364ee81f836e Gerrit-Change-Number: 62526 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/amdtools: Add script to update the SPI speed in the EFS header
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Marina Michelle has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/56644 ) Change subject: util/amdtools: Add script to update the SPI speed in the EFS header ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/56644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I905a9fd8bd93a28aab927dffecbbcf24934b9e03 Gerrit-Change-Number: 56644 Gerrit-PatchSet: 6 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: revert

1 0

Change in coreboot[master]: Revert "util/amdtools: Add script to update the SPI speed in the EFS ...
by Marina Michelle (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Paul Menzel, Karthik Ramasubramanian, Felix Held. Hello build bot (Jenkins), Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Paul Menzel, Karthik Ramasubramanian, Felix Held, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62525 to review the following change. Change subject: Revert "util/amdtools: Add script to update the SPI speed in the EFS header" ...................................................................... Revert "util/amdtools: Add script to update the SPI speed in the EFS header" This reverts commit a95cd265bdaf1529094040e91cf8f1e0036f5a7f. Reason for revert: <INSERT REASONING HERE> Not running Change-Id: Ie89290decbbfdb0b766dfb15f11ce7053e6bf6bc --- D util/amdtools/update_efs_spi_speed 1 file changed, 0 insertions(+), 121 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/62525/1 diff --git a/util/amdtools/update_efs_spi_speed b/util/amdtools/update_efs_spi_speed deleted file mode 100755 index 00b82bd..0000000 --- a/util/amdtools/update_efs_spi_speed +++ /dev/null @@ -1,121 +0,0 @@ -#!/usr/bin/env bash -# SPDX-License-Identifier: BSD-3-Clause - -ROM="$1" -declare -i NEW_SPEED="$2" - -readonly EFS_SIG_DWORD="55aa55aa" -readonly FAST_SPEED_NEW_F15_MOD_60_6F_OFFSET=0x41 -readonly SPI_FASTSPEED_F17_MOD_00_2F_OFFSET=0x44 -readonly SPI_FASTSPEED_F17_MOD_30_3F_OFFSET=0x48 - -# print out the very simple usage -usage() { - echo "Usage: $0 <ROM> <Speed>" - echo " Speed must be between 0 & 5" - echo " 0: 66.66Mhz" - echo " 1: 33.33MHz" - echo " 2: 22.22MHz" - echo " 3: 16.66MHz" - echo " 4: 100MHz" - echo " 5: 800KHz" -} - -# Validate the input parameters -if [[ $# -ne 2 || ! -f "${ROM}" || "${NEW_SPEED}" -lt 0 || "${NEW_SPEED}" -gt 5 ]]; then - usage - exit 1 -fi - -# Read a 32, 16, or 8 bit value from a location in a binary file -getval() { - local location=$1 - local length=$2 - - if [[ ${length} -eq 1 ]]; then - dd "if=${ROM}" bs=1 "skip=${location}" "count=${length}" 2>/dev/null | hexdump -v -e '1/1 "%02x\n"' - elif [[ ${length} -eq 2 ]]; then - dd "if=${ROM}" bs=1 "skip=${location}" "count=${length}" 2>/dev/null | hexdump -v -e '1/2 "%04x\n"' - elif [[ ${length} -eq 4 ]]; then - dd "if=${ROM}" bs=1 "skip=${location}" "count=${length}" 2>/dev/null | hexdump -v -e '1/4 "%08x\n"' - else - echo "Error: invalid value" - exit 1 - fi -} - -# Update a location in a binary -# Note that the passed in value must be formatted correctly: -# Each byte needs to be specified as "\\xXX" where X is a hex digit -setval() { - local location=$1 - local length=$2 - local hexval=$3 - - # shellcheck disable=SC2059 - if ! printf "$hexval" | dd "of=${ROM}" bs=1 "seek=${location}" "count=${length}" conv=notrunc status=none; then - echo "Error: Could not write to ${ROM}" - exit 1 - fi -} - -# Print the speed associated with the passed-in value -showspeed() { - local speedval=$1 - case ${speedval} in - 0 | 00) echo "0: 66.66Mhz" ;; - 1 | 01) echo "1: 33.33MHz" ;; - 2 | 02) echo "2: 22.22MHz" ;; - 3 | 03) echo "3: 16.66MHz" ;; - 4 | 04) echo "4: 100MHz" ;; - 5 | 05) echo "5: 800KHz" ;; - ff) echo "Error: Speed not set" ;; - *) echo "Error: Unknown speed (${speedval})" ;; - esac -} - -# Locate the SPI speed data and update it to the new speed -update_efs() { - local location=$1 - local updated_speed=0 - - for speed_offset in FAST_SPEED_NEW_F15_MOD_60_6F_OFFSET SPI_FASTSPEED_F17_MOD_00_2F_OFFSET SPI_FASTSPEED_F17_MOD_30_3F_OFFSET; do - local speed_val - local speed_loc=$((location + speed_offset)) - speed_val=$(getval "${speed_loc}" "1") - - if [[ "${speed_val}" != "ff" ]]; then - printf "Found speed value of %s at %#06x\n" "$(showspeed "${speed_val}")" "${speed_loc}" - updated_speed=1 - setval "${speed_loc}" "1" "\\x0${NEW_SPEED}" - speed_val=$(getval "${speed_loc}" "1") - printf "New speed value: %s\n" "$(showspeed "${speed_val}")" - fi - - done - if [[ ${updated_speed} -eq 0 ]]; then - echo "Error: Could not find speed value to update." - exit 1 - fi -} - -# Find the EFS location and update the speed -main() { - local location - local val - - for i in {0..5}; do - location="$((0xffffff - (0x80000 << i) + 0x20000 + 1))" - val="$(getval "${location}" 4 )" - if [[ "${val}" == "${EFS_SIG_DWORD}" ]]; then - printf "EFS found at %#06x\n" "${location}" - update_efs "${location}" - exit 0 - fi - done - - echo "Error: EFS not found in ${ROM}." - exit 1 -} - -main -- To view, visit https://review.coreboot.org/c/coreboot/+/62525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie89290decbbfdb0b766dfb15f11ce7053e6bf6bc Gerrit-Change-Number: 62525 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022