coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: Revert "soc/mediatek/mt8186: Set RTC capid to 0xC0 to pass XTAL 26 MH...
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62530 ) Change subject: Revert "soc/mediatek/mt8186: Set RTC capid to 0xC0 to pass XTAL 26 MHz test" ...................................................................... Abandoned crap -- To view, visit https://review.coreboot.org/c/coreboot/+/62530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb83c806d9da6be346d7b099847a79a63bf9202d Gerrit-Change-Number: 62530 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "util/crossgcc: Update binutils to 2.37"
by Patrick Georgi (Code Review) 02 Mar '22

02 Mar '22

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62531 ) Change subject: Revert "util/crossgcc: Update binutils to 2.37" ...................................................................... Abandoned crap -- To view, visit https://review.coreboot.org/c/coreboot/+/62531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8652ce621cde940eb54fadb96acebbddabd736e1 Gerrit-Change-Number: 62531 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: xin hua wang <xinhuawang0101(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/brya: Change "mainboard: EC init" loglevel prefix
by Tim Wawrzynczak (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Ian Feng. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62508 ) Change subject: mb/google/brya: Change "mainboard: EC init" loglevel prefix ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3de63fc13e7a5ed6a4b4617542851782fbb6f00 Gerrit-Change-Number: 62508 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:35:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "soc/mediatek/mt8186: Set RTC capid to 0xC0 to pass XTAL 26 MH...
by Tim Wawrzynczak (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Marina Michelle, Yu-Ping Wu, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62530 ) Change subject: Revert "soc/mediatek/mt8186: Set RTC capid to 0xC0 to pass XTAL 26 MHz test" ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb83c806d9da6be346d7b099847a79a63bf9202d Gerrit-Change-Number: 62530 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:32:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "util/crossgcc: Update binutils to 2.37"
by Tim Wawrzynczak (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Nico Huber, Patrick Georgi, Paul Menzel, Marina Michelle. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62531 ) Change subject: Revert "util/crossgcc: Update binutils to 2.37" ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8652ce621cde940eb54fadb96acebbddabd736e1 Gerrit-Change-Number: 62531 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: xin hua wang <xinhuawang0101(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:32:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "util/docker/coreboot-jenkins-node: Alphabetize installed tools"
by Tim Wawrzynczak (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Felix Singer, Martin Roth, Marina Michelle, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62529 ) Change subject: Revert "util/docker/coreboot-jenkins-node: Alphabetize installed tools" ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8922f82d5d7ed193fa94ddf81e0e699c86a3eb78 Gerrit-Change-Number: 62529 Gerrit-PatchSet: 1 Gerrit-Owner: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marina Michelle <marinamichelle100(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:32:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Add GPIO driving functions
by Paul Menzel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62471 ) Change subject: soc/mediatek/mt8186: Add GPIO driving functions ...................................................................... Patch Set 4: (1 comment) File src/soc/mediatek/common/include/soc/gpio_common.h: https://review.coreboot.org/c/coreboot/+/62471/comment/7154c119_998d72a9 PS4, Line 51: int8_t width; Why not make them unsigned? -- To view, visit https://review.coreboot.org/c/coreboot/+/62471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d987f28be98b515fa5c542222bda08bea1d5118 Gerrit-Change-Number: 62471 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:23:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Add GPIO driving functions
by Paul Menzel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62471 ) Change subject: soc/mediatek/mt8186: Add GPIO driving functions ...................................................................... Patch Set 4: (2 comments) File src/soc/mediatek/common/include/soc/gpio_common.h: https://review.coreboot.org/c/coreboot/+/62471/comment/e18a3307_adb29516 PS4, Line 31: }; If it’s SoC specific, why put it in common code? https://review.coreboot.org/c/coreboot/+/62471/comment/0994ffc5_8f618670 PS4, Line 46: }; Why not use the current values as names? -- To view, visit https://review.coreboot.org/c/coreboot/+/62471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d987f28be98b515fa5c542222bda08bea1d5118 Gerrit-Change-Number: 62471 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:22:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave
by Matt DeVillier (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Tim Wawrzynczak. Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62447 to look at the new patch set (#3). Change subject: mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave ...................................................................... mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave Commit 017b5c453a72f57ec785da1764939e24651ac5eb [ec/google/chromeec/acpi: Rename EC_ENABLE_TABLET_EVENT config] broke tablet mode on google/caroline and cave in mainline Linux kernels by changing the inclusion of the ChromeEC tablet mode ACPI handler. Fix this by addding it back (using the updated name guarding the inclusion of the tmbc ACPI). Test: build/boot google/cave under Linux 5.16, observe tablet mode handled correctly. Change-Id: Ie0ae5b6a61f104b5e973383344d289cc2e2a7b8d Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/glados/variants/caroline/include/variant/ec.h M src/mainboard/google/glados/variants/cave/include/variant/ec.h 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/62447/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0ae5b6a61f104b5e973383344d289cc2e2a7b8d Gerrit-Change-Number: 62447 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave
by Matt DeVillier (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Matt DeVillier, Tim Wawrzynczak. Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62447 to look at the new patch set (#2). Change subject: mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave ...................................................................... mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave Commit 017b5c453a72f57ec785da1764939e24651ac5eb [ec/google/chromeec/acpi: Rename EC_ENABLE_TABLET_EVENT config] broke tablet mode on google/caroline and cave in mainline Linux kernels by changing the inclusion of the ChromeEC tablet mode ACPI handler. Fix this by add it back (using the updated name guarding the inclusion of the tmbc ACPI). Test: build/boot google/cave under Linux 5.16, observe tablet mode handled correctly. Change-Id: Ie0ae5b6a61f104b5e973383344d289cc2e2a7b8d Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/glados/variants/caroline/include/variant/ec.h M src/mainboard/google/glados/variants/cave/include/variant/ec.h 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/62447/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0ae5b6a61f104b5e973383344d289cc2e2a7b8d Gerrit-Change-Number: 62447 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022