Attention is currently required from: Kyösti Mälkki, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70106 )
Change subject: commonlib/helpers.h: use unsigned literals in definitions
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Does this force all arithmetic involving KiB to use 64bit arithmetic? For i386 builds too?
Not all, only those that would eventually end up in 64bit variable. Compilers are allowed to use smaller width if it doesn't change the result, and even skip multiplication entirely or change the multiplier if it can be calculated at the time of compilation.
Nevertheless, result of multiplication on i386 is returned in `%edx:%eax`, so it already is 64bit wide.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b
Gerrit-Change-Number: 70106
Gerrit-PatchSet: 3
Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 14:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 )
Change subject: mb/google/poppy: Add support for a variant finalize function
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635
Gerrit-Change-Number: 70319
Gerrit-PatchSet: 5
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 14:08:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/139a1816_b175ce3a
PS9, Line 31: LPI_REVISION_0
> imho, I think it's important to have them incase anyone ever adds other things. In these cases, these values have specific meanings (values) in the specification and if someone inserts something, we could now be sending across the wrong values.
>
> @subrata, wdyt?
Sure, please add those enum value explicitly as Tarun suggested. (i'm okay with it)
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 12
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 14:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com>
Comment-In-Reply-To: Eran Mitrani <mitrani(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Tarun Tuli, Subrata Banik.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 )
Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/google/poppy/variants/nami/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165231):
https://review.coreboot.org/c/coreboot/+/68820/comment/48ae6209_7ea0f177
PS11, Line 334: }
adding a line without newline at end of file
--
To view, visit https://review.coreboot.org/c/coreboot/+/68820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21eb85dc11e0ea0eb5de8a6092b01663d3c3df91
Gerrit-Change-Number: 68820
Gerrit-PatchSet: 11
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 14:04:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 )
Change subject: mb/google/poppy: Add support for a variant finalize function
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/poppy/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165230):
https://review.coreboot.org/c/coreboot/+/70319/comment/1ea3bace_231548d7
PS4, Line 77: };
adding a line without newline at end of file
--
To view, visit https://review.coreboot.org/c/coreboot/+/70319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635
Gerrit-Change-Number: 70319
Gerrit-PatchSet: 4
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 14:03:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Jason Glenesk, Zheng Bao, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70314 )
Change subject: mb/amd/birman: Add EC fw to flash
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> If you want, I can handle updating the birman EC placement. […]
I can also modify the signature file to place the main EC blob elsewhere - I was planning on locating it at ROM offset 0xf00000 (depending on how the rest of the amdfw / 32MB ROM worked out), but that is not too hard to change.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e20f399c4bfe32ec43242619628f7775b4e659e
Gerrit-Change-Number: 70314
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 13:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com>
Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-MessageType: comment