Fred Reitberger has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70281 )
Change subject: soc/amd/common/block/include/gpio_defs.h: Fix documentation
......................................................................
soc/amd/common/block/include/gpio_defs.h: Fix documentation
Fixing documentation of PAD_INT macro and replacing spaces with a tab to
match the rest of the documentation.
Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com>
Change-Id: I72a2578ce21dd10b3beb65c706440c3379f216d6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70281
Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
---
M src/soc/amd/common/block/include/amdblocks/gpio_defs.h
1 file changed, 19 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Eric Lai: Looks good to me, approved
Matt DeVillier: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/gpio_defs.h b/src/soc/amd/common/block/include/amdblocks/gpio_defs.h
index 718a45c..c5aa3f1 100644
--- a/src/soc/amd/common/block/include/amdblocks/gpio_defs.h
+++ b/src/soc/amd/common/block/include/amdblocks/gpio_defs.h
@@ -160,7 +160,7 @@
* pin the pin to be programmed
* pull pull up, pull down or no pull
* trigger LEVEL_LOW, LEVEL_HIGH, EDGE_LOW, EDGE_HIGH, BOTH_EDGES
- * action STATUS, DELIVER, STATUS_DELIVER
+ * action STATUS, DELIVERY, STATUS_DELIVERY
* PAD_SCI The pin is a SCI source
* pin the pin to be programmed
* pull pull up, pull down or no pull
@@ -168,7 +168,7 @@
* PAD_SMI The pin is a SMI source
* pin the pin to be programmed
* pull pull up, pull down or no pull
- * event trigger LEVEL_LOW, LEVEL_HIGH
+ * event trigger LEVEL_LOW, LEVEL_HIGH
* PAD_NF_SCI Define native alternate function and confiure SCI source
* pin the pin to be programmed
* function the native function
--
To view, visit https://review.coreboot.org/c/coreboot/+/70281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72a2578ce21dd10b3beb65c706440c3379f216d6
Gerrit-Change-Number: 70281
Gerrit-PatchSet: 3
Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70145 )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT
......................................................................
commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT
ELOG_CROS_DIAG_RESULT_* codes should be consistent with the enum
definition of enumerated histograms.
Hence add comments based on the requirements of enum histograms in
histogram guidelines.
BUG=b:4047421
TEST=none
Change-Id: I1a1a7c863d5aa9496649f81dc94fd79a6ad482df
Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70145
Reviewed-by: Yu-Ping Wu <yupingso(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/commonlib/bsd/include/commonlib/bsd/elog.h
1 file changed, 28 insertions(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Yu-Ping Wu: Looks good to me, approved
diff --git a/src/commonlib/bsd/include/commonlib/bsd/elog.h b/src/commonlib/bsd/include/commonlib/bsd/elog.h
index 06ea5a7..1f39090 100644
--- a/src/commonlib/bsd/include/commonlib/bsd/elog.h
+++ b/src/commonlib/bsd/include/commonlib/bsd/elog.h
@@ -316,7 +316,12 @@
#define ELOG_CROS_DIAG_TYPE_STORAGE_TEST_EXTENDED 0x03
#define ELOG_CROS_DIAG_TYPE_MEMORY_QUICK 0x04
#define ELOG_CROS_DIAG_TYPE_MEMORY_FULL 0x05
-/* Result codes for elog_event_cros_diag_log in ELOG_CROS_DIAGNOSTICS_LOGS */
+/*
+ * Result codes for elog_event_cros_diag_log in ELOG_CROS_DIAGNOSTICS_LOGS
+ *
+ * These values are persisted to logs. Entries should not be renumbered and
+ * numeric values should never be reused.
+ */
#define ELOG_CROS_DIAG_RESULT_PASSED 0x01
#define ELOG_CROS_DIAG_RESULT_ERROR 0x02
#define ELOG_CROS_DIAG_RESULT_FAILED 0x03
--
To view, visit https://review.coreboot.org/c/coreboot/+/70145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a1a7c863d5aa9496649f81dc94fd79a6ad482df
Gerrit-Change-Number: 70145
Gerrit-PatchSet: 4
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Martin L Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70110 )
Change subject: [WIP][DO NOT MERGE] ssdtgen: ACPI SSDT generator
......................................................................
Patch Set 3:
(2 comments)
File ssdtgen/Makefile.inc:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165239):
https://review.coreboot.org/c/coreboot/+/70110/comment/c17b591b_e7b9d64a
PS3, Line 3: # Set all necesary paths. Remember that .SECONDEXPANSION is enabled,
'necesary' may be misspelled - perhaps 'necessary'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165239):
https://review.coreboot.org/c/coreboot/+/70110/comment/ed5b2622_ab8d0756
PS3, Line 137: # Clear ramstage sources to prevent generation of unnecesary resipes in main Makefile
'unnecesary' may be misspelled - perhaps 'unnecessary'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/70110
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78766cd1f47e24b2cd7f9b5cf1cca066441ead06
Gerrit-Change-Number: 70110
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jan Dabros <jsd(a)semihalf.com>
Gerrit-CC: Noga Smith <nogasmith(a)google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 14:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment