coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
by build bot (Jenkins) (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Shelley Chen, Tarun Tuli, Subrata Banik. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 ) Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup ...................................................................... Patch Set 11: (1 comment) File src/mainboard/google/poppy/variants/nami/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165231): https://review.coreboot.org/c/coreboot/+/68820/comment/48ae6209_7ea0f177 PS11, Line 334: } adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/68820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21eb85dc11e0ea0eb5de8a6092b01663d3c3df91 Gerrit-Change-Number: 68820 Gerrit-PatchSet: 11 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 14:04:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/poppy: Add support for a variant finalize function
by build bot (Jenkins) (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 ) Change subject: mb/google/poppy: Add support for a variant finalize function ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/poppy/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165230): https://review.coreboot.org/c/coreboot/+/70319/comment/1ea3bace_231548d7 PS4, Line 77: }; adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/70319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635 Gerrit-Change-Number: 70319 Gerrit-PatchSet: 4 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 14:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/poppy: Add support for a variant finalize function
by Tarun Tuli (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 ) Change subject: mb/google/poppy: Add support for a variant finalize function ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/poppy/mainboard.c: https://review.coreboot.org/c/coreboot/+/70319/comment/363308e7_f38e30c1 PS3, Line 64: { > nit: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/70319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635 Gerrit-Change-Number: 70319 Gerrit-PatchSet: 4 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 14:03:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: commonlib/helpers.h: use unsigned literals in definitions
by Kyösti Mälkki (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Krystian Hebel, Sergii Dmytruk. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70106 ) Change subject: commonlib/helpers.h: use unsigned literals in definitions ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Does this force all arithmetic involving KiB to use 64bit arithmetic? For i386 builds too? -- To view, visit https://review.coreboot.org/c/coreboot/+/70106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b Gerrit-Change-Number: 70106 Gerrit-PatchSet: 3 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 13:55:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/amd/birman: Add EC fw to flash
by Fred Reitberger (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Bao Zheng, Jason Glenesk, Zheng Bao, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70314 ) Change subject: mb/amd/birman: Add EC fw to flash ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > If you want, I can handle updating the birman EC placement. […] I can also modify the signature file to place the main EC blob elsewhere - I was planning on locating it at ROM offset 0xf00000 (depending on how the rest of the amdfw / 32MB ROM worked out), but that is not too hard to change. -- To view, visit https://review.coreboot.org/c/coreboot/+/70314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e20f399c4bfe32ec43242619628f7775b4e659e Gerrit-Change-Number: 70314 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 13:07:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/amd/birman: Add EC fw to flash
by Fred Reitberger (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Bao Zheng, Jason Glenesk, Zheng Bao, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70314 ) Change subject: mb/amd/birman: Add EC fw to flash ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > BIRMAN_EC_POSITION […] If you want, I can handle updating the birman EC placement. The main EC blob does not need to be in a CBFS region, so I had been planning on using an FMAP region to hold it (and renaming EC to ECSIG like you did here). -- To view, visit https://review.coreboot.org/c/coreboot/+/70314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e20f399c4bfe32ec43242619628f7775b4e659e Gerrit-Change-Number: 70314 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 12:53:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: commonlib/helpers.h: use unsigned literals in definitions
by Krystian Hebel (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Sergii Dmytruk. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70106 ) Change subject: commonlib/helpers.h: use unsigned literals in definitions ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70106/comment/14a4484e_d0a0da6c PS1, Line 21: so if result of : multiplication is negative > If result of multiplying two positive integers is negative, further integer promotions don't matter […] Overflow reporting sounds nice, but negative frequency doesn't make sense, so I've changed it to `ULL`. -- To view, visit https://review.coreboot.org/c/coreboot/+/70106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b Gerrit-Change-Number: 70106 Gerrit-PatchSet: 3 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 12:25:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: commonlib/helpers.h: use unsigned literals in definitions
by Krystian Hebel (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Krystian Hebel. Hello build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70106 to look at the new patch set (#3). Change subject: commonlib/helpers.h: use unsigned literals in definitions ...................................................................... commonlib/helpers.h: use unsigned literals in definitions This protects against some of unintentional integer promotions, e.g.: uint16_t freq_mhz = 2148; // or bigger uint64_t freq = freq_mhz * MHz; In this example, MHz used to be treated as int32_t, and because int32_t can represent every value that uin16_t can, multiplication was being performed with both arguments treated as int32_t. During assignment, result of multiplication is promoted to int64_t (because it can represent each value that int32_t can), and finally implicitly converted to uint64_t. Promotions preserve the value, including the sign, so if result of multiplication is negative, the same negative number (but extended to 64 bits) is converted to unsigned number. Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b --- M src/commonlib/bsd/include/commonlib/bsd/helpers.h 1 file changed, 32 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/70106/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/70106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b Gerrit-Change-Number: 70106 Gerrit-PatchSet: 3 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: commonlib/helpers.h: use unsigned literals in definitions
by build bot (Jenkins) (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Krystian Hebel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70106 ) Change subject: commonlib/helpers.h: use unsigned literals in definitions ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165229): https://review.coreboot.org/c/coreboot/+/70106/comment/44e2444d_8ef47c3b PS2, Line 26: Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b Duplicate signature -- To view, visit https://review.coreboot.org/c/coreboot/+/70106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b Gerrit-Change-Number: 70106 Gerrit-PatchSet: 2 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 12:14:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: commonlib/helpers.h: use unsigned literals in definitions
by Krystian Hebel (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Krystian Hebel. Hello build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70106 to look at the new patch set (#2). Change subject: commonlib/helpers.h: use unsigned literals in definitions ...................................................................... commonlib/helpers.h: use unsigned literals in definitions This protects against some of unintentional integer promotions, e.g.: uint16_t freq_mhz = 2148; // or bigger uint64_t freq = freq_mhz * MHz; In this example, MHz used to be treated as int32_t, and because int32_t can represent every value that uin16_t can, multiplication was being performed with both arguments treated as int32_t. During assignment, result of multiplication is promoted to int64_t (because it can represent each value that int32_t can), and finally implicitly converted to uint64_t. Promotions preserve the value, including the sign, so if result of multiplication is negative, the same negative number (but extended to 64 bits) is converted to unsigned number. Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> --- M src/commonlib/bsd/include/commonlib/bsd/helpers.h 1 file changed, 33 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/70106/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b Gerrit-Change-Number: 70106 Gerrit-PatchSet: 2 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022